@putout/plugin-destructuring 1.1.0 → 1.3.0

package/README.md

@@ -20,8 +20,10 @@ npm i @putout/plugin-destructuring
 - ✅ [apply-object](#apply-object);
 - ✅ [apply-array](#apply-array);
 - ✅ [convert-object-to-array](#convert-object-to-array);
+- ✅ [extract-properties](#extract-properties);
 - ✅ [remove-useless-object](#remove-useless-object);
 - ✅ [remove-useless-arguments](#remove-useless-arguments);
+- ✅ [remove-useless-variables](#remove-useless-variables);
 - ✅ [split-nested](#split-nested);
 - ✅ [split-call](#split-call);
 - ✅ [merge-properties](#merge-properties);
@@ -34,8 +36,10 @@ npm i @putout/plugin-destructuring
         "destructuring/apply-object": "on",
         "destructuring/apply-array": "on",
         "destructuring/convert-object-to-array": "on",
+        "destructuring/extract-properties": "on",
         "destructuring/remove-useless-object": "on",
         "destructuring/remove-useless-arguments": "on",
+        "destructuring/remove-useless-variables": "on",
         "destructuring/split-nested": "on",
         "destructuring/split-call": "on",
         "destructuring/merge-properties": "on"
@@ -219,6 +223,58 @@ onIfStatement({
 function onIfStatement({push}) {}
 ```
 
+## remove-useless-variables
+
+### ❌ Example of incorrect code
+
+```js
+function hi(c) {
+    const {a, b} = c;
+}
+```
+
+### ✅ Example of correct code
+
+```js
+function hi({a, b}) {}
+```
+
+## extract-properties
+
+### Equal Deep
+
+#### ❌ Example of incorrect code
+
+```js
+const {replaceWith} = a.operate;
+const {isIdentifier} = a.types;
+```
+
+#### ✅ Example of correct code
+
+```js
+const {operator, types} = a;
+
+const {replaceWith} = operator;
+const {isIdentifier} = types;
+```
+
+### Not Equal Deep
+
+#### ❌ Example of incorrect code
+
+```js
+const {replaceWith} = a;
+const {isIdentifier} = a.types;
+```
+
+#### ✅ Example of correct code
+
+```js
+const {replaceWith, types} = a;
+const {isIdentifier} = types;
+```
+
 ## License
 
 MIT

package/lib/extract-properties-equal-deep/index.js

@@ -0,0 +1,78 @@
+import {
+    template,
+    generate,
+    types,
+    operator,
+} from 'putout';
+
+const {
+    findBinding,
+    replaceWith,
+    getTemplateValues,
+} = operator;
+
+const {
+    isIdentifier,
+    isCallExpression,
+} = types;
+
+export const report = () => `Extract object properties into variables`;
+
+const buildAst = template(`
+    const {PROPERTY} = OBJECT;
+`);
+
+export const fix = ({items}) => {
+    const names = [];
+    
+    for (const item of items) {
+        const {object, property} = item.node;
+        
+        if (isIdentifier(property) && !names.includes(property.name)) {
+            names.push(property.name);
+            
+            const {body = item.scope.block.body} = item.scope.block.body;
+            
+            body.unshift(buildAst({
+                PROPERTY: property,
+                OBJECT: object,
+            }));
+        }
+        
+        replaceWith(item, item.node.property);
+    }
+};
+
+export const traverse = ({uplist, push}) => ({
+    'const __object = __a.__b': (fullPath) => {
+        const {__a, __b} = getTemplateValues(fullPath, 'const __object = __a.__b');
+        const initPath = fullPath.get('declarations.0.init');
+        const {uid} = initPath.scope;
+        
+        if (findBinding(fullPath, __b.name))
+            return;
+        
+        if (isIdentifier(__a) || isCallExpression(__a)) {
+            const {code} = generate(__a);
+            const id = `${uid}-${code}`;
+            
+            return uplist(id, initPath);
+        }
+    },
+    'Program': {
+        exit: () => {
+            for (const items of uplist()) {
+                if (items.length < 2)
+                    continue;
+                
+                const index = items.length - 1;
+                const path = items[index];
+                
+                push({
+                    path,
+                    items,
+                });
+            }
+        },
+    },
+});

package/lib/extract-properties-not-equal-deep/index.js

@@ -0,0 +1,72 @@
+import {operator, types} from 'putout';
+
+const {objectProperty} = types;
+
+const {replaceWith, compare} = operator;
+
+const SHORTHAND = true;
+const COMPUTED = false;
+
+export const report = () => `Extract object properties into variables`;
+
+export const fix = ({path, expandPath, property}) => {
+    const newProperty = objectProperty(property, property, COMPUTED, SHORTHAND);
+    
+    expandPath.node.properties.push(newProperty);
+    replaceWith(path, property);
+};
+
+export const traverse = ({listStore, push}) => ({
+    'const __object = __a.__b': save({
+        listStore,
+    }),
+    'const __object = __a(__args)': save({
+        listStore,
+    }),
+    'Program': {
+        exit: exit({
+            push,
+            listStore,
+        }),
+    },
+});
+
+const save = ({listStore}) => (path) => {
+    const idPath = path.get('declarations.0.id');
+    const initPath = path.get('declarations.0.init');
+    
+    listStore([initPath, idPath]);
+};
+
+const exit = ({push, listStore}) => () => {
+    const items = listStore();
+    
+    for (const [initPath] of items) {
+        for (const [currentPath, expandPath] of items) {
+            const objectPath = initPath.get('object');
+            
+            if (!objectPath.isMemberExpression() && !objectPath.isCallExpression())
+                continue;
+            
+            const propertyPath = initPath.get('property');
+            const property = propertyPath.node;
+            
+            const current = currentPath.node;
+            const {object} = initPath.node;
+            const {name} = property;
+            
+            if (expandPath.scope.bindings[name])
+                continue;
+            
+            if (expandPath.scope.uid !== initPath.scope.uid)
+                continue;
+            
+            if (compare(object, current))
+                push({
+                    expandPath,
+                    path: initPath,
+                    property,
+                });
+        }
+    }
+};

package/lib/index.js

@@ -1,8 +1,11 @@
-import * as convertObjectToArray from './convert-object-to-array/index.js';
 import * as applyObject from './apply-object/index.js';
 import * as applyArray from './apply-array/index.js';
+import * as extractPropertiesEqualDeep from './extract-properties-equal-deep/index.js';
+import * as extractPropertiesNotEqualDeep from './extract-properties-not-equal-deep/index.js';
+import * as convertObjectToArray from './convert-object-to-array/index.js';
 import * as removeUselessObject from './remove-useless-object/index.js';
 import * as removeUselessArguments from './remove-useless-arguments/index.js';
+import * as removeUselessVariables from './remove-useless-variables/index.js';
 import * as splitNested from './split-nested/index.js';
 import * as splitCall from './split-call/index.js';
 import * as mergeProperties from './merge-properties/index.js';
@@ -10,9 +13,12 @@ import * as mergeProperties from './merge-properties/index.js';
 export const rules = {
     'apply-object': applyObject,
     'apply-array': applyArray,
+    'convert-object-to-array': convertObjectToArray,
+    'extract-properties-equal-deep': extractPropertiesEqualDeep,
+    'extract-properties-not-equal-deep': extractPropertiesNotEqualDeep,
     'remove-useless-object': removeUselessObject,
     'remove-useless-arguments': removeUselessArguments,
-    'convert-object-to-array': convertObjectToArray,
+    'remove-useless-variables': removeUselessVariables,
     'split-nested': splitNested,
     'split-call': splitCall,
     'merge-properties': mergeProperties,

package/lib/remove-useless-variables/index.js

@@ -0,0 +1,78 @@
+import {types, operator} from 'putout';
+
+const {
+    isIdentifier,
+    isRestElement,
+    isAssignmentPattern,
+} = types;
+
+const {replaceWith} = operator;
+
+const MAX_LENGTH = 20;
+
+const getKeyLength = (a) => {
+    const {key, value} = a;
+    
+    if (!isAssignmentPattern(value) && isIdentifier(key))
+        return a.key.name.length;
+    
+    if (isRestElement(a) && isIdentifier(a.argument))
+        return a.argument.name.length + 3;
+    
+    return MAX_LENGTH;
+};
+
+const sum = (a, b) => a + getKeyLength(b);
+
+export const report = (path) => {
+    return `Avoid useless variable '${path.node.declarations[0].init.name}'`;
+};
+
+export const match = () => ({
+    'const __object = __a': ({__a, __object}, path) => {
+        const {parentPath} = path.parentPath;
+        
+        if (!parentPath)
+            return false;
+        
+        if (!parentPath.isFunction())
+            return false;
+        
+        if (path.node !== parentPath.node.body.body[0])
+            return false;
+        
+        const {params} = parentPath.node;
+        
+        if (params.length !== 1)
+            return false;
+        
+        const [first] = params;
+        
+        if (__object.properties.length > 3)
+            return false;
+        
+        if (!isIdentifier(first))
+            return false;
+        
+        if (__a.name !== first.name)
+            return false;
+        
+        const binding = path.scope.bindings[first.name];
+        
+        if (binding.path.node.typeAnnotation)
+            return false;
+        
+        if (binding.references > 1)
+            return false;
+        
+        const namesLength = __object.properties.reduce(sum, 0);
+        
+        return namesLength < MAX_LENGTH;
+    },
+});
+
+export const replace = () => ({
+    'const __object = __a': ({__object}, path) => {
+        replaceWith(path.parentPath.parentPath.get('params.0'), __object);
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-destructuring",
-  "version": "1.1.0",
+  "version": "1.3.0",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform destructuring",
@@ -39,6 +39,7 @@
     "@putout/plugin-printer": "*",
     "@putout/plugin-putout": "*",
     "@putout/plugin-tape": "*",
+    "@putout/plugin-variables": "*",
     "@putout/test": "^14.0.0",
     "c8": "^10.0.0",
     "eslint": "v10.0.0-alpha.0",