@putout/plugin-destructuring 1.1.0 → 1.2.0

package/README.md

@@ -22,6 +22,7 @@ npm i @putout/plugin-destructuring
 - ✅ [convert-object-to-array](#convert-object-to-array);
 - ✅ [remove-useless-object](#remove-useless-object);
 - ✅ [remove-useless-arguments](#remove-useless-arguments);
+- ✅ [remove-useless-variables](#remove-useless-variables);
 - ✅ [split-nested](#split-nested);
 - ✅ [split-call](#split-call);
 - ✅ [merge-properties](#merge-properties);
@@ -36,6 +37,7 @@ npm i @putout/plugin-destructuring
         "destructuring/convert-object-to-array": "on",
         "destructuring/remove-useless-object": "on",
         "destructuring/remove-useless-arguments": "on",
+        "destructuring/remove-useless-variables": "on",
         "destructuring/split-nested": "on",
         "destructuring/split-call": "on",
         "destructuring/merge-properties": "on"
@@ -219,6 +221,22 @@ onIfStatement({
 function onIfStatement({push}) {}
 ```
 
+## remove-useless-variables
+
+### ❌ Example of incorrect code
+
+```js
+function hi(c) {
+    const {a, b} = c;
+}
+```
+
+### ✅ Example of correct code
+
+```js
+function hi({a, b}) {}
+```
+
 ## License
 
 MIT

package/lib/index.js

@@ -3,6 +3,7 @@ import * as applyObject from './apply-object/index.js';
 import * as applyArray from './apply-array/index.js';
 import * as removeUselessObject from './remove-useless-object/index.js';
 import * as removeUselessArguments from './remove-useless-arguments/index.js';
+import * as removeUselessVariables from './remove-useless-variables/index.js';
 import * as splitNested from './split-nested/index.js';
 import * as splitCall from './split-call/index.js';
 import * as mergeProperties from './merge-properties/index.js';
@@ -12,6 +13,7 @@ export const rules = {
     'apply-array': applyArray,
     'remove-useless-object': removeUselessObject,
     'remove-useless-arguments': removeUselessArguments,
+    'remove-useless-variables': removeUselessVariables,
     'convert-object-to-array': convertObjectToArray,
     'split-nested': splitNested,
     'split-call': splitCall,

package/lib/remove-useless-variables/index.js

@@ -0,0 +1,78 @@
+import {types, operator} from 'putout';
+
+const {
+    isIdentifier,
+    isRestElement,
+    isAssignmentPattern,
+} = types;
+
+const {replaceWith} = operator;
+
+const MAX_LENGTH = 20;
+
+const getKeyLength = (a) => {
+    const {key, value} = a;
+    
+    if (!isAssignmentPattern(value) && isIdentifier(key))
+        return a.key.name.length;
+    
+    if (isRestElement(a) && isIdentifier(a.argument))
+        return a.argument.name.length + 3;
+    
+    return MAX_LENGTH;
+};
+
+const sum = (a, b) => a + getKeyLength(b);
+
+export const report = (path) => {
+    return `Avoid useless variable '${path.node.declarations[0].init.name}'`;
+};
+
+export const match = () => ({
+    'const __object = __a': ({__a, __object}, path) => {
+        const {parentPath} = path.parentPath;
+        
+        if (!parentPath)
+            return false;
+        
+        if (!parentPath.isFunction())
+            return false;
+        
+        if (path.node !== parentPath.node.body.body[0])
+            return false;
+        
+        const {params} = parentPath.node;
+        
+        if (params.length !== 1)
+            return false;
+        
+        const [first] = params;
+        
+        if (__object.properties.length > 3)
+            return false;
+        
+        if (!isIdentifier(first))
+            return false;
+        
+        if (__a.name !== first.name)
+            return false;
+        
+        const binding = path.scope.bindings[first.name];
+        
+        if (binding.path.node.typeAnnotation)
+            return false;
+        
+        if (binding.references > 1)
+            return false;
+        
+        const namesLength = __object.properties.reduce(sum, 0);
+        
+        return namesLength < MAX_LENGTH;
+    },
+});
+
+export const replace = () => ({
+    'const __object = __a': ({__object}, path) => {
+        replaceWith(path.parentPath.parentPath.get('params.0'), __object);
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-destructuring",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform destructuring",