@putout/plugin-conditions 6.4.0 → 6.6.0

package/README.md

@@ -28,6 +28,7 @@ npm i @putout/plugin-conditions -D
 - ✅ [remove-same-values-condition](hremove-same-values-condition);
 - ✅ [remove-useless-else](#remove-ureless-else);
 - ✅ [remove-zero](#remove-zero);
+- ✅ [remove-undefined](#remove-undefined);
 - ✅ [simplify](#simplify);
 - ✅ [wrap-with-block](#wrap-with-block);
 
@@ -48,6 +49,7 @@ npm i @putout/plugin-conditions -D
         "conditions/remove-boolean": "on",
         "conditions/remove-constant": "on",
         "conditions/remove-zero": "on",
+        "conditions/remove-undefined": "on",
         "conditions/remove-useless-else": "on",
         "conditions/remove-same-values-condition": "on",
         "conditions/merge-if-statements": "on",
@@ -322,6 +324,24 @@ if (!b) {}
 if (b) {}
 ```
 
+## remove-undefined
+
+### ❌ Example of incorrect code
+
+```js
+if (b === undefined) {}
+
+if (b !== undefined) {}
+```
+
+### ✅ Example of correct code
+
+```js
+if (!b) {}
+
+if (b) {}
+```
+
 ## simplify
 
 ### ❌ Example of incorrect code

package/lib/apply-consistent-blocks/index.js

@@ -5,8 +5,7 @@ const {replaceWith} = operator;
 const {
     isBlockStatement,
     BlockStatement,
-    isExpressionStatement,
-    isIfStatement,
+    isVariableDeclaration,
 } = types;
 
 module.exports.report = () => `Use consistent blocks`;
@@ -75,7 +74,7 @@ module.exports.filter = (path) => {
         if (is && body.length === 1) {
             const [first] = body;
             
-            if (!isExpressionStatement(first) && !isIfStatement(first))
+            if (isVariableDeclaration(first))
                 continue;
         }
         

package/lib/apply-if/index.js

@@ -11,9 +11,7 @@ module.exports.filter = (path) => {
     if (!nextPath.node)
         return false;
     
-    return path
-        .get('consequent')
-        .isEmptyStatement();
+    return path.get('consequent').isEmptyStatement();
 };
 
 module.exports.include = () => [

package/lib/avoid-in-assertions.js

@@ -0,0 +1,48 @@
+'use strict';
+
+const {types} = require('putout');
+const {
+    isBinaryExpression,
+    isJSXExpressionContainer,
+} = types;
+
+module.exports.createAvoidInAssertions = (value) => ({
+    report: createReport(value),
+    match: createMatch(value),
+    replace: createReplace(value),
+});
+
+const check = (vars, path) => {
+    const {parentPath} = path;
+    
+    if (parentPath.find(isJSXExpressionContainer))
+        return false;
+    
+    if (parentPath.isAssignmentExpression())
+        return false;
+    
+    return !parentPath.isVariableDeclarator();
+};
+
+const createReport = (value) => () => `Avoid '${value}' in assertions`;
+
+const createMatch = (value) => () => ({
+    [`__a !== ${value}`]: check,
+    [`__a != ${value}`]: check,
+    [`__a === ${value}`]: check,
+    [`__a == ${value}`]: check,
+});
+
+const createReplace = (value) => () => ({
+    [`__a !== ${value}`]: '__a',
+    [`__a != ${value}`]: '__a',
+    [`__a === ${value}`]: maybeParens,
+    [`__a == ${value}`]: maybeParens,
+});
+
+function maybeParens({__a}) {
+    if (isBinaryExpression(__a))
+        return '!(__a)';
+    
+    return '!__a';
+}

package/lib/index.js

@@ -9,6 +9,7 @@ const convertEqualToStrictEqual = require('./convert-equal-to-strict-equal');
 const mergeIfStatements = require('./merge-if-statements');
 const removeBoolean = require('./remove-boolean');
 const removeZero = require('./remove-zero');
+const removeUndefined = require('./remove-undefined');
 const removeUselessElse = require('./remove-useless-else');
 const simplify = require('./simplify');
 const removeSameValuesCondition = require('./remove-same-values-condition');
@@ -27,6 +28,7 @@ module.exports.rules = {
     'merge-if-statements': mergeIfStatements,
     'remove-boolean': removeBoolean,
     'remove-zero': removeZero,
+    'remove-undefined': removeUndefined,
     'remove-useless-else': removeUselessElse,
     simplify,
     'remove-same-values-condition': removeSameValuesCondition,

package/lib/remove-undefined/index.js

@@ -0,0 +1,5 @@
+'use strict';
+
+const {createAvoidInAssertions} = require('../avoid-in-assertions');
+
+module.exports = createAvoidInAssertions(undefined);

package/lib/remove-zero/index.js

@@ -1,42 +1,5 @@
 'use strict';
 
-const {types} = require('putout');
-const {
-    isBinaryExpression,
-    isJSXExpressionContainer,
-} = types;
+const {createAvoidInAssertions} = require('../avoid-in-assertions');
 
-const check = (vars, path) => {
-    const {parentPath} = path;
-    
-    if (parentPath.find(isJSXExpressionContainer))
-        return false;
-    
-    if (parentPath.isAssignmentExpression())
-        return false;
-    
-    return !parentPath.isVariableDeclarator();
-};
-
-module.exports.report = () => 'Avoid zero in assertions';
-
-module.exports.match = () => ({
-    '__a !== 0': check,
-    '__a != 0': check,
-    '__a === 0': check,
-    '__a == 0': check,
-});
-
-module.exports.replace = () => ({
-    '__a !== 0': '__a',
-    '__a != 0': '__a',
-    '__a === 0': maybeParens,
-    '__a == 0': maybeParens,
-});
-
-function maybeParens({__a}) {
-    if (isBinaryExpression(__a))
-        return '!(__a)';
-    
-    return '!__a';
-}
+module.exports = createAvoidInAssertions(0);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-conditions",
-  "version": "6.4.0",
+  "version": "6.6.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds support of conditions transformations",