@putout/plugin-conditions 3.0.0 → 3.0.2

package/README.md

@@ -25,6 +25,7 @@ npm i @putout/plugin-conditions -D
         "conditions/remove-constant": "on",
         "conditions/remove-zero": "on",
         "conditions/remove-useless-else": "on",
+        "conditions/remove-same-values-condition": "on",
         "conditions/merge-if-statements": "on"
     }
 }
@@ -272,6 +273,45 @@ if (x)
 console.log();
 ```
 
+## remove-same-values-condition"
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/e537d4ec636d4a9b849063a8326b70ae/661041b3fbb1e3678bf7f828e4c8bf6ca723f89d).
+
+### ❌ Example of incorrect code
+
+```js
+for (const [i, el] of entries(elements)) {
+    if (el !== path)
+        continue;
+    
+    if (!Number(i) && n) {
+        path.parentPath.node.elements[i] = null;
+        break;
+    }
+    
+    if (el === path) {
+        remove(path);
+        break;
+    }
+}
+```
+
+### ✅ Example of correct code
+
+```js
+for (const [i, el] of entries(elements)) {
+    if (el !== path)
+        continue;
+    
+    if (!Number(i) && n) {
+        path.parentPath.node.elements[i] = null;
+        break;
+    }
+    
+    remove(path);
+}
+```
+
 ### Comparison
 
 Linter | Rule | Fix

package/lib/convert-equal-to-strict-equal/index.js

@@ -1,6 +1,6 @@
 'use strict';
 
-module.exports.report = () => 'Strict equal should be used instead of equal';
+module.exports.report = () => `Use strict equal ('===') instead of equal ('==')`;
 
 module.exports.exclude = () => [
     '__ == null',

package/lib/index.js

@@ -10,6 +10,7 @@ const removeBoolean = require('./remove-boolean');
 const removeZero = require('./remove-zero');
 const removeUselessElse = require('./remove-useless-else');
 const simplify = require('./simplify');
+const removeSameValuesCondition = require('./remove-same-values-condition');
 
 module.exports.rules = {
     'apply-comparison-order': applyComparisonOrder,
@@ -22,4 +23,5 @@ module.exports.rules = {
     'remove-zero': removeZero,
     'remove-useless-else': removeUselessElse,
     simplify,
+    'remove-same-values-condition': removeSameValuesCondition,
 };

package/lib/remove-same-values-condition/index.js

@@ -0,0 +1,39 @@
+'use strict';
+
+const {operator} = require('putout');
+const {
+    replaceWith,
+    getTemplateValues,
+    compare,
+} = operator;
+
+module.exports.report = () => `Avoid condition with the same value`;
+
+module.exports.match = () => ({
+    'if (__a === __b) __c'({__a, __b}, prev) {
+        while (prev = prev.getPrevSibling(), prev.node) {
+            if (!compare(prev, 'if (__a !== __b) __c'))
+                continue;
+            
+            const values = getTemplateValues(prev, 'if (__a !== __b) __c');
+            
+            if (!compare(__a, values.__a))
+                continue;
+            
+            if (!compare(__b, values.__b))
+                continue;
+            
+            return true;
+        }
+        
+        return false;
+    },
+});
+
+module.exports.replace = () => ({
+    'if (__a === __b) __c': (vars, path) => {
+        replaceWith(path, path.get('consequent'));
+        
+        return path;
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-conditions",
-  "version": "3.0.0",
+  "version": "3.0.2",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds support of conditions transformations",
@@ -37,7 +37,7 @@
     "c8": "^8.0.0",
     "eslint": "^8.0.1",
     "eslint-plugin-n": "^16.0.0",
-    "eslint-plugin-putout": "^19.0.0",
+    "eslint-plugin-putout": "^21.0.0",
     "lerna": "^6.0.1",
     "madrun": "^9.0.0",
     "montag": "^1.2.1",