@putout/plugin-conditions 1.0.3 → 2.0.0

package/README.md

@@ -22,7 +22,8 @@ npm i @putout/plugin-conditions -D
         "conditions/convert-equal-to-strict-equal": "on",
         "conditions/evaluate": "on",
         "conditions/remove-boolean": "on",
-        "conditions/remove-constant": "on"
+        "conditions/remove-constant": "on",
+        "conditions/remove-zero": "on"
     }
 }
 ```
@@ -174,6 +175,24 @@ function hi(b) {
 }
 ```
 
+## remove-zero
+
+### ❌ Example of incorrect code
+
+```js
+if (b === 0) {}
+
+if (b !== 0) {}
+```
+
+### ✅ Example of correct code
+
+```js
+if (!b) {}
+
+if (b) {}
+```
+
 ## simplify
 
 ## ❌ Example of incorrect code
@@ -184,7 +203,8 @@ if (zone?.tooltipCallback) {
 }
 
 if (a)
-    alert('hello');else
+    alert('hello');
+else
     alert('hello');
 ```
 

package/lib/apply-comparison-order/index.js

@@ -51,10 +51,7 @@ function isLeftValid(leftPath) {
     if (leftPath.isIdentifier() || leftPath.isMemberExpression() || leftPath.isCallExpression())
         return false;
     
-    if (leftPath.isOptionalMemberExpression())
-        return false;
-    
-    return true;
+    return !leftPath.isOptionalMemberExpression();
 }
 
 function convertOperator(operator) {

package/lib/convert-comparison-to-boolean/index.js

@@ -1,19 +1,10 @@
 'use strict';
 
-const {
-    types,
-    operator,
-} = require('putout');
+const {types, operator} = require('putout');
 
-const {
-    replaceWith,
-    compute,
-} = operator;
+const {replaceWith, compute} = operator;
 
-const {
-    isIdentifier,
-    BooleanLiteral,
-} = types;
+const {isIdentifier, BooleanLiteral} = types;
 
 module.exports.report = () => 'Avoid constant conditions';
 

package/lib/index.js

@@ -11,5 +11,6 @@ module.exports.rules = {
     ...getRule('convert-comparison-to-boolean'),
     ...getRule('convert-equal-to-strict-equal'),
     ...getRule('remove-boolean'),
+    ...getRule('remove-zero'),
     ...getRule('simplify'),
 };

package/lib/remove-constant/index.js

@@ -1,9 +1,6 @@
 'use strict';
 
-const {
-    types,
-    operator,
-} = require('putout');
+const {types, operator} = require('putout');
 
 const {runInNewContext} = require('vm');
 
@@ -18,10 +15,7 @@ const {isIdentifier} = types;
 module.exports.report = () => 'Avoid constant conditions';
 
 module.exports.fix = ({path, result}) => {
-    const {
-        alternate,
-        consequent,
-    } = path.node;
+    const {alternate, consequent} = path.node;
     
     const {body = [consequent]} = consequent;
     

package/lib/remove-zero/index.js

@@ -0,0 +1,29 @@
+'use strict';
+
+const {isJSXExpressionContainer} = require('putout').types;
+
+const check = (vars, path) => {
+    const {parentPath} = path;
+    
+    if (parentPath.find(isJSXExpressionContainer))
+        return false;
+    
+    if (parentPath.isAssignmentExpression())
+        return false;
+    
+    return !parentPath.isVariableDeclarator();
+};
+
+module.exports.report = () => 'Avoid zero in assertions';
+
+module.exports.match = () => ({
+    '__a !== 0': check,
+    '__a != 0': check,
+});
+
+module.exports.replace = () => ({
+    '__a !== 0': '__a',
+    '__a != 0': '__a',
+    '__a === 0': '!__a',
+    '__a == 0': '!__a',
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-conditions",
-  "version": "1.0.3",
+  "version": "2.0.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds support of conditions transformations",
@@ -33,18 +33,18 @@
   ],
   "devDependencies": {
     "@putout/plugin-for-of": "*",
-    "@putout/test": "^6.0.0",
-    "c8": "^7.5.0",
+    "@putout/test": "^7.0.0",
+    "c8": "^8.0.0",
     "eslint": "^8.0.1",
-    "eslint-plugin-n": "^15.2.4",
-    "eslint-plugin-putout": "^17.0.0",
+    "eslint-plugin-n": "^16.0.0",
+    "eslint-plugin-putout": "^18.0.0",
     "lerna": "^6.0.1",
     "madrun": "^9.0.0",
     "montag": "^1.2.1",
-    "nodemon": "^2.0.1"
+    "nodemon": "^3.0.1"
   },
   "peerDependencies": {
-    "putout": ">=29"
+    "putout": ">=30"
   },
   "license": "MIT",
   "engines": {