@putout/plugin-conditions 1.0.2 → 1.1.0

package/README.md

@@ -22,7 +22,8 @@ npm i @putout/plugin-conditions -D
         "conditions/convert-equal-to-strict-equal": "on",
         "conditions/evaluate": "on",
         "conditions/remove-boolean": "on",
-        "conditions/remove-constant": "on"
+        "conditions/remove-constant": "on",
+        "conditions/remove-zero": "on"
     }
 }
 ```
@@ -101,15 +102,13 @@ const t = false;
 ### ❌ Example of incorrect code
 
 ```js
-if (a == b) {
-}
+if (a == b) {}
 ```
 
 ### ✅ Example of correct code
 
 ```js
-if (a === b) {
-}
+if (a === b) {}
 ```
 
 ## evaluate
@@ -176,6 +175,24 @@ function hi(b) {
 }
 ```
 
+## remove-zero-
+
+### ❌ Example of incorrect code
+
+```js
+if (b === 0) {}
+
+if (b !== 0) {}
+```
+
+### ✅ Example of correct code
+
+```js
+if (!b) {}
+
+if (b) {}
+```
+
 ## simplify
 
 ## ❌ Example of incorrect code
@@ -186,8 +203,7 @@ if (zone?.tooltipCallback) {
 }
 
 if (a)
-    alert('hello');
-else
+    alert('hello');else
     alert('hello');
 ```
 

package/lib/apply-if/index.js

@@ -10,10 +10,14 @@ module.exports.filter = (path) => {
     if (!nextPath.node)
         return false;
     
-    return path.get('consequent').isEmptyStatement();
+    return path
+        .get('consequent')
+        .isEmptyStatement();
 };
 
-module.exports.include = () => ['IfStatement'];
+module.exports.include = () => [
+    'IfStatement',
+];
 
 module.exports.fix = (path) => {
     const nextPath = path.getNextSibling();

package/lib/convert-comparison-to-boolean/index.js

@@ -5,7 +5,11 @@ const {
     operator,
 } = require('putout');
 
-const {replaceWith, compute} = operator;
+const {
+    replaceWith,
+    compute,
+} = operator;
+
 const {
     isIdentifier,
     BooleanLiteral,

package/lib/convert-equal-to-strict-equal/index.js

@@ -11,4 +11,3 @@ module.exports.replace = () => ({
     '__a == __b': '__a === __b',
     '__a != __b': '__a !== __b',
 });
-

package/lib/evaluate/index.js

@@ -22,4 +22,3 @@ module.exports.replace = () => ({
         return '__b';
     },
 });
-

package/lib/index.js

@@ -11,6 +11,6 @@ module.exports.rules = {
     ...getRule('convert-comparison-to-boolean'),
     ...getRule('convert-equal-to-strict-equal'),
     ...getRule('remove-boolean'),
+    ...getRule('remove-zero'),
     ...getRule('simplify'),
 };
-

package/lib/remove-boolean/index.js

@@ -5,19 +5,14 @@ module.exports.report = () => 'Avoid boolean in assertions';
 module.exports.replace = () => ({
     'return __a === true': 'return Boolean(__a)',
     'return __a == true': 'return Boolean(__a)',
-    
-    'const __a = __b === true': 'const __a = __b === Boolean(__a)',
-    'const __a = __b == true': 'const __a = __b == Boolean(__a)',
-    
+    'const __a = __b === true': 'const __a = __b',
+    'const __a = __b == true': 'const __a = __b',
     '__a = __b === true': '__a = __b === Boolean(__a)',
     '__a = __b == true': '__a = __b == Boolean(__a)',
-    
     '__a === true': '__a',
     '__a === false': '!__a',
     '__a == true': '__a',
     '__a == false': '!__a',
-    
     '__a !== true': '!__a',
     '__a != true': '!__a',
 });
-

package/lib/remove-constant/index.js

@@ -12,6 +12,7 @@ const {
     replaceWithMultiple,
     remove,
 } = operator;
+
 const {isIdentifier} = types;
 
 module.exports.report = () => 'Avoid constant conditions';
@@ -22,9 +23,7 @@ module.exports.fix = ({path, result}) => {
         consequent,
     } = path.node;
     
-    const {
-        body = [consequent],
-    } = consequent;
+    const {body = [consequent]} = consequent;
     
     if (result)
         return replaceWithMultiple(path, body);
@@ -38,6 +37,7 @@ module.exports.fix = ({path, result}) => {
 module.exports.traverse = ({push, generate}) => ({
     IfStatement(path) {
         const testPath = path.get('test');
+        
         const {
             left,
             right,
@@ -78,4 +78,3 @@ function containsIdentifiers(testPath) {
     
     return is;
 }
-

package/lib/remove-zero/index.js

@@ -0,0 +1,27 @@
+'use strict';
+
+const check = (vars, path) => {
+    const {parentPath} = path;
+    
+    if (parentPath.isAssignmentExpression())
+        return false;
+    
+    if (parentPath.isVariableDeclarator())
+        return false;
+    
+    return true;
+};
+
+module.exports.report = () => 'Avoid zero in assertions';
+
+module.exports.match = () => ({
+    '__a !== 0': check,
+    '__a != 0': check,
+});
+
+module.exports.replace = () => ({
+    '__a !== 0': '__a',
+    '__a != 0': '__a',
+    '__a === 0': '!__a',
+    '__a == 0': '!__a',
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-conditions",
-  "version": "1.0.2",
+  "version": "1.1.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds support of conditions transformations",
@@ -32,13 +32,12 @@
     "conditions"
   ],
   "devDependencies": {
-    "@putout/plugin-convert-for-each-to-for-of": "^8.1.0",
-    "@putout/plugin-remove-useless-variables": "^7.3.0",
+    "@putout/plugin-for-of": "*",
     "@putout/test": "^6.0.0",
     "c8": "^7.5.0",
     "eslint": "^8.0.1",
     "eslint-plugin-n": "^15.2.4",
-    "eslint-plugin-putout": "^16.0.0",
+    "eslint-plugin-putout": "^17.0.0",
     "lerna": "^6.0.1",
     "madrun": "^9.0.0",
     "montag": "^1.2.1",