@pushpalsdev/cli 1.1.5 → 1.1.7

package/runtime/sandbox/apps/workerpals/src/merge_conflict_job.ts

@@ -125,11 +125,31 @@ function isTestPath(path: string): boolean {
   return /(^tests\/|__tests__\/|\.test\.[cm]?[jt]sx?$|\.spec\.[cm]?[jt]sx?$)/i.test(path);
 }
 
+function formatBunTestPathArg(path: string): string {
+  const normalized = String(path ?? "").replace(/\\/g, "/").trim();
+  if (!normalized) return normalized;
+  const pathArg =
+    normalized.startsWith("./") ||
+    normalized.startsWith("../") ||
+    normalized.startsWith("/") ||
+    /^[A-Za-z]:\//.test(normalized)
+      ? normalized
+      : `./${normalized}`;
+  return quoteValidationCommandArg(pathArg);
+}
+
+function quoteValidationCommandArg(arg: string): string {
+  if (!/[\s"\\]/.test(arg)) return arg;
+  return `"${arg.replace(/\\/g, "\\\\").replace(/"/g, '\\"')}"`;
+}
+
 function deriveValidationSteps(existing: unknown, conflictPaths: string[]): string[] {
   const preserved = Array.isArray(existing)
     ? existing.map((entry) => String(entry ?? "").trim()).filter(Boolean)
     : [];
-  const targeted = conflictPaths.filter(isTestPath).map((entry) => `bun test ${entry}`);
+  const targeted = conflictPaths
+    .filter(isTestPath)
+    .map((entry) => `bun test ${formatBunTestPathArg(entry)}`);
   const merged = dedupeStrings([...targeted, ...preserved], 8);
   return merged.length > 0 ? merged : ["bun test"];
 }

package/runtime/sandbox/apps/workerpals/src/workerpals_main.ts

@@ -987,7 +987,11 @@ function failNoChangeReviewFixJob(jobId: string, result: WorkerJobResult): Worke
     ok: false,
     summary:
       `Rejected review-fix job ${jobId} produced no code changes; refusing unchanged branch re-review.`,
-    stderr: [result.stderr, "Apply at least one concrete fix before requesting another review."]
+    stderr: [
+      result.stderr,
+      "Review-fix jobs must make at least one concrete code/test/docs change before requesting another review.",
+      "If the reviewer feedback is invalid, commit a narrow explanatory change that documents the decision; unchanged branch re-review is refused.",
+    ]
       .filter(Boolean)
       .join("\n"),
     exitCode: typeof result.exitCode === "number" ? result.exitCode : 4,

package/runtime/sandbox/configs/default.toml

@@ -159,9 +159,11 @@ quality_publish_gate_enabled = true
 # Browser/e2e validation commands get a longer built-in floor (10m) because they
 # may need to start a dev server and run browser automation.
 quality_validation_step_timeout_ms = 180000
-quality_critic_timeout_ms = 45000
+quality_critic_timeout_ms = 90000
+quality_critic_timeout_behavior = "retry_once" # skip | retry_once | block
 quality_soft_pass_on_exhausted = true
 quality_critic_min_score = 8.0
+quality_critic_model = "" # Optional faster/smaller model override for the critic.
 quality_critic_max_diff_chars = 16000
 quality_critic_max_validation_output_chars = 8000
 executor_result_prefix = "__PUSHPALS_OH_RESULT__ "

package/runtime/sandbox/configs/local.example.toml

@@ -75,9 +75,11 @@ quality_publish_gate_enabled = true
 # Browser/e2e validation commands get a longer built-in floor (10m) because they
 # may need to start a dev server and run browser automation.
 quality_validation_step_timeout_ms = 180000
-quality_critic_timeout_ms = 45000
+quality_critic_timeout_ms = 90000
+quality_critic_timeout_behavior = "retry_once" # skip | retry_once | block
 quality_soft_pass_on_exhausted = true
 quality_critic_min_score = 8.0
+quality_critic_model = "" # Optional faster/smaller model override for the critic.
 quality_critic_max_diff_chars = 16000
 quality_critic_max_validation_output_chars = 8000
 executor_result_prefix = "__PUSHPALS_OH_RESULT__ "

package/runtime/sandbox/packages/shared/src/config.ts

@@ -20,7 +20,8 @@ const DEFAULT_WORKERPALS_OUTPUT_MAX_CHARS = 192 * 1024;
 const DEFAULT_WORKERPALS_OUTPUT_MAX_LINES = 600;
 const DEFAULT_WORKERPALS_OUTPUT_MAX_HEAD_LINES = 120;
 const DEFAULT_WORKERPALS_QUALITY_VALIDATION_STEP_TIMEOUT_MS = 180_000;
-const DEFAULT_WORKERPALS_QUALITY_CRITIC_TIMEOUT_MS = 45_000;
+const DEFAULT_WORKERPALS_QUALITY_CRITIC_TIMEOUT_MS = 90_000;
+const DEFAULT_WORKERPALS_QUALITY_CRITIC_TIMEOUT_BEHAVIOR = "retry_once";
 const DEFAULT_WORKERPALS_QUALITY_CRITIC_MAX_DIFF_CHARS = 16_000;
 const DEFAULT_WORKERPALS_QUALITY_CRITIC_MAX_VALIDATION_OUTPUT_CHARS = 8_000;
 export const DEFAULT_WORKERPALS_EXECUTOR = "openai_codex";
@@ -217,8 +218,10 @@ export interface PushPalsConfig {
     qualityPublishGateEnabled: boolean;
     qualityValidationStepTimeoutMs: number;
     qualityCriticTimeoutMs: number;
+    qualityCriticTimeoutBehavior: "skip" | "retry_once" | "block";
     qualitySoftPassOnExhausted: boolean;
     qualityCriticMinScore: number;
+    qualityCriticModel: string;
     qualityCriticMaxDiffChars: number;
     qualityCriticMaxValidationOutputChars: number;
     executorResultPrefix: string;
@@ -365,6 +368,17 @@ function asString(value: unknown, fallback: string): string {
   return fallback;
 }
 
+function asQualityCriticTimeoutBehavior(value: unknown): "skip" | "retry_once" | "block" {
+  const normalized = String(value ?? "")
+    .trim()
+    .toLowerCase()
+    .replace(/-/g, "_");
+  if (normalized === "skip" || normalized === "retry_once" || normalized === "block") {
+    return normalized;
+  }
+  return DEFAULT_WORKERPALS_QUALITY_CRITIC_TIMEOUT_BEHAVIOR as "skip" | "retry_once" | "block";
+}
+
 function asBoolean(value: unknown, fallback: boolean): boolean {
   if (typeof value === "boolean") return value;
   if (typeof value === "string") {
@@ -1003,6 +1017,10 @@ export function loadPushPalsConfig(options: LoadOptions = {}): PushPalsConfig {
       DEFAULT_WORKERPALS_QUALITY_CRITIC_TIMEOUT_MS,
     ),
   );
+  const workerQualityCriticTimeoutBehavior = asQualityCriticTimeoutBehavior(
+    process.env.WORKERPALS_QUALITY_CRITIC_TIMEOUT_BEHAVIOR ??
+      workerNode.quality_critic_timeout_behavior,
+  );
   const workerQualitySoftPassOnExhausted =
     parseBoolEnv("WORKERPALS_QUALITY_SOFT_PASS_ON_EXHAUSTED") ??
     asBoolean(workerNode.quality_soft_pass_on_exhausted, true);
@@ -1032,6 +1050,11 @@ export function loadPushPalsConfig(options: LoadOptions = {}): PushPalsConfig {
     if (!Number.isFinite(parsed)) return DEFAULT_WORKERPALS_QUALITY_CRITIC_MIN_SCORE;
     return Math.max(0, Math.min(10, parsed));
   })();
+  const workerQualityCriticModel = firstNonEmpty(
+    process.env.WORKERPALS_QUALITY_CRITIC_MODEL,
+    asString(workerNode.quality_critic_model, ""),
+    "",
+  );
   const workerQualityCriticMaxDiffChars = Math.max(
     256,
     Math.min(
@@ -2067,8 +2090,10 @@ export function loadPushPalsConfig(options: LoadOptions = {}): PushPalsConfig {
       qualityPublishGateEnabled: workerQualityPublishGateEnabled,
       qualityValidationStepTimeoutMs: workerQualityValidationStepTimeoutMs,
       qualityCriticTimeoutMs: workerQualityCriticTimeoutMs,
+      qualityCriticTimeoutBehavior: workerQualityCriticTimeoutBehavior,
       qualitySoftPassOnExhausted: workerQualitySoftPassOnExhausted,
       qualityCriticMinScore: workerQualityCriticMinScore,
+      qualityCriticModel: workerQualityCriticModel,
       qualityCriticMaxDiffChars: workerQualityCriticMaxDiffChars,
       qualityCriticMaxValidationOutputChars: workerQualityCriticMaxValidationOutputChars,
       executorResultPrefix: workerExecutorResultPrefix,