@pushpalsdev/cli 1.0.99 → 1.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushpalsdev/cli",
-  "version": "1.0.99",
+  "version": "1.1.0",
   "description": "PushPals terminal CLI for LocalBuddy -> RemoteBuddy orchestration",
   "license": "MIT",
   "repository": {

package/runtime/prompts/workerpals/openai_codex_task_execute_system_prompt.md

@@ -16,6 +16,7 @@ Execution rules:
 - If the hinted file is a thin wrapper or the behavior lives elsewhere, edit the behavior-owning file(s) needed to solve the task and explain the scope expansion in your final response.
 - Avoid irrelevant sprawl; the review agent will judge whether changed files are necessary for the requested outcome.
 - Read relevant files before editing, then run focused validation.
+- PushPals runs the deterministic ValidationGate after your edit, including any repo-required `vision.md` commands. During the editing turn, prefer focused/fast validation. Do not spend the main Codex execution budget repeatedly running long browser/e2e smoke commands such as `bun run web:e2e`; run them only when the task is specifically about the browser harness or when you need a final targeted confirmation and can stop promptly on a clear failure.
 - Use direct commands without shell wrappers. Prefer plain commands like `git diff -- path`, `git add <path>`, `git status --porcelain`, and `pwd`.
 - Do not wrap commands in `/bin/bash -lc`, `sh -lc`, `cmd /c`, or `powershell -Command`, and avoid pipelines, `awk`, heredocs, or multi-command shell snippets unless they are truly unavoidable.
 - If the command router rejects a command, simplify it to a single direct command instead of retrying more shell wrappers.

package/runtime/sandbox/apps/workerpals/src/execute_job.ts

@@ -647,7 +647,10 @@ async function terminateValidationProcessTree(
   }
 }
 
-function captureValidationStream(stream: ReadableStream<Uint8Array> | null) {
+function captureValidationStream(
+  stream: ReadableStream<Uint8Array> | null,
+  onChunk?: (chunk: string) => void,
+) {
   let text = "";
   let done = false;
   const reader = stream?.getReader();
@@ -657,7 +660,9 @@ function captureValidationStream(stream: ReadableStream<Uint8Array> | null) {
           while (true) {
             const result = await reader.read();
             if (result.done) break;
-            text += Buffer.from(result.value).toString("utf8");
+            const chunk = Buffer.from(result.value).toString("utf8");
+            text += chunk;
+            onChunk?.(chunk);
           }
         } catch {
           // Stream cancellation after process exit is expected when descendants
@@ -689,6 +694,41 @@ function captureValidationStream(stream: ReadableStream<Uint8Array> | null) {
   };
 }
 
+const DEFAULT_BROWSER_VALIDATION_FAILURE_IDLE_MS = 15_000;
+
+function browserValidationFailureIdleMs(env: Record<string, string>): number {
+  const configured = Number(env.PUSHPALS_VALIDATION_FAILURE_IDLE_MS ?? "");
+  if (Number.isFinite(configured) && configured >= 250) {
+    return Math.min(120_000, Math.trunc(configured));
+  }
+  return DEFAULT_BROWSER_VALIDATION_FAILURE_IDLE_MS;
+}
+
+function hasBrowserValidationFailureSignal(output: string): boolean {
+  const text = String(output ?? "");
+  if (!text.trim()) return false;
+  const patterns = [
+    /\bAssertionError\b/i,
+    /\bTimeoutError\b/i,
+    /\bWeb end-to-end smoke test failed:/i,
+    /\bexpect\([^)]*\)\.[a-z0-9_]+\([^)]*\)\s+failed/i,
+    /\bError:\s+expect\(/i,
+    /\blocator\.[a-z0-9_]+:\s+Timeout\s+\d+ms\s+exceeded\b/i,
+    /\bpage\.[a-z0-9_]+:\s+Timeout\s+\d+ms\s+exceeded\b/i,
+    /\bTimeout\s+\d+ms\s+exceeded\b/i,
+    /\bTest timeout of \d+ms exceeded\b/i,
+    /\bCall log:\s*(?:\r?\n|$)/i,
+    /\bwaiting for getBy(?:TestId|Role|Text|Label|Placeholder|Title)\([^)]*\)/i,
+    /\bpage\.[a-z0-9_]+:\s+net::ERR_[A-Z0-9_]+/i,
+    /\bbrowserType\.launch:/i,
+    /\bERR_SOCKET_BAD_PORT\b/i,
+    /\blisten\s+EPERM\b/i,
+    /\bEADDRINUSE\b/i,
+    /\berror:\s+script\s+"[^"]+"\s+exited with code\s+\d+/i,
+  ];
+  return patterns.some((pattern) => pattern.test(text));
+}
+
 export async function runValidationArgv(
   repo: string,
   command: string,
@@ -707,26 +747,62 @@ export async function runValidationArgv(
     stderr: "pipe",
     detached: process.platform !== "win32",
   });
-  const stdoutCapture = captureValidationStream(proc.stdout);
-  const stderrCapture = captureValidationStream(proc.stderr);
+  let lastOutputAt = Date.now();
+  const noteOutput = () => {
+    lastOutputAt = Date.now();
+  };
+  const stdoutCapture = captureValidationStream(proc.stdout, noteOutput);
+  const stderrCapture = captureValidationStream(proc.stderr, noteOutput);
   let timedOut = false;
+  let stoppedAfterFailureSignal = false;
   const timeout = Math.max(1_000, timeoutMs);
   let timeoutTimer: ReturnType<typeof setTimeout> | null = null;
-  const timeoutPromise = new Promise<"timeout">((resolveTimeout) => {
+  const timeoutPromise = new Promise<{ type: "timeout" }>((resolveTimeout) => {
     timeoutTimer = setTimeout(() => {
       timedOut = true;
-      void terminateValidationProcessTree(proc);
-      resolveTimeout("timeout");
+      resolveTimeout({ type: "timeout" });
     }, timeout);
   });
+
+  let failureSignalTimer: ReturnType<typeof setInterval> | null = null;
+  const failureSignalPromise = isLongRunningBrowserValidationCommand(command)
+    ? new Promise<{ type: "failure-signal" }>((resolveFailureSignal) => {
+        const idleMs = browserValidationFailureIdleMs(env);
+        failureSignalTimer = setInterval(() => {
+          const combinedOutput = `${stdoutCapture.text()}\n${stderrCapture.text()}`;
+          if (
+            hasBrowserValidationFailureSignal(combinedOutput) &&
+            Date.now() - lastOutputAt >= idleMs
+          ) {
+            stoppedAfterFailureSignal = true;
+            resolveFailureSignal({ type: "failure-signal" });
+          }
+        }, 250);
+      })
+    : new Promise<never>(() => {
+        // Non-browser validations should only end on process exit or timeout.
+      });
+
   const exitOrTimeout = await Promise.race([
     proc.exited.then((code) => ({ type: "exit" as const, code })),
     timeoutPromise,
+    failureSignalPromise,
   ]);
   if (timeoutTimer) clearTimeout(timeoutTimer);
-  const exitCode = exitOrTimeout === "timeout" ? 124 : exitOrTimeout.code;
+  if (failureSignalTimer) clearInterval(failureSignalTimer);
+
+  if (timedOut || stoppedAfterFailureSignal) {
+    await terminateValidationProcessTree(proc);
+  }
+
+  const exitCode =
+    exitOrTimeout.type === "timeout"
+      ? 124
+      : exitOrTimeout.type === "failure-signal"
+        ? 1
+        : exitOrTimeout.code;
 
-  if (!timedOut) {
+  if (!timedOut && !stoppedAfterFailureSignal) {
     await Promise.race([
       Promise.all([stdoutCapture.promise, stderrCapture.promise]),
       Bun.sleep(1_000),
@@ -754,6 +830,9 @@ export async function runValidationArgv(
       [
         stderrCapture.text().trim(),
         timedOut ? timeoutMessage : "",
+        stoppedAfterFailureSignal
+          ? `Validation command emitted a browser/e2e failure signal and then produced no output for ${browserValidationFailureIdleMs(env)}ms. PushPals terminated the leaked process tree and preserved the captured failure output for repair.`
+          : "",
       ]
         .filter(Boolean)
         .join("\n"),
@@ -1474,6 +1553,12 @@ export function extractValidationFailureDigest(run: {
     /\bCould not resolve\s+['"`]?[^'"`\r\n]+['"`]?[^\r\n]*/i,
     /\bModule not found[^\r\n]*/i,
     /\bbrowserType\.launch:[^\r\n]*/i,
+    /\bWeb end-to-end smoke test failed:[^\r\n]*/i,
+    /\blocator\.[a-z0-9_]+:\s+Timeout\s+\d+ms\s+exceeded[^\r\n]*/i,
+    /\bpage\.[a-z0-9_]+:\s+Timeout\s+\d+ms\s+exceeded[^\r\n]*/i,
+    /\bTimeout\s+\d+ms\s+exceeded[^\r\n]*/i,
+    /\bwaiting for getBy(?:TestId|Role|Text|Label|Placeholder|Title)\([^)]*\)[^\r\n]*/i,
+    /\bpage\.[a-z0-9_]+:\s+net::ERR_[A-Z0-9_]+[^\r\n]*/i,
     /\bExecutable doesn't exist[^\r\n]*/i,
     /\bPlease run the following command to download new browsers:[^\r\n]*(?:\r?\n\s+[^\r\n]+)?/i,
     /\bRun ["`]?npx playwright install[^'"`\r\n]*["`]?[^\r\n]*/i,

package/runtime/sandbox/prompts/workerpals/openai_codex_task_execute_system_prompt.md

@@ -16,6 +16,7 @@ Execution rules:
 - If the hinted file is a thin wrapper or the behavior lives elsewhere, edit the behavior-owning file(s) needed to solve the task and explain the scope expansion in your final response.
 - Avoid irrelevant sprawl; the review agent will judge whether changed files are necessary for the requested outcome.
 - Read relevant files before editing, then run focused validation.
+- PushPals runs the deterministic ValidationGate after your edit, including any repo-required `vision.md` commands. During the editing turn, prefer focused/fast validation. Do not spend the main Codex execution budget repeatedly running long browser/e2e smoke commands such as `bun run web:e2e`; run them only when the task is specifically about the browser harness or when you need a final targeted confirmation and can stop promptly on a clear failure.
 - Use direct commands without shell wrappers. Prefer plain commands like `git diff -- path`, `git add <path>`, `git status --porcelain`, and `pwd`.
 - Do not wrap commands in `/bin/bash -lc`, `sh -lc`, `cmd /c`, or `powershell -Command`, and avoid pipelines, `awk`, heredocs, or multi-command shell snippets unless they are truly unavoidable.
 - If the command router rejects a command, simplify it to a single direct command instead of retrying more shell wrappers.