@pushary/agent-hooks 0.71.0 → 0.73.0

package/CHANGELOG.md

@@ -1,5 +1,64 @@
 # Changelog
 
+## 0.73.0
+
+### Codex could finish setup with no skill installed
+
+If your machine already uses skills.sh, setup installs the Pushary skill
+through that CLI so the install registers rather than being invisible. For
+Codex, `skills add --agent codex` prints "copy to Codex", says "Installation
+complete" and exits 0, then writes only `~/.agents/skills/pushary`. Nothing
+lands in `~/.codex/skills`, which is where Codex reads. Setup took the exit
+code as proof, skipped the copy it ships, and Codex ended up with no skill.
+
+Doctor caught it, and then gave advice that could not work: clean and set up
+again reinstalled exactly the same way and failed the same check.
+
+The exit code no longer decides this. What decides it is whether the run left
+a SKILL.md where that agent reads, which is the same thing doctor looks at,
+and setup writes its own copy when it did not. Anything skills.sh really did
+install is left exactly as it installed it, symlinks included.
+
+Everything else about the wiring was fine, so this cost you the skill and
+nothing more. Approvals, hooks and the instructions in `~/.codex/AGENTS.md`
+were all in place.
+
+### A skill that will not install no longer stops setup
+
+The skill is the one piece of the wiring nothing else depends on. It used to
+be able to abort setup partway, leaving an agent half configured. Now it warns
+and setup finishes the rest, and `pushary doctor` tells you the skill is
+missing.
+
+## 0.72.0
+
+### Setup tells you when Codex was already quarantined
+
+0.71.0 stopped setup from getting your Codex binary deleted. This handles the
+machines where it already happened. What macOS leaves behind passes every check
+setup made: the `codex` on your PATH is a small JavaScript launcher and it
+survives, `which codex` still answers, only the binary it launches is gone. So
+setup wired up an agent that could not start and reported success.
+
+It now says so before writing anything, and only when it can prove it: a vendor
+directory that exists and holds nothing the size of a native binary. A layout it
+does not recognise stays quiet, because telling somebody their working install is
+broken is the worse mistake. Reinstall with `npm install -g @openai/codex` or
+`brew install --cask codex`.
+
+### Setup no longer runs the Hermes binary either
+
+The same hazard, one agent over. When the config edit that enables the plugin
+failed, setup fell back to running `hermes plugins enable pushary` — executing a
+third-party agent binary, which is exactly what cost people their Codex install.
+The fallback also did not work, because `hermes plugins enable` does not see a
+pip install. It is gone, and a failed config edit now tells you the one line to
+add by hand.
+
+Executing an agent binary is now a build failure rather than a habit: every
+source file in this package is scanned on every CI run, and the check knows the
+difference between running `codex` and asking `which` where it is.
+
 ## 0.71.0
 
 ### Setting up Codex no longer gets Codex deleted by macOS
@@ -15,9 +74,6 @@ it. The version now comes from the package manifest next to the binary, which
 covers npm, bun, pnpm and yarn installs, and from `brew list` for the Homebrew
 cask, which ships no manifest. Same result, nothing launched.
 
-If your Codex was already quarantined, reinstall it: `npm install -g @openai/codex`
-or `brew install --cask codex`.
-
 ## 0.70.0
 
 ### A key you name is the key you get

package/dist/bin/pushary-setup.js

@@ -110,8 +110,8 @@ import {
 } from "../chunk-KZERVKTD.js";
 
 // bin/pushary-setup.ts
-import { existsSync, readFileSync, writeFileSync, mkdirSync, cpSync, rmSync, renameSync, realpathSync } from "fs";
-import { join, dirname, basename } from "path";
+import { existsSync, readFileSync, writeFileSync, mkdirSync, cpSync, rmSync, renameSync, realpathSync, readdirSync, statSync } from "fs";
+import { join as join2, dirname as dirname2, basename } from "path";
 import { homedir, tmpdir } from "os";
 import { execSync as execSync2 } from "child_process";
 import { checkbox, input, confirm } from "@inquirer/prompts";
@@ -199,6 +199,7 @@ var describeClosing = (facts) => {
 };
 
 // src/setup/codex-version.ts
+import { dirname, join } from "path";
 var parseCodexVersion = (raw) => {
   const match = raw.match(/(\d+)\.(\d+)\.(\d+)/);
   if (!match) return null;
@@ -210,21 +211,21 @@ var compareCodexVersion = (a, b) => {
   }
   return 0;
 };
-var versionFromPackageManifest = (probe, binPath) => {
-  let dir = probe.dirname(binPath);
+var versionFromManifest = (probe, binPath) => {
+  let dir = dirname(binPath);
   for (let depth = 0; depth < 4; depth++) {
-    const raw = probe.readFile(probe.join(dir, "package.json"));
+    const raw = probe.readFile(join(dir, "package.json"));
     if (raw) {
       try {
-        const manifest = JSON.parse(raw);
-        if (typeof manifest.version === "string") {
-          const parsed = parseCodexVersion(manifest.version);
+        const { version } = JSON.parse(raw);
+        if (typeof version === "string") {
+          const parsed = parseCodexVersion(version);
           if (parsed) return parsed;
         }
       } catch {
       }
     }
-    const parent = probe.dirname(dir);
+    const parent = dirname(dir);
     if (parent === dir) break;
     dir = parent;
   }
@@ -233,16 +234,51 @@ var versionFromPackageManifest = (probe, binPath) => {
 var readCodexVersion = (probe) => {
   const onPath = probe.resolveOnPath();
   if (onPath) {
-    const real = probe.realpath(onPath) ?? onPath;
-    const fromManifest = versionFromPackageManifest(probe, real);
-    if (fromManifest) return { kind: "known", version: fromManifest, source: "package manifest" };
+    const fromManifest = versionFromManifest(probe, probe.realpath(onPath) ?? onPath);
+    if (fromManifest) return fromManifest;
   }
   const brew = probe.brewVersions();
-  if (brew) {
-    const parsed = parseCodexVersion(brew);
-    if (parsed) return { kind: "known", version: parsed, source: "homebrew" };
+  return brew ? parseCodexVersion(brew) : null;
+};
+
+// src/setup/codex-install.ts
+var NATIVE_BINARY_MIN_BYTES = 20 * 1024 * 1024;
+var packageRootFor = (probe, binPath) => {
+  let dir = probe.dirname(binPath);
+  for (let depth = 0; depth < 4; depth++) {
+    if (probe.exists(probe.join(dir, "package.json"))) return dir;
+    const parent = probe.dirname(dir);
+    if (parent === dir) return null;
+    dir = parent;
   }
-  return { kind: "unknown" };
+  return null;
+};
+var holdsNativeBinary = (probe, dir, depth = 0) => {
+  if (depth > 4) return false;
+  const entries = probe.listDir(dir);
+  if (!entries) return false;
+  return entries.some((entry) => {
+    const path = probe.join(dir, entry);
+    const size = probe.fileSize(path);
+    if (size !== null) return size >= NATIVE_BINARY_MIN_BYTES;
+    return holdsNativeBinary(probe, path, depth + 1);
+  });
+};
+var platformPackages = (probe, packageRoot) => {
+  const scopes = [probe.join(packageRoot, "node_modules", "@openai"), probe.dirname(packageRoot)];
+  return scopes.flatMap(
+    (scope) => (probe.listDir(scope) ?? []).filter((entry) => entry.startsWith("codex-")).map((entry) => probe.join(scope, entry))
+  );
+};
+var checkCodexInstall = (probe) => {
+  const onPath = probe.resolveOnPath();
+  if (!onPath) return { kind: "unknown" };
+  const packageRoot = packageRootFor(probe, probe.realpath(onPath) ?? onPath);
+  if (!packageRoot) return { kind: "unknown" };
+  const vendors = platformPackages(probe, packageRoot).map((pkg) => probe.join(pkg, "vendor")).filter((vendor) => probe.exists(vendor));
+  if (vendors.length === 0) return { kind: "unknown" };
+  if (vendors.some((vendor) => holdsNativeBinary(probe, vendor))) return { kind: "ok" };
+  return { kind: "binary-missing", vendorDir: vendors[0] };
 };
 
 // src/skills-cli.ts
@@ -258,6 +294,17 @@ var installSkillViaSkillsCli = (agent) => {
     return false;
   }
 };
+var installAgentSkill = async (request, effects) => {
+  if (request.skillsCliInUse) {
+    const startedAt = effects.now();
+    if (effects.runSkillsCli(request.agent)) {
+      const modifiedAt = effects.skillModifiedAt(request.agentSkillDir);
+      if (modifiedAt !== null && modifiedAt >= startedAt) return "skills-cli";
+    }
+  }
+  await effects.writePackagedSkill(request.agentSkillDir);
+  return "packaged-copy";
+};
 
 // src/setup/telemetry.ts
 var currentStep = "start";
@@ -482,7 +529,7 @@ var readAgentJson = (filePath) => {
   );
 };
 var writeJson = (filePath, data) => {
-  const dir = dirname(filePath);
+  const dir = dirname2(filePath);
   if (!existsSync(dir)) mkdirSync(dir, { recursive: true });
   writeFileSync(filePath, JSON.stringify(data, null, 2) + "\n", "utf-8");
 };
@@ -561,24 +608,32 @@ var installGlobally2 = async () => {
 var _cachedSkillContent = null;
 var fetchSkillContent = async () => {
   if (_cachedSkillContent) return _cachedSkillContent;
-  const __dirname = dirname(fileURLToPath(import.meta.url));
+  const __dirname = dirname2(fileURLToPath(import.meta.url));
   const candidates = [
-    join(__dirname, "..", "..", "data", "SKILL.md"),
-    join(__dirname, "..", "data", "SKILL.md")
+    join2(__dirname, "..", "..", "data", "SKILL.md"),
+    join2(__dirname, "..", "data", "SKILL.md")
   ];
   const source = candidates.find((path) => existsSync(path));
   if (!source) throw new Error("packaged skill not found");
   _cachedSkillContent = readFileSync(source, "utf-8");
   return _cachedSkillContent;
 };
-var skillsCliInUse = () => isInstalled("skills") || existsSync(join(homedir(), ".agents", "skills"));
-var installSkill = async (agent, fallbackDir) => {
+var writePackagedSkill = async (dir) => {
+  const content = await fetchSkillContent();
+  if (!existsSync(dir)) mkdirSync(dir, { recursive: true });
+  writeFileSync(join2(dir, "SKILL.md"), content, "utf-8");
+};
+var skillsCliInUse = () => isInstalled("skills") || existsSync(join2(homedir(), ".agents", "skills"));
+var skillInstallEffects = {
+  runSkillsCli: installSkillViaSkillsCli,
+  skillModifiedAt: (dir) => statSync(join2(dir, "SKILL.md"), { throwIfNoEntry: false })?.mtimeMs ?? null,
+  writePackagedSkill,
+  now: () => Date.now()
+};
+var installSkill = async (agent, agentSkillDir) => {
   await spinner("Installing Pushary skill", async () => {
-    if (skillsCliInUse() && installSkillViaSkillsCli(agent)) return;
-    const content = await fetchSkillContent();
-    if (!existsSync(fallbackDir)) mkdirSync(fallbackDir, { recursive: true });
-    writeFileSync(join(fallbackDir, "SKILL.md"), content, "utf-8");
-  });
+    await installAgentSkill({ agent, agentSkillDir, skillsCliInUse: skillsCliInUse() }, skillInstallEffects);
+  }, { optional: true });
 };
 var setupClaudeCode = async (apiKey) => {
   console.log(`
@@ -624,8 +679,8 @@ var resolveHermesPython = () => {
     }
   } catch {
   }
-  const venvRoot = join(homedir(), ".hermes", "hermes-agent", "venv");
-  const candidates = IS_WINDOWS ? [join(venvRoot, "Scripts", "python.exe"), join(venvRoot, "Scripts", "python3.exe")] : [join(venvRoot, "bin", "python3"), join(venvRoot, "bin", "python")];
+  const venvRoot = join2(homedir(), ".hermes", "hermes-agent", "venv");
+  const candidates = IS_WINDOWS ? [join2(venvRoot, "Scripts", "python.exe"), join2(venvRoot, "Scripts", "python3.exe")] : [join2(venvRoot, "bin", "python3"), join2(venvRoot, "bin", "python")];
   return candidates.find(existsSync) ?? null;
 };
 var ensurePip = (python) => {
@@ -641,13 +696,13 @@ var ensurePip = (python) => {
 };
 var enablePusharyPlugin = (python) => {
   const snippet = 'from hermes_cli.config import load_config, save_config; c = load_config(); p = c.get("plugins") if isinstance(c.get("plugins"), dict) else {}; e = p.get("enabled") if isinstance(p.get("enabled"), list) else []; p["enabled"] = (e + ["pushary"]) if "pushary" not in e else e; c["plugins"] = p; a = c.get("agent") if isinstance(c.get("agent"), dict) else {}; d = a.get("disabled_toolsets") if isinstance(a.get("disabled_toolsets"), list) else []; a["disabled_toolsets"] = (d + ["clarify"]) if "clarify" not in d else d; c["agent"] = a; save_config(c)';
-  const scriptPath = join(tmpdir(), `pushary-hermes-${process.pid}.py`);
+  const scriptPath = join2(tmpdir(), `pushary-hermes-${process.pid}.py`);
   try {
     writeFileSync(scriptPath, snippet.split("; ").join("\n"), "utf-8");
     execSync2(`"${python}" "${scriptPath}"`, { stdio: "pipe", timeout: 15e3 });
-    return;
+    return true;
   } catch {
-    execSync2("hermes plugins enable pushary", { stdio: "ignore", timeout: 1e4 });
+    return false;
   } finally {
     try {
       rmSync(scriptPath, { force: true });
@@ -674,9 +729,14 @@ var setupHermes = async (_apiKey) => {
     ensurePip(python);
     execSync2(`"${python}" -m pip install --upgrade hermes-plugin-pushary`, { stdio: "pipe", timeout: 18e4 });
   });
+  let pluginEnabled = false;
   await spinner("Enabling plugin + routing questions to push", async () => {
-    enablePusharyPlugin(python);
+    pluginEnabled = enablePusharyPlugin(python);
   });
+  if (!pluginEnabled) {
+    console.log(`  ${yellow("!")} Installed the plugin, but could not edit Hermes' config.`);
+    noteManual('Add "pushary" to plugins.enabled in ~/.hermes/config.yaml, and "clarify" to agent.disabled_toolsets');
+  }
   console.log();
   console.log(`  ${dim("What this configured:")}`);
   console.log(`  ${dim("\u2022")} Native tools: pushary_notify, pushary_ask, pushary_wait, pushary_cancel`);
@@ -685,49 +745,71 @@ var setupHermes = async (_apiKey) => {
   console.log(`  ${dim("\u2022")} Permission gating: set ${bold("PUSHARY_GATE_TOOLS")} to require lock-screen approval for risky tools`);
   console.log(`  ${dim("To re-enable terminal prompts:")} remove ${bold("clarify")} from ${dim("agent.disabled_toolsets")} in ~/.hermes/config.yaml`);
 };
-var CODEX_HOOKS_JSON = join(CODEX_HOME, "hooks.json");
+var CODEX_HOOKS_JSON = join2(CODEX_HOME, "hooks.json");
 var CODEX_HOOKS_MIN_VERSION = [0, 122, 0];
 var CODEX_TRUST_VERIFIED_MAX = [0, 142, 2];
+var codexOnPath = () => {
+  const whichCmd = IS_WINDOWS ? "where" : "which";
+  try {
+    const found = execSync2(`${whichCmd} codex`, { encoding: "utf-8", stdio: "pipe", timeout: 5e3 }).split("\n")[0].trim();
+    return found || null;
+  } catch {
+    return null;
+  }
+};
+var codexRealpath = (path) => {
+  try {
+    return realpathSync(path);
+  } catch {
+    return null;
+  }
+};
 var detectCodexVersion = () => readCodexVersion({
-  resolveOnPath: () => {
-    const whichCmd = IS_WINDOWS ? "where" : "which";
+  resolveOnPath: codexOnPath,
+  realpath: codexRealpath,
+  readFile: (path) => {
     try {
-      const found = execSync2(`${whichCmd} codex`, { encoding: "utf-8", stdio: "pipe", timeout: 5e3 }).split("\n")[0].trim();
-      return found || null;
+      return readFileSync(path, "utf-8");
     } catch {
       return null;
     }
   },
-  realpath: (path) => {
+  brewVersions: () => {
     try {
-      return realpathSync(path);
+      return execSync2("brew list --versions codex", {
+        encoding: "utf-8",
+        stdio: "pipe",
+        timeout: 1e4
+      }).trim() || null;
     } catch {
       return null;
     }
-  },
-  readFile: (path) => {
+  }
+});
+var detectCodexInstall = () => checkCodexInstall({
+  resolveOnPath: codexOnPath,
+  realpath: codexRealpath,
+  exists: existsSync,
+  listDir: (path) => {
     try {
-      return readFileSync(path, "utf-8");
+      return readdirSync(path);
     } catch {
       return null;
     }
   },
-  brewVersions: () => {
+  fileSize: (path) => {
     try {
-      return execSync2("brew list --versions codex", {
-        encoding: "utf-8",
-        stdio: "pipe",
-        timeout: 1e4
-      }).trim() || null;
+      const stat = statSync(path);
+      return stat.isFile() ? stat.size : null;
     } catch {
       return null;
     }
   },
-  join,
-  dirname
+  join: join2,
+  dirname: dirname2
 });
-var codexSupportsHooks = (result) => result.kind === "known" && compareCodexVersion(result.version, CODEX_HOOKS_MIN_VERSION) >= 0;
-var codexTrustAutoSupported = (result) => result.kind === "known" && codexSupportsHooks(result) && compareCodexVersion(result.version, CODEX_TRUST_VERIFIED_MAX) <= 0;
+var codexSupportsHooks = (version) => version !== null && compareCodexVersion(version, CODEX_HOOKS_MIN_VERSION) >= 0;
+var codexTrustAutoSupported = (version) => version !== null && codexSupportsHooks(version) && compareCodexVersion(version, CODEX_TRUST_VERIFIED_MAX) <= 0;
 var removeCodexNotifyEntry = (codexConfig) => {
   let raw = "";
   try {
@@ -771,6 +853,16 @@ var setupCodex = async (apiKey) => {
     console.log(`  ${dim("Install Codex and re-run setup to configure.")}`);
     return "skipped";
   }
+  if (detectCodexInstall().kind === "binary-missing") {
+    console.log(`  ${yellow("!")} Your Codex install is missing the binary it runs.`);
+    console.log(`  ${dim("A Pushary setup before 0.71.0 asked Codex its version. On macOS that hands")}`);
+    console.log(`  ${dim("the binary to XProtect, which quarantines the Codex CLI and moves it to the")}`);
+    console.log(`  ${dim("Trash. Setup no longer runs it. Reinstall Codex to get it back:")}`);
+    console.log(`  ${cyan("npm install -g @openai/codex")}`);
+    console.log(`  ${dim("Configuring anyway, so it is ready when Codex is.")}`);
+    console.log();
+    noteManual("Reinstall Codex: a Pushary setup before 0.71.0 got its binary quarantined by macOS");
+  }
   await installGlobally2();
   const codexConfig = codexConfigToml();
   await spinner("Adding Pushary MCP server (key embedded, auto-allowed)", async () => {
@@ -806,7 +898,7 @@ var setupCodex = async (apiKey) => {
       removeCodexNotifyEntry(codexConfig);
     });
   } else {
-    if (codexVersion.kind === "known") {
+    if (codexVersion !== null) {
       console.log(`  ${yellow("!")} This Codex version predates native hooks (needs ${CODEX_HOOKS_MIN_VERSION.join(".")}+).`);
       console.log(`  ${dim("Installing the deprecated notify handler instead. Upgrade Codex and re-run setup")}`);
       console.log(`  ${dim("to get policy enforcement, phone approvals, and session tracking.")}`);
@@ -853,17 +945,17 @@ var setupCodex = async (apiKey) => {
   }
 };
 var resolveBundledPlugin = () => {
-  const dir = dirname(fileURLToPath(import.meta.url));
+  const dir = dirname2(fileURLToPath(import.meta.url));
   const candidates = [
-    join(dir, "..", "..", "data", "cursor-plugin"),
-    join(dir, "..", "data", "cursor-plugin"),
-    join(dir, "..", "..", "..", "cursor-plugin"),
-    join(dir, "..", "..", "cursor-plugin")
+    join2(dir, "..", "..", "data", "cursor-plugin"),
+    join2(dir, "..", "data", "cursor-plugin"),
+    join2(dir, "..", "..", "..", "cursor-plugin"),
+    join2(dir, "..", "..", "cursor-plugin")
   ];
-  return candidates.find((p) => existsSync(join(p, ".cursor-plugin", "plugin.json"))) ?? null;
+  return candidates.find((p) => existsSync(join2(p, ".cursor-plugin", "plugin.json"))) ?? null;
 };
 var installCursorUserHooks = (gateScript) => {
-  const template = readJson(join(CURSOR_PLUGIN_DIR, "hooks", "hooks.json")).hooks?.beforeShellExecution?.[0];
+  const template = readJson(join2(CURSOR_PLUGIN_DIR, "hooks", "hooks.json")).hooks?.beforeShellExecution?.[0];
   if (!template) throw new Error("bundled Cursor hooks.json missing a beforeShellExecution entry");
   const entry = { ...template, command: `node "${gateScript}"` };
   let userHooks = {};
@@ -885,7 +977,7 @@ var installCursorUserHooks = (gateScript) => {
   writeJson(CURSOR_USER_HOOKS, { ...userHooks, version: userHooks.version ?? 1, hooks });
 };
 var neutralizePluginGate = () => {
-  const path = join(CURSOR_PLUGIN_DIR, "hooks", "hooks.json");
+  const path = join2(CURSOR_PLUGIN_DIR, "hooks", "hooks.json");
   if (!existsSync(path)) return;
   const data = readJson(path);
   if (data.hooks && "beforeShellExecution" in data.hooks) {
@@ -900,7 +992,7 @@ var setupCursor = async (apiKey) => {
   const source = resolveBundledPlugin();
   if (!source) throw new Error("bundled Cursor plugin not found in this package");
   await spinner("Installing Pushary plugin", async () => {
-    const staging = join(dirname(CURSOR_PLUGIN_DIR), `.pushary-staging-${process.pid}`);
+    const staging = join2(dirname2(CURSOR_PLUGIN_DIR), `.pushary-staging-${process.pid}`);
     const backup = `${CURSOR_PLUGIN_DIR}.pushary-backup-${(/* @__PURE__ */ new Date()).toISOString().replace(/[:.]/g, "-")}`;
     rmSync(staging, { recursive: true, force: true });
     try {
@@ -908,7 +1000,7 @@ var setupCursor = async (apiKey) => {
         recursive: true,
         filter: (p) => !["tools", "node_modules", ".git", ".DS_Store"].includes(basename(p))
       });
-      const staged = readJsonSafe(join(staging, ".cursor-plugin", "plugin.json"));
+      const staged = readJsonSafe(join2(staging, ".cursor-plugin", "plugin.json"));
       if (staged.kind !== "ok") {
         throw new Error("staged Cursor plugin is missing or has an unreadable plugin.json");
       }
@@ -926,7 +1018,7 @@ var setupCursor = async (apiKey) => {
     }
   });
   await spinner("Linking your API key", async () => {
-    const mcpPath = join(CURSOR_PLUGIN_DIR, "mcp.json");
+    const mcpPath = join2(CURSOR_PLUGIN_DIR, "mcp.json");
     const mcp = readAgentJson(mcpPath);
     const servers = mcp.mcpServers ?? {};
     if (servers.pushary) {
@@ -936,7 +1028,7 @@ var setupCursor = async (apiKey) => {
     }
   });
   await spinner("Registering permission gate (~/.cursor/hooks.json)", async () => {
-    installCursorUserHooks(join(CURSOR_PLUGIN_DIR, "scripts", "pushary-gate.mjs"));
+    installCursorUserHooks(join2(CURSOR_PLUGIN_DIR, "scripts", "pushary-gate.mjs"));
     neutralizePluginGate();
   });
   console.log();
@@ -948,23 +1040,23 @@ var setupCursor = async (apiKey) => {
   noteManual("Fully quit and reopen Cursor. A Reload Window may not be enough.");
 };
 var resolveBundledVsCodePlugin = () => {
-  const dir = dirname(fileURLToPath(import.meta.url));
+  const dir = dirname2(fileURLToPath(import.meta.url));
   const candidates = [
-    join(dir, "..", "..", "data", "vscode-plugin"),
-    join(dir, "..", "data", "vscode-plugin"),
-    join(dir, "..", "..", "..", "vscode-plugin"),
-    join(dir, "..", "..", "vscode-plugin")
+    join2(dir, "..", "..", "data", "vscode-plugin"),
+    join2(dir, "..", "data", "vscode-plugin"),
+    join2(dir, "..", "..", "..", "vscode-plugin"),
+    join2(dir, "..", "..", "vscode-plugin")
   ];
-  return candidates.find((p) => existsSync(join(p, ".claude-plugin", "plugin.json"))) ?? null;
+  return candidates.find((p) => existsSync(join2(p, ".claude-plugin", "plugin.json"))) ?? null;
 };
 var pinVsCodeGatePath = (pluginDir) => {
-  const hooksPath = join(pluginDir, "hooks", "hooks.json");
+  const hooksPath = join2(pluginDir, "hooks", "hooks.json");
   const data = readJson(hooksPath);
   const entries = data.hooks?.PreToolUse;
   if (!Array.isArray(entries) || entries.length === 0) {
     throw new Error("bundled VS Code hooks.json is missing a PreToolUse entry");
   }
-  const gate = join(pluginDir, "scripts", "pushary-gate.mjs");
+  const gate = join2(pluginDir, "scripts", "pushary-gate.mjs");
   data.hooks.PreToolUse = entries.map((entry) => ({ ...entry, command: `node "${gate}"` }));
   writeJson(hooksPath, data);
 };
@@ -980,7 +1072,7 @@ var registerVsCodePlugin = (pluginDir) => {
       continue;
     }
     if (current !== null) backupFile(settingsPath);
-    mkdirSync(dirname(settingsPath), { recursive: true });
+    mkdirSync(dirname2(settingsPath), { recursive: true });
     writeFileAtomic(settingsPath, result.content);
     written.push(settingsPath);
   }
@@ -993,16 +1085,16 @@ var setupVsCode = async (apiKey) => {
   const source = resolveBundledVsCodePlugin();
   if (!source) throw new Error("bundled VS Code plugin not found in this package");
   await spinner("Installing Pushary plugin", async () => {
-    const staging = join(dirname(VSCODE_PLUGIN_DIR), `.pushary-staging-vscode-${process.pid}`);
+    const staging = join2(dirname2(VSCODE_PLUGIN_DIR), `.pushary-staging-vscode-${process.pid}`);
     const backup = `${VSCODE_PLUGIN_DIR}.pushary-backup-${(/* @__PURE__ */ new Date()).toISOString().replace(/[:.]/g, "-")}`;
-    mkdirSync(dirname(VSCODE_PLUGIN_DIR), { recursive: true });
+    mkdirSync(dirname2(VSCODE_PLUGIN_DIR), { recursive: true });
     rmSync(staging, { recursive: true, force: true });
     try {
       cpSync(source, staging, {
         recursive: true,
         filter: (p) => !["tools", "node_modules", ".git", ".DS_Store"].includes(basename(p))
       });
-      const staged = readJsonSafe(join(staging, ".claude-plugin", "plugin.json"));
+      const staged = readJsonSafe(join2(staging, ".claude-plugin", "plugin.json"));
       if (staged.kind !== "ok") {
         throw new Error("staged VS Code plugin is missing or has an unreadable plugin.json");
       }
@@ -1020,7 +1112,7 @@ var setupVsCode = async (apiKey) => {
     }
   });
   await spinner("Linking your API key", async () => {
-    const mcpPath = join(VSCODE_PLUGIN_DIR, ".mcp.json");
+    const mcpPath = join2(VSCODE_PLUGIN_DIR, ".mcp.json");
     const mcp = readAgentJson(mcpPath);
     const servers = mcp.mcpServers ?? {};
     if (servers.pushary) {
@@ -1160,27 +1252,27 @@ var agentIsWired = (agent) => {
       return claudeWired({
         claudeJson: readJson2(CLAUDE_JSON),
         settings: readJson2(CLAUDE_SETTINGS),
-        skillExists: existsSync(join(CLAUDE_SKILL_DIR, "SKILL.md"))
+        skillExists: existsSync(join2(CLAUDE_SKILL_DIR, "SKILL.md"))
       });
     case "codex": {
       let config = null;
       try {
-        config = parseTOML(readFileSync(join(CODEX_HOME, "config.toml"), "utf-8"));
+        config = parseTOML(readFileSync(join2(CODEX_HOME, "config.toml"), "utf-8"));
       } catch {
         config = null;
       }
       return codexWired({
         config,
         hooks: readJson2(CODEX_HOOKS_JSON),
-        skillExists: existsSync(join(CODEX_SKILL_DIR, "SKILL.md"))
+        skillExists: existsSync(join2(CODEX_SKILL_DIR, "SKILL.md"))
       });
     }
     case "gemini_cli":
       return geminiWired({ settings: readJson2(GEMINI_SETTINGS) });
     case "cursor":
-      return existsSync(join(CURSOR_PLUGIN_DIR, "mcp.json"));
+      return existsSync(join2(CURSOR_PLUGIN_DIR, "mcp.json"));
     case "vscode":
-      return existsSync(join(VSCODE_PLUGIN_DIR, ".mcp.json"));
+      return existsSync(join2(VSCODE_PLUGIN_DIR, ".mcp.json"));
     default:
       return true;
   }
@@ -1208,8 +1300,8 @@ var offerProjectInstructions = async (agents, options) => {
   });
   if (!wanted) return;
   for (const target of targets) {
-    await spinner(`Writing managed block to ${join(process.cwd(), target.file)}`, async () => {
-      writeInstructionBlock(join(process.cwd(), target.file), renderProjectAgentInstructions(target.label));
+    await spinner(`Writing managed block to ${join2(process.cwd(), target.file)}`, async () => {
+      writeInstructionBlock(join2(process.cwd(), target.file), renderProjectAgentInstructions(target.label));
     }, { optional: true });
   }
   console.log(`  ${dim("Commit the file to share it. Teammates without a key fall back to the terminal.")}`);
@@ -1360,12 +1452,12 @@ var resolveAgents = async (options) => {
   });
 };
 var AGENT_TARGETS = {
-  claude_code: [CLAUDE_JSON, CLAUDE_SETTINGS, join(CLAUDE_SKILL_DIR, "SKILL.md")],
-  codex: [join(CODEX_HOME, "config.toml"), CODEX_HOOKS_JSON, join(CODEX_SKILL_DIR, "SKILL.md"), CODEX_AGENTS_MD],
+  claude_code: [CLAUDE_JSON, CLAUDE_SETTINGS, join2(CLAUDE_SKILL_DIR, "SKILL.md")],
+  codex: [join2(CODEX_HOME, "config.toml"), CODEX_HOOKS_JSON, join2(CODEX_SKILL_DIR, "SKILL.md"), CODEX_AGENTS_MD],
   gemini_cli: [GEMINI_SETTINGS, GEMINI_MD],
   hermes: ["the Hermes virtualenv (pip install pushary-hermes)"],
-  cursor: [join(CURSOR_PLUGIN_DIR, "mcp.json"), CURSOR_USER_HOOKS],
-  vscode: [join(VSCODE_PLUGIN_DIR, ".mcp.json"), ...vscodeSettingsTargets(existsSync)],
+  cursor: [join2(CURSOR_PLUGIN_DIR, "mcp.json"), CURSOR_USER_HOOKS],
+  vscode: [join2(VSCODE_PLUGIN_DIR, ".mcp.json"), ...vscodeSettingsTargets(existsSync)],
   custom: ["nothing (prints connection details only)"]
 };
 var reportDryRun = (apiKey, agents, keyCheck) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushary/agent-hooks",
-  "version": "0.71.0",
+  "version": "0.73.0",
   "description": "Permission hooks for AI coding agents: route tool approvals through Pushary push notifications",
   "keywords": [
     "pushary",