@pushary/agent-hooks 0.64.1 → 0.64.2

package/CHANGELOG.md

@@ -1,5 +1,40 @@
 # Changelog
 
+## 0.64.2
+
+### A run that gave up reported nothing, and said it stopped at the start
+
+`agent_setup_completed` was wired to one of setup's fifteen exits: the last line
+of a run that finished. Every other way out returned before it. A key the server
+refused, a cancelled pairing, no terminal to sign in from, an installer that
+threw, a Ctrl-C at the agent checkbox: all silent. The beacon was added so failed
+and abandoned runs would stop being invisible, and the runs it could see were
+still only the ones that already worked.
+
+Every early exit reports now, and each says why it stopped: `key-refused`,
+`pairing-cancelled`, `no-key`, `login-rejected`, `no-agents-detected`,
+`invalid-key`, `interrupted`, `crashed`.
+
+Argv-time exits stay silent, along with `--help` and `--dry-run`. A flag typo is
+not an abandoned run: nothing was attempted and nothing was written. It is also
+the fastest-failing path there is, and waiting on a beacon took `setup --bogus`
+from 60ms to two seconds against an unreachable server. A dry run stays silent
+for the other reason: counting it as a completed setup would be its own lie.
+
+`abandonedAt` said where. It was always `start`, because `markStep` had no call
+site outside its own test, so the field that was supposed to locate a failure was
+a constant. It now moves through the run, per agent inside the configure loop, so
+an installer that hangs is named rather than grouped.
+
+Ctrl-C at the pairing QR reports before the process leaves. The cancel and the
+beacon run concurrently and the exit waits for both, so this adds nothing to the
+worst case a cancel already had.
+
+The beacon authenticates with the key the run resolved rather than the one
+already installed. Most of these exits happen before the key is written to disk,
+so without that they posted as nobody, which meant the window holding the
+interesting failures was exactly the window that could not report.
+
 ## 0.64.1
 
 ### Ctrl-C at the pairing QR printed nothing

package/dist/bin/pushary-claude.js

@@ -17,7 +17,7 @@ import {
   reportEvent,
   resolvePolicy,
   waitForAnswer
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-codex-hook.js

@@ -31,7 +31,7 @@ import {
   toCodexWire,
   toPolicyLookup,
   waitForAnswer
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import {
   isGatingMoment,
   recordKeylessMoment

package/dist/bin/pushary-codex.js

@@ -3,7 +3,7 @@ import {
   askUser,
   reportEvent,
   waitForAnswer
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-connect.js

@@ -6,7 +6,7 @@ import {
   confirmAppConnection,
   connectDevice,
   printConnectInstructions
-} from "../chunk-RASBS2CC.js";
+} from "../chunk-GFHQ26ST.js";
 import "../chunk-3EGEA4KH.js";
 import {
   readKeySource

package/dist/bin/pushary-doctor.js

@@ -34,7 +34,7 @@ import {
   describeReach,
   fetchChannels,
   reachVerdict
-} from "../chunk-RASBS2CC.js";
+} from "../chunk-GFHQ26ST.js";
 import "../chunk-3EGEA4KH.js";
 import {
   keyPrefix,

package/dist/bin/pushary-gemini-hook.js

@@ -23,7 +23,7 @@ import {
   savePendingQuestion,
   sendNotification,
   waitForAnswer
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import {
   isGatingMoment,
   recordKeylessMoment

package/dist/bin/pushary-hook.js

@@ -1,14 +1,14 @@
 #!/usr/bin/env node
 import {
   handlePreToolUse
-} from "../chunk-SDXF5I46.js";
+} from "../chunk-SONXGCZY.js";
 import "../chunk-CAJZAFVS.js";
 import {
   exitOnHelpFlag
 } from "../chunk-ATP6UQPH.js";
 import "../chunk-JGH37QRB.js";
 import "../chunk-YHG74UFF.js";
-import "../chunk-5ZDYDU2Q.js";
+import "../chunk-XOUYM27W.js";
 import "../chunk-WLGEY4UX.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";

package/dist/bin/pushary-notification-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handleNotification
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-permission-denied-hook.js

@@ -1,10 +1,10 @@
 #!/usr/bin/env node
 import {
   handlePermissionDenied
-} from "../chunk-SDXF5I46.js";
+} from "../chunk-SONXGCZY.js";
 import "../chunk-CAJZAFVS.js";
 import "../chunk-YHG74UFF.js";
-import "../chunk-5ZDYDU2Q.js";
+import "../chunk-XOUYM27W.js";
 import "../chunk-WLGEY4UX.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";

package/dist/bin/pushary-permission-hook.js

@@ -1,10 +1,10 @@
 #!/usr/bin/env node
 import {
   handlePermissionRequest
-} from "../chunk-SDXF5I46.js";
+} from "../chunk-SONXGCZY.js";
 import "../chunk-CAJZAFVS.js";
 import "../chunk-YHG74UFF.js";
-import "../chunk-5ZDYDU2Q.js";
+import "../chunk-XOUYM27W.js";
 import "../chunk-WLGEY4UX.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";

package/dist/bin/pushary-post-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handlePostToolUse
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-prompt-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handleUserPrompt
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-session-end-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handleSessionEnd
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-session-start-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handleSessionStart
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-setup.js

@@ -45,7 +45,7 @@ import {
   connectViaAppPairing,
   printConnectInstructions,
   setHumanStream
-} from "../chunk-RASBS2CC.js";
+} from "../chunk-GFHQ26ST.js";
 import "../chunk-3EGEA4KH.js";
 import {
   KEY_FILE_MODE,
@@ -86,7 +86,7 @@ import {
 } from "../chunk-JGH37QRB.js";
 import {
   reportEvent
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import {
@@ -206,32 +206,60 @@ var installSkillViaSkillsCli = (agent) => {
 
 // src/setup/telemetry.ts
 var currentStep = "start";
+var markStep = (step) => {
+  currentStep = step;
+};
+var recordedOptions = null;
+var recordSetupOptions = (options) => {
+  recordedOptions = options;
+};
+var recordedKey = null;
+var recordSetupKey = (apiKey) => {
+  recordedKey = apiKey;
+};
 var emitted = false;
-var reportSetupOutcome = async (outcome) => {
+var defaultDeps = { report: reportEvent };
+var emit = async (deps, props) => {
   if (emitted) return;
   emitted = true;
   try {
-    await reportEvent(
-      {
-        event: "agent_setup_completed",
-        agentType: "setup",
-        agents: outcome.completed,
-        connectMode: outcome.options.connectMode,
-        connectOutcome: outcome.connectOutcome,
-        failedAgents: outcome.failed.length,
-        skippedAgents: outcome.skipped,
-        nonInteractive: outcome.options.nonInteractive,
-        keyCheck: outcome.keyCheck,
-        exitCode: outcome.exitCode,
-        // Where the run stopped. On a completed run this is the closing step, so
-        // the interesting values are the ones that are not.
-        abandonedAt: outcome.exitCode === 0 ? null : currentStep
-      },
-      { maxAttempts: 1, timeoutMs: 2e3 }
+    await deps.report(
+      { event: "agent_setup_completed", agentType: "setup", ...props },
+      { maxAttempts: 1, timeoutMs: 2e3, ...recordedKey ? { apiKey: recordedKey } : {} }
     );
   } catch {
   }
 };
+var reportSetupOutcomeWith = async (deps, outcome) => emit(deps, {
+  agents: outcome.completed,
+  connectMode: outcome.options.connectMode,
+  connectOutcome: outcome.connectOutcome,
+  failedAgents: outcome.failed.length,
+  skippedAgents: outcome.skipped,
+  nonInteractive: outcome.options.nonInteractive,
+  keyCheck: outcome.keyCheck,
+  exitCode: outcome.exitCode,
+  // Where the run stopped. On a completed run this is the closing step, so the
+  // interesting values are the ones that are not.
+  abandonedAt: outcome.exitCode === 0 ? null : currentStep,
+  // Always present, so a query can separate "ended" from "gave up" on the
+  // property rather than on the absence of one.
+  abortReason: null
+});
+var reportSetupOutcome = (outcome) => reportSetupOutcomeWith(defaultDeps, outcome);
+var reportSetupAbortWith = async (deps, reason, exitCode, keyCheck = "unknown") => emit(deps, {
+  agents: [],
+  connectMode: recordedOptions?.connectMode ?? null,
+  connectOutcome: "skipped",
+  failedAgents: 0,
+  skippedAgents: [],
+  nonInteractive: recordedOptions?.nonInteractive ?? null,
+  keyCheck,
+  exitCode,
+  abandonedAt: currentStep,
+  abortReason: reason
+});
+var reportSetupAbort = (reason, exitCode, keyCheck) => reportSetupAbortWith(defaultDeps, reason, exitCode, keyCheck);
 
 // src/setup/options.ts
 var AGENT_CHOICES = ["claude_code", "codex", "gemini_cli", "hermes", "cursor", "custom"];
@@ -333,6 +361,10 @@ var green = (s) => `\x1B[32m${s}\x1B[0m`;
 var cyan = (s) => `\x1B[36m${s}\x1B[0m`;
 var yellow = (s) => `\x1B[33m${s}\x1B[0m`;
 var check = green("\u2713");
+var abortWith = async (reason, code, keyCheck) => {
+  await reportSetupAbort(reason, code, keyCheck);
+  return code;
+};
 var readKeyFromStdin = async (options) => {
   if (!options.keyStdin) return void 0;
   const chunks = [];
@@ -341,14 +373,14 @@ var readKeyFromStdin = async (options) => {
   if (!first) {
     console.log(`
   ${yellow("!")} --key-stdin was passed but stdin was empty.`);
-    process.exit(2);
+    process.exit(EXIT.USAGE);
   }
   if (!isValidApiKey(first)) {
     console.log(`
   ${yellow("!")} The key on stdin is not a valid Pushary key. Expected: ${dim("pk_xxx.xxx")}`);
     console.log(`  ${dim("Copy your key from")} ${cyan("https://pushary.com/dashboard/agent/settings")}
 `);
-    process.exit(2);
+    process.exit(EXIT.USAGE);
   }
   return first;
 };
@@ -971,7 +1003,7 @@ var verifyKeyOrExit = async (apiKey, options, precomputed) => {
     console.log(`  ${yellow("!")} ${report.message}`);
     for (const line of report.next) console.log(`  ${dim(line)}`);
     console.log();
-    process.exit(report.exitCode);
+    process.exit(await abortWith("key-refused", report.exitCode, result.kind));
   }
   if (result.kind === "ok") {
     const { siteSlug, siteName, plan } = result.identity;
@@ -1054,7 +1086,7 @@ var resolveAgents = async (options) => {
       console.log(`  ${yellow("!")} No agents detected, so nothing was configured. Your key is saved.`);
       console.log(`  ${dim("Install an agent and re-run, name one with --agents <id>, or pass --agents none to accept this.")}`);
       console.log();
-      process.exit(EXIT.PROBLEMS_FOUND);
+      process.exit(await abortWith("no-agents-detected", EXIT.PROBLEMS_FOUND));
     }
     console.log(`  ${check} Selected automatically: ${picked.map((a) => AGENT_NAMES[a]).join(", ")} ${dim("(--agents to choose)")}`);
     return picked;
@@ -1125,6 +1157,7 @@ var main = async () => {
 `);
     process.exit(EXIT.OK);
   }
+  recordSetupOptions(options);
   if (options.json) {
     humanStream = process.stderr;
     setHumanStream(process.stderr);
@@ -1139,6 +1172,7 @@ var main = async () => {
   console.log(`  ${dim("Push notifications for AI agents")}`);
   console.log();
   await checkForUpdates(version);
+  markStep("resolve-key");
   const connectMode = options.connectMode;
   const flagKey = await readKeyFromStdin(options) ?? options.key ?? void 0;
   const envKey = process.env.PUSHARY_API_KEY?.trim();
@@ -1174,11 +1208,17 @@ var main = async () => {
   } else if (connectMode === "app" && canRunBrowserLogin() && !options.skipPhone) {
     console.log(`  ${dim("Pairing with your Pushary app.")}`);
     console.log(`  ${dim("No app? Ctrl-C, then:")} ${cyan("npx @pushary/agent-hooks setup --connect browser")}`);
+    markStep("pair");
     const previous = readKeySource();
-    const paired = await connectViaAppPairing({ onCancelled: printPairingEscape });
+    const paired = await connectViaAppPairing({
+      onCancelled: async () => {
+        printPairingEscape();
+        await reportSetupAbort("pairing-cancelled", 130);
+      }
+    });
     if (!paired) {
       printPairingEscape();
-      process.exit(EXIT.NOT_CONFIGURED);
+      process.exit(await abortWith("pairing-cancelled", EXIT.NOT_CONFIGURED));
     }
     trimmedKey = paired.apiKey;
     keyFromPairing = true;
@@ -1195,8 +1235,9 @@ var main = async () => {
     console.log(`  ${dim("Pass --key <pk_xxx.xxx>, or --key-stdin, or export PUSHARY_API_KEY.")}`);
     console.log(`  ${dim("On a machine with a terminal, run")} ${cyan("pushary login")} ${dim("once and re-run this.")}`);
     console.log();
-    process.exit(EXIT.NOT_CONFIGURED);
+    process.exit(await abortWith("no-key", EXIT.NOT_CONFIGURED));
   } else {
+    markStep("browser-login");
     const outcome = await runBrowserLogin(
       { say: (line) => console.log(line), bold, dim, cyan, yellow },
       { cliVersion: version }
@@ -1210,7 +1251,7 @@ var main = async () => {
       console.log();
       console.log(`  ${yellow("!")} That request was rejected in the browser. Nothing was written.`);
       console.log();
-      process.exit(EXIT.NOT_CONFIGURED);
+      process.exit(await abortWith("login-rejected", EXIT.NOT_CONFIGURED));
     } else {
       console.log();
       if (outcome.kind === "unavailable") {
@@ -1231,15 +1272,19 @@ var main = async () => {
     console.log(`  ${dim("Copy your key from")} ${cyan("https://pushary.com/dashboard/agent/settings")}`);
     console.log(`  ${dim("Or sign up at")} ${cyan("https://pushary.com/sign-up?from=ai-coding")}
 `);
-    process.exit(EXIT.USAGE);
+    process.exit(await abortWith("invalid-key", EXIT.USAGE));
   }
+  recordSetupKey(trimmedKey);
+  markStep("verify-key");
   const keyCheck = keyFromPairing ? null : await verifyKeyOrExit(trimmedKey, options, storedKeyCheck ?? void 0);
+  markStep("resolve-agents");
   const agents = await resolveAgents(options);
   if (options.dryRun) {
     reportDryRun(trimmedKey, agents, keyCheck);
     emitJson(options, { ok: true, dryRun: true, agents, keyCheck: keyCheck?.kind ?? "skipped" });
     process.exit(EXIT.OK);
   }
+  markStep("save-key");
   const rc = await saveApiKey(trimmedKey);
   const context = { rc };
   const failed = [];
@@ -1251,6 +1296,7 @@ var main = async () => {
     console.log(`  ${dim("Run setup again with --agents <id> when you want one wired up.")}`);
   } else {
     for (const agent of agents) {
+      markStep(`configure:${agent}`);
       try {
         const outcome = await AGENT_SETUP[agent](trimmedKey, context);
         if (outcome === "skipped") skipped.push(agent);
@@ -1269,11 +1315,13 @@ var main = async () => {
       console.log();
       console.log(`  ${yellow("!")} Failed: ${failed.join(", ")} ${dim("(others completed successfully)")}`);
     }
+    markStep("project-instructions");
     await offerProjectInstructions(agents, options);
     if (completed.includes("claude_code")) {
       await offerClaudeAlias(options);
     }
   }
+  markStep("connect-phone");
   const skipPhone = options.skipPhone;
   let phone = null;
   if (keyCheck?.kind === "locked") {
@@ -1311,6 +1359,15 @@ var main = async () => {
       rc: rc.kind,
       exitCode: report.exitCode
     });
+    await reportSetupOutcome({
+      options,
+      completed,
+      skipped,
+      failed,
+      connectOutcome: "skipped",
+      keyCheck: "locked",
+      exitCode: report.exitCode
+    });
     process.exit(report.exitCode);
   }
   printManualSteps();
@@ -1318,6 +1375,7 @@ var main = async () => {
   const agentsOk = failed.length === 0 && !configuredNothing;
   const reachChecked = phone !== null;
   const reachesYou = phone?.reachesYou ?? true;
+  markStep("closing");
   const closing = describeClosing({
     agentsOk,
     configuredNothing,
@@ -1372,7 +1430,7 @@ var main = async () => {
     process.exit(exitCode);
   }
 };
-main().catch((err) => {
+main().catch(async (err) => {
   if (err instanceof UsageError) {
     console.log();
     console.log(`  ${yellow("!")} ${err.message}`);
@@ -1384,11 +1442,11 @@ main().catch((err) => {
     console.log();
     console.log(`  ${dim("Cancelled. Nothing further was changed.")}`);
     console.log();
-    process.exit(130);
+    process.exit(await abortWith("interrupted", 130));
   }
   console.log();
   console.log(`  ${yellow("!")} Setup failed: ${formatError(err)}`);
   console.log(`  ${dim("Run")} ${cyan("npx @pushary/agent-hooks doctor")} ${dim("after fixing the issue, then rerun setup.")}`);
   console.log();
-  process.exit(1);
+  process.exit(await abortWith("crashed", EXIT.FAILED));
 });

package/dist/bin/pushary-status.js

@@ -7,7 +7,7 @@ import {
   describeReach,
   fetchChannels,
   reachVerdict
-} from "../chunk-RASBS2CC.js";
+} from "../chunk-GFHQ26ST.js";
 import "../chunk-3EGEA4KH.js";
 import {
   readKeySource

package/dist/bin/pushary-stop-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handleStop
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/bin/pushary-stopfailure-hook.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   handleStopFailure
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";
 import "../chunk-7QLSKOSU.js";

package/dist/{chunk-RASBS2CC.js → chunk-GFHQ26ST.js}

@@ -520,8 +520,8 @@ var connectViaAppPairing = async (options = {}) => {
   const onInterrupt = () => {
     cancelled = true;
     stop(yellow("!"), "Cancelled");
-    options.onCancelled?.();
-    void cancelPairing(pairId).finally(() => process.exit(EXIT_ABORTED));
+    const flushed = options.onCancelled?.();
+    void Promise.allSettled([Promise.resolve(flushed), cancelPairing(pairId)]).finally(() => process.exit(EXIT_ABORTED));
   };
   process.once("SIGINT", onInterrupt);
   try {

package/dist/{chunk-SDXF5I46.js → chunk-SONXGCZY.js}

@@ -25,7 +25,7 @@ import {
   sendNotification,
   throttlePass,
   waitForAnswer
-} from "./chunk-5ZDYDU2Q.js";
+} from "./chunk-XOUYM27W.js";
 import {
   isGatingMoment,
   recordKeylessMoment

package/dist/{chunk-5ZDYDU2Q.js → chunk-XOUYM27W.js}

@@ -928,7 +928,7 @@ ${injected}` : injected;
 };
 var detectInstallMode = () => (process.argv[1] ?? "").includes("_npx") ? "npx" : "cli";
 var reportEvent = async (event, options = {}) => {
-  const apiKey = getApiKey();
+  const apiKey = options.apiKey ?? getApiKey();
   const baseUrl = getBaseUrl();
   return withRetry(async () => {
     const res = await fetch(`${baseUrl}/api/agent/event`, {

package/dist/src/index.d.ts

@@ -73,6 +73,16 @@ interface AgentEvent {
 interface ReportEventOptions {
     maxAttempts?: number;
     timeoutMs?: number;
+    /**
+     * Authenticate with this key instead of the ambient one.
+     *
+     * getApiKey() reads the environment and ~/.pushary/config.json, so it can only
+     * ever speak for a key that is already installed. setup resolves a key minutes
+     * before it writes one, and its abort beacons run inside that window: without
+     * an override they post as nobody, so the runs that fail before saveApiKey are
+     * exactly the runs that cannot report failing.
+     */
+    apiKey?: string;
 }
 interface EventResponse {
     readonly ok?: boolean;

package/dist/src/index.js

@@ -1,6 +1,6 @@
 import {
   handlePreToolUse
-} from "../chunk-SDXF5I46.js";
+} from "../chunk-SONXGCZY.js";
 import "../chunk-CAJZAFVS.js";
 import "../chunk-YHG74UFF.js";
 import {
@@ -15,7 +15,7 @@ import {
   reportEvent,
   resolvePolicy,
   waitForAnswer
-} from "../chunk-5ZDYDU2Q.js";
+} from "../chunk-XOUYM27W.js";
 import "../chunk-WLGEY4UX.js";
 import "../chunk-BSZYIAZL.js";
 import "../chunk-SAF6HGAA.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushary/agent-hooks",
-  "version": "0.64.1",
+  "version": "0.64.2",
   "description": "Permission hooks for AI coding agents: route tool approvals through Pushary push notifications",
   "keywords": [
     "pushary",