@push.rocks/smartproxy 19.5.3 → 19.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@push.rocks/smartproxy",
-  "version": "19.5.3",
+  "version": "19.5.5",
   "private": false,
   "description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.",
   "main": "dist_ts/index.js",
@@ -12,7 +12,7 @@
     "@git.zone/tsbuild": "^2.6.4",
     "@git.zone/tsrun": "^1.2.44",
     "@git.zone/tstest": "^2.3.1",
-    "@types/node": "^22.15.24",
+    "@types/node": "^22.15.29",
     "typescript": "^5.8.3"
   },
   "dependencies": {

package/readme.hints.md

@@ -318,4 +318,99 @@ const routes: IRouteConfig[] = [{
 - Authentication requires TLS termination (cannot be enforced on passthrough/direct connections)
 - Per-route connection limits are not yet implemented
 - Security is defined at the route level (route.security), not in the action
-- Route matching is based solely on match criteria; security is enforced after matching
+- Route matching is based solely on match criteria; security is enforced after matching
+
+## Performance Issues Investigation (v19.5.3+)
+
+### Critical Blocking Operations Found
+1. **Busy Wait Loop** in `ts/proxies/nftables-proxy/nftables-proxy.ts:235-238`
+   - Blocks entire event loop with `while (Date.now() < waitUntil) {}`
+   - Should use `await new Promise(resolve => setTimeout(resolve, delay))`
+
+2. **Synchronous Filesystem Operations**
+   - Certificate management uses `fs.existsSync()`, `fs.mkdirSync()`, `fs.readFileSync()`
+   - NFTables proxy uses `execSync()` for system commands
+   - Certificate store uses `ensureDirSync()`, `fileExistsSync()`, `removeManySync()`
+
+3. **Memory Leak Risks**
+   - Several `setInterval()` calls without storing references for cleanup
+   - Event listeners added without proper cleanup in error paths
+   - Missing `removeAllListeners()` calls in some connection cleanup scenarios
+
+### Performance Recommendations
+- Replace all sync filesystem operations with async alternatives
+- Fix the busy wait loop immediately (critical event loop blocker)
+- Add proper cleanup for all timers and event listeners
+- Consider worker threads for CPU-intensive operations
+- See `readme.problems.md` for detailed analysis and recommendations
+
+## Performance Optimizations Implemented (Phase 1 - v19.6.0)
+
+### 1. Async Utilities Created (`ts/core/utils/async-utils.ts`)
+- **delay()**: Non-blocking alternative to busy wait loops
+- **retryWithBackoff()**: Retry operations with exponential backoff
+- **withTimeout()**: Execute operations with timeout protection
+- **parallelLimit()**: Run async operations with concurrency control
+- **debounceAsync()**: Debounce async functions
+- **AsyncMutex**: Ensure exclusive access to resources
+- **CircuitBreaker**: Protect against cascading failures
+
+### 2. Filesystem Utilities Created (`ts/core/utils/fs-utils.ts`)
+- **AsyncFileSystem**: Complete async filesystem operations
+  - exists(), ensureDir(), readFile(), writeFile()
+  - readJSON(), writeJSON() with proper error handling
+  - copyFile(), moveFile(), removeDir()
+  - Stream creation and file listing utilities
+
+### 3. Critical Fixes Applied
+
+#### Busy Wait Loop Fixed
+- **Location**: `ts/proxies/nftables-proxy/nftables-proxy.ts:235-238`
+- **Fix**: Replaced `while (Date.now() < waitUntil) {}` with `await delay(ms)`
+- **Impact**: Unblocks event loop, massive performance improvement
+
+#### Certificate Manager Migration
+- **File**: `ts/proxies/http-proxy/certificate-manager.ts`
+- Added async initialization method
+- Kept sync methods for backward compatibility with deprecation warnings
+- Added `loadDefaultCertificatesAsync()` method
+
+#### Certificate Store Migration  
+- **File**: `ts/proxies/smart-proxy/cert-store.ts`
+- Replaced all `fileExistsSync`, `ensureDirSync`, `removeManySync`
+- Used parallel operations with `Promise.all()` for better performance
+- Improved error handling and async JSON operations
+
+#### NFTables Proxy Improvements
+- Added deprecation warnings to sync methods
+- Created `executeWithTempFile()` helper for common pattern
+- Started migration of sync filesystem operations to async
+- Added import for delay and AsyncFileSystem utilities
+
+### 4. Backward Compatibility Maintained
+- All sync methods retained with deprecation warnings
+- Existing APIs unchanged, new async methods added alongside
+- Feature flags prepared for gradual rollout
+
+### 5. Phase 1 Completion Status
+✅ **Phase 1 COMPLETE** - All critical performance fixes have been implemented:
+- ✅ Fixed busy wait loop in nftables-proxy.ts  
+- ✅ Created async utilities (delay, retry, timeout, parallelLimit, mutex, circuit breaker)
+- ✅ Created filesystem utilities (AsyncFileSystem with full async operations)
+- ✅ Migrated all certificate management to async operations
+- ✅ Migrated nftables-proxy filesystem operations to async (except stopSync for exit handlers)
+- ✅ All tests passing for new utilities
+
+### 6. Phase 2 Progress Status
+🔨 **Phase 2 IN PROGRESS** - Resource Lifecycle Management:
+- ✅ Created LifecycleComponent base class for automatic resource cleanup
+- ✅ Created BinaryHeap data structure for priority queue operations
+- ✅ Created EnhancedConnectionPool with backpressure and health checks
+- ✅ Cleaned up legacy code (removed ts/common/, event-utils.ts, event-system.ts)
+- 📋 TODO: Migrate existing components to extend LifecycleComponent
+- 📋 TODO: Add integration tests for resource management
+
+### 7. Next Steps (Remaining Work)
+- **Phase 2 (cont)**: Migrate components to use LifecycleComponent
+- **Phase 3**: Add worker threads for CPU-intensive operations  
+- **Phase 4**: Performance monitoring dashboard