@push.rocks/smartproxy 19.3.9 → 19.3.11

package/ts/proxies/smart-proxy/certificate-manager.ts

@@ -4,6 +4,7 @@ import type { IRouteConfig, IRouteTls } from './models/route-types.js';
 import type { IAcmeOptions } from './models/interfaces.js';
 import { CertStore } from './cert-store.js';
 import type { AcmeStateManager } from './acme-state-manager.js';
+import { logger } from '../../core/utils/logger.js';
 
 export interface ICertStatus {
   domain: string;
@@ -125,15 +126,16 @@ export class SmartCertManager {
       
       // Add challenge route once at initialization if not already active
       if (!this.challengeRouteActive) {
-        console.log('Adding ACME challenge route during initialization');
+        logger.log('info', 'Adding ACME challenge route during initialization', { component: 'certificate-manager' });
         await this.addChallengeRoute();
       } else {
-        console.log('Challenge route already active from previous instance');
+        logger.log('info', 'Challenge route already active from previous instance', { component: 'certificate-manager' });
       }
     }
     
-    // Provision certificates for all routes
-    await this.provisionAllCertificates();
+    // Skip automatic certificate provisioning during initialization
+    // This will be called later after ports are listening
+    logger.log('info', 'Certificate manager initialized. Deferring certificate provisioning until after ports are listening.', { component: 'certificate-manager' });
     
     // Start renewal timer
     this.startRenewalTimer();
@@ -142,7 +144,7 @@ export class SmartCertManager {
   /**
    * Provision certificates for all routes that need them
    */
-  private async provisionAllCertificates(): Promise<void> {
+  public async provisionAllCertificates(): Promise<void> {
     const certRoutes = this.routes.filter(r => 
       r.action.tls?.mode === 'terminate' || 
       r.action.tls?.mode === 'terminate-and-reencrypt'
@@ -156,7 +158,7 @@ export class SmartCertManager {
         try {
           await this.provisionCertificate(route, true); // Allow concurrent since we're managing it here
         } catch (error) {
-          console.error(`Failed to provision certificate for route ${route.name}: ${error}`);
+          logger.log('error', `Failed to provision certificate for route ${route.name}`, { routeName: route.name, error, component: 'certificate-manager' });
         }
       }
     } finally {
@@ -175,13 +177,13 @@ export class SmartCertManager {
     
     // Check if provisioning is already in progress (prevent concurrent provisioning)
     if (!allowConcurrent && this.isProvisioning) {
-      console.log(`Certificate provisioning already in progress, skipping ${route.name}`);
+      logger.log('info', `Certificate provisioning already in progress, skipping ${route.name}`, { routeName: route.name, component: 'certificate-manager' });
       return;
     }
     
     const domains = this.extractDomainsFromRoute(route);
     if (domains.length === 0) {
-      console.warn(`Route ${route.name} has TLS termination but no domains`);
+      logger.log('warn', `Route ${route.name} has TLS termination but no domains`, { routeName: route.name, component: 'certificate-manager' });
       return;
     }
     
@@ -218,7 +220,7 @@ export class SmartCertManager {
     // Check if we already have a valid certificate
     const existingCert = await this.certStore.getCertificate(routeName);
     if (existingCert && this.isCertificateValid(existingCert)) {
-      console.log(`Using existing valid certificate for ${primaryDomain}`);
+      logger.log('info', `Using existing valid certificate for ${primaryDomain}`, { domain: primaryDomain, component: 'certificate-manager' });
       await this.applyCertificate(primaryDomain, existingCert);
       this.updateCertStatus(routeName, 'valid', 'acme', existingCert);
       return;
@@ -229,7 +231,7 @@ export class SmartCertManager {
                          this.globalAcmeDefaults?.renewThresholdDays || 
                          30;
     
-    console.log(`Requesting ACME certificate for ${domains.join(', ')} (renew ${renewThreshold} days before expiry)`);
+    logger.log('info', `Requesting ACME certificate for ${domains.join(', ')} (renew ${renewThreshold} days before expiry)`, { domains: domains.join(', '), renewThreshold, component: 'certificate-manager' });
     this.updateCertStatus(routeName, 'pending', 'acme');
     
     try {
@@ -251,7 +253,7 @@ export class SmartCertManager {
                                     hasDnsChallenge;
       
       if (shouldIncludeWildcard) {
-        console.log(`Requesting wildcard certificate for ${primaryDomain} (DNS-01 available)`);
+        logger.log('info', `Requesting wildcard certificate for ${primaryDomain} (DNS-01 available)`, { domain: primaryDomain, challengeType: 'DNS-01', component: 'certificate-manager' });
       }
       
       // Use smartacme to get certificate with optional wildcard
@@ -278,9 +280,9 @@ export class SmartCertManager {
       await this.applyCertificate(primaryDomain, certData);
       this.updateCertStatus(routeName, 'valid', 'acme', certData);
       
-      console.log(`Successfully provisioned ACME certificate for ${primaryDomain}`);
+      logger.log('info', `Successfully provisioned ACME certificate for ${primaryDomain}`, { domain: primaryDomain, component: 'certificate-manager' });
     } catch (error) {
-      console.error(`Failed to provision ACME certificate for ${primaryDomain}: ${error}`);
+      logger.log('error', `Failed to provision ACME certificate for ${primaryDomain}: ${error.message}`, { domain: primaryDomain, error: error.message, component: 'certificate-manager' });
       this.updateCertStatus(routeName, 'error', 'acme', undefined, error.message);
       throw error;
     }
@@ -327,9 +329,9 @@ export class SmartCertManager {
       await this.applyCertificate(domain, certData);
       this.updateCertStatus(routeName, 'valid', 'static', certData);
       
-      console.log(`Successfully loaded static certificate for ${domain}`);
+      logger.log('info', `Successfully loaded static certificate for ${domain}`, { domain, component: 'certificate-manager' });
     } catch (error) {
-      console.error(`Failed to provision static certificate for ${domain}: ${error}`);
+      logger.log('error', `Failed to provision static certificate for ${domain}: ${error.message}`, { domain, error: error.message, component: 'certificate-manager' });
       this.updateCertStatus(routeName, 'error', 'static', undefined, error.message);
       throw error;
     }
@@ -340,7 +342,7 @@ export class SmartCertManager {
    */
   private async applyCertificate(domain: string, certData: ICertificateData): Promise<void> {
     if (!this.httpProxy) {
-      console.warn('HttpProxy not set, cannot apply certificate');
+      logger.log('warn', `HttpProxy not set, cannot apply certificate for domain ${domain}`, { domain, component: 'certificate-manager' });
       return;
     }
     
@@ -397,13 +399,13 @@ export class SmartCertManager {
   private async addChallengeRoute(): Promise<void> {
     // Check with state manager first
     if (this.acmeStateManager && this.acmeStateManager.isChallengeRouteActive()) {
-      console.log('Challenge route already active in global state, skipping');
+      logger.log('info', 'Challenge route already active in global state, skipping', { component: 'certificate-manager' });
       this.challengeRouteActive = true;
       return;
     }
     
     if (this.challengeRouteActive) {
-      console.log('Challenge route already active locally, skipping');
+      logger.log('info', 'Challenge route already active locally, skipping', { component: 'certificate-manager' });
       return;
     }
     
@@ -426,9 +428,9 @@ export class SmartCertManager {
         this.acmeStateManager.addChallengeRoute(challengeRoute);
       }
       
-      console.log('ACME challenge route successfully added');
+      logger.log('info', 'ACME challenge route successfully added', { component: 'certificate-manager' });
     } catch (error) {
-      console.error('Failed to add challenge route:', error);
+      logger.log('error', `Failed to add challenge route: ${error.message}`, { error: error.message, component: 'certificate-manager' });
       if ((error as any).code === 'EADDRINUSE') {
         throw new Error(`Port ${this.globalAcmeDefaults?.port || 80} is already in use for ACME challenges`);
       }
@@ -441,7 +443,7 @@ export class SmartCertManager {
    */
   private async removeChallengeRoute(): Promise<void> {
     if (!this.challengeRouteActive) {
-      console.log('Challenge route not active, skipping removal');
+      logger.log('info', 'Challenge route not active, skipping removal', { component: 'certificate-manager' });
       return;
     }
     
@@ -459,9 +461,9 @@ export class SmartCertManager {
         this.acmeStateManager.removeChallengeRoute('acme-challenge');
       }
       
-      console.log('ACME challenge route successfully removed');
+      logger.log('info', 'ACME challenge route successfully removed', { component: 'certificate-manager' });
     } catch (error) {
-      console.error('Failed to remove challenge route:', error);
+      logger.log('error', `Failed to remove challenge route: ${error.message}`, { error: error.message, component: 'certificate-manager' });
       // Reset the flag even on error to avoid getting stuck
       this.challengeRouteActive = false;
       throw error;
@@ -491,11 +493,11 @@ export class SmartCertManager {
         const cert = await this.certStore.getCertificate(routeName);
         
         if (cert && !this.isCertificateValid(cert)) {
-          console.log(`Certificate for ${routeName} needs renewal`);
+          logger.log('info', `Certificate for ${routeName} needs renewal`, { routeName, component: 'certificate-manager' });
           try {
             await this.provisionCertificate(route);
           } catch (error) {
-            console.error(`Failed to renew certificate for ${routeName}: ${error}`);
+            logger.log('error', `Failed to renew certificate for ${routeName}: ${error.message}`, { routeName, error: error.message, component: 'certificate-manager' });
           }
         }
       }
@@ -620,7 +622,7 @@ export class SmartCertManager {
     
     // Always remove challenge route on shutdown
     if (this.challengeRoute) {
-      console.log('Removing ACME challenge route during shutdown');
+      logger.log('info', 'Removing ACME challenge route during shutdown', { component: 'certificate-manager' });
       await this.removeChallengeRoute();
     }
     

package/ts/proxies/smart-proxy/connection-manager.ts

@@ -2,6 +2,7 @@ import * as plugins from '../../plugins.js';
 import type { IConnectionRecord, ISmartProxyOptions } from './models/interfaces.js';
 import { SecurityManager } from './security-manager.js';
 import { TimeoutManager } from './timeout-manager.js';
+import { logger } from '../../core/utils/logger.js';
 
 /**
  * Manages connection lifecycle, tracking, and cleanup
@@ -97,7 +98,7 @@ export class ConnectionManager {
    */
   public initiateCleanupOnce(record: IConnectionRecord, reason: string = 'normal'): void {
     if (this.settings.enableDetailedLogging) {
-      console.log(`[${record.id}] Connection cleanup initiated for ${record.remoteIP} (${reason})`);
+      logger.log('info', `Connection cleanup initiated`, { connectionId: record.id, remoteIP: record.remoteIP, reason, component: 'connection-manager' });
     }
 
     if (
@@ -139,7 +140,7 @@ export class ConnectionManager {
           // Reset the handler references
           record.renegotiationHandler = undefined;
         } catch (err) {
-          console.log(`[${record.id}] Error removing data handlers: ${err}`);
+          logger.log('error', `Error removing data handlers for connection ${record.id}: ${err}`, { connectionId: record.id, error: err, component: 'connection-manager' });
         }
       }
 
@@ -160,16 +161,36 @@ export class ConnectionManager {
 
       // Log connection details
       if (this.settings.enableDetailedLogging) {
-        console.log(
-          `[${record.id}] Connection from ${record.remoteIP} on port ${record.localPort} terminated (${reason}).` +
-            ` Duration: ${plugins.prettyMs(duration)}, Bytes IN: ${bytesReceived}, OUT: ${bytesSent}, ` +
-            `TLS: ${record.isTLS ? 'Yes' : 'No'}, Keep-Alive: ${record.hasKeepAlive ? 'Yes' : 'No'}` +
-            `${record.usingNetworkProxy ? ', Using NetworkProxy' : ''}` +
-            `${record.domainSwitches ? `, Domain switches: ${record.domainSwitches}` : ''}`
+        logger.log('info', 
+          `Connection from ${record.remoteIP} on port ${record.localPort} terminated (${reason}). ` +
+          `Duration: ${plugins.prettyMs(duration)}, Bytes IN: ${bytesReceived}, OUT: ${bytesSent}, ` +
+          `TLS: ${record.isTLS ? 'Yes' : 'No'}, Keep-Alive: ${record.hasKeepAlive ? 'Yes' : 'No'}` +
+          `${record.usingNetworkProxy ? ', Using NetworkProxy' : ''}` +
+          `${record.domainSwitches ? `, Domain switches: ${record.domainSwitches}` : ''}`, 
+          {
+            connectionId: record.id,
+            remoteIP: record.remoteIP,
+            localPort: record.localPort,
+            reason,
+            duration: plugins.prettyMs(duration),
+            bytes: { in: bytesReceived, out: bytesSent },
+            tls: record.isTLS,
+            keepAlive: record.hasKeepAlive,
+            usingNetworkProxy: record.usingNetworkProxy,
+            domainSwitches: record.domainSwitches || 0,
+            component: 'connection-manager'
+          }
         );
       } else {
-        console.log(
-          `[${record.id}] Connection from ${record.remoteIP} terminated (${reason}). Active connections: ${this.connectionRecords.size}`
+        logger.log('info', 
+          `Connection from ${record.remoteIP} terminated (${reason}). Active connections: ${this.connectionRecords.size}`, 
+          {
+            connectionId: record.id,
+            remoteIP: record.remoteIP,
+            reason,
+            activeConnections: this.connectionRecords.size,
+            component: 'connection-manager'
+          }
         );
       }
     }
@@ -189,7 +210,7 @@ export class ConnectionManager {
               socket.destroy();
             }
           } catch (err) {
-            console.log(`[${record.id}] Error destroying ${side} socket: ${err}`);
+            logger.log('error', `Error destroying ${side} socket for connection ${record.id}: ${err}`, { connectionId: record.id, side, error: err, component: 'connection-manager' });
           }
         }, 1000);
 
@@ -199,13 +220,13 @@ export class ConnectionManager {
         }
       }
     } catch (err) {
-      console.log(`[${record.id}] Error closing ${side} socket: ${err}`);
+      logger.log('error', `Error closing ${side} socket for connection ${record.id}: ${err}`, { connectionId: record.id, side, error: err, component: 'connection-manager' });
       try {
         if (!socket.destroyed) {
           socket.destroy();
         }
       } catch (destroyErr) {
-        console.log(`[${record.id}] Error destroying ${side} socket: ${destroyErr}`);
+        logger.log('error', `Error destroying ${side} socket for connection ${record.id}: ${destroyErr}`, { connectionId: record.id, side, error: destroyErr, component: 'connection-manager' });
       }
     }
   }
@@ -224,21 +245,36 @@ export class ConnectionManager {
 
       if (code === 'ECONNRESET') {
         reason = 'econnreset';
-        console.log(
-          `[${record.id}] ECONNRESET on ${side} side from ${record.remoteIP}: ${err.message}. ` +
-          `Duration: ${plugins.prettyMs(connectionDuration)}, Last activity: ${plugins.prettyMs(lastActivityAge)} ago`
-        );
+        logger.log('warn', `ECONNRESET on ${side} connection from ${record.remoteIP}. Error: ${err.message}. Duration: ${plugins.prettyMs(connectionDuration)}, Last activity: ${plugins.prettyMs(lastActivityAge)}`, {
+          connectionId: record.id,
+          side,
+          remoteIP: record.remoteIP,
+          error: err.message,
+          duration: plugins.prettyMs(connectionDuration),
+          lastActivity: plugins.prettyMs(lastActivityAge),
+          component: 'connection-manager'
+        });
       } else if (code === 'ETIMEDOUT') {
         reason = 'etimedout';
-        console.log(
-          `[${record.id}] ETIMEDOUT on ${side} side from ${record.remoteIP}: ${err.message}. ` +
-          `Duration: ${plugins.prettyMs(connectionDuration)}, Last activity: ${plugins.prettyMs(lastActivityAge)} ago`
-        );
+        logger.log('warn', `ETIMEDOUT on ${side} connection from ${record.remoteIP}. Error: ${err.message}. Duration: ${plugins.prettyMs(connectionDuration)}, Last activity: ${plugins.prettyMs(lastActivityAge)}`, {
+          connectionId: record.id,
+          side,
+          remoteIP: record.remoteIP,
+          error: err.message,
+          duration: plugins.prettyMs(connectionDuration),
+          lastActivity: plugins.prettyMs(lastActivityAge),
+          component: 'connection-manager'
+        });
       } else {
-        console.log(
-          `[${record.id}] Error on ${side} side from ${record.remoteIP}: ${err.message}. ` +
-          `Duration: ${plugins.prettyMs(connectionDuration)}, Last activity: ${plugins.prettyMs(lastActivityAge)} ago`
-        );
+        logger.log('error', `Error on ${side} connection from ${record.remoteIP}: ${err.message}. Duration: ${plugins.prettyMs(connectionDuration)}, Last activity: ${plugins.prettyMs(lastActivityAge)}`, {
+          connectionId: record.id,
+          side,
+          remoteIP: record.remoteIP,
+          error: err.message,
+          duration: plugins.prettyMs(connectionDuration),
+          lastActivity: plugins.prettyMs(lastActivityAge),
+          component: 'connection-manager'
+        });
       }
 
       if (side === 'incoming' && record.incomingTerminationReason === null) {
@@ -259,7 +295,12 @@ export class ConnectionManager {
   public handleClose(side: 'incoming' | 'outgoing', record: IConnectionRecord) {
     return () => {
       if (this.settings.enableDetailedLogging) {
-        console.log(`[${record.id}] Connection closed on ${side} side from ${record.remoteIP}`);
+        logger.log('info', `Connection closed on ${side} side`, {
+          connectionId: record.id,
+          side,
+          remoteIP: record.remoteIP,
+          component: 'connection-manager'
+        });
       }
 
       if (side === 'incoming' && record.incomingTerminationReason === null) {
@@ -321,11 +362,13 @@ export class ConnectionManager {
       if (inactivityTime > effectiveTimeout && !record.connectionClosed) {
         // For keep-alive connections, issue a warning first
         if (record.hasKeepAlive && !record.inactivityWarningIssued) {
-          console.log(
-            `[${id}] Warning: Keep-alive connection from ${record.remoteIP} inactive for ${
-              plugins.prettyMs(inactivityTime)
-            }. Will close in 10 minutes if no activity.`
-          );
+          logger.log('warn', `Keep-alive connection ${id} from ${record.remoteIP} inactive for ${plugins.prettyMs(inactivityTime)}. Will close in 10 minutes if no activity.`, {
+            connectionId: id,
+            remoteIP: record.remoteIP,
+            inactiveFor: plugins.prettyMs(inactivityTime),
+            closureWarning: '10 minutes',
+            component: 'connection-manager'
+          });
 
           // Set warning flag and add grace period
           record.inactivityWarningIssued = true;
@@ -337,27 +380,30 @@ export class ConnectionManager {
               record.outgoing.write(Buffer.alloc(0));
 
               if (this.settings.enableDetailedLogging) {
-                console.log(`[${id}] Sent probe packet to test keep-alive connection`);
+                logger.log('info', `Sent probe packet to test keep-alive connection ${id}`, { connectionId: id, component: 'connection-manager' });
               }
             } catch (err) {
-              console.log(`[${id}] Error sending probe packet: ${err}`);
+              logger.log('error', `Error sending probe packet to connection ${id}: ${err}`, { connectionId: id, error: err, component: 'connection-manager' });
             }
           }
         } else {
           // For non-keep-alive or after warning, close the connection
-          console.log(
-            `[${id}] Inactivity check: No activity on connection from ${record.remoteIP} ` +
-            `for ${plugins.prettyMs(inactivityTime)}.` +
-            (record.hasKeepAlive ? ' Despite keep-alive being enabled.' : '')
-          );
+          logger.log('warn', `Closing inactive connection ${id} from ${record.remoteIP} (inactive for ${plugins.prettyMs(inactivityTime)}, keep-alive: ${record.hasKeepAlive ? 'Yes' : 'No'})`, {
+            connectionId: id,
+            remoteIP: record.remoteIP,
+            inactiveFor: plugins.prettyMs(inactivityTime),
+            hasKeepAlive: record.hasKeepAlive,
+            component: 'connection-manager'
+          });
           this.cleanupConnection(record, 'inactivity');
         }
       } else if (inactivityTime <= effectiveTimeout && record.inactivityWarningIssued) {
         // If activity detected after warning, clear the warning
         if (this.settings.enableDetailedLogging) {
-          console.log(
-            `[${id}] Connection activity detected after inactivity warning, resetting warning`
-          );
+          logger.log('info', `Connection ${id} activity detected after inactivity warning`, {
+            connectionId: id,
+            component: 'connection-manager'
+          });
         }
         record.inactivityWarningIssued = false;
       }
@@ -369,11 +415,12 @@ export class ConnectionManager {
         !record.connectionClosed &&
         now - record.outgoingClosedTime > 120000
       ) {
-        console.log(
-          `[${id}] Parity check: Incoming socket for ${record.remoteIP} still active ${
-            plugins.prettyMs(now - record.outgoingClosedTime)
-          } after outgoing closed.`
-        );
+        logger.log('warn', `Parity check: Connection ${id} from ${record.remoteIP} has incoming socket still active ${plugins.prettyMs(now - record.outgoingClosedTime)} after outgoing socket closed`, {
+          connectionId: id,
+          remoteIP: record.remoteIP,
+          timeElapsed: plugins.prettyMs(now - record.outgoingClosedTime),
+          component: 'connection-manager'
+        });
         this.cleanupConnection(record, 'parity_check');
       }
     }
@@ -406,7 +453,7 @@ export class ConnectionManager {
             record.outgoing.end();
           }
         } catch (err) {
-          console.log(`Error during graceful connection end for ${id}: ${err}`);
+          logger.log('error', `Error during graceful end of connection ${id}: ${err}`, { connectionId: id, error: err, component: 'connection-manager' });
         }
       }
     }
@@ -433,7 +480,7 @@ export class ConnectionManager {
               }
             }
           } catch (err) {
-            console.log(`Error during forced connection destruction for ${id}: ${err}`);
+            logger.log('error', `Error during forced destruction of connection ${id}: ${err}`, { connectionId: id, error: err, component: 'connection-manager' });
           }
         }
       }