@push.rocks/smartproxy 18.1.0 → 19.0.0

package/ts/proxies/network-proxy/network-proxy.ts

@@ -18,7 +18,6 @@ import { RequestHandler, type IMetricsTracker } from './request-handler.js';
 import { WebSocketHandler } from './websocket-handler.js';
 import { ProxyRouter } from '../../http/router/index.js';
 import { RouteRouter } from '../../http/router/route-router.js';
-import { Port80Handler } from '../../http/port80/port80-handler.js';
 import { FunctionCache } from './function-cache.js';
 
 /**
@@ -221,15 +220,10 @@ export class NetworkProxy implements IMetricsTracker {
   }
 
   /**
-   * Sets an external Port80Handler for certificate management
-   * This allows the NetworkProxy to use a centrally managed Port80Handler
-   * instead of creating its own
-   * 
-   * @param handler The Port80Handler instance to use
+   * @deprecated Use SmartCertManager instead
    */
-  public setExternalPort80Handler(handler: Port80Handler): void {
-    // Connect it to the certificate manager
-    this.certificateManager.setExternalPort80Handler(handler);
+  public setExternalPort80Handler(handler: any): void {
+    this.logger.warn('Port80Handler is deprecated - use SmartCertManager instead');
   }
 
   /**
@@ -238,10 +232,7 @@ export class NetworkProxy implements IMetricsTracker {
   public async start(): Promise<void> {
     this.startTime = Date.now();
     
-    // Initialize Port80Handler if enabled and not using external handler
-    if (this.options.acme?.enabled && !this.options.useExternalPort80Handler) {
-      await this.certificateManager.initializePort80Handler();
-    }
+    // Certificate management is now handled by SmartCertManager
     
     // Create HTTP/2 server with HTTP/1 fallback
     this.httpsServer = plugins.http2.createSecureServer(
@@ -385,7 +376,7 @@ export class NetworkProxy implements IMetricsTracker {
 
     // Directly update the certificate manager with the new routes
     // This will extract domains and handle certificate provisioning
-    this.certificateManager.updateRouteConfigs(routes);
+    this.certificateManager.updateRoutes(routes);
 
     // Collect all domains and certificates for configuration
     const currentHostnames = new Set<string>();
@@ -425,7 +416,7 @@ export class NetworkProxy implements IMetricsTracker {
     // Update certificate cache with any static certificates
     for (const [domain, certData] of certificateUpdates.entries()) {
       try {
-        this.certificateManager.updateCertificateCache(
+        this.certificateManager.updateCertificate(
           domain,
           certData.cert,
           certData.key
@@ -500,6 +491,9 @@ export class NetworkProxy implements IMetricsTracker {
       this.logger.warn('Router has no recognized configuration method');
     }
 
+    // Update WebSocket handler with new routes
+    this.webSocketHandler.setRoutes(routes);
+
     this.logger.info(`Route configuration updated with ${routes.length} routes and ${legacyConfigs.length} proxy configs`);
   }
 
@@ -544,8 +538,7 @@ export class NetworkProxy implements IMetricsTracker {
     // Close all connection pool connections
     this.connectionPool.closeAllConnections();
     
-    // Stop Port80Handler if internally managed
-    await this.certificateManager.stopPort80Handler();
+    // Certificate management cleanup is handled by SmartCertManager
     
     // Close the HTTPS server
     return new Promise((resolve) => {
@@ -563,7 +556,8 @@ export class NetworkProxy implements IMetricsTracker {
    * @returns A promise that resolves when the request is submitted (not when the certificate is issued)
    */
   public async requestCertificate(domain: string): Promise<boolean> {
-    return this.certificateManager.requestCertificate(domain);
+    this.logger.warn('requestCertificate is deprecated - use SmartCertManager instead');
+    return false;
   }
   
   /**
@@ -584,7 +578,7 @@ export class NetworkProxy implements IMetricsTracker {
     expiryDate?: Date
   ): void {
     this.logger.info(`Updating certificate for ${domain}`);
-    this.certificateManager.updateCertificateCache(domain, certificate, privateKey, expiryDate);
+    this.certificateManager.updateCertificate(domain, certificate, privateKey);
   }
 
   /**

package/ts/proxies/network-proxy/websocket-handler.ts

@@ -419,9 +419,15 @@ export class WebSocketHandler {
         wsIncoming.on('close', (code, reason) => {
           this.logger.debug(`WebSocket client connection closed: ${code} ${reason}`);
           if (wsOutgoing.readyState === wsOutgoing.OPEN) {
-            const validCode = code || 1000;
-            const reasonString = toBuffer(reason).toString();
-            wsOutgoing.close(validCode, reasonString);
+            // Ensure code is a valid WebSocket close code number
+            const validCode = typeof code === 'number' && code >= 1000 && code <= 4999 ? code : 1000;
+            try {
+              const reasonString = reason ? toBuffer(reason).toString() : '';
+              wsOutgoing.close(validCode, reasonString);
+            } catch (err) {
+              this.logger.error('Error closing wsOutgoing:', err);
+              wsOutgoing.close(validCode);
+            }
           }
 
           // Clean up timers
@@ -432,9 +438,15 @@ export class WebSocketHandler {
         wsOutgoing.on('close', (code, reason) => {
           this.logger.debug(`WebSocket target connection closed: ${code} ${reason}`);
           if (wsIncoming.readyState === wsIncoming.OPEN) {
-            const validCode = code || 1000;
-            const reasonString = toBuffer(reason).toString();
-            wsIncoming.close(validCode, reasonString);
+            // Ensure code is a valid WebSocket close code number
+            const validCode = typeof code === 'number' && code >= 1000 && code <= 4999 ? code : 1000;
+            try {
+              const reasonString = reason ? toBuffer(reason).toString() : '';
+              wsIncoming.close(validCode, reasonString);
+            } catch (err) {
+              this.logger.error('Error closing wsIncoming:', err);
+              wsIncoming.close(validCode);
+            }
           }
 
           // Clean up timers

package/ts/proxies/smart-proxy/cert-store.ts

@@ -0,0 +1,86 @@
+import * as plugins from '../../plugins.js';
+import type { ICertificateData } from './certificate-manager.js';
+
+export class CertStore {
+  constructor(private certDir: string) {}
+  
+  public async initialize(): Promise<void> {
+    await plugins.smartfile.fs.ensureDirSync(this.certDir);
+  }
+  
+  public async getCertificate(routeName: string): Promise<ICertificateData | null> {
+    const certPath = this.getCertPath(routeName);
+    const metaPath = `${certPath}/meta.json`;
+    
+    if (!await plugins.smartfile.fs.fileExistsSync(metaPath)) {
+      return null;
+    }
+    
+    try {
+      const metaFile = await plugins.smartfile.SmartFile.fromFilePath(metaPath);
+      const meta = JSON.parse(metaFile.contents.toString());
+      
+      const certFile = await plugins.smartfile.SmartFile.fromFilePath(`${certPath}/cert.pem`);
+      const cert = certFile.contents.toString();
+      
+      const keyFile = await plugins.smartfile.SmartFile.fromFilePath(`${certPath}/key.pem`);
+      const key = keyFile.contents.toString();
+      
+      let ca: string | undefined;
+      const caPath = `${certPath}/ca.pem`;
+      if (await plugins.smartfile.fs.fileExistsSync(caPath)) {
+        const caFile = await plugins.smartfile.SmartFile.fromFilePath(caPath);
+        ca = caFile.contents.toString();
+      }
+      
+      return {
+        cert,
+        key,
+        ca,
+        expiryDate: new Date(meta.expiryDate),
+        issueDate: new Date(meta.issueDate)
+      };
+    } catch (error) {
+      console.error(`Failed to load certificate for ${routeName}: ${error}`);
+      return null;
+    }
+  }
+  
+  public async saveCertificate(
+    routeName: string, 
+    certData: ICertificateData
+  ): Promise<void> {
+    const certPath = this.getCertPath(routeName);
+    await plugins.smartfile.fs.ensureDirSync(certPath);
+    
+    // Save certificate files
+    await plugins.smartfile.memory.toFs(certData.cert, `${certPath}/cert.pem`);
+    await plugins.smartfile.memory.toFs(certData.key, `${certPath}/key.pem`);
+    
+    if (certData.ca) {
+      await plugins.smartfile.memory.toFs(certData.ca, `${certPath}/ca.pem`);
+    }
+    
+    // Save metadata
+    const meta = {
+      expiryDate: certData.expiryDate.toISOString(),
+      issueDate: certData.issueDate.toISOString(),
+      savedAt: new Date().toISOString()
+    };
+    
+    await plugins.smartfile.memory.toFs(JSON.stringify(meta, null, 2), `${certPath}/meta.json`);
+  }
+  
+  public async deleteCertificate(routeName: string): Promise<void> {
+    const certPath = this.getCertPath(routeName);
+    if (await plugins.smartfile.fs.fileExistsSync(certPath)) {
+      await plugins.smartfile.fs.removeManySync([certPath]);
+    }
+  }
+  
+  private getCertPath(routeName: string): string {
+    // Sanitize route name for filesystem
+    const safeName = routeName.replace(/[^a-zA-Z0-9-_]/g, '_');
+    return `${this.certDir}/${safeName}`;
+  }
+}