@push.rocks/smartproxy 15.0.2 → 16.0.3

package/ts/proxies/smart-proxy/network-proxy-bridge.ts

@@ -1,13 +1,21 @@
 import * as plugins from '../../plugins.js';
 import { NetworkProxy } from '../network-proxy/index.js';
 import { Port80Handler } from '../../http/port80/port80-handler.js';
-import { Port80HandlerEvents } from '../../core/models/common-types.js';
 import { subscribeToPort80Handler } from '../../core/utils/event-utils.js';
 import type { ICertificateData } from '../../certificate/models/certificate-types.js';
-import type { IConnectionRecord, ISmartProxyOptions, IDomainConfig } from './models/interfaces.js';
+import type { IConnectionRecord, ISmartProxyOptions } from './models/interfaces.js';
+import type { IRouteConfig } from './models/route-types.js';
 
 /**
  * Manages NetworkProxy integration for TLS termination
+ *
+ * NetworkProxyBridge connects SmartProxy with NetworkProxy to handle TLS termination.
+ * It directly passes route configurations to NetworkProxy and manages the physical
+ * connection piping between SmartProxy and NetworkProxy for TLS termination.
+ *
+ * It is used by SmartProxy for routes that have:
+ * - TLS mode of 'terminate' or 'terminate-and-reencrypt'
+ * - Certificate set to 'auto' or custom certificate
  */
 export class NetworkProxyBridge {
   private networkProxy: NetworkProxy | null = null;
@@ -40,7 +48,7 @@ export class NetworkProxyBridge {
    */
   public async initialize(): Promise<void> {
     if (!this.networkProxy && this.settings.useNetworkProxy && this.settings.useNetworkProxy.length > 0) {
-      // Configure NetworkProxy options based on PortProxy settings
+      // Configure NetworkProxy options based on SmartProxy settings
       const networkProxyOptions: any = {
         port: this.settings.networkProxyPort!,
         portProxyIntegration: true,
@@ -48,7 +56,6 @@ export class NetworkProxyBridge {
         useExternalPort80Handler: !!this.port80Handler // Use Port80Handler if available
       };
 
-
       this.networkProxy = new NetworkProxy(networkProxyOptions);
 
       console.log(`Initialized NetworkProxy on port ${this.settings.networkProxyPort}`);
@@ -58,8 +65,8 @@ export class NetworkProxyBridge {
         this.networkProxy.setExternalPort80Handler(this.port80Handler);
       }
 
-      // Convert and apply domain configurations to NetworkProxy
-      await this.syncDomainConfigsToNetworkProxy();
+      // Apply route configurations to NetworkProxy
+      await this.syncRoutesToNetworkProxy(this.settings.routes || []);
     }
   }
   
@@ -71,29 +78,8 @@ export class NetworkProxyBridge {
 
     console.log(`Received certificate for ${data.domain} from Port80Handler, updating NetworkProxy`);
 
-    try {
-      // Find existing config for this domain
-      const existingConfigs = this.networkProxy.getProxyConfigs()
-        .filter(config => config.hostName === data.domain);
-
-      if (existingConfigs.length > 0) {
-        // Update existing configs with new certificate
-        for (const config of existingConfigs) {
-          config.privateKey = data.privateKey;
-          config.publicKey = data.certificate;
-        }
-
-        // Apply updated configs
-        this.networkProxy.updateProxyConfigs(existingConfigs)
-          .then(() => console.log(`Updated certificate for ${data.domain} in NetworkProxy`))
-          .catch(err => console.log(`Error updating certificate in NetworkProxy: ${err}`));
-      } else {
-        // Create a new config for this domain
-        console.log(`No existing config found for ${data.domain}, creating new config in NetworkProxy`);
-      }
-    } catch (err) {
-      console.log(`Error handling certificate event: ${err}`);
-    }
+    // Apply certificate directly to NetworkProxy
+    this.networkProxy.updateCertificate(data.domain, data.certificate, data.privateKey);
   }
 
   /**
@@ -104,7 +90,9 @@ export class NetworkProxyBridge {
       console.log(`NetworkProxy not initialized: cannot apply external certificate for ${data.domain}`);
       return;
     }
-    this.handleCertificateEvent(data);
+    
+    // Apply certificate directly to NetworkProxy
+    this.networkProxy.updateCertificate(data.domain, data.certificate, data.privateKey);
   }
   
   /**
@@ -146,37 +134,6 @@ export class NetworkProxyBridge {
     }
   }
   
-  /**
-   * Register domains with Port80Handler
-   */
-  public registerDomainsWithPort80Handler(domains: string[]): void {
-    if (!this.port80Handler) {
-      console.log('Cannot register domains - Port80Handler not initialized');
-      return;
-    }
-    
-    for (const domain of domains) {
-      // Skip wildcards
-      if (domain.includes('*')) {
-        console.log(`Skipping wildcard domain for ACME: ${domain}`);
-        continue;
-      }
-      
-      // Register the domain
-      try {
-        this.port80Handler.addDomain({
-          domainName: domain,
-          sslRedirect: true,
-          acmeMaintenance: true
-        });
-        
-        console.log(`Registered domain with Port80Handler: ${domain}`);
-      } catch (err) {
-        console.log(`Error registering domain ${domain} with Port80Handler: ${err}`);
-      }
-    }
-  }
-  
   /**
    * Forwards a TLS connection to a NetworkProxy for handling
    */
@@ -241,7 +198,6 @@ export class NetworkProxyBridge {
       socket.pipe(proxySocket);
       proxySocket.pipe(socket);
 
-      // Update activity on data transfer (caller should handle this)
       if (this.settings.enableDetailedLogging) {
         console.log(`[${connectionId}] TLS connection successfully forwarded to NetworkProxy`);
       }
@@ -249,76 +205,44 @@ export class NetworkProxyBridge {
   }
   
   /**
-   * Synchronizes domain configurations to NetworkProxy
+   * Synchronizes routes to NetworkProxy
+   *
+   * This method directly passes route configurations to NetworkProxy without any
+   * intermediate conversion. NetworkProxy natively understands route configurations.
+   *
+   * @param routes The route configurations to sync to NetworkProxy
    */
-  public async syncDomainConfigsToNetworkProxy(): Promise<void> {
+  public async syncRoutesToNetworkProxy(routes: IRouteConfig[]): Promise<void> {
     if (!this.networkProxy) {
       console.log('Cannot sync configurations - NetworkProxy not initialized');
       return;
     }
 
     try {
-      // Get SSL certificates from assets
-      // Import fs directly since it's not in plugins
-      const fs = await import('fs');
-
-      let certPair;
-      try {
-        certPair = {
-          key: fs.readFileSync('assets/certs/key.pem', 'utf8'),
-          cert: fs.readFileSync('assets/certs/cert.pem', 'utf8'),
-        };
-      } catch (certError) {
-        console.log(`Warning: Could not read default certificates: ${certError}`);
-        console.log(
-          'Using empty certificate placeholders - ACME will generate proper certificates if enabled'
+      // Filter only routes that are applicable to NetworkProxy (TLS termination)
+      const networkProxyRoutes = routes.filter(route => {
+        return (
+          route.action.type === 'forward' &&
+          route.action.tls &&
+          (route.action.tls.mode === 'terminate' || route.action.tls.mode === 'terminate-and-reencrypt')
         );
+      });
 
-        // Use empty placeholders - NetworkProxy will use its internal defaults
-        // or ACME will generate proper ones if enabled
-        certPair = {
-          key: '',
-          cert: '',
-        };
-      }
-
-      // Convert domain configs to NetworkProxy configs
-      const proxyConfigs = this.networkProxy.convertSmartProxyConfigs(
-        this.settings.domainConfigs,
-        certPair
-      );
-
-      // Log ACME-eligible domains
-      const acmeEnabled = !!this.settings.acme?.enabled;
-      if (acmeEnabled) {
-        const acmeEligibleDomains = proxyConfigs
-          .filter((config) => !config.hostName.includes('*')) // Exclude wildcards
-          .map((config) => config.hostName);
-
-        if (acmeEligibleDomains.length > 0) {
-          console.log(`Domains eligible for ACME certificates: ${acmeEligibleDomains.join(', ')}`);
-          
-          // Register these domains with Port80Handler if available
-          if (this.port80Handler) {
-            this.registerDomainsWithPort80Handler(acmeEligibleDomains);
-          }
-        } else {
-          console.log('No domains eligible for ACME certificates found in configuration');
-        }
-      }
-
-      // Update NetworkProxy with the converted configs
-      await this.networkProxy.updateProxyConfigs(proxyConfigs);
-      console.log(`Successfully synchronized ${proxyConfigs.length} domain configurations to NetworkProxy`);
+      // Pass routes directly to NetworkProxy
+      await this.networkProxy.updateRouteConfigs(networkProxyRoutes);
+      console.log(`Synced ${networkProxyRoutes.length} routes directly to NetworkProxy`);
     } catch (err) {
-      console.log(`Failed to sync configurations: ${err}`);
+      console.log(`Error syncing routes to NetworkProxy: ${err}`);
     }
   }
   
   /**
    * Request a certificate for a specific domain
+   *
+   * @param domain The domain to request a certificate for
+   * @param routeName Optional route name to associate with this certificate
    */
-  public async requestCertificate(domain: string): Promise<boolean> {
+  public async requestCertificate(domain: string, routeName?: string): Promise<boolean> {
     // Delegate to Port80Handler if available
     if (this.port80Handler) {
       try {
@@ -328,14 +252,24 @@ export class NetworkProxyBridge {
           console.log(`Certificate already exists for ${domain}`);
           return true;
         }
-        
-        // Register the domain for certificate issuance
-        this.port80Handler.addDomain({
+
+        // Build the domain options
+        const domainOptions: any = {
           domainName: domain,
           sslRedirect: true,
-          acmeMaintenance: true
-        });
-        
+          acmeMaintenance: true,
+        };
+
+        // Add route reference if available
+        if (routeName) {
+          domainOptions.routeReference = {
+            routeName
+          };
+        }
+
+        // Register the domain for certificate issuance
+        this.port80Handler.addDomain(domainOptions);
+
         console.log(`Domain ${domain} registered for certificate issuance`);
         return true;
       } catch (err) {
@@ -343,7 +277,7 @@ export class NetworkProxyBridge {
         return false;
       }
     }
-    
+
     // Fall back to NetworkProxy if Port80Handler is not available
     if (!this.networkProxy) {
       console.log('Cannot request certificate - NetworkProxy not initialized');

package/ts/proxies/smart-proxy/port-manager.ts

@@ -0,0 +1,195 @@
+import * as plugins from '../../plugins.js';
+import type { ISmartProxyOptions } from './models/interfaces.js';
+import { RouteConnectionHandler } from './route-connection-handler.js';
+
+/**
+ * PortManager handles the dynamic creation and removal of port listeners
+ * 
+ * This class provides methods to add and remove listening ports at runtime,
+ * allowing SmartProxy to adapt to configuration changes without requiring
+ * a full restart.
+ */
+export class PortManager {
+  private servers: Map<number, plugins.net.Server> = new Map();
+  private settings: ISmartProxyOptions;
+  private routeConnectionHandler: RouteConnectionHandler;
+  private isShuttingDown: boolean = false;
+
+  /**
+   * Create a new PortManager
+   * 
+   * @param settings The SmartProxy settings
+   * @param routeConnectionHandler The handler for new connections
+   */
+  constructor(
+    settings: ISmartProxyOptions,
+    routeConnectionHandler: RouteConnectionHandler
+  ) {
+    this.settings = settings;
+    this.routeConnectionHandler = routeConnectionHandler;
+  }
+
+  /**
+   * Start listening on a specific port
+   * 
+   * @param port The port number to listen on
+   * @returns Promise that resolves when the server is listening or rejects on error
+   */
+  public async addPort(port: number): Promise<void> {
+    // Check if we're already listening on this port
+    if (this.servers.has(port)) {
+      console.log(`PortManager: Already listening on port ${port}`);
+      return;
+    }
+
+    // Create a server for this port
+    const server = plugins.net.createServer((socket) => {
+      // Check if shutting down
+      if (this.isShuttingDown) {
+        socket.end();
+        socket.destroy();
+        return;
+      }
+      
+      // Delegate to route connection handler
+      this.routeConnectionHandler.handleConnection(socket);
+    }).on('error', (err: Error) => {
+      console.log(`Server Error on port ${port}: ${err.message}`);
+    });
+    
+    // Start listening on the port
+    return new Promise<void>((resolve, reject) => {
+      server.listen(port, () => {
+        const isNetworkProxyPort = this.settings.useNetworkProxy?.includes(port);
+        console.log(
+          `SmartProxy -> OK: Now listening on port ${port}${
+            isNetworkProxyPort ? ' (NetworkProxy forwarding enabled)' : ''
+          }`
+        );
+        
+        // Store the server reference
+        this.servers.set(port, server);
+        resolve();
+      }).on('error', (err) => {
+        console.log(`Failed to listen on port ${port}: ${err.message}`);
+        reject(err);
+      });
+    });
+  }
+
+  /**
+   * Stop listening on a specific port
+   * 
+   * @param port The port to stop listening on
+   * @returns Promise that resolves when the server is closed
+   */
+  public async removePort(port: number): Promise<void> {
+    // Get the server for this port
+    const server = this.servers.get(port);
+    if (!server) {
+      console.log(`PortManager: Not listening on port ${port}`);
+      return;
+    }
+
+    // Close the server
+    return new Promise<void>((resolve) => {
+      server.close((err) => {
+        if (err) {
+          console.log(`Error closing server on port ${port}: ${err.message}`);
+        } else {
+          console.log(`SmartProxy -> Stopped listening on port ${port}`);
+        }
+        
+        // Remove the server reference
+        this.servers.delete(port);
+        resolve();
+      });
+    });
+  }
+
+  /**
+   * Add multiple ports at once
+   * 
+   * @param ports Array of ports to add
+   * @returns Promise that resolves when all servers are listening
+   */
+  public async addPorts(ports: number[]): Promise<void> {
+    const uniquePorts = [...new Set(ports)];
+    await Promise.all(uniquePorts.map(port => this.addPort(port)));
+  }
+
+  /**
+   * Remove multiple ports at once
+   * 
+   * @param ports Array of ports to remove
+   * @returns Promise that resolves when all servers are closed
+   */
+  public async removePorts(ports: number[]): Promise<void> {
+    const uniquePorts = [...new Set(ports)];
+    await Promise.all(uniquePorts.map(port => this.removePort(port)));
+  }
+
+  /**
+   * Update listening ports to match the provided list
+   * 
+   * This will add any ports that aren't currently listening,
+   * and remove any ports that are no longer needed.
+   * 
+   * @param ports Array of ports that should be listening
+   * @returns Promise that resolves when all operations are complete
+   */
+  public async updatePorts(ports: number[]): Promise<void> {
+    const targetPorts = new Set(ports);
+    const currentPorts = new Set(this.servers.keys());
+    
+    // Find ports to add and remove
+    const portsToAdd = ports.filter(port => !currentPorts.has(port));
+    const portsToRemove = Array.from(currentPorts).filter(port => !targetPorts.has(port));
+    
+    // Log the changes
+    if (portsToAdd.length > 0) {
+      console.log(`PortManager: Adding new listeners for ports: ${portsToAdd.join(', ')}`);
+    }
+    
+    if (portsToRemove.length > 0) {
+      console.log(`PortManager: Removing listeners for ports: ${portsToRemove.join(', ')}`);
+    }
+    
+    // Add and remove ports
+    await this.removePorts(portsToRemove);
+    await this.addPorts(portsToAdd);
+  }
+
+  /**
+   * Get all ports that are currently listening
+   * 
+   * @returns Array of port numbers
+   */
+  public getListeningPorts(): number[] {
+    return Array.from(this.servers.keys());
+  }
+
+  /**
+   * Mark the port manager as shutting down
+   */
+  public setShuttingDown(isShuttingDown: boolean): void {
+    this.isShuttingDown = isShuttingDown;
+  }
+
+  /**
+   * Close all listening servers
+   * 
+   * @returns Promise that resolves when all servers are closed
+   */
+  public async closeAll(): Promise<void> {
+    const allPorts = Array.from(this.servers.keys());
+    await this.removePorts(allPorts);
+  }
+
+  /**
+   * Get all server instances (for testing or debugging)
+   */
+  public getServers(): Map<number, plugins.net.Server> {
+    return new Map(this.servers);
+  }
+}