@push.rocks/smartproxy 12.0.0 → 13.1.2

package/ts/{port80handler/classes.port80handler.ts → http/port80/port80-handler.ts}

@@ -1,6 +1,6 @@
-import * as plugins from '../plugins.js';
+import * as plugins from '../../plugins.js';
 import { IncomingMessage, ServerResponse } from 'http';
-import { Port80HandlerEvents } from '../common/types.js';
+import { CertificateEvents } from '../../certificate/events/certificate-events.js';
 import type {
   IForwardConfig,
   IDomainOptions,
@@ -8,50 +8,26 @@ import type {
   ICertificateFailure,
   ICertificateExpiring,
   IAcmeOptions
-} from '../common/types.js';
-// (fs and path I/O moved to CertProvisioner)
+} from '../../certificate/models/certificate-types.js';
+import {
+  HttpEvents,
+  HttpStatus,
+  HttpError,
+  CertificateError,
+  ServerError,
+} from '../models/http-types.js';
+import type { IDomainCertificate } from '../models/http-types.js';
+import { ChallengeResponder } from './challenge-responder.js';
 
-/**
- * Custom error classes for better error handling
- */
-export class Port80HandlerError extends Error {
-  constructor(message: string) {
-    super(message);
-    this.name = 'Port80HandlerError';
-  }
-}
-
-export class CertificateError extends Port80HandlerError {
-  constructor(
-    message: string,
-    public readonly domain: string,
-    public readonly isRenewal: boolean = false
-  ) {
-    super(`${message} for domain ${domain}${isRenewal ? ' (renewal)' : ''}`);
-    this.name = 'CertificateError';
-  }
-}
-
-export class ServerError extends Port80HandlerError {
-  constructor(message: string, public readonly code?: string) {
-    super(message);
-    this.name = 'ServerError';
-  }
+// Re-export for backward compatibility
+export {
+  HttpError as Port80HandlerError,
+  CertificateError,
+  ServerError
 }
 
-
-/**
- * Represents a domain configuration with certificate status information
- */
-interface IDomainCertificate {
-  options: IDomainOptions;
-  certObtained: boolean;
-  obtainingInProgress: boolean;
-  certificate?: string;
-  privateKey?: string;
-  expiryDate?: Date;
-  lastRenewalAttempt?: Date;
-}
+// Port80Handler events enum for backward compatibility
+export const Port80HandlerEvents = CertificateEvents;
 
 /**
  * Configuration options for the Port80Handler
@@ -65,13 +41,10 @@ interface IDomainCertificate {
  */
 export class Port80Handler extends plugins.EventEmitter {
   private domainCertificates: Map<string, IDomainCertificate>;
-  // SmartAcme instance for certificate management
-  private smartAcme: plugins.smartacme.SmartAcme | null = null;
-  private smartAcmeHttp01Handler!: plugins.smartacme.handlers.Http01MemoryHandler;
+  private challengeResponder: ChallengeResponder | null = null;
   private server: plugins.http.Server | null = null;
-  
+
   // Renewal scheduling is handled externally by SmartProxy
-  // (Removed internal renewal timer)
   private isShuttingDown: boolean = false;
   private options: Required<IAcmeOptions>;
 
@@ -82,7 +55,7 @@ export class Port80Handler extends plugins.EventEmitter {
   constructor(options: IAcmeOptions = {}) {
     super();
     this.domainCertificates = new Map<string, IDomainCertificate>();
-    
+
     // Default options
     this.options = {
       port: options.port ?? 80,
@@ -97,6 +70,32 @@ export class Port80Handler extends plugins.EventEmitter {
       autoRenew: options.autoRenew ?? true,
       domainForwards: options.domainForwards ?? []
     };
+
+    // Initialize challenge responder
+    if (this.options.enabled) {
+      this.challengeResponder = new ChallengeResponder(
+        this.options.useProduction,
+        this.options.accountEmail,
+        this.options.certificateStore
+      );
+
+      // Forward certificate events from the challenge responder
+      this.challengeResponder.on(CertificateEvents.CERTIFICATE_ISSUED, (data: ICertificateData) => {
+        this.emit(CertificateEvents.CERTIFICATE_ISSUED, data);
+      });
+
+      this.challengeResponder.on(CertificateEvents.CERTIFICATE_RENEWED, (data: ICertificateData) => {
+        this.emit(CertificateEvents.CERTIFICATE_RENEWED, data);
+      });
+
+      this.challengeResponder.on(CertificateEvents.CERTIFICATE_FAILED, (error: ICertificateFailure) => {
+        this.emit(CertificateEvents.CERTIFICATE_FAILED, error);
+      });
+
+      this.challengeResponder.on(CertificateEvents.CERTIFICATE_EXPIRING, (expiry: ICertificateExpiring) => {
+        this.emit(CertificateEvents.CERTIFICATE_EXPIRING, expiry);
+      });
+    }
   }
 
   /**
@@ -106,7 +105,7 @@ export class Port80Handler extends plugins.EventEmitter {
     if (this.server) {
       throw new ServerError('Server is already running');
     }
-    
+
     if (this.isShuttingDown) {
       throw new ServerError('Server is shutting down');
     }
@@ -116,24 +115,22 @@ export class Port80Handler extends plugins.EventEmitter {
       console.log('Port80Handler is disabled, skipping start');
       return;
     }
-    // Initialize SmartAcme with in-memory HTTP-01 challenge handler
-    if (this.options.enabled) {
-      this.smartAcmeHttp01Handler = new plugins.smartacme.handlers.Http01MemoryHandler();
-      this.smartAcme = new plugins.smartacme.SmartAcme({
-        accountEmail: this.options.accountEmail,
-        certManager: new plugins.smartacme.certmanagers.MemoryCertManager(),
-        environment: this.options.useProduction ? 'production' : 'integration',
-        challengeHandlers: [ this.smartAcmeHttp01Handler ],
-        challengePriority: ['http-01'],
-      });
-      await this.smartAcme.start();
+
+    // Initialize the challenge responder if enabled
+    if (this.options.enabled && this.challengeResponder) {
+      try {
+        await this.challengeResponder.initialize();
+      } catch (error) {
+        throw new ServerError(`Failed to initialize challenge responder: ${
+          error instanceof Error ? error.message : String(error)
+        }`);
+      }
     }
 
     return new Promise((resolve, reject) => {
       try {
-        
         this.server = plugins.http.createServer((req, res) => this.handleRequest(req, res));
-        
+
         this.server.on('error', (error: NodeJS.ErrnoException) => {
           if (error.code === 'EACCES') {
             reject(new ServerError(`Permission denied to bind to port ${this.options.port}. Try running with elevated privileges or use a port > 1024.`, error.code));
@@ -143,11 +140,11 @@ export class Port80Handler extends plugins.EventEmitter {
             reject(new ServerError(error.message, error.code));
           }
         });
-        
+
         this.server.listen(this.options.port, () => {
           console.log(`Port80Handler is listening on port ${this.options.port}`);
-          this.emit(Port80HandlerEvents.MANAGER_STARTED, this.options.port);
-          
+          this.emit(CertificateEvents.MANAGER_STARTED, this.options.port);
+
           // Start certificate process for domains with acmeMaintenance enabled
           for (const [domain, domainInfo] of this.domainCertificates.entries()) {
             // Skip glob patterns for certificate issuance
@@ -155,14 +152,14 @@ export class Port80Handler extends plugins.EventEmitter {
               console.log(`Skipping initial certificate for glob pattern: ${domain}`);
               continue;
             }
-            
+
             if (domainInfo.options.acmeMaintenance && !domainInfo.certObtained && !domainInfo.obtainingInProgress) {
               this.obtainCertificate(domain).catch(err => {
                 console.error(`Error obtaining initial certificate for ${domain}:`, err);
               });
             }
           }
-          
+
           resolve();
         });
       } catch (error) {
@@ -173,22 +170,21 @@ export class Port80Handler extends plugins.EventEmitter {
   }
 
   /**
-   * Stops the HTTP server and renewal timer
+   * Stops the HTTP server and cleanup resources
    */
   public async stop(): Promise<void> {
     if (!this.server) {
       return;
     }
-    
+
     this.isShuttingDown = true;
-    
 
     return new Promise<void>((resolve) => {
       if (this.server) {
         this.server.close(() => {
           this.server = null;
           this.isShuttingDown = false;
-          this.emit(Port80HandlerEvents.MANAGER_STOPPED);
+          this.emit(CertificateEvents.MANAGER_STOPPED);
           resolve();
         });
       } else {
@@ -204,25 +200,25 @@ export class Port80Handler extends plugins.EventEmitter {
    */
   public addDomain(options: IDomainOptions): void {
     if (!options.domainName || typeof options.domainName !== 'string') {
-      throw new Port80HandlerError('Invalid domain name');
+      throw new HttpError('Invalid domain name');
     }
-    
+
     const domainName = options.domainName;
-    
+
     if (!this.domainCertificates.has(domainName)) {
       this.domainCertificates.set(domainName, {
         options,
         certObtained: false,
         obtainingInProgress: false
       });
-      
+
       console.log(`Domain added: ${domainName} with configuration:`, {
         sslRedirect: options.sslRedirect,
         acmeMaintenance: options.acmeMaintenance,
         hasForward: !!options.forward,
         hasAcmeForward: !!options.acmeForward
       });
-      
+
       // If acmeMaintenance is enabled and not a glob pattern, start certificate process immediately
       if (options.acmeMaintenance && this.server && !this.isGlobPattern(domainName)) {
         this.obtainCertificate(domainName).catch(err => {
@@ -256,13 +252,13 @@ export class Port80Handler extends plugins.EventEmitter {
     if (this.isGlobPattern(domain)) {
       return null;
     }
-    
+
     const domainInfo = this.domainCertificates.get(domain);
-    
+
     if (!domainInfo || !domainInfo.certObtained || !domainInfo.certificate || !domainInfo.privateKey) {
       return null;
     }
-    
+
     return {
       domain,
       certificate: domainInfo.certificate,
@@ -295,14 +291,14 @@ export class Port80Handler extends plugins.EventEmitter {
         pattern: requestDomain
       };
     }
-    
+
     // Then try glob patterns
     for (const [pattern, domainInfo] of this.domainCertificates.entries()) {
       if (this.isGlobPattern(pattern) && this.domainMatchesPattern(requestDomain, pattern)) {
         return { domainInfo, pattern };
       }
     }
-    
+
     return null;
   }
   
@@ -339,16 +335,45 @@ export class Port80Handler extends plugins.EventEmitter {
    * @param res The HTTP response
    */
   private handleRequest(req: plugins.http.IncomingMessage, res: plugins.http.ServerResponse): void {
+    // Emit request received event with basic info
+    this.emit(HttpEvents.REQUEST_RECEIVED, {
+      url: req.url,
+      method: req.method,
+      headers: req.headers
+    });
+
     const hostHeader = req.headers.host;
     if (!hostHeader) {
-      res.statusCode = 400;
+      res.statusCode = HttpStatus.BAD_REQUEST;
       res.end('Bad Request: Host header is missing');
       return;
     }
-    
+
     // Extract domain (ignoring any port in the Host header)
     const domain = hostHeader.split(':')[0];
 
+    // Check if this is an ACME challenge request that our ChallengeResponder can handle
+    if (this.challengeResponder && req.url?.startsWith('/.well-known/acme-challenge/')) {
+      // Handle ACME HTTP-01 challenge with the challenge responder
+      const domainMatch = this.getDomainInfoForRequest(domain);
+
+      // If there's a specific ACME forwarding config for this domain, use that instead
+      if (domainMatch?.domainInfo.options.acmeForward) {
+        this.forwardRequest(req, res, domainMatch.domainInfo.options.acmeForward, 'ACME challenge');
+        return;
+      }
+
+      // If domain exists and has acmeMaintenance enabled, or we don't have the domain yet
+      // (for auto-provisioning), try to handle the ACME challenge
+      if (!domainMatch || domainMatch.domainInfo.options.acmeMaintenance) {
+        // Let the challenge responder try to handle this request
+        if (this.challengeResponder.handleRequest(req, res)) {
+          // Challenge was handled
+          return;
+        }
+      }
+    }
+
     // Dynamic provisioning: if domain not yet managed, register for ACME and return 503
     if (!this.domainCertificates.has(domain)) {
       try {
@@ -356,14 +381,15 @@ export class Port80Handler extends plugins.EventEmitter {
       } catch (err) {
         console.error(`Error registering domain for on-demand provisioning: ${err}`);
       }
-      res.statusCode = 503;
+      res.statusCode = HttpStatus.SERVICE_UNAVAILABLE;
       res.end('Certificate issuance in progress');
       return;
     }
+
     // Get domain config, using glob pattern matching if needed
     const domainMatch = this.getDomainInfoForRequest(domain);
     if (!domainMatch) {
-      res.statusCode = 404;
+      res.statusCode = HttpStatus.NOT_FOUND;
       res.end('Domain not configured');
       return;
     }
@@ -371,29 +397,6 @@ export class Port80Handler extends plugins.EventEmitter {
     const { domainInfo, pattern } = domainMatch;
     const options = domainInfo.options;
 
-    // Handle ACME HTTP-01 challenge requests or forwarding
-    if (req.url && req.url.startsWith('/.well-known/acme-challenge/')) {
-      // Forward ACME requests if configured
-      if (options.acmeForward) {
-        this.forwardRequest(req, res, options.acmeForward, 'ACME challenge');
-        return;
-      }
-      // If not managing ACME for this domain, return 404
-      if (!options.acmeMaintenance) {
-        res.statusCode = 404;
-        res.end('Not found');
-        return;
-      }
-      // Delegate to Http01MemoryHandler
-      if (this.smartAcmeHttp01Handler) {
-        this.smartAcmeHttp01Handler.handleRequest(req, res);
-      } else {
-        res.statusCode = 500;
-        res.end('ACME HTTP-01 handler not initialized');
-      }
-      return;
-    }
-
     // Check if we should forward non-ACME requests
     if (options.forward) {
       this.forwardRequest(req, res, options.forward, 'HTTP');
@@ -406,13 +409,13 @@ export class Port80Handler extends plugins.EventEmitter {
       const httpsPort = this.options.httpsRedirectPort;
       const portSuffix = httpsPort === 443 ? '' : `:${httpsPort}`;
       const redirectUrl = `https://${domain}${portSuffix}${req.url || '/'}`;
-      
-      res.statusCode = 301;
+
+      res.statusCode = HttpStatus.MOVED_PERMANENTLY;
       res.setHeader('Location', redirectUrl);
       res.end(`Redirecting to ${redirectUrl}`);
       return;
     }
-    
+
     // Handle case where certificate maintenance is enabled but not yet obtained
     // (Skip for glob patterns as they can't have certificates)
     if (!this.isGlobPattern(pattern) && options.acmeMaintenance && !domainInfo.certObtained) {
@@ -420,7 +423,7 @@ export class Port80Handler extends plugins.EventEmitter {
       if (!domainInfo.obtainingInProgress) {
         this.obtainCertificate(domain).catch(err => {
           const errorMessage = err instanceof Error ? err.message : 'Unknown error';
-          this.emit(Port80HandlerEvents.CERTIFICATE_FAILED, {
+          this.emit(CertificateEvents.CERTIFICATE_FAILED, {
             domain,
             error: errorMessage,
             isRenewal: false
@@ -428,15 +431,22 @@ export class Port80Handler extends plugins.EventEmitter {
           console.error(`Error obtaining certificate for ${domain}:`, err);
         });
       }
-      
-      res.statusCode = 503;
+
+      res.statusCode = HttpStatus.SERVICE_UNAVAILABLE;
       res.end('Certificate issuance in progress, please try again later.');
       return;
     }
-    
+
     // Default response for unhandled request
-    res.statusCode = 404;
+    res.statusCode = HttpStatus.NOT_FOUND;
     res.end('No handlers configured for this request');
+
+    // Emit request handled event
+    this.emit(HttpEvents.REQUEST_HANDLED, {
+      domain,
+      url: req.url,
+      statusCode: res.statusCode
+    });
   }
   
   /**
@@ -447,7 +457,7 @@ export class Port80Handler extends plugins.EventEmitter {
    * @param requestType Type of request for logging
    */
   private forwardRequest(
-    req: plugins.http.IncomingMessage, 
+    req: plugins.http.IncomingMessage,
     res: plugins.http.ServerResponse,
     target: IForwardConfig,
     requestType: string
@@ -459,40 +469,47 @@ export class Port80Handler extends plugins.EventEmitter {
       method: req.method,
       headers: { ...req.headers }
     };
-    
+
     const domain = req.headers.host?.split(':')[0] || 'unknown';
     console.log(`Forwarding ${requestType} request for ${domain} to ${target.ip}:${target.port}`);
-    
+
     const proxyReq = plugins.http.request(options, (proxyRes) => {
       // Copy status code
-      res.statusCode = proxyRes.statusCode || 500;
-      
+      res.statusCode = proxyRes.statusCode || HttpStatus.INTERNAL_SERVER_ERROR;
+
       // Copy headers
       for (const [key, value] of Object.entries(proxyRes.headers)) {
         if (value) res.setHeader(key, value);
       }
-      
+
       // Pipe response data
       proxyRes.pipe(res);
-      
-      this.emit(Port80HandlerEvents.REQUEST_FORWARDED, {
+
+      this.emit(HttpEvents.REQUEST_FORWARDED, {
         domain,
         requestType,
         target: `${target.ip}:${target.port}`,
         statusCode: proxyRes.statusCode
       });
     });
-    
+
     proxyReq.on('error', (error) => {
       console.error(`Error forwarding request to ${target.ip}:${target.port}:`, error);
+
+      this.emit(HttpEvents.REQUEST_ERROR, {
+        domain,
+        error: error.message,
+        target: `${target.ip}:${target.port}`
+      });
+
       if (!res.headersSent) {
-        res.statusCode = 502;
+        res.statusCode = HttpStatus.INTERNAL_SERVER_ERROR;
         res.end(`Proxy error: ${error.message}`);
       } else {
         res.end();
       }
     });
-    
+
     // Pipe original request to proxy request
     if (req.readable) {
       req.pipe(proxyReq);
@@ -507,59 +524,45 @@ export class Port80Handler extends plugins.EventEmitter {
    * @param domain The domain to obtain a certificate for
    * @param isRenewal Whether this is a renewal attempt
    */
-  /**
-   * Obtains a certificate for a domain using SmartAcme HTTP-01 challenges
-   * @param domain The domain to obtain a certificate for
-   * @param isRenewal Whether this is a renewal attempt
-   */
   private async obtainCertificate(domain: string, isRenewal: boolean = false): Promise<void> {
     if (this.isGlobPattern(domain)) {
       throw new CertificateError('Cannot obtain certificates for glob pattern domains', domain, isRenewal);
     }
+
     const domainInfo = this.domainCertificates.get(domain)!;
+
     if (!domainInfo.options.acmeMaintenance) {
       console.log(`Skipping certificate issuance for ${domain} - acmeMaintenance is disabled`);
       return;
     }
+
     if (domainInfo.obtainingInProgress) {
       console.log(`Certificate issuance already in progress for ${domain}`);
       return;
     }
-    if (!this.smartAcme) {
-      throw new Port80HandlerError('SmartAcme is not initialized');
+
+    if (!this.challengeResponder) {
+      throw new HttpError('Challenge responder is not initialized');
     }
+
     domainInfo.obtainingInProgress = true;
     domainInfo.lastRenewalAttempt = new Date();
+
     try {
-      // Request certificate via SmartAcme
-      const certObj = await this.smartAcme.getCertificateForDomain(domain);
-      const certificate = certObj.publicKey;
-      const privateKey = certObj.privateKey;
-      const expiryDate = new Date(certObj.validUntil);
-      domainInfo.certificate = certificate;
-      domainInfo.privateKey = privateKey;
+      // Request certificate via ChallengeResponder
+      // The ChallengeResponder handles all ACME client interactions and will emit events
+      const certData = await this.challengeResponder.requestCertificate(domain, isRenewal);
+
+      // Update domain info with certificate data
+      domainInfo.certificate = certData.certificate;
+      domainInfo.privateKey = certData.privateKey;
       domainInfo.certObtained = true;
-      domainInfo.expiryDate = expiryDate;
+      domainInfo.expiryDate = certData.expiryDate;
 
       console.log(`Certificate ${isRenewal ? 'renewed' : 'obtained'} for ${domain}`);
-      // Persistence moved to CertProvisioner
-      const eventType = isRenewal
-        ? Port80HandlerEvents.CERTIFICATE_RENEWED
-        : Port80HandlerEvents.CERTIFICATE_ISSUED;
-      this.emitCertificateEvent(eventType, {
-        domain,
-        certificate,
-        privateKey,
-        expiryDate: expiryDate || this.getDefaultExpiryDate()
-      });
     } catch (error: any) {
-      const errorMsg = error?.message || 'Unknown error';
+      const errorMsg = error instanceof Error ? error.message : String(error);
       console.error(`Error during certificate issuance for ${domain}:`, error);
-      this.emit(Port80HandlerEvents.CERTIFICATE_FAILED, {
-        domain,
-        error: errorMsg,
-        isRenewal
-      } as ICertificateFailure);
       throw new CertificateError(errorMsg, domain, isRenewal);
     } finally {
       domainInfo.obtainingInProgress = false;
@@ -609,7 +612,7 @@ export class Port80Handler extends plugins.EventEmitter {
    * @param eventType The event type to emit
    * @param data The certificate data
    */
-  private emitCertificateEvent(eventType: Port80HandlerEvents, data: ICertificateData): void {
+  private emitCertificateEvent(eventType: CertificateEvents, data: ICertificateData): void {
     this.emit(eventType, data);
   }
   
@@ -671,7 +674,7 @@ export class Port80Handler extends plugins.EventEmitter {
    */
   public async renewCertificate(domain: string): Promise<void> {
     if (!this.domainCertificates.has(domain)) {
-      throw new Port80HandlerError(`Domain not managed: ${domain}`);
+      throw new HttpError(`Domain not managed: ${domain}`);
     }
     // Trigger renewal via ACME
     await this.obtainCertificate(domain, true);

package/ts/http/redirects/index.ts

@@ -0,0 +1,3 @@
+/**
+ * HTTP redirects
+ */

package/ts/http/router/index.ts

@@ -0,0 +1,5 @@
+/**
+ * HTTP routing
+ */
+
+export * from './proxy-router.js';