@push.rocks/smartmta 8.0.1 → 8.1.1

package/ts/mail/routing/classes.email.router.ts

@@ -4,6 +4,7 @@ import type { IStorageManager } from '../interfaces.storage.js';
 import type { IEmailRoute, IEmailMatch, IEmailAction, IEmailContext } from './interfaces.js';
 import type { Email } from '../core/classes.email.js';
 import { getErrorMessage } from '../../functions.errors.js';
+import { assertValidRetentionDays } from './functions.routing.validation.js';
 
 /**
  * Email router that evaluates routes and determines actions
@@ -25,6 +26,7 @@ export class EmailRouter extends EventEmitter {
     persistChanges?: boolean;
   }) {
     super();
+    this.validateRoutes(routes);
     this.routes = this.sortRoutesByPriority(routes);
     this.storageManager = options?.storageManager;
     this.persistChanges = options?.persistChanges ?? !!this.storageManager;
@@ -41,6 +43,32 @@ export class EmailRouter extends EventEmitter {
   public async initialize(): Promise<void> {
     await this.initializationPromise;
   }
+
+  private validateRoute(route: IEmailRoute): void {
+    if (!route?.name || !route.match || !route.action) {
+      throw new Error('Invalid route: missing required fields');
+    }
+
+    if (route.action.type !== 'store') {
+      return;
+    }
+    if (!route.action.store) {
+      throw new Error(`Store route ${route.name} requires store configuration`);
+    }
+    assertValidRetentionDays(
+      route.action.store.retentionDays,
+      `Store route ${route.name}`,
+    );
+  }
+
+  private validateRoutes(routes: IEmailRoute[]): void {
+    if (!Array.isArray(routes)) {
+      throw new Error('Invalid routes: expected an array');
+    }
+    for (const route of routes) {
+      this.validateRoute(route);
+    }
+  }
   
   /**
    * Sort routes by priority (higher priority first)
@@ -69,6 +97,7 @@ export class EmailRouter extends EventEmitter {
    * @param persist Whether to persist changes (defaults to persistChanges setting)
    */
   public async updateRoutes(routes: IEmailRoute[], persist?: boolean): Promise<void> {
+    this.validateRoutes(routes);
     this.routes = this.sortRoutesByPriority(routes);
     this.clearCache();
     this.emit('routesUpdated', this.routes);
@@ -409,11 +438,7 @@ export class EmailRouter extends EventEmitter {
     
     try {
       // Validate all routes before saving
-      for (const route of this.routes) {
-        if (!route.name || !route.match || !route.action) {
-          throw new Error(`Invalid route: ${JSON.stringify(route)}`);
-        }
-      }
+      this.validateRoutes(this.routes);
       
       const routesData = JSON.stringify(this.routes, null, 2);
       await this.storageManager.set('/email/routes/config.json', routesData);
@@ -447,13 +472,7 @@ export class EmailRouter extends EventEmitter {
       
       const loadedRoutes = JSON.parse(routesData) as IEmailRoute[];
       
-      // Validate loaded routes
-      for (const route of loadedRoutes) {
-        if (!route.name || !route.match || !route.action) {
-          console.warn(`Skipping invalid route: ${JSON.stringify(route)}`);
-          continue;
-        }
-      }
+      this.validateRoutes(loadedRoutes);
       
       if (options?.replace) {
         // Replace all routes
@@ -491,10 +510,7 @@ export class EmailRouter extends EventEmitter {
    * @param persist Whether to persist changes
    */
   public async addRoute(route: IEmailRoute, persist?: boolean): Promise<void> {
-    // Validate route
-    if (!route.name || !route.match || !route.action) {
-      throw new Error('Invalid route: missing required fields');
-    }
+    this.validateRoute(route);
     
     // Check if route already exists
     const existingIndex = this.routes.findIndex(r => r.name === route.name);
@@ -547,10 +563,7 @@ export class EmailRouter extends EventEmitter {
    * @param persist Whether to persist changes
    */
   public async updateRoute(name: string, route: IEmailRoute, persist?: boolean): Promise<void> {
-    // Validate route
-    if (!route.name || !route.match || !route.action) {
-      throw new Error('Invalid route: missing required fields');
-    }
+    this.validateRoute(route);
     
     const index = this.routes.findIndex(r => r.name === name);