@push-rpc/next 3.0.1 → 3.0.2

package/.claude/settings.local.json

@@ -0,0 +1,12 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(wc:*)",
+      "Bash(npm ls:*)",
+      "Bash(npm audit:*)",
+      "Bash(npm outdated:*)",
+      "Bash(npx tsc *)",
+      "Bash(echo \"---TYPECHECK DONE \\(exit $?\\)---\")"
+    ]
+  }
+}

package/dist/index.d.ts

@@ -2,7 +2,7 @@ import { ServicesClient } from "./client/remote";
 import type { Services } from "./rpc.js";
 import type { ServicesImplementation } from "./server/implementation.js";
 export { Services };
-export type { RemoteFunction, Consumer, RpcContext, RpcConnectionContext } from "./rpc.js";
+export type { RemoteFunction, Consumer, RpcContext, RpcConnectionContext, PING_MSG, PONG_MSG, } from "./rpc.js";
 export { RpcError, RpcErrors, CallOptions } from "./rpc.js";
 export type { Middleware } from "./utils/middleware.js";
 export { withMiddlewares } from "./utils/middleware.js";

package/dist/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;AAQA,mCAAyD;AAAjD,kGAAA,QAAQ,OAAA;AAAE,mGAAA,SAAS,OAAA;AAAE,qGAAA,WAAW,OAAA;AAGxC,uDAAqD;AAA7C,gHAAA,eAAe,OAAA;AAIvB,8CAAiD;AAAzC,2GAAA,eAAe,OAAA;AAYvB,8CAAiD;AAAzC,2GAAA,eAAe,OAAA;AAIvB,yCAA0C;AAAlC,gGAAA,GAAG,OAAA;AAAE,sGAAA,SAAS,OAAA;AACtB,2CAA4D;AAApD,wGAAA,aAAa,OAAA;AAAE,wGAAA,aAAa,OAAA"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;AAeA,mCAAyD;AAAjD,kGAAA,QAAQ,OAAA;AAAE,mGAAA,SAAS,OAAA;AAAE,qGAAA,WAAW,OAAA;AAGxC,uDAAqD;AAA7C,gHAAA,eAAe,OAAA;AAIvB,8CAAiD;AAAzC,2GAAA,eAAe,OAAA;AAYvB,8CAAiD;AAAzC,2GAAA,eAAe,OAAA;AAIvB,yCAA0C;AAAlC,gGAAA,GAAG,OAAA;AAAE,sGAAA,SAAS,OAAA;AACtB,2CAA4D;AAApD,wGAAA,aAAa,OAAA;AAAE,wGAAA,aAAa,OAAA"}

package/dist/server/ConnectionsServer.js

@@ -46,7 +46,7 @@ class ConnectionsServer {
                     return;
                 }
                 ws.alive = false;
-                ws.send(rpc_js_1.PONG_MSG);
+                ws.send(rpc_js_1.PING_MSG);
             });
         }, options.pingInterval);
         this.wss.on("close", () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@push-rpc/next",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {

package/src/index.ts

@@ -5,7 +5,14 @@ import type {ServicesImplementation} from "./server/implementation.js"
 
 export {Services}
 
-export type {RemoteFunction, Consumer, RpcContext, RpcConnectionContext} from "./rpc.js"
+export type {
+  RemoteFunction,
+  Consumer,
+  RpcContext,
+  RpcConnectionContext,
+  PING_MSG,
+  PONG_MSG,
+} from "./rpc.js"
 export {RpcError, RpcErrors, CallOptions} from "./rpc.js"
 
 export type {Middleware} from "./utils/middleware.js"

package/src/server/ConnectionsServer.ts

@@ -2,7 +2,7 @@ import {safeStringify} from "../utils/json.js"
 import WebSocket, {WebSocketServer} from "ws"
 import http from "http"
 import {log} from "../logger.js"
-import {PONG_MSG} from "../rpc.js"
+import {PING_MSG} from "../rpc.js"
 
 export class ConnectionsServer {
   constructor(
@@ -56,7 +56,7 @@ export class ConnectionsServer {
         }
 
         ws.alive = false
-        ws.send(PONG_MSG)
+        ws.send(PING_MSG)
       })
     }, options.pingInterval)
 

package/tests/connection.ts

@@ -39,6 +39,34 @@ describe("connection", () => {
     WebSocket.prototype.send = oldSend
   }).timeout(5000)
 
+  it("server keeps healthy client connected across ping cycles", async () => {
+    const pingInterval = 100
+
+    const services = await startTestServer(
+      {
+        test: {
+          async call() {},
+        },
+      },
+      {
+        pingInterval,
+      },
+    )
+
+    const remote = await createTestClient<typeof services>({
+      reconnectDelay: pingInterval * 4, // so a stray reconnect can't mask a dropped connection
+    })
+
+    await remote.test.call.subscribe(() => {})
+    assert.equal(testServer?._allSubscriptions().length, 1)
+
+    // the client is healthy and replies to each server PING with a PONG,
+    // so the server must keep it connected across multiple ping cycles
+    await adelay(pingInterval * 3.5)
+
+    assert.equal(testServer?._allSubscriptions().length, 1)
+  }).timeout(5000)
+
   it("client close connection on ping timeout", async () => {
     const pingInterval = 100 // less than server pings, so client will close connection first