@purpurds/promotion-card 5.27.3 → 5.27.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@purpurds/promotion-card",
-  "version": "5.27.3",
+  "version": "5.27.4",
   "license": "AGPL-3.0-only",
   "main": "./dist/promotion-card.cjs.js",
   "types": "./dist/promotion-card.d.ts",
@@ -16,13 +16,13 @@
   "source": "src/promotion-card.tsx",
   "dependencies": {
     "classnames": "~2.5.0",
-    "@purpurds/badge": "5.27.3",
-    "@purpurds/button": "5.27.3",
-    "@purpurds/cta-link": "5.27.3",
-    "@purpurds/card": "5.27.3",
-    "@purpurds/icon": "5.27.3",
-    "@purpurds/heading": "5.27.3",
-    "@purpurds/tokens": "5.27.3"
+    "@purpurds/badge": "5.27.4",
+    "@purpurds/button": "5.27.4",
+    "@purpurds/cta-link": "5.27.4",
+    "@purpurds/heading": "5.27.4",
+    "@purpurds/card": "5.27.4",
+    "@purpurds/icon": "5.27.4",
+    "@purpurds/tokens": "5.27.4"
   },
   "devDependencies": {
     "@rushstack/eslint-patch": "~1.10.0",
@@ -47,9 +47,9 @@
     "vite": "5.4.8",
     "vitest": "^2.1.2",
     "@purpurds/component-rig": "1.0.0",
-    "@purpurds/text-spacing": "5.27.3",
-    "@purpurds/paragraph": "5.27.3",
-    "@purpurds/grid": "5.27.3"
+    "@purpurds/paragraph": "5.27.4",
+    "@purpurds/text-spacing": "5.27.4",
+    "@purpurds/grid": "5.27.4"
   },
   "scripts": {
     "build:dev": "vite",

package/src/promotion-card.stories.tsx

@@ -121,6 +121,7 @@ export const WithDecorativeImage: Story = {
       </PromotionCard>
     );
   },
+  tags: ["visual:check"],
 };
 
 export const WithProductImage: Story = {
@@ -149,6 +150,7 @@ export const WithProductImage: Story = {
       </PromotionCard>
     );
   },
+  tags: ["visual:check"],
 };
 
 export const CardGroup: Story = {
@@ -190,10 +192,12 @@ export const CardGroup: Story = {
       </Grid>
     );
   },
+  tags: ["visual:check"],
 };
 
 export const Showcase: Story = {
   args: { children: <Children /> },
+  tags: ["visual:check"],
 };
 
 export const ActionButtons: Story = {
@@ -213,4 +217,5 @@ export const ActionButtons: Story = {
       },
     ],
   },
+  tags: ["visual:check"],
 };

package/src/promotion-card.tsx

@@ -41,7 +41,10 @@ const colors: StyleRecord = {
 type DecorativeImage = { decorativeImage?: ReactNode; hasGradient?: boolean };
 type ProductImage = { productImage?: ReactNode; hasGradient?: never };
 
-type Action = { label: string } & Omit<ButtonProps | CtaAnchorProps, "children">;
+type Action = { label: string } & (
+  | Omit<ButtonProps, "children" | "variant">
+  | Omit<CtaAnchorProps, "children" | "variant">
+);
 
 export type PromotionCardProps = {
   ["data-testid"]?: string;
@@ -53,7 +56,7 @@ export type PromotionCardProps = {
   badgeText?: string;
   badgeIcon?: ReactNode;
   className?: string;
-  actions?: Array<Action>;
+  actions?: Action[];
   children: ReactNode;
 } & (DecorativeImage | ProductImage);
 
@@ -154,21 +157,21 @@ const PromotionCardComponent = (
               <div className={cx(`${rootClassName}__child-content`)}>{children}</div>
               {actions && actions.length > 0 && (
                 <div className={cx(`${rootClassName}__actions`)}>
-                  {actions.map(({ label, variant: variantOverride, ...rest }, index) => {
-                    const actionVariant = variantOverride ?? index === 0 ? "primary" : "secondary";
+                  {actions.map(({ label, ...rest }, index) => {
+                    const actionVariant = index === 0 ? "primary" : "secondary";
                     const props = {
                       variant: actionVariant,
                       negative: variant === "primary",
                       ...rest,
                       children: label,
-                    };
+                    } as const;
                     if (isValidAnchor(props)) {
                       return <CtaLink key={label} {...props} />;
-                    } else if (isValidButton(props)) {
+                    }
+                    if ("onClick" in props && !("href" in props)) {
                       return <Button key={label} {...props} />;
-                    } else {
-                      return null;
                     }
+                    return null;
                   })}
                 </div>
               )}
@@ -203,9 +206,6 @@ const PromotionCardComponent = (
 const isValidAnchor = (action: object): action is CtaAnchorProps => {
   return "href" in action;
 };
-const isValidButton = (action: object): action is ButtonProps => {
-  return "onClick" in action;
-};
 
 export const PromotionCard = forwardRef(PromotionCardComponent);
 PromotionCard.displayName = "PromotionCard";