@purchasely/cordova-plugin-purchasely 6.0.0 → 6.0.1

package/Package.swift

@@ -0,0 +1,77 @@
+// swift-tools-version:5.9
+//
+// Swift Package Manager manifest for the iOS plugin.
+//
+// `plugin.xml` marks the ios platform with package="swift", which makes two hosts read
+// this file instead of building the plugin through CocoaPods:
+//
+//   * Cordova iOS 8 and later (Apache's own mechanism)
+//   * Capacitor in SPM mode, which is the Capacitor 8 default
+//
+// Capacitor is the reason this exists. Its SPM path never reads <podspec>, so before this
+// manifest a Capacitor 8 app scaffolded with the default package manager linked the plugin
+// with no Purchasely SDK behind it at all, silently.
+//
+// The <podspec> block stays in plugin.xml for CocoaPods consumers: Cordova iOS 7 and
+// earlier, and Capacitor in CocoaPods mode. Its pod carries nospm="true" so Cordova iOS 8
+// does not install the pod AND this package and link Purchasely twice.
+//
+// KEEP THE FIRST DEPENDENCY EXACTLY AS WRITTEN, AND ADD NO PROSE ABOVE IT.
+// The Capacitor CLI rewrites this file in place on every sync
+// (@capacitor/cli, dist/ios/update.js:83-89). It rewrites the first occurrence of the
+// Apache org slug, every occurrence of the upstream repository slug, and then pins the
+// version by replacing everything between the rewritten URL and the next ")". Both slugs
+// are lowercase and hyphenated, and both first appear in the Cordova dependency below.
+// Writing either one in a comment above that line silently retargets the URL to a
+// repository that does not exist, and the plugin then builds with no SDK. The rewrite is
+// idempotent, and this comment is deliberately written without those two literals.
+//
+// Note for local development: npm installs a `file:` dependency as a symlink, so a
+// `npx cap sync` in a sample app that consumes this plugin by path rewrites THIS file in
+// the repository, not a copy. Check `git status` after syncing a local sample.
+//
+// The package and product names must equal the npm package id: the Capacitor CLI hardcodes
+// `plugin.id` on both sides of the generated dependency (dist/util/spm.js:110-112, :164).
+
+import PackageDescription
+
+let package = Package(
+    name: "@purchasely/cordova-plugin-purchasely",
+    // 13.0, not higher: Cordova iOS 8 builds its aggregate CordovaPlugins target at 13.0,
+    // and a package declaring more fails the build outright ("requires minimum platform
+    // version 15.0 ... but this target supports 13.0"). The Purchasely xcframework itself
+    // is built for iOS 13.4, so that floor still applies at link time, exactly as it does
+    // through the podspec.
+    platforms: [.iOS(.v13)],
+    products: [
+        .library(
+            name: "@purchasely/cordova-plugin-purchasely",
+            targets: ["PurchaselyCordovaPlugin"]
+        )
+    ],
+    dependencies: [
+        .package(url: "https://github.com/apache/cordova-ios.git", from: "8.0.0"),
+        // exact, not `from:`. A range permits any 6.x, so a fresh resolve picks up
+        // whatever is newest while the podspec pins one version and VERSIONS.md
+        // documents another. That makes the linked SDK depend on install time and lets
+        // the two integration paths drift apart. Bump this with the podspec, in the
+        // same commit, and VERSIONS.md with it.
+        .package(url: "https://github.com/Purchasely/Purchasely-iOS.git", exact: "6.0.1")
+    ],
+    targets: [
+        .target(
+            name: "PurchaselyCordovaPlugin",
+            dependencies: [
+                .product(name: "Cordova", package: "cordova-ios"),
+                .product(name: "Purchasely", package: "Purchasely-iOS")
+            ],
+            path: "src/ios",
+            publicHeadersPath: ".",
+            cSettings: [
+                // The Hybrid/ type-marshalling headers are imported unqualified from the
+                // sources next to them, so their directory has to be on the search path.
+                .headerSearchPath("Hybrid")
+            ]
+        )
+    ]
+)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@purchasely/cordova-plugin-purchasely",
-  "version": "6.0.0",
+  "version": "6.0.1",
   "description": "Purchasely is a solution to ease the integration and boost your In-App Purchases & Subscriptions on the App Store, Google Play Store, Amazon Appstore and Huawei App Gallery.",
   "cordova": {
     "id": "@purchasely/cordova-plugin-purchasely",
@@ -41,6 +41,12 @@
   "author": "Purchasely",
   "license": "ISC",
   "main": "index.js",
+  "files": [
+    "src",
+    "www",
+    "plugin.xml",
+    "Package.swift"
+  ],
   "directories": {
     "example": "example"
   },
@@ -57,5 +63,8 @@
   "bugs": {
     "url": "https://github.com/Purchasely/Purchasely-Cordova/issues"
   },
-  "homepage": "https://github.com/Purchasely/Purchasely-Cordova#readme"
+  "homepage": "https://github.com/Purchasely/Purchasely-Cordova#readme",
+  "overrides": {
+    "js-yaml@3": "^3.15.1"
+  }
 }

package/plugin.xml

@@ -1,5 +1,5 @@
 <?xml version='1.0' encoding='utf-8'?>
-<plugin id="@purchasely/cordova-plugin-purchasely" version="6.0.0" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
+<plugin id="@purchasely/cordova-plugin-purchasely" version="6.0.1" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
     <name>Purchasely</name>
     <js-module name="Purchasely" src="www/Purchasely.js">
         <clobbers target="Purchasely" />
@@ -8,7 +8,7 @@
         <engine name="cordova" version=">=11.0.0"/>
         <engine name="cordova-android" version=">=12.0.0"/>
    </engines>
-    <platform name="ios">
+    <platform name="ios" package="swift">
         <config-file parent="/*" target="config.xml">
             <feature name="Purchasely">
               <param name="ios-package" value="CDVPurchasely" />
@@ -38,7 +38,7 @@
                 <source url="https://github.com/CocoaPods/Specs.git"/>
             </config>
             <pods use-frameworks="true">
-                <pod name="Purchasely" spec="6.0.0"/>
+                <pod name="Purchasely" spec="6.0.1" nospm="true"/>
             </pods>
         </podspec>
     </platform>
@@ -53,7 +53,7 @@
             <preference name="GradlePluginKotlinCodeStyle" value="official" />
         </config-file>
         <framework src="src/android/build-extras.gradle" custom="true" type="gradleReference" />
-        <framework src="io.purchasely:core:6.0.1" />
+        <framework src="io.purchasely:core:6.0.2" />
         <source-file src="src/android/PurchaselyPlugin.kt" target-dir="java/cordova/plugin/purchasely" />
     </platform>
 </plugin>

package/src/ios/CDVPurchasely.m

@@ -13,14 +13,20 @@
 
 @implementation CDVPurchasely
 
-- (instancetype)init {
-    self = [super init];
+// pluginInitialize is Cordova's setup hook and is called by every host, after
+// viewController/webView/commandDelegate are assigned. The previous -init override was only
+// reached on cordova-ios, whose -initWithWebViewEngine: calls [self init]; Capacitor's
+// vendored CapacitorCordova calls [super init] instead, which dispatches to NSObject and
+// never reaches a subclass override - so under Capacitor these collections stayed nil, and
+// writing into a nil NSMutableDictionary/NSMutableArray is a silent no-op. That lost every
+// interceptor callbackId (intercepted actions completed .notHandled without reaching JS) and
+// every preloaded presentation ("Presentation not loaded" from preload/display).
+- (void)pluginInitialize {
+    [super pluginInitialize];
 
     self.presentationsLoaded = [NSMutableArray new];
     self.actionInterceptorCallbackIds = [NSMutableDictionary new];
     self.pendingInterceptCompletions = [NSMutableDictionary new];
-
-    return self;
 }
 
 - (void)start:(CDVInvokedUrlCommand*)command {
@@ -1266,6 +1272,18 @@ static BOOL PLYPresentationActionFromString(NSString *kind, PLYPresentationActio
             } else if (presentation != nil) {
                 [self.presentationsLoaded addObject:presentation];
                 [self successFor:command resultDict:[self resultDictionaryForFetchPresentation:presentation]];
+            } else {
+                // Neither branch taken means the Cordova command is never completed and the
+                // JS promise returned by preload() stays pending for the life of the page:
+                // no resolve, no reject, no error, nothing logged. Answer instead, so the
+                // caller can handle it.
+                //
+                // Purchasely 6.0.0 does not produce this pair (PresentationRequest.swift
+                // maps a success-with-nil presentation to PLYError.presentationNotLoaded),
+                // so this is defence in depth against a future SDK, not a fix for a
+                // reproduced failure. It costs one branch and removes a whole class of
+                // silent hang.
+                [self failureFor:command resultString: @"Presentation preload completed without a presentation and without an error"];
             }
         }];
     });

package/www/Purchasely.js

@@ -63,7 +63,7 @@ exports.start = function (options, success, error) {
     var opts = options || {};
     var cordovaSdkVersion = cordova.define.moduleMap['cordova/plugin_list'].exports['metadata']['cordova-plugin-purchasely']
     if(!cordovaSdkVersion) {
-        cordovaSdkVersion = "6.0.0";
+        cordovaSdkVersion = "6.0.1";
     }
     opts.sdkVersion = cordovaSdkVersion;
     exec(success, error, 'Purchasely', 'start', [opts]);