@pumpn/eslint-config 12.1.4 → 13.0.0

package/plugins.js

@@ -1,12 +1,12 @@
-/* eslint-disable import/max-dependencies -- collection file */
+/* eslint-disable import-x/max-dependencies -- collection file */
 import eslintComments from "@eslint-community/eslint-plugin-eslint-comments";
 import stylistic from "@stylistic/eslint-plugin";
-import github from "eslint-plugin-github";
-import eslintPluginImport from "eslint-plugin-import";
+// import github from "eslint-plugin-github";
+import importX from "eslint-plugin-import-x";
 import jsdoc from "eslint-plugin-jsdoc";
-import jsxA11y from "eslint-plugin-jsx-a11y";
+// import jsxA11y from "eslint-plugin-jsx-a11y";
 import noSecrets from "eslint-plugin-no-secrets";
-import noUnsanitized from "eslint-plugin-no-unsanitized";
+// import noUnsanitized from "eslint-plugin-no-unsanitized";
 import perfectionist from "eslint-plugin-perfectionist";
 import promise from "eslint-plugin-promise";
 import react from "eslint-plugin-react";
@@ -20,12 +20,12 @@ import unicorn from "eslint-plugin-unicorn";
 const plugins = {
 	"@eslint-community/eslint-comments": eslintComments,
 	"@stylistic": stylistic,
-	github,
-	import: eslintPluginImport,
+	// github,
+	"import-x": importX,
 	jsdoc,
-	"jsx-a11y": jsxA11y,
+	// "jsx-a11y": jsxA11y,
 	"no-secrets": noSecrets,
-	"no-unsanitized": noUnsanitized,
+	// "no-unsanitized": noUnsanitized,
 	perfectionist,
 	promise,
 	react,

package/rules/_exports.js

@@ -1,17 +1,17 @@
 export { default as eslintCommentsRules } from "./eslint-comments.js";
-export { default as githubRules } from "./github.js";
-export { default as importRules } from "./import.js";
+// export { default as githubRules } from "./github.js";
+export { default as importXRules } from "./import-x.js";
 export { default as jsdocRules } from "./jsdoc.js";
-export { default as jsxA11yRules } from "./jsx-a11y.js";
+// export { default as jsxA11yRules } from "./jsx-a11y.js";
 export {
 	default as layoutAndFormattingRules
 } from "./layout-and-formatting.js";
 export { default as noSecretsRules } from "./no-secrets.js";
-export { default as noUnsanitizedRules } from "./no-unsanitized.js";
+// export { default as noUnsanitizedRules } from "./no-unsanitized.js";
 export { default as perfectionistRules } from "./perfectionist.js";
 export { default as possibleProblemsRules } from "./possible-problems.js";
 export { default as reactRules } from "./react.js";
-export { default as redosRules } from "./redos.js";
+// export { default as redosRules } from "./redos.js";
 export { default as regexpRules } from "./regexp.js";
 export { default as securityRules } from "./security.js";
 export { default as sonarjsRules } from "./sonarjs.js";

package/rules/github.js

@@ -12,7 +12,7 @@ const githubRules = {
 	"github/js-class-name": "error",
 	"github/no-blur": "error",
 	"github/no-d-none": "error",
-	"github/no-dataset": "error",
+	"github/no-dataset": "off",
 	"github/no-dynamic-script-tag": "error",
 	"github/no-implicit-buggy-globals": "off",
 	"github/no-inner-html": "error",

package/rules/import-x/helpful-warnings.js

@@ -0,0 +1,18 @@
+const helpfulWarningsRules = {
+	"import-x/export": "error",
+	"import-x/no-deprecated": "warn",
+	"import-x/no-empty-named-blocks": "error",
+	"import-x/no-extraneous-dependencies": "off",
+	"import-x/no-mutable-exports": "error",
+	"import-x/no-named-as-default": "error",
+	"import-x/no-named-as-default-member": "error",
+	"import-x/no-unused-modules": [
+		"error",
+		{
+			missingExports: true,
+			unusedExports: false
+		}
+	]
+};
+
+export default helpfulWarningsRules;

package/rules/import-x/module-systems.js

@@ -0,0 +1,9 @@
+const moduleSystemsRules = {
+	"import-x/no-amd": "error",
+	"import-x/no-commonjs": "error",
+	"import-x/no-import-module-exports": "error",
+	"import-x/no-nodejs-modules": "off",
+	"import-x/unambiguous": "error"
+};
+
+export default moduleSystemsRules;

package/rules/{import → import-x}/static-analysis.js

@@ -1,24 +1,24 @@
 const staticAnalysisRules = {
-	"import/default": "error",
-	"import/named": "error",
-	"import/namespace": "error",
-	"import/no-absolute-path": "error",
-	"import/no-cycle": [
+	"import-x/default": "error",
+	"import-x/named": "error",
+	"import-x/namespace": "error",
+	"import-x/no-absolute-path": "error",
+	"import-x/no-cycle": [
 		"error",
 		{
 			maxDepth: Infinity
 		}
 	],
-	"import/no-dynamic-require": "error",
-	"import/no-internal-modules": [
+	"import-x/no-dynamic-require": "error",
+	"import-x/no-internal-modules": [
 		"off",
 		{
 			allow: []
 		}
 	],
-	"import/no-relative-packages": "error",
-	"import/no-relative-parent-imports": "off",
-	"import/no-restricted-paths": [
+	"import-x/no-relative-packages": "error",
+	"import-x/no-relative-parent-imports": "off",
+	"import-x/no-restricted-paths": [
 		"error",
 		{
 			zones: [
@@ -56,17 +56,17 @@ const staticAnalysisRules = {
 			]
 		}
 	],
-	"import/no-self-import": "error",
-	// TODO [2024-04-01]: Change to "error" when there is a resolver for deno
-	"import/no-unresolved": "off",
-	"import/no-useless-path-segments": [
+	"import-x/no-self-import": "error",
+	// TODO [2024-07-01]: Change to "error" when there is a resolver for deno
+	"import-x/no-unresolved": "off",
+	"import-x/no-useless-path-segments": [
 		"error",
 		{
 			commonjs: false,
 			noUselessIndex: false
 		}
 	],
-	"import/no-webpack-loader-syntax": "error"
+	"import-x/no-webpack-loader-syntax": "error"
 };
 
 export default staticAnalysisRules;

package/rules/{import → import-x}/style-guide.js

@@ -1,20 +1,20 @@
 const maxDependencies = 10;
 
 const styleGuideRules = {
-	"import/consistent-type-specifier-style": "error",
-	"import/dynamic-import-chunkname": "off",
-	"import/exports-last": "error",
-	"import/extensions": ["error", "ignorePackages"],
-	"import/first": "error",
-	"import/group-exports": "error",
-	"import/max-dependencies": [
+	"import-x/consistent-type-specifier-style": "error",
+	"import-x/dynamic-import-chunkname": "off",
+	"import-x/exports-last": "error",
+	"import-x/extensions": ["error", "ignorePackages"],
+	"import-x/first": "error",
+	"import-x/group-exports": "error",
+	"import-x/max-dependencies": [
 		"error",
 		{
 			max: maxDependencies
 		}
 	],
-	"import/newline-after-import": "error",
-	"import/no-anonymous-default-export": [
+	"import-x/newline-after-import": "error",
+	"import-x/no-anonymous-default-export": [
 		"error",
 		{
 			allowAnonymousClass: false,
@@ -27,18 +27,18 @@ const styleGuideRules = {
 			allowObject: false
 		}
 	],
-	"import/no-default-export": "off",
-	"import/no-duplicates": "error",
-	"import/no-named-default": "error",
-	"import/no-named-export": "off",
-	"import/no-namespace": [
+	"import-x/no-default-export": "off",
+	"import-x/no-duplicates": "error",
+	"import-x/no-named-default": "error",
+	"import-x/no-named-export": "off",
+	"import-x/no-namespace": [
 		"error",
 		{
 			ignore: ["{./**/,**/}_exports.?(*.)js"]
 		}
 	],
-	"import/no-unassigned-import": "error",
-	"import/order": [
+	"import-x/no-unassigned-import": "error",
+	"import-x/order": [
 		"off",
 		{
 			alphabetize: {
@@ -80,7 +80,7 @@ const styleGuideRules = {
 			warnOnUnassignedImports: false
 		}
 	],
-	"import/prefer-default-export": ["error", { target: "single" }]
+	"import-x/prefer-default-export": ["error", { target: "single" }]
 };
 
 export default styleGuideRules;

package/rules/import-x.js

@@ -0,0 +1,12 @@
+import * as importRuleSets from "./import-x/_exports.js";
+
+const importXRules = Object.values(importRuleSets)
+	.reduce(
+		(allRules, ruleSet) => ({
+			...allRules,
+			...ruleSet
+		}),
+		{}
+	);
+
+export default importXRules;

package/rules/jsdoc.js

@@ -49,7 +49,50 @@ const jsdocRules = {
 	"jsdoc/require-description": [
 		"warn",
 		{
-			contexts: ["any"],
+			contexts: [
+				"ArrayExpression",
+				"ArrowFunctionExpression",
+				"AssignmentExpression",
+				"AwaitExpression",
+				"BinaryExpression",
+				"CallExpression",
+				"ChainExpression",
+				"Class",
+				"ClassDeclaration",
+				"ClassExpression",
+				"ClassHasInstanceExpression",
+				"ConditionalExpression",
+				"DoExpression",
+				"ExportAllDeclaration",
+				"ExportDefaultDeclaration",
+				"ExportNamedDeclaration",
+				"Expression",
+				"ExpressionStatement",
+				"FunctionDeclaration",
+				"FunctionExpression",
+				"ImportDeclaration",
+				"ImportExpression",
+				"LogicalExpression",
+				"LogicalExpression",
+				"MemberExpression",
+				"MethodDefinition",
+				"ModuleDeclarations",
+				"ModuleExpression",
+				"NewExpression",
+				"ObjectExpression",
+				"PropertyDefinition",
+				"RecordExpression",
+				"SequenceExpression",
+				"SliceExpression",
+				"StaticBlock",
+				"TaggedTemplateExpression",
+				"ThisExpression",
+				"TupleExpression",
+				"UnaryExpression",
+				"VariableDeclaration",
+				"VariableDeclarator",
+				"YieldExpression"
+			],
 			descriptionStyle: "body"
 		}
 	],

package/rules/layout-and-formatting.js

@@ -1,5 +1,5 @@
 const layoutAndFormattingRules = {
-	"line-comment-position": ["error", { position: "above" }],
+	"line-comment-position": "off",
 	"unicode-bom": ["error", "never"]
 };
 

package/rules/perfectionist.js

@@ -70,12 +70,12 @@ const perfectionistRules = {
 				"builtin",
 				"std",
 				"external",
-				"internal",
 				"utilities",
 				"plugins",
 				"logic",
 				"components",
 				"islands",
+				"internal",
 				"type",
 				"internal-type",
 				"parent-type",
@@ -88,6 +88,7 @@ const perfectionistRules = {
 				"unknown"
 			],
 			"ignore-case": false,
+			"internal-pattern": ["@/**"],
 			"newlines-between": "always",
 			order: "asc",
 			type: "natural"
@@ -101,6 +102,14 @@ const perfectionistRules = {
 			type: "natural"
 		}
 	],
+	"perfectionist/sort-intersection-types": [
+		"error",
+		{
+			"ignore-case": false,
+			order: "asc",
+			type: "natural"
+		}
+	],
 	"perfectionist/sort-jsx-props": [
 		"error",
 		{

package/rules/react.js

@@ -6,7 +6,7 @@ const reactRules = {
 	"react/default-props-match-prop-types": "error",
 	"react/destructuring-assignment": "error",
 	"react/display-name": "error",
-	"react/forbid-component-props": "error",
+	"react/forbid-component-props": "off",
 	"react/forbid-dom-props": "error",
 	"react/forbid-elements": "error",
 	"react/forbid-foreign-prop-types": "error",

package/rules/regexp/best-practices.js

@@ -33,7 +33,7 @@ const bestPracticesRules = {
 	"regexp/prefer-regexp-test": "off",
 	"regexp/prefer-set-operation": "error",
 	"regexp/require-unicode-regexp": "error",
-	// TODO [2024-04-01]: enable when https://github.com/microsoft/vscode/pull/206580 is merged
+	// TODO [2024-07-01]: enable when https://github.com/microsoft/vscode/pull/206580 is resolved
 	"regexp/require-unicode-sets-regexp": "off",
 	"regexp/simplify-set-operations": "error",
 	"regexp/sort-alternatives": "error",

package/rules/regexp/stylistic-issues.js

@@ -45,18 +45,30 @@ const stylisticIssuesRules = {
 		"error",
 		{
 			order: [
-				"\\s",
-				"\\w",
-				"\\d",
-				"\\p",
+				String.raw`\s`,
+				String.raw`\w`,
+				String.raw`\d`,
+				String.raw`\p`,
 				"*",
-				"\\q",
+				String.raw`\q`,
 				"[]"
 			]
 		}
 	],
 	"regexp/sort-flags": "error",
-	"regexp/unicode-escape": ["error", "unicodeCodePointEscape"]
+	"regexp/unicode-escape": ["error", "unicodeCodePointEscape"],
+	"regexp/unicode-property": [
+		"error",
+		{
+			generalCategory: "never",
+			key: "ignore",
+			property: {
+				binary: "ignore",
+				generalCategory: "ignore",
+				script: "long"
+			}
+		}
+	]
 };
 
 export default stylisticIssuesRules;

package/rules/stylistic/brackets.js

@@ -47,9 +47,9 @@ const bracketsRules = {
 			condition: wrapMultilinesDefault,
 			declaration: wrapMultilinesDefault,
 			logical: wrapMultilinesDefault,
+			prop: wrapMultilinesDefault,
+			propertyValue: wrapMultilinesDefault,
 			return: wrapMultilinesDefault
-			// TODO [@stylistic/eslint-plugin@>1.6.3]: uncomment when @stylistic/eslint-plugin releases
-			// prop: "never"
 		}
 	],
 	"@stylistic/new-parens": ["error", "always"],

package/rules/stylistic/comments.js

@@ -1,4 +1,5 @@
 const commentsRules = {
+	"@stylistic/line-comment-position": ["error", { position: "above" }],
 	"@stylistic/lines-around-comment": [
 		"error",
 		{
@@ -17,6 +18,7 @@ const commentsRules = {
 			ignorePattern: "/* @type"
 		}
 	],
+	"@stylistic/multiline-comment-style": "off",
 	"@stylistic/spaced-comment": "off"
 };
 

package/rules/stylistic/jsx.js

@@ -9,8 +9,7 @@ const jsxRules = {
 			when: "multiline"
 		}
 	],
-	// TODO [@stylistic/eslint-plugin@>1.6.3]: change to "non-jsx" when @stylistic/eslint-plugin releases
-	"@stylistic/jsx-one-expression-per-line": ["off"],
+	"@stylistic/jsx-one-expression-per-line": ["error", { allow: "single-line" }],
 	"@stylistic/jsx-pascal-case": ["error", { allowNamespace: true }],
 	"@stylistic/jsx-props-no-multi-spaces": "error",
 	"@stylistic/jsx-self-closing-comp": "error",

package/rules/stylistic/linebreaks.js

@@ -14,6 +14,7 @@ const lineBreaksRules = {
 	"@stylistic/function-call-argument-newline": ["error", "consistent"],
 	"@stylistic/implicit-arrow-linebreak": ["error", "beside"],
 	"@stylistic/jsx-first-prop-new-line": ["error", "multiline"],
+	"@stylistic/jsx-function-call-newline": ["error", "multiline"],
 	"@stylistic/jsx-newline": "error",
 	"@stylistic/linebreak-style": ["error", "unix"],
 	"@stylistic/lines-between-class-members": ["error", "always"],

package/rules/tailwindcss.js

@@ -5,7 +5,8 @@ const tailwindcssRules = {
 	"tailwindcss/migration-from-tailwind-2": "error",
 	"tailwindcss/no-arbitrary-value": "off",
 	"tailwindcss/no-contradicting-classname": "error",
-	"tailwindcss/no-custom-classname": "off"
+	"tailwindcss/no-custom-classname": "off",
+	"tailwindcss/no-unnecessary-arbitrary-value": "error"
 };
 
 export default tailwindcssRules;

package/rules/unicorn.js

@@ -34,6 +34,7 @@ const unicornRules = {
 	"unicorn/better-regex": "error",
 	"unicorn/catch-error-name": "error",
 	"unicorn/consistent-destructuring": "error",
+	"unicorn/consistent-empty-array-spread": "error",
 	"unicorn/consistent-function-scoping": "error",
 	"unicorn/custom-error-definition": "error",
 	"unicorn/empty-brace-spaces": "error",
@@ -50,23 +51,25 @@ const unicornRules = {
 	"unicorn/import-style": "error",
 	"unicorn/new-for-builtins": "error",
 	"unicorn/no-abusive-eslint-disable": "error",
-	// TODO [eslint-plugin-unicorn@>51.0.1]: uncomment below when eslint-plugin-unicorn releases
-	// "unicorn/no-anonymous-default-export": "error",
-	"unicorn/no-array-callback-reference": "error",
+	"unicorn/no-anonymous-default-export": "error",
+	"unicorn/no-array-callback-reference": "off",
 	"unicorn/no-array-for-each": "error",
 	"unicorn/no-array-method-this-argument": "error",
 	"unicorn/no-array-push-push": "error",
 	"unicorn/no-array-reduce": "off",
 	"unicorn/no-await-expression-member": "error",
+	"unicorn/no-await-in-promise-methods": "error",
 	"unicorn/no-console-spaces": "error",
 	"unicorn/no-document-cookie": "error",
 	"unicorn/no-empty-file": "error",
 	"unicorn/no-for-loop": "error",
 	"unicorn/no-hex-escape": "error",
 	"unicorn/no-instanceof-array": "error",
+	"unicorn/no-invalid-fetch-options": "error",
 	"unicorn/no-invalid-remove-event-listener": "error",
 	"unicorn/no-keyword-prefix": ["error", { disallowedPrefixes: ["new"] }],
 	"unicorn/no-lonely-if": "error",
+	"unicorn/no-magic-array-flat-depth": "error",
 	"unicorn/no-negated-condition": "error",
 	"unicorn/no-nested-ternary": "error",
 	"unicorn/no-new-array": "error",
@@ -74,6 +77,7 @@ const unicornRules = {
 	"unicorn/no-null": "off",
 	"unicorn/no-object-as-default-parameter": "error",
 	"unicorn/no-process-exit": "error",
+	"unicorn/no-single-promise-in-promise-methods": "error",
 	"unicorn/no-static-only-class": "error",
 	"unicorn/no-thenable": "error",
 	"unicorn/no-this-assignment": "error",
@@ -156,10 +160,12 @@ const unicornRules = {
 	"unicorn/prefer-set-has": "error",
 	"unicorn/prefer-set-size": "error",
 	"unicorn/prefer-spread": "error",
+	"unicorn/prefer-string-raw": "error",
 	"unicorn/prefer-string-replace-all": "error",
 	"unicorn/prefer-string-slice": "error",
 	"unicorn/prefer-string-starts-ends-with": "error",
 	"unicorn/prefer-string-trim-start-end": "error",
+	"unicorn/prefer-structured-clone": "error",
 	"unicorn/prefer-switch": "error",
 	"unicorn/prefer-ternary": ["error", "only-single-line"],
 	"unicorn/prefer-top-level-await": "error",

package/rules/import/helpful-warnings.js

@@ -1,18 +0,0 @@
-const helpfulWarningsRules = {
-	"import/export": "error",
-	"import/no-deprecated": "warn",
-	"import/no-empty-named-blocks": "error",
-	"import/no-extraneous-dependencies": "off",
-	"import/no-mutable-exports": "error",
-	"import/no-named-as-default": "error",
-	"import/no-named-as-default-member": "error",
-	"import/no-unused-modules": [
-		"error",
-		{
-			missingExports: true,
-			unusedExports: false
-		}
-	]
-};
-
-export default helpfulWarningsRules;

package/rules/import/module-systems.js

@@ -1,9 +0,0 @@
-const moduleSystemsRules = {
-	"import/no-amd": "error",
-	"import/no-commonjs": "error",
-	"import/no-import-module-exports": "error",
-	"import/no-nodejs-modules": "off",
-	"import/unambiguous": "error"
-};
-
-export default moduleSystemsRules;

package/rules/import.js

@@ -1,12 +0,0 @@
-import * as importRuleSets from "./import/_exports.js";
-
-const importRules = Object.values(importRuleSets)
-	.reduce(
-		(allRules, ruleSet) => ({
-			...allRules,
-			...ruleSet
-		}),
-		{}
-	);
-
-export default importRules;