@pumpn/eslint-config 11.2.0 → 12.0.0

package/rules/react.js

@@ -1,4 +1,107 @@
-export default {
+const maxDepth = 10;
+
+const reactRules = {
+	"react/boolean-prop-naming": "error",
+	"react/button-has-type": "error",
+	"react/default-props-match-prop-types": "error",
+	"react/destructuring-assignment": "error",
+	"react/display-name": "error",
+	"react/forbid-component-props": "error",
+	"react/forbid-dom-props": "error",
+	"react/forbid-elements": "error",
+	"react/forbid-foreign-prop-types": "error",
+	"react/forbid-prop-types": "error",
+	"react/function-component-definition": [
+		"error",
+		{
+			namedComponents: "arrow-function",
+			unnamedComponents: "arrow-function"
+		}
+	],
+	"react/hook-use-state": ["error", { allowDestructuredState: true }],
+	"react/iframe-missing-sandbox": "error",
+	"react/jsx-boolean-value": "error",
+	"react/jsx-filename-extension": [
+		"error",
+		{
+			allow: "as-needed",
+			extensions: [".jsx"],
+			ignoreFilesWithoutCode: true
+		}
+	],
+	"react/jsx-fragments": ["error", "syntax"],
+	"react/jsx-handler-names": "error",
+	"react/jsx-key": "error",
+	"react/jsx-max-depth": ["error", { max: maxDepth }],
+	"react/jsx-no-bind": "error",
+	"react/jsx-no-comment-textnodes": "error",
+	"react/jsx-no-constructed-context-values": "error",
+	"react/jsx-no-duplicate-props": "error",
+	"react/jsx-no-leaked-render": "error",
+	"react/jsx-no-literals": "off",
+	"react/jsx-no-script-url": "error",
+	"react/jsx-no-target-blank": [
+		"error",
+		{
+			allowReferrer: false,
+			enforceDynamicLinks: "always",
+			forms: false,
+			links: true,
+			warnOnSpreadAttributes: true
+		}
+	],
+	"react/jsx-no-undef": "error",
+	"react/jsx-no-useless-fragment": "error",
+	"react/jsx-props-no-spreading": "off",
+	"react/jsx-uses-react": "error",
 	"react/jsx-uses-vars": "error",
-	"react/jsx-uses-react": "error"
+	"react/no-access-state-in-setstate": "error",
+	"react/no-adjacent-inline-elements": "error",
+	"react/no-array-index-key": "off",
+	"react/no-arrow-function-lifecycle": "off",
+	"react/no-children-prop": "error",
+	"react/no-danger": "error",
+	"react/no-danger-with-children": "error",
+	"react/no-deprecated": "error",
+	"react/no-did-mount-set-state": "error",
+	"react/no-did-update-set-state": "error",
+	"react/no-direct-mutation-state": "error",
+	"react/no-find-dom-node": "error",
+	"react/no-invalid-html-attribute": "error",
+	"react/no-is-mounted": "error",
+	"react/no-multi-comp": ["error", { ignoreStateless: false }],
+	"react/no-namespace": "error",
+	"react/no-object-type-as-default-prop": "error",
+	"react/no-redundant-should-component-update": "error",
+	"react/no-render-return-value": "error",
+	"react/no-set-state": "off",
+	"react/no-string-refs": "error",
+	"react/no-this-in-sfc": "error",
+	"react/no-typos": "error",
+	"react/no-unescaped-entities": "error",
+	"react/no-unknown-property": "error",
+	"react/no-unsafe": "error",
+	"react/no-unstable-nested-components": "error",
+	"react/no-unused-class-component-methods": "error",
+	"react/no-unused-prop-types": "error",
+	"react/no-unused-state": "error",
+	"react/no-will-update-set-state": "error",
+	"react/prefer-es6-class": ["error", "always"],
+	"react/prefer-exact-props": "error",
+	"react/prefer-read-only-props": "error",
+	"react/prefer-stateless-function": "error",
+	"react/prop-types": "off",
+	"react/react-in-jsx-scope": "off",
+	"react/require-default-props": "error",
+	"react/require-optimization": "error",
+	"react/require-render-return": "error",
+	"react/sort-comp": "off",
+	"react/sort-default-props": "off",
+	"react/sort-prop-types": "off",
+	"react/state-in-constructor": ["error", "never"],
+	"react/static-property-placement": "error",
+	"react/style-prop-object": "error",
+	"react/void-dom-elements-no-children": "error"
 };
+
+export default reactRules;

package/rules/redos.js

@@ -0,0 +1,15 @@
+const timeout = 10_000;
+
+const redosRules = {
+	"redos/no-vulnerable": [
+		"error",
+		{
+			checker: "auto",
+			ignoreErrors: true,
+			permittableComplexities: [],
+			timeout
+		}
+	]
+};
+
+export default redosRules;

package/rules/regexp/_exports.js

@@ -0,0 +1,3 @@
+export { default as bestPracticesRules } from "./best-practices.js";
+export { default as possibleErrorsRules } from "./possible-errors.js";
+export { default as stylisticIssuesRules } from "./stylistic-issues.js";

package/rules/regexp/best-practices.js

@@ -0,0 +1,43 @@
+const bestPracticesRules = {
+	"regexp/confusing-quantifier": "error",
+	"regexp/control-character-escape": "error",
+	"regexp/negation": "error",
+	"regexp/no-dupe-characters-character-class": "error",
+	"regexp/no-empty-string-literal": "error",
+	"regexp/no-extra-lookaround-assertions": "error",
+	"regexp/no-invisible-character": "error",
+	"regexp/no-legacy-features": "error",
+	"regexp/no-non-standard-flag": "error",
+	"regexp/no-obscure-range": "error",
+	"regexp/no-octal": "error",
+	"regexp/no-standalone-backslash": "error",
+	"regexp/no-trivially-nested-assertion": "error",
+	"regexp/no-trivially-nested-quantifier": "error",
+	"regexp/no-unused-capturing-group": "error",
+	"regexp/no-useless-character-class": "error",
+	"regexp/no-useless-flag": "error",
+	"regexp/no-useless-lazy": "error",
+	"regexp/no-useless-quantifier": "error",
+	"regexp/no-useless-range": "error",
+	"regexp/no-useless-set-operand": "error",
+	"regexp/no-useless-string-literal": "error",
+	"regexp/no-useless-two-nums-quantifier": "error",
+	"regexp/no-zero-quantifier": "error",
+	"regexp/optimal-lookaround-quantifier": "error",
+	"regexp/optimal-quantifier-concatenation": "error",
+	"regexp/prefer-escape-replacement-dollar-char": "error",
+	"regexp/prefer-predefined-assertion": "error",
+	"regexp/prefer-quantifier": "error",
+	"regexp/prefer-range": "error",
+	"regexp/prefer-regexp-exec": "off",
+	"regexp/prefer-regexp-test": "off",
+	"regexp/prefer-set-operation": "error",
+	"regexp/require-unicode-regexp": "error",
+	// TODO [2024-04-01]: enable when https://github.com/microsoft/vscode/pull/206580 is merged
+	"regexp/require-unicode-sets-regexp": "off",
+	"regexp/simplify-set-operations": "error",
+	"regexp/sort-alternatives": "error",
+	"regexp/use-ignore-case": "error"
+};
+
+export default bestPracticesRules;

package/rules/regexp/possible-errors.js

@@ -0,0 +1,26 @@
+const possibleErrorsRules = {
+	"regexp/no-contradiction-with-assertion": "error",
+	"regexp/no-control-character": "error",
+	"regexp/no-dupe-disjunctions": "error",
+	"regexp/no-empty-alternative": "error",
+	"regexp/no-empty-capturing-group": "error",
+	"regexp/no-empty-character-class": "error",
+	"regexp/no-empty-group": "error",
+	"regexp/no-empty-lookarounds-assertion": "error",
+	"regexp/no-escape-backspace": "error",
+	"regexp/no-invalid-regexp": "error",
+	"regexp/no-lazy-ends": "error",
+	"regexp/no-misleading-capturing-group": "error",
+	"regexp/no-misleading-unicode-character": "error",
+	"regexp/no-missing-g-flag": "error",
+	"regexp/no-optional-assertion": "error",
+	"regexp/no-potentially-useless-backreference": "error",
+	"regexp/no-super-linear-backtracking": "error",
+	"regexp/no-super-linear-move": "error",
+	"regexp/no-useless-assertions": "error",
+	"regexp/no-useless-backreference": "error",
+	"regexp/no-useless-dollar-replacements": "error",
+	"regexp/strict": "error"
+};
+
+export default possibleErrorsRules;

package/rules/regexp/stylistic-issues.js

@@ -0,0 +1,62 @@
+const stylisticIssuesRules = {
+	"regexp/grapheme-string-literal": "off",
+	"regexp/hexadecimal-escape": ["error", "always"],
+	"regexp/letter-case": [
+		"error",
+		{
+			caseInsensitive: "lowercase",
+			controlEscape: "uppercase",
+			hexadecimalEscape: "lowercase",
+			unicodeEscape: "lowercase"
+		}
+	],
+	"regexp/match-any": "error",
+	"regexp/no-useless-escape": "error",
+	"regexp/no-useless-non-capturing-group": "error",
+	"regexp/prefer-character-class": "error",
+	"regexp/prefer-d": "error",
+	"regexp/prefer-lookaround": [
+		"error",
+		{
+			lookbehind: true,
+			strictTypes: true
+		}
+	],
+	"regexp/prefer-named-backreference": "error",
+	"regexp/prefer-named-capture-group": "error",
+	"regexp/prefer-named-replacement": [
+		"error",
+		{
+			strictTypes: true
+		}
+	],
+	"regexp/prefer-plus-quantifier": "error",
+	"regexp/prefer-question-quantifier": "error",
+	"regexp/prefer-result-array-groups": [
+		"error",
+		{
+			strictTypes: true
+		}
+	],
+	"regexp/prefer-star-quantifier": "error",
+	"regexp/prefer-unicode-codepoint-escapes": "error",
+	"regexp/prefer-w": "error",
+	"regexp/sort-character-class-elements": [
+		"error",
+		{
+			order: [
+				"\\s",
+				"\\w",
+				"\\d",
+				"\\p",
+				"*",
+				"\\q",
+				"[]"
+			]
+		}
+	],
+	"regexp/sort-flags": "error",
+	"regexp/unicode-escape": ["error", "unicodeCodePointEscape"]
+};
+
+export default stylisticIssuesRules;

package/rules/regexp.js

@@ -0,0 +1,12 @@
+import * as regexpRuleSets from "./regexp/_exports.js";
+
+const regexpRules = Object.values(regexpRuleSets)
+	.reduce(
+		(allRules, ruleSet) => ({
+			...allRules,
+			...ruleSet
+		}),
+		{}
+	);
+
+export default regexpRules;

package/rules/security.js

@@ -0,0 +1,18 @@
+const securityRules = {
+	"security/detect-bidi-characters": "warn",
+	"security/detect-buffer-noassert": "warn",
+	"security/detect-child-process": "warn",
+	"security/detect-disable-mustache-escape": "warn",
+	"security/detect-eval-with-expression": "warn",
+	"security/detect-new-buffer": "warn",
+	"security/detect-no-csrf-before-method-override": "warn",
+	"security/detect-non-literal-fs-filename": "warn",
+	"security/detect-non-literal-regexp": "warn",
+	"security/detect-non-literal-require": "warn",
+	"security/detect-object-injection": "off",
+	"security/detect-possible-timing-attacks": "warn",
+	"security/detect-pseudoRandomBytes": "warn",
+	"security/detect-unsafe-regex": "warn"
+};
+
+export default securityRules;

package/rules/sonarjs/_exports.js

@@ -0,0 +1,2 @@
+export { default as bugDetectionRules } from "./bug-detection.js";
+export { default as sonarjsCodeSmellRules } from "./code-smell-detection.js";

package/rules/sonarjs/bug-detection.js

@@ -0,0 +1,14 @@
+const bugDetectionRules = {
+	"sonarjs/no-all-duplicated-branches": "error",
+	"sonarjs/no-element-overwrite": "error",
+	"sonarjs/no-empty-collection": "error",
+	"sonarjs/no-extra-arguments": "error",
+	"sonarjs/no-identical-conditions": "error",
+	"sonarjs/no-identical-expressions": "error",
+	"sonarjs/no-ignored-return": "error",
+	"sonarjs/no-one-iteration-loop": "error",
+	"sonarjs/no-use-of-empty-return-value": "error",
+	"sonarjs/non-existent-operator": "error"
+};
+
+export default bugDetectionRules;

package/rules/sonarjs/code-smell-detection.js

@@ -0,0 +1,37 @@
+const maximumCognitiveComplexity = 15;
+const maxSwitchCases = 5;
+const duplicateStringThreshold = 3;
+const identicalFunctionThreshold = 3;
+
+const codeSmellDetectionRules = {
+	"sonarjs/cognitive-complexity": ["error", maximumCognitiveComplexity],
+	"sonarjs/elseif-without-else": "off",
+	"sonarjs/max-switch-cases": ["error", maxSwitchCases],
+	"sonarjs/no-collapsible-if": "error",
+	"sonarjs/no-collection-size-mischeck": "error",
+	"sonarjs/no-duplicate-string": [
+		"error",
+		{
+			ignoreStrings: "application/json",
+			threshold: duplicateStringThreshold
+		}
+	],
+	"sonarjs/no-duplicated-branches": "error",
+	"sonarjs/no-gratuitous-expressions": "error",
+	"sonarjs/no-identical-functions": ["error", identicalFunctionThreshold],
+	"sonarjs/no-inverted-boolean-check": "error",
+	"sonarjs/no-nested-switch": "error",
+	"sonarjs/no-nested-template-literals": "error",
+	"sonarjs/no-redundant-boolean": "error",
+	"sonarjs/no-redundant-jump": "error",
+	"sonarjs/no-same-line-conditional": "error",
+	"sonarjs/no-small-switch": "error",
+	"sonarjs/no-unused-collection": "error",
+	"sonarjs/no-useless-catch": "error",
+	"sonarjs/prefer-immediate-return": "error",
+	"sonarjs/prefer-object-literal": "error",
+	"sonarjs/prefer-single-boolean-return": "error",
+	"sonarjs/prefer-while": "error"
+};
+
+export default codeSmellDetectionRules;

package/rules/sonarjs.js

@@ -0,0 +1,12 @@
+import * as sonarjsRuleSets from "./sonarjs/_exports.js";
+
+const sonarjsRules = Object.values(sonarjsRuleSets)
+	.reduce(
+		(allRules, ruleSet) => ({
+			...allRules,
+			...ruleSet
+		}),
+		{}
+	);
+
+export default sonarjsRules;

package/rules/stylistic/_common/_exports.js

@@ -0,0 +1,3 @@
+export {
+	default as minItemsForArrayNewline
+} from "./min-items-for-array-newline.js";

package/rules/stylistic/_common/min-items-for-array-newline.js

@@ -0,0 +1,3 @@
+const minItemsForArrayNewline = 3;
+
+export default minItemsForArrayNewline;

package/rules/stylistic/_exports.js

@@ -0,0 +1,13 @@
+export { default as bracketsRules } from "./brackets.js";
+export { default as commasRules } from "./commas.js";
+export { default as commentsRules } from "./comments.js";
+export { default as disallowRules } from "./disallow.js";
+export { default as indentRules } from "./indent.js";
+export { default as jsxRules } from "./jsx.js";
+export { default as linebreaksRules } from "./linebreaks.js";
+export { default as miscRules } from "./misc.js";
+export { default as operatorsRules } from "./operators.js";
+export { default as quotesRules } from "./quotes.js";
+export { default as semisRules } from "./semis.js";
+export { default as spacingRules } from "./spacing.js";
+export { default as typesRules } from "./types.js";

package/rules/stylistic/brackets.js

@@ -0,0 +1,79 @@
+import { minItemsForArrayNewline } from "./_common/_exports.js";
+
+const minPropertiesForObjectNewline = 3;
+const wrapMultilinesDefault = "parens-new-line";
+
+const bracketsRules = {
+	"@stylistic/array-bracket-newline": [
+		"error",
+		{
+			minItems: minItemsForArrayNewline,
+			multiline: true
+		}
+	],
+	"@stylistic/array-bracket-spacing": ["error", "never"],
+	"@stylistic/arrow-parens": ["error", "always"],
+	"@stylistic/brace-style": ["error", "stroustrup"],
+	"@stylistic/function-paren-newline": ["error", "multiline-arguments"],
+	"@stylistic/jsx-closing-bracket-location": "error",
+	"@stylistic/jsx-curly-brace-presence": [
+		"error",
+		{
+			children: "never",
+			propElementValues: "always",
+			props: "never"
+		}
+	],
+	"@stylistic/jsx-curly-newline": [
+		"error",
+		{
+			multiline: "consistent",
+			singleline: "forbid"
+		}
+	],
+	"@stylistic/jsx-curly-spacing": [
+		"error",
+		{
+			attributes: true,
+			children: true,
+			when: "never"
+		}
+	],
+	"@stylistic/jsx-wrap-multilines": [
+		"error",
+		{
+			arrow: wrapMultilinesDefault,
+			assignment: wrapMultilinesDefault,
+			condition: wrapMultilinesDefault,
+			declaration: wrapMultilinesDefault,
+			logical: wrapMultilinesDefault,
+			return: wrapMultilinesDefault
+			// TODO [@stylistic/eslint-plugin@>1.6.3]: uncomment when @stylistic/eslint-plugin releases
+			// prop: "never"
+		}
+	],
+	"@stylistic/new-parens": ["error", "always"],
+	"@stylistic/object-curly-newline": [
+		"error",
+		{
+			minProperties: minPropertiesForObjectNewline,
+			consistent: true,
+			multiline: true
+		}
+	],
+	"@stylistic/object-curly-spacing": ["error", "always"],
+	"@stylistic/space-before-function-paren": [
+		"error",
+		{
+			anonymous: "always",
+			asyncArrow: "always",
+			named: "never"
+		}
+	],
+	"@stylistic/space-in-parens": ["error", "never"],
+	"@stylistic/template-curly-spacing": ["error", "never"],
+	"@stylistic/wrap-iife": ["error", "inside"],
+	"@stylistic/wrap-regex": "off"
+};
+
+export default bracketsRules;

package/rules/stylistic/commas.js

@@ -0,0 +1,13 @@
+const commasRules = {
+	"@stylistic/comma-dangle": ["error", "never"],
+	"@stylistic/comma-spacing": [
+		"error",
+		{
+			before: false,
+			after: true
+		}
+	],
+	"@stylistic/comma-style": ["error", "last"]
+};
+
+export default commasRules;

package/rules/stylistic/comments.js

@@ -0,0 +1,23 @@
+const commentsRules = {
+	"@stylistic/lines-around-comment": [
+		"error",
+		{
+			beforeBlockComment: true,
+			beforeLineComment: false,
+			afterBlockComment: false,
+			afterLineComment: false,
+			allowArrayEnd: false,
+			allowArrayStart: false,
+			allowBlockEnd: false,
+			allowBlockStart: false,
+			allowClassEnd: false,
+			allowClassStart: false,
+			allowObjectEnd: false,
+			allowObjectStart: false,
+			ignorePattern: "/* @type"
+		}
+	],
+	"@stylistic/spaced-comment": "off"
+};
+
+export default commentsRules;

package/rules/stylistic/disallow.js

@@ -0,0 +1,31 @@
+const disallowRules = {
+	"@stylistic/no-confusing-arrow": "error",
+	"@stylistic/no-extra-parens": ["error", "functions"],
+	"@stylistic/no-floating-decimal": "error",
+	"@stylistic/no-mixed-spaces-and-tabs": "error",
+	"@stylistic/no-multi-spaces": [
+		"error",
+		{
+			exceptions: { Property: false }
+		}
+	],
+	"@stylistic/no-multiple-empty-lines": [
+		"error",
+		{
+			max: 1,
+			maxBOF: 0,
+			maxEOF: 1
+		}
+	],
+	"@stylistic/no-tabs": "off",
+	"@stylistic/no-trailing-spaces": [
+		"error",
+		{
+			ignoreComments: false,
+			skipBlankLines: false
+		}
+	],
+	"@stylistic/no-whitespace-before-property": "error"
+};
+
+export default disallowRules;

package/rules/stylistic/indent.js

@@ -0,0 +1,12 @@
+const indentRules = {
+	"@stylistic/indent": [
+		"error",
+		"tab",
+		{ SwitchCase: 1 }
+	],
+	"@stylistic/indent-binary-ops": ["error", "tab"],
+	"@stylistic/jsx-indent": ["error", "tab"],
+	"@stylistic/jsx-indent-props": ["error", "tab"]
+};
+
+export default indentRules;

package/rules/stylistic/jsx.js

@@ -0,0 +1,35 @@
+const jsxRules = {
+	"@stylistic/jsx-child-element-spacing": "error",
+	"@stylistic/jsx-closing-tag-location": "error",
+	"@stylistic/jsx-equals-spacing": ["error", "never"],
+	"@stylistic/jsx-max-props-per-line": [
+		"error",
+		{
+			maximum: 1,
+			when: "multiline"
+		}
+	],
+	// TODO [@stylistic/eslint-plugin@>1.6.3]: change to "non-jsx" when @stylistic/eslint-plugin releases
+	"@stylistic/jsx-one-expression-per-line": ["off"],
+	"@stylistic/jsx-pascal-case": ["error", { allowNamespace: true }],
+	"@stylistic/jsx-props-no-multi-spaces": "error",
+	"@stylistic/jsx-self-closing-comp": "error",
+	"@stylistic/jsx-sort-props": [
+		"off",
+		{
+			callbacksLast: true,
+			shorthandFirst: true
+		}
+	],
+	"@stylistic/jsx-tag-spacing": [
+		"error",
+		{
+			beforeClosing: "allow",
+			beforeSelfClosing: "always",
+			afterOpening: "never",
+			closingSlash: "never"
+		}
+	]
+};
+
+export default jsxRules;

package/rules/stylistic/linebreaks.js

@@ -0,0 +1,74 @@
+import { minItemsForArrayNewline } from "./_common/_exports.js";
+
+const maxIgnoredChainDepth = 3;
+
+const lineBreaksRules = {
+	"@stylistic/array-element-newline": [
+		"error",
+		{
+			minItems: minItemsForArrayNewline,
+			multiline: true
+		}
+	],
+	"@stylistic/eol-last": ["error", "always"],
+	"@stylistic/function-call-argument-newline": ["error", "consistent"],
+	"@stylistic/implicit-arrow-linebreak": ["error", "beside"],
+	"@stylistic/jsx-first-prop-new-line": ["error", "multiline"],
+	"@stylistic/jsx-newline": "error",
+	"@stylistic/linebreak-style": ["error", "unix"],
+	"@stylistic/lines-between-class-members": ["error", "always"],
+	"@stylistic/newline-per-chained-call": [
+		"error",
+		{
+			ignoreChainWithDepth: maxIgnoredChainDepth
+		}
+	],
+	"@stylistic/object-property-newline": [
+		"error",
+		{
+			allowAllPropertiesOnSameLine: false
+		}
+	],
+	"@stylistic/padding-line-between-statements": [
+		"error",
+		{
+			prev: "*",
+			next: "return",
+			blankLine: "always"
+		},
+		{
+			prev: [
+				"const",
+				"let",
+				"var"
+			],
+			next: "*",
+			blankLine: "always"
+		},
+		{
+			prev: [
+				"const",
+				"let",
+				"var"
+			],
+			next: [
+				"const",
+				"let",
+				"var"
+			],
+			blankLine: "any"
+		},
+		{
+			prev: [
+				"return",
+				"break",
+				"block",
+				"block-like"
+			],
+			next: ["case", "default"],
+			blankLine: "always"
+		}
+	]
+};
+
+export default lineBreaksRules;