@pulsepairs/sdk 0.8.0 → 0.8.1

package/dist/ws.js

@@ -212,7 +212,48 @@ export class UpDownWsClient {
             const delay = attempt > 12 ? 30_000 : Math.min(30_000, 1000 * 2 ** Math.min(attempt, 5));
             this.timer = setTimeout(() => this.openSocket(), delay);
         };
-        ws.onerror = () => ws.close();
+        // NEVER call close() synchronously from here.
+        //
+        // `onerror = () => ws.close()` stood here through 0.8.0 and took
+        // LedgerCore's process down twice against our 502s:
+        // "RangeError: Maximum call stack size exceeded" at dist/ws.js:215. On a
+        // WebSocket implementation that fails a CONNECTING socket SYNCHRONOUSLY,
+        // close() dispatches `error` before it returns, which re-enters this
+        // handler, which calls close() again — unbounded recursion on the stack
+        // rather than a loop that backoff could ever slow down. A handshake that
+        // fails fast, like a 502 from a load balancer, is exactly the trigger.
+        //
+        // Node's built-in WebSocket and the `ws` package both defer that error to a
+        // later tick and so survive it, which is why this went unnoticed here: the
+        // bug is invisible on the runtimes we test on and fatal on the ones we
+        // don't. The guard below therefore does not depend on knowing which
+        // implementation is underneath.
+        //
+        // The close is also redundant on every conforming implementation: a socket
+        // that emits `error` emits `close` afterwards, and `onclose` already owns
+        // reconnect. It is kept only for an implementation that errors without ever
+        // closing, deferred to a later tick where re-entry cannot grow the stack.
+        let errorHandled = false;
+        ws.onerror = () => {
+            if (errorHandled)
+                return; // re-entry is the bug; make it impossible
+            errorHandled = true;
+            if (this.closed || this.ws !== ws)
+                return;
+            setTimeout(() => {
+                // `onclose` normally fires on its own and has already scheduled the
+                // reconnect. Only force it if this socket errored and then just sat
+                // there, which would otherwise strand the client with no retry.
+                if (ws.readyState === 3 /* CLOSED */)
+                    return;
+                try {
+                    ws.close();
+                }
+                catch {
+                    /* ignore */
+                }
+            }, 0);
+        };
     }
     async startHandshake() {
         if (!this.mode || !this.ws)

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@pulsepairs/sdk",
-  "version": "0.8.0",
-  "description": "Standalone SDK for the UpDown (PulsePairs) up/down prediction markets — matcher REST/WS client, EIP-712 order signing, trade-math, and Alchemy Account Kit (smart-account) order signing for rain.trade integration.",
+  "version": "0.8.1",
+  "description": "Standalone SDK for the UpDown (PulsePairs) up/down prediction markets \u2014 matcher REST/WS client, EIP-712 order signing, trade-math, and Alchemy Account Kit (smart-account) order signing for rain.trade integration.",
   "license": "UNLICENSED",
   "type": "module",
   "main": "dist/index.js",
@@ -34,7 +34,7 @@
   "scripts": {
     "clean": "node -e \"fs.rmSync('dist',{recursive:true,force:true})\"",
     "build": "npm run clean && tsc",
-    "test": "node scripts/eip712-golden.test.mjs && node scripts/rawtx-tier.test.mjs && node scripts/hot-key-safety.test.mjs && node scripts/reconcile.test.mjs && node scripts/pnl.test.mjs && node scripts/ws-subscribe.test.mjs",
+    "test": "node scripts/eip712-golden.test.mjs && node scripts/rawtx-tier.test.mjs && node scripts/hot-key-safety.test.mjs && node scripts/reconcile.test.mjs && node scripts/pnl.test.mjs && node scripts/ws-subscribe.test.mjs && node scripts/ws-onerror.test.mjs",
     "prepublishOnly": "npm run build && npm test",
     "example:taker": "npx tsx examples/simple-taker.ts",
     "example:maker": "npx tsx examples/simple-maker.ts",