@pulsehub/runner 0.1.15 → 0.1.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pulsehub/runner",
-  "version": "0.1.15",
+  "version": "0.1.16",
   "description": "Local, credential-safe Pulse Runner",
   "repository": {
     "type": "git",

package/src/runtime.js

@@ -140,11 +140,20 @@ export async function runOnce(config, options = {}) {
   let jobPhase = 'poll';
   let completionReported = false;
   let agentActive = false;
+  let heartbeatQueue = Promise.resolve();
+  // Preserve host phase order, including the explicit final stop. A delayed
+  // preparation request must finish before execution can start its lease.
+  const sendJobHeartbeat = () => {
+    const active = agentActive;
+    const sent = heartbeatQueue.then(() => remote(config, 'pulseRunnerHeartbeat', { status: 'busy', jobId: job.id, agentActive: active }));
+    heartbeatQueue = sent.catch(() => {});
+    return sent;
+  };
   const journal = join(paths().root, 'active-job.json');
   const checkActive = async () => {
     controller.signal.throwIfAborted();
     if (Date.parse(job.expiresAt) <= Date.now()) controller.abort();
-    const response = await remote(config, 'pulseRunnerHeartbeat', { status: 'busy', jobId: job.id, agentActive });
+    const response = await sendJobHeartbeat();
     if (response.cancelRequested) controller.abort();
     controller.signal.throwIfAborted();
   };
@@ -212,7 +221,7 @@ export async function runOnce(config, options = {}) {
           result = await runAgent(agent.kind, job, primary.worktree, checkouts.filter((entry) => entry !== primary), config, delivery.mcpCredential, temp, { signal: controller.signal, profile, onDiagnostic: ({ event, ...details }) => logEvent(event, { jobId: job.id, ...details }) });
         } finally {
           agentActive = false;
-          await remote(config, 'pulseRunnerHeartbeat', { status: 'busy', jobId: job.id, agentActive: false }).catch(() => {});
+          await sendJobHeartbeat().catch(() => {});
         }
         controller.signal.throwIfAborted();
         await checkActive();

package/test/integration.test.js

@@ -11,7 +11,7 @@ import { paths, ensureDataDir, writeCredential } from '../src/config.js';
 import { jobPayload } from '../src/job.js';
 import { command } from '../src/process.js';
 import { inspectReadiness } from '../src/readiness.js';
-import { runOnce, recoverInterruptedWork, withRunnerLock } from '../src/runtime.js';
+import { runOnce, request, recoverInterruptedWork, withRunnerLock } from '../src/runtime.js';
 
 const exists = (file) => access(file).then(() => true).catch(() => false);
 async function git(args) { const result = await command('git', args); assert.equal(result.code, 0, result.output); return result.output.trim(); }
@@ -154,6 +154,46 @@ for (const kind of ['claude','codex']) {
   }));
 }
 
+test('integration: delayed preparation heartbeat cannot stop a running CLI lease', () => fixture('codex', async f => {
+  f.config.agentRole = 'qa'; f.job.mode = 'review'; f.signJob();
+  let preparationStarted;
+  const preparation = new Promise(resolve => { preparationStarted = resolve; });
+  let busyCount = 0, inFlight = 0, peak = 0;
+  const committed = [];
+  await f.run({
+    checkout: async () => {
+      await preparation;
+      await mkdir(join(paths().worktrees, f.job.id), { recursive: true });
+      const primary = { repo: f.job.repoFullName, worktree: f.source };
+      return { primary, checkouts: [primary] };
+    },
+    cleanup: async () => {},
+    request: async (config, path, body) => {
+      if (path !== 'pulseRunnerHeartbeat' || !body.jobId) return request(config, path, body);
+      inFlight++; peak = Math.max(peak, inFlight);
+      const order = ++busyCount;
+      try {
+        if (order === 2) {
+          assert.equal(body.agentActive, false);
+          preparationStarted();
+          await new Promise(resolve => setTimeout(resolve, 200));
+        }
+        const response = await request(config, path, body);
+        committed.push({ order, active: body.agentActive });
+        return response;
+      } finally { inFlight--; }
+    },
+  });
+  assert.equal(peak, 1, 'watcher and phase transitions must never overlap requests');
+  assert.equal(committed[1].active, false);
+  const firstActive = committed.findIndex(entry => entry.active);
+  assert(firstActive > 1, 'execution starts only after preparation heartbeat commits');
+  const stopped = committed.findIndex((entry, i) => i > firstActive && !entry.active);
+  assert(stopped > firstActive);
+  assert(committed.slice(stopped).every(entry => !entry.active), 'final stop stays final');
+  assert.equal(f.calls.find(c => c.path === '/pulseRunnerComplete').body.outcome, 'completed');
+}));
+
 test('integration: invalid signed jobs never reach checkout', () => fixture('codex', async f => {
   const original = {...f.job};
   const cases = [