@pulsehub/runner 0.1.14 → 0.1.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pulsehub/runner",
-  "version": "0.1.14",
+  "version": "0.1.16",
   "description": "Local, credential-safe Pulse Runner",
   "repository": {
     "type": "git",

package/src/runtime.js

@@ -139,11 +139,21 @@ export async function runOnce(config, options = {}) {
   let job;
   let jobPhase = 'poll';
   let completionReported = false;
+  let agentActive = false;
+  let heartbeatQueue = Promise.resolve();
+  // Preserve host phase order, including the explicit final stop. A delayed
+  // preparation request must finish before execution can start its lease.
+  const sendJobHeartbeat = () => {
+    const active = agentActive;
+    const sent = heartbeatQueue.then(() => remote(config, 'pulseRunnerHeartbeat', { status: 'busy', jobId: job.id, agentActive: active }));
+    heartbeatQueue = sent.catch(() => {});
+    return sent;
+  };
   const journal = join(paths().root, 'active-job.json');
   const checkActive = async () => {
     controller.signal.throwIfAborted();
     if (Date.parse(job.expiresAt) <= Date.now()) controller.abort();
-    const response = await remote(config, 'pulseRunnerHeartbeat', { status: 'busy', jobId: job.id });
+    const response = await sendJobHeartbeat();
     if (response.cancelRequested) controller.abort();
     controller.signal.throwIfAborted();
   };
@@ -204,7 +214,15 @@ export async function runOnce(config, options = {}) {
         controller.signal.throwIfAborted();
         jobPhase = 'run-agent';
         await logEvent('agent.started', { jobId: job.id, repo: primary.repo, mode: job.mode });
-        const result = await runAgent(agent.kind, job, primary.worktree, checkouts.filter((entry) => entry !== primary), config, delivery.mcpCredential, temp, { signal: controller.signal, profile, onDiagnostic: ({ event, ...details }) => logEvent(event, { jobId: job.id, ...details }) });
+        agentActive = true;
+        let result;
+        try {
+          await checkActive();
+          result = await runAgent(agent.kind, job, primary.worktree, checkouts.filter((entry) => entry !== primary), config, delivery.mcpCredential, temp, { signal: controller.signal, profile, onDiagnostic: ({ event, ...details }) => logEvent(event, { jobId: job.id, ...details }) });
+        } finally {
+          agentActive = false;
+          await sendJobHeartbeat().catch(() => {});
+        }
         controller.signal.throwIfAborted();
         await checkActive();
         await logEvent(result.code === 0 ? 'agent.completed' : 'agent.failed', { jobId: job.id, exitCode: result.code, ...(result.code === 0 ? {} : { error: failureDetail(result.output) }) });

package/test/integration.test.js

@@ -11,7 +11,7 @@ import { paths, ensureDataDir, writeCredential } from '../src/config.js';
 import { jobPayload } from '../src/job.js';
 import { command } from '../src/process.js';
 import { inspectReadiness } from '../src/readiness.js';
-import { runOnce, recoverInterruptedWork, withRunnerLock } from '../src/runtime.js';
+import { runOnce, request, recoverInterruptedWork, withRunnerLock } from '../src/runtime.js';
 
 const exists = (file) => access(file).then(() => true).catch(() => false);
 async function git(args) { const result = await command('git', args); assert.equal(result.code, 0, result.output); return result.output.trim(); }
@@ -138,6 +138,10 @@ for (const kind of ['claude','codex']) {
     assert.equal(await exists(join(paths().root,'tmp',f.job.id)),false);
     const completion = f.calls.find(c=>c.path==='/pulseRunnerComplete').body;
     assert.equal(completion.outcome,'completed');
+    const heartbeats = f.calls.filter(c => c.path === '/pulseRunnerHeartbeat' && c.body.jobId);
+    assert.equal(heartbeats[0].body.agentActive, false);
+    assert(heartbeats.some(c => c.body.agentActive === true));
+    assert.equal(heartbeats.at(-1).body.agentActive, false);
     assert.ok(!JSON.stringify(f.calls).includes('pulse_sk_fixture'));
   }));
   test(`integration: ${kind} missing native session rejects before creating worktrees`, () => fixture(kind, async f => {
@@ -150,6 +154,46 @@ for (const kind of ['claude','codex']) {
   }));
 }
 
+test('integration: delayed preparation heartbeat cannot stop a running CLI lease', () => fixture('codex', async f => {
+  f.config.agentRole = 'qa'; f.job.mode = 'review'; f.signJob();
+  let preparationStarted;
+  const preparation = new Promise(resolve => { preparationStarted = resolve; });
+  let busyCount = 0, inFlight = 0, peak = 0;
+  const committed = [];
+  await f.run({
+    checkout: async () => {
+      await preparation;
+      await mkdir(join(paths().worktrees, f.job.id), { recursive: true });
+      const primary = { repo: f.job.repoFullName, worktree: f.source };
+      return { primary, checkouts: [primary] };
+    },
+    cleanup: async () => {},
+    request: async (config, path, body) => {
+      if (path !== 'pulseRunnerHeartbeat' || !body.jobId) return request(config, path, body);
+      inFlight++; peak = Math.max(peak, inFlight);
+      const order = ++busyCount;
+      try {
+        if (order === 2) {
+          assert.equal(body.agentActive, false);
+          preparationStarted();
+          await new Promise(resolve => setTimeout(resolve, 200));
+        }
+        const response = await request(config, path, body);
+        committed.push({ order, active: body.agentActive });
+        return response;
+      } finally { inFlight--; }
+    },
+  });
+  assert.equal(peak, 1, 'watcher and phase transitions must never overlap requests');
+  assert.equal(committed[1].active, false);
+  const firstActive = committed.findIndex(entry => entry.active);
+  assert(firstActive > 1, 'execution starts only after preparation heartbeat commits');
+  const stopped = committed.findIndex((entry, i) => i > firstActive && !entry.active);
+  assert(stopped > firstActive);
+  assert(committed.slice(stopped).every(entry => !entry.active), 'final stop stays final');
+  assert.equal(f.calls.find(c => c.path === '/pulseRunnerComplete').body.outcome, 'completed');
+}));
+
 test('integration: invalid signed jobs never reach checkout', () => fixture('codex', async f => {
   const original = {...f.job};
   const cases = [
@@ -388,6 +432,7 @@ test('integration: publication failure retains commits and retry does not run th
   f.job.publicationTargets=[...f.job.publicationTargets.map(t=>({...t,sha:entry.sha}))];f.signJob();
   await f.run();
   assert.equal(await readFile(f.trace,'utf8'),previousTrace);
+  assert(f.calls.filter(c => c.path === '/pulseRunnerHeartbeat' && c.body.jobId).every(c => c.body.agentActive === false));
   const retry=f.calls.find(c=>c.path==='/pulseRunnerComplete').body;
   assert.equal(retry.outcome,'completed');assert.equal(retry.publication.repositories[0].sha,entry.sha);
   assert.equal(retry.publication.repositories[0].stage,'linked');assert.equal(publishCalls,1);