@pryv/monitor 3.13.0 → 3.15.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pryv/monitor",
-  "version": "3.13.0",
+  "version": "3.15.0",
   "description": "Extends `pryv` with event-driven notifications for changes on a Pryv.io account",
   "keywords": [
     "Pryv",

package/src/lib/updateStreams.js

@@ -7,7 +7,10 @@ const Changes = require('./Changes');
 module.exports = async function _updateStreams (monitor) {
   try {
     const result = await monitor.connection.get('streams');
-    if (!result.streams) { throw new Error('Invalid response ' + JSON.stringify(result)); }
+    if (!result.streams) {
+      // The answer rides on `innerObject`, never in the message (it holds stream data).
+      throw Object.assign(new Error('Invalid streams.get answer: no streams'), { innerObject: result });
+    }
     monitor.emit(Changes.STREAMS, result.streams);
   } catch (e) {
     monitor.emit(Changes.ERROR, e);

package/test/monitor-updateStreams.test.js

@@ -0,0 +1,32 @@
+/**
+ * @license
+ * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
+ */
+/* global describe, it, expect */
+
+require('./load-helpers');
+const Changes = require('../src/lib/Changes');
+const updateStreams = require('../src/lib/updateStreams');
+
+/**
+ * [MUSX] A `streams.get` answer without streams is reported without its
+ * content in the message (stream names and clientData), on `innerObject`
+ * instead. A fake monitor: no server.
+ */
+describe('[MUSX] updateStreams with an invalid answer', function () {
+  it('[MUS1] emits an error whose message leaves the answer out', async function () {
+    const SECRET = 'S3CRET-stream-name';
+    const answer = { error: { id: 'unknown-error', message: 'x' }, streams_partial: [{ name: SECRET }] };
+    const emitted = [];
+    const monitor = {
+      connection: { get: async () => answer },
+      emit: (type, value) => emitted.push({ type, value })
+    };
+    await updateStreams(monitor);
+    expect(emitted).to.have.length(1);
+    expect(emitted[0].type).to.equal(Changes.ERROR);
+    expect(emitted[0].value.message).to.equal('Invalid streams.get answer: no streams');
+    expect(emitted[0].value.message).to.not.include(SECRET);
+    expect(emitted[0].value.innerObject).to.equal(answer);
+  });
+});