@proyecto-viviana/solidaria 0.2.5 → 0.3.0

package/src/popover/createOverlayPosition.ts

@@ -5,14 +5,15 @@
  * Ported from @react-aria/overlays useOverlayPosition.
  */
 
-import { createEffect, createSignal, onCleanup, type JSX } from 'solid-js';
+import { createEffect, createSignal, onCleanup, type JSX } from "solid-js";
+import { useLocale } from "../i18n";
 import {
   calculatePosition,
   getRect,
   type Placement,
   type PlacementAxis,
   type PositionResult,
-} from './calculatePosition';
+} from "./calculatePosition";
 
 export interface PositionProps {
   /**
@@ -108,13 +109,13 @@ export interface PositionAria {
   updatePosition: () => void;
 }
 
-const visualViewport = typeof document !== 'undefined' ? window.visualViewport : null;
+const visualViewport = typeof document !== "undefined" ? window.visualViewport : null;
 
 function translateRTL(position: string, direction: string): string {
-  if (direction === 'rtl') {
-    return position.replace('start', 'right').replace('end', 'left');
+  if (direction === "rtl") {
+    return position.replace("start", "right").replace("end", "left");
   }
-  return position.replace('start', 'left').replace('end', 'right');
+  return position.replace("start", "left").replace("end", "right");
 }
 
 /**
@@ -122,18 +123,19 @@ function translateRTL(position: string, direction: string): string {
  * element, and updating the position when the window resizes.
  */
 export function createOverlayPosition(props: AriaPositionProps): PositionAria {
-  const direction = 'ltr'; // TODO: get from locale context
+  const locale = useLocale();
+  const direction = () => locale().direction;
 
   const arrowSize = () => props.arrowSize ?? 0;
   const targetRef = () => props.targetRef();
   const overlayRef = () => props.overlayRef();
   const arrowRef = () => props.arrowRef?.() ?? null;
   const scrollRef = () => props.scrollRef?.() ?? overlayRef();
-  const placement = () => (props.placement ?? 'bottom') as Placement;
+  const placement = () => (props.placement ?? "bottom") as Placement;
   const containerPadding = () => props.containerPadding ?? 12;
   const shouldFlip = () => props.shouldFlip ?? true;
   const boundaryElement = () =>
-    props.boundaryElement ?? (typeof document !== 'undefined' ? document.body : null);
+    props.boundaryElement ?? (typeof document !== "undefined" ? document.body : null);
   const offset = () => props.offset ?? 0;
   const crossOffset = () => props.crossOffset ?? 0;
   const shouldUpdatePosition = () => props.shouldUpdatePosition ?? true;
@@ -172,13 +174,13 @@ export function createOverlayPosition(props: AriaPositionProps): PositionAria {
     // Reset overlay's previous max height
     const overlay = overlayNode as HTMLElement;
     if (!maxHeight() && overlayNode) {
-      overlay.style.top = '0px';
-      overlay.style.bottom = '';
-      overlay.style.maxHeight = (window.visualViewport?.height ?? window.innerHeight) + 'px';
+      overlay.style.top = "0px";
+      overlay.style.bottom = "";
+      overlay.style.maxHeight = (window.visualViewport?.height ?? window.innerHeight) + "px";
     }
 
     const result = calculatePosition({
-      placement: translateRTL(placement(), direction) as Placement,
+      placement: translateRTL(placement(), direction()) as Placement,
       overlayNode,
       targetNode,
       scrollNode: scrollNode || overlayNode,
@@ -197,15 +199,16 @@ export function createOverlayPosition(props: AriaPositionProps): PositionAria {
     }
 
     // Apply styles directly for immediate positioning
-    overlay.style.top = '';
-    overlay.style.bottom = '';
-    overlay.style.left = '';
-    overlay.style.right = '';
-
-    Object.keys(result.position).forEach((key) => {
-      (overlay.style as any)[key] = (result.position as any)[key] + 'px';
+    overlay.style.top = "";
+    overlay.style.bottom = "";
+    overlay.style.left = "";
+    overlay.style.right = "";
+
+    const pos = result.position as Record<string, number | undefined>;
+    Object.keys(pos).forEach((key) => {
+      overlay.style.setProperty(key, pos[key] + "px");
     });
-    overlay.style.maxHeight = result.maxHeight != null ? result.maxHeight + 'px' : '';
+    overlay.style.maxHeight = result.maxHeight != null ? result.maxHeight + "px" : "";
 
     setPosition(result);
   };
@@ -237,10 +240,10 @@ export function createOverlayPosition(props: AriaPositionProps): PositionAria {
     if (!isOpen()) return;
 
     const handleResize = () => updatePosition();
-    window.addEventListener('resize', handleResize, false);
+    window.addEventListener("resize", handleResize, false);
 
     onCleanup(() => {
-      window.removeEventListener('resize', handleResize, false);
+      window.removeEventListener("resize", handleResize, false);
     });
   });
 
@@ -292,12 +295,12 @@ export function createOverlayPosition(props: AriaPositionProps): PositionAria {
       }
     };
 
-    visualViewport?.addEventListener('resize', onResize);
-    visualViewport?.addEventListener('scroll', onScroll);
+    visualViewport?.addEventListener("resize", onResize);
+    visualViewport?.addEventListener("scroll", onScroll);
 
     onCleanup(() => {
-      visualViewport?.removeEventListener('resize', onResize);
-      visualViewport?.removeEventListener('scroll', onScroll);
+      visualViewport?.removeEventListener("resize", onResize);
+      visualViewport?.removeEventListener("scroll", onScroll);
       clearTimeout(timeout);
     });
   });
@@ -322,35 +325,41 @@ export function createOverlayPosition(props: AriaPositionProps): PositionAria {
       }
     };
 
-    document.addEventListener('scroll', handleScroll, true);
+    document.addEventListener("scroll", handleScroll, true);
 
     onCleanup(() => {
-      document.removeEventListener('scroll', handleScroll, true);
+      document.removeEventListener("scroll", handleScroll, true);
     });
   });
 
   return {
     overlayProps: {
-      style: {
-        position: position() ? 'absolute' : 'fixed',
-        top: !position() ? 0 : undefined,
-        left: !position() ? 0 : undefined,
-        'z-index': 100000,
-        'max-height': position()?.maxHeight ?? '100vh',
-      } as JSX.CSSProperties,
+      get style(): JSX.CSSProperties {
+        const current = position();
+        return {
+          position: current ? "absolute" : "fixed",
+          top: !current ? 0 : undefined,
+          left: !current ? 0 : undefined,
+          "z-index": 100000,
+          "max-height": current?.maxHeight ?? "100vh",
+        } as JSX.CSSProperties;
+      },
     },
     placement: () => position()?.placement ?? null,
     triggerAnchorPoint: () => position()?.triggerAnchorPoint ?? null,
     arrowProps: {
-      'aria-hidden': 'true',
-      role: 'presentation',
-      style: {
-        left: position()?.arrowOffsetLeft != null ? `${position()!.arrowOffsetLeft}px` : undefined,
-        top: position()?.arrowOffsetTop != null ? `${position()!.arrowOffsetTop}px` : undefined,
-      } as JSX.CSSProperties,
+      "aria-hidden": "true",
+      role: "presentation",
+      get style(): JSX.CSSProperties {
+        const current = position();
+        return {
+          left: current?.arrowOffsetLeft != null ? `${current.arrowOffsetLeft}px` : undefined,
+          top: current?.arrowOffsetTop != null ? `${current.arrowOffsetTop}px` : undefined,
+        };
+      },
     },
     updatePosition,
   };
 }
 
-export { type Placement, type PlacementAxis } from './calculatePosition';
+export { type Placement, type PlacementAxis } from "./calculatePosition";

package/src/popover/createPopover.ts

@@ -5,16 +5,16 @@
  * Ported from @react-aria/overlays usePopover.
  */
 
-import { createEffect, onCleanup, type JSX } from 'solid-js';
-import { createOverlay } from '../overlays/createOverlay';
+import { createEffect, onCleanup, type JSX } from "solid-js";
+import { createOverlay } from "../overlays/createOverlay";
 import {
   createOverlayPosition,
   type AriaPositionProps,
   type PlacementAxis,
-} from './createOverlayPosition';
-import { createPreventScroll } from '../overlays/createPreventScroll';
-import { ariaHideOutside, keepVisible } from '../overlays/ariaHideOutside';
-import { mergeProps } from '../utils/mergeProps';
+} from "./createOverlayPosition";
+import { createPreventScroll } from "../overlays/createPreventScroll";
+import { ariaHideOutside, keepVisible } from "../overlays/ariaHideOutside";
+import { mergeProps } from "../utils/mergeProps";
 
 export interface OverlayTriggerState {
   /** Whether the overlay is currently open. */
@@ -27,8 +27,10 @@ export interface OverlayTriggerState {
   toggle: () => void;
 }
 
-export interface AriaPopoverProps
-  extends Omit<AriaPositionProps, 'isOpen' | 'onClose' | 'targetRef' | 'overlayRef'> {
+export interface AriaPopoverProps extends Omit<
+  AriaPositionProps,
+  "isOpen" | "onClose" | "targetRef" | "overlayRef"
+> {
   /**
    * The ref for the element which the popover positions itself with respect to.
    */
@@ -94,29 +96,36 @@ export interface PopoverAria {
  * Provides the behavior and accessibility implementation for a popover component.
  * A popover is an overlay element positioned relative to a trigger.
  */
-export function createPopover(
-  props: AriaPopoverProps,
-  state: OverlayTriggerState
-): PopoverAria {
+export function createPopover(props: AriaPopoverProps, state: OverlayTriggerState): PopoverAria {
   const triggerRef = () => props.triggerRef();
   const popoverRef = () => props.popoverRef();
   const groupRef = () => props.groupRef?.() ?? null;
   const isNonModal = () => props.isNonModal ?? false;
   const isKeyboardDismissDisabled = () => props.isKeyboardDismissDisabled ?? false;
   const shouldCloseOnInteractOutside = props.shouldCloseOnInteractOutside;
-  const isSubmenu = () => props.trigger === 'SubmenuTrigger';
+  const isSubmenu = () => props.trigger === "SubmenuTrigger";
 
   // Overlay behavior (dismiss handling)
   const { overlayProps, underlayProps } = createOverlay(
     {
-      isOpen: state.isOpen(),
+      get isOpen() {
+        return state.isOpen();
+      },
       onClose: state.close,
-      shouldCloseOnBlur: true,
-      isDismissable: !isNonModal() || isSubmenu(),
-      isKeyboardDismissDisabled: isKeyboardDismissDisabled(),
-      shouldCloseOnInteractOutside,
+      get shouldCloseOnBlur() {
+        return !isSubmenu();
+      },
+      get isDismissable() {
+        return !isNonModal() || isSubmenu();
+      },
+      get isKeyboardDismissDisabled() {
+        return isKeyboardDismissDisabled();
+      },
+      get shouldCloseOnInteractOutside() {
+        return shouldCloseOnInteractOutside;
+      },
     },
-    () => groupRef() ?? popoverRef()
+    () => groupRef() ?? popoverRef(),
   );
 
   // Overlay positioning
@@ -129,13 +138,19 @@ export function createPopover(
     ...props,
     targetRef: triggerRef,
     overlayRef: popoverRef,
-    isOpen: state.isOpen(),
-    onClose: isNonModal() && !isSubmenu() ? state.close : null,
+    get isOpen() {
+      return state.isOpen();
+    },
+    get onClose() {
+      return isNonModal() && !isSubmenu() ? state.close : null;
+    },
   });
 
   // Prevent scroll when modal popover is open
   createPreventScroll({
-    isDisabled: isNonModal() || !state.isOpen(),
+    get isDisabled() {
+      return isNonModal() || !state.isOpen();
+    },
   });
 
   // Aria-hide outside elements
@@ -158,8 +173,32 @@ export function createPopover(
     }
   });
 
+  const merged = mergeProps(overlayProps, positionProps) as Record<string, unknown>;
+  const popoverProps = new Proxy(merged, {
+    get(target, key: string) {
+      if (key === "style") return positionProps.style;
+      return target[key];
+    },
+    has(target, key) {
+      return key in target;
+    },
+    ownKeys(target) {
+      return Reflect.ownKeys(target);
+    },
+    getOwnPropertyDescriptor(target, key) {
+      if (key === "style") {
+        return {
+          configurable: true,
+          enumerable: true,
+          get: () => positionProps.style,
+        };
+      }
+      return Reflect.getOwnPropertyDescriptor(target, key);
+    },
+  });
+
   return {
-    popoverProps: mergeProps(overlayProps, positionProps),
+    popoverProps,
     arrowProps,
     underlayProps,
     placement,
@@ -167,4 +206,4 @@ export function createPopover(
   };
 }
 
-export { type PlacementAxis } from './createOverlayPosition';
+export { type PlacementAxis } from "./createOverlayPosition";

package/src/popover/index.ts

@@ -4,7 +4,7 @@ export {
   type AriaPopoverProps,
   type PopoverAria,
   type OverlayTriggerState,
-} from './createPopover';
+} from "./createPopover";
 
 // Overlay Position
 export {
@@ -12,7 +12,7 @@ export {
   type AriaPositionProps,
   type PositionProps,
   type PositionAria,
-} from './createOverlayPosition';
+} from "./createOverlayPosition";
 
 // Position calculation utilities
 export {
@@ -21,4 +21,4 @@ export {
   type PlacementAxis,
   type PositionOpts,
   type PositionResult,
-} from './calculatePosition';
+} from "./calculatePosition";

package/src/progress/createProgressBar.ts

@@ -8,16 +8,14 @@
  * This is a 1:1 port of @react-aria/progress's useProgressBar hook.
  */
 
-import { createLabel } from '../label/createLabel';
-import { mergeProps } from '../utils/mergeProps';
-import { filterDOMProps } from '../utils/filterDOMProps';
-import { type MaybeAccessor, access } from '../utils/reactivity';
-
-// ============================================
-// TYPES
-// ============================================
+import { createLabel } from "../label/createLabel";
+import { mergeProps } from "../utils/mergeProps";
+import { filterDOMProps } from "../utils/filterDOMProps";
+import { type MaybeAccessor, access } from "../utils/reactivity";
 
 export interface AriaProgressBarProps {
+  /** The element id. */
+  id?: string;
   /** The current value (controlled). */
   value?: number;
   /** The smallest value allowed for the input. @default 0 */
@@ -33,13 +31,13 @@ export interface AriaProgressBarProps {
   /** The content to display as the label. */
   label?: string;
   /** An accessibility label for this item. */
-  'aria-label'?: string;
+  "aria-label"?: string;
   /** Identifies the element (or elements) that labels the current element. */
-  'aria-labelledby'?: string;
+  "aria-labelledby"?: string;
   /** Identifies the element (or elements) that describes the object. */
-  'aria-describedby'?: string;
+  "aria-describedby"?: string;
   /** Identifies the element (or elements) that provide a detailed, extended description for the object. */
-  'aria-details'?: string;
+  "aria-details"?: string;
 }
 
 export interface ProgressBarAria {
@@ -49,17 +47,14 @@ export interface ProgressBarAria {
   labelProps: Record<string, unknown>;
 }
 
-// ============================================
-// UTILITIES
-// ============================================
-
 function clamp(value: number, min: number, max: number): number {
   return Math.min(Math.max(value, min), max);
 }
 
-// ============================================
-// IMPLEMENTATION
-// ============================================
+function getSafeRange(min: number, max: number): number {
+  const range = max - min;
+  return Number.isFinite(range) && range > 0 ? range : 1;
+}
 
 /**
  * Provides the accessibility implementation for a progress bar component.
@@ -67,18 +62,27 @@ function clamp(value: number, min: number, max: number): number {
  * over time.
  */
 export function createProgressBar(
-  props: MaybeAccessor<AriaProgressBarProps> = {}
+  props: MaybeAccessor<AriaProgressBarProps> = {},
 ): ProgressBarAria {
   const getProps = () => access(props);
 
   // Create label handling
   const { labelProps, fieldProps } = createLabel({
-    get label() { return getProps().label; },
-    get 'aria-label'() { return getProps()['aria-label']; },
-    get 'aria-labelledby'() { return getProps()['aria-labelledby']; },
+    get id() {
+      return getProps().id;
+    },
+    get label() {
+      return getProps().label;
+    },
+    get "aria-label"() {
+      return getProps()["aria-label"];
+    },
+    get "aria-labelledby"() {
+      return getProps()["aria-labelledby"];
+    },
     // Progress bar is not an HTML input element so it
     // shouldn't be labeled by a <label> element.
-    labelElementType: 'span',
+    labelElementType: "span",
   });
 
   // Build progress bar props
@@ -88,15 +92,15 @@ export function createProgressBar(
     const minValue = p.minValue ?? 0;
     const maxValue = p.maxValue ?? 100;
     const isIndeterminate = p.isIndeterminate ?? false;
-    const formatOptions = p.formatOptions ?? { style: 'percent' as const };
+    const formatOptions = p.formatOptions ?? { style: "percent" as const };
 
     const clampedValue = clamp(value, minValue, maxValue);
-    const percentage = (clampedValue - minValue) / (maxValue - minValue);
+    const percentage = (clampedValue - minValue) / getSafeRange(minValue, maxValue);
 
     // Format value label
     let valueLabel = p.valueLabel;
     if (!isIndeterminate && !valueLabel) {
-      const valueToFormat = formatOptions.style === 'percent' ? percentage : clampedValue;
+      const valueToFormat = formatOptions.style === "percent" ? percentage : clampedValue;
       try {
         const formatter = new Intl.NumberFormat(undefined, formatOptions);
         valueLabel = formatter.format(valueToFormat);
@@ -109,11 +113,11 @@ export function createProgressBar(
     const domProps = filterDOMProps(p as Record<string, unknown>, { labelable: true });
 
     return mergeProps(domProps, fieldProps as Record<string, unknown>, {
-      'aria-valuenow': isIndeterminate ? undefined : clampedValue,
-      'aria-valuemin': minValue,
-      'aria-valuemax': maxValue,
-      'aria-valuetext': isIndeterminate ? undefined : valueLabel,
-      role: 'progressbar',
+      "aria-valuenow": isIndeterminate ? undefined : clampedValue,
+      "aria-valuemin": minValue,
+      "aria-valuemax": maxValue,
+      "aria-valuetext": isIndeterminate ? undefined : valueLabel,
+      role: "progressbar",
     });
   };
 

package/src/progress/index.ts

@@ -2,4 +2,4 @@ export {
   createProgressBar,
   type AriaProgressBarProps,
   type ProgressBarAria,
-} from './createProgressBar';
+} from "./createProgressBar";