@prowise/eslint-config-linting-rules 2.0.4 → 2.0.6

package/rules/plugin-typescript-rules.js

@@ -91,7 +91,7 @@ export default {
          * https://typescript-eslint.io/rules/consistent-type-definitions.
          * Turned off => we want to keep difference between defining type and interface.
          */
-        "@typescript-eslint/consistent-type-definitions": "off",
+        // "@typescript-eslint/consistent-type-definitions": "off",
 
         /**
          * Enforce consistent usage of type exports 🔧 💭
@@ -104,7 +104,11 @@ export default {
          * https://typescript-eslint.io/rules/consistent-type-imports.
          * Turned off to allow us to use type import to prevent circular import warning.
          */
-        "@typescript-eslint/consistent-type-imports": ["off", { prefer: "no-type-imports" }],
+        "@typescript-eslint/consistent-type-imports": ["warn", {
+            prefer: "type-imports",
+            fixStyle: "inline-type-imports",
+            disallowTypeAnnotations: false,
+        }],
 
         /**
          * Enforce default parameters to be last.
@@ -158,14 +162,14 @@ export default {
          * Require or disallow initialization in variable declarations
          * https://typescript-eslint.io/rules/init-declarations.
          */
-        "init-declarations": "off",
-        "@typescript-eslint/init-declarations": baseRules.rules["init-declarations"],
+        // "init-declarations": "off",
+        // "@typescript-eslint/init-declarations": baseRules.rules["init-declarations"],
 
         /**
          * Require a consistent member declaration order
          * https://typescript-eslint.io/rules/member-ordering.
          */
-        "@typescript-eslint/member-ordering": "off",
+        // "@typescript-eslint/member-ordering": "off",
 
         /**
          * Enforce using a particular method signature syntax 🔧
@@ -278,7 +282,7 @@ export default {
          * Disallow classes used as namespaces 🔒
          * https://typescript-eslint.io/rules/no-extraneous-class.
          */
-        "@typescript-eslint/no-extraneous-class": "off",
+        // "@typescript-eslint/no-extraneous-class": "off",
 
         /**
          * Require Promise-like statements to be handled appropriately ✅ 💡 💭
@@ -297,7 +301,6 @@ export default {
          * https://typescript-eslint.io/rules/no-implied-eval.
          */
         "no-implied-eval": "off",
-        "no-new-function": "off",
         "@typescript-eslint/no-implied-eval": baseRules.rules["no-implied-eval"],
 
         /**
@@ -311,14 +314,14 @@ export default {
          * Disallow this keywords outside of classes or class-like objects.
          * Https://typescript-eslint.io/rules/no-invalid-this.
          */
-        "no-invalid-this": "off",
-        "@typescript-eslint/no-invalid-this": baseRules.rules["no-invalid-this"],
+        // "no-invalid-this": "off",
+        // "@typescript-eslint/no-invalid-this": baseRules.rules["no-invalid-this"],
 
         /**
          * Disallow void type outside of generic or return types 🔒
          * https://typescript-eslint.io/rules/no-invalid-void-type.
          */
-        "@typescript-eslint/no-invalid-void-type": "off",
+        // "@typescript-eslint/no-invalid-void-type": "off",
 
         /**
          * Disallow function declarations that contain unsafe references inside loop statements.
@@ -331,8 +334,8 @@ export default {
          * Disallow magic numbers.
          * Https://typescript-eslint.io/rules/no-magic-numbers.
          */
-        "no-magic-numbers": "off",
-        "@typescript-eslint/no-magic-numbers": baseRules.rules["no-magic-numbers"],
+        // "no-magic-numbers": "off",
+        // "@typescript-eslint/no-magic-numbers": baseRules.rules["no-magic-numbers"],
 
         /**
          * Disallow the void operator except when used to discard a value 🔒 🔧 💡 💭
@@ -432,7 +435,7 @@ export default {
          * https://typescript-eslint.io/rules/no-unnecessary-condition.
          * Turned off for now: a lot of false positives which breaks code!!
          */
-        "@typescript-eslint/no-unnecessary-condition": "off",
+        // "@typescript-eslint/no-unnecessary-condition": "off",
 
         /**
          * Disallow unnecessary namespace qualifiers 🔧 💭
@@ -469,20 +472,20 @@ export default {
          * Off: catched by tsc
          * https://typescript-eslint.io/rules/no-unsafe-assignment.
          */
-        "@typescript-eslint/no-unsafe-assignment": "off",
+        // "@typescript-eslint/no-unsafe-assignment": "off",
 
         /**
          * Disallow calling a value with type any ✅ 💭
          * Off: gives too much false positive
          * https://typescript-eslint.io/rules/no-unsafe-call.
          */
-        "@typescript-eslint/no-unsafe-call": "off",
+        // "@typescript-eslint/no-unsafe-call": "off",
 
         /**
          * Disallow member access on a value with type any ✅ 💭
          * https://typescript-eslint.io/rules/no-unsafe-member-access.
          */
-        "@typescript-eslint/no-unsafe-member-access": "off",
+        // "@typescript-eslint/no-unsafe-member-access": "off",
 
         /**
          * Disallow returning a value with type any from a function ✅ 💭
@@ -552,7 +555,7 @@ export default {
          * Require each enum member value to be explicitly initialized 💡
          * https://typescript-eslint.io/rules/prefer-enum-initializers.
          */
-        "@typescript-eslint/prefer-enum-initializers": "off",
+        // "@typescript-eslint/prefer-enum-initializers": "off",
 
         /**
          * Enforce the use of for-of loop over the standard for loop where possible 🔒
@@ -588,7 +591,7 @@ export default {
          * Enforce using the nullish coalescing operator instead of logical chaining 🔒 💡 💭
          * https://typescript-eslint.io/rules/prefer-nullish-coalescing.
          */
-        "@typescript-eslint/prefer-nullish-coalescing": "off",
+        // "@typescript-eslint/prefer-nullish-coalescing": "off",
 
         /**
          * Enforce using concise optional chain expressions instead of chained logical ands 🔒 💡
@@ -606,7 +609,7 @@ export default {
          * Require function parameters to be typed as readonly to prevent accidental mutation of inputs 💭
          * https://typescript-eslint.io/rules/prefer-readonly-parameter-types.
          */
-        "@typescript-eslint/prefer-readonly-parameter-types": "off",
+        // "@typescript-eslint/prefer-readonly-parameter-types": "off",
 
         /**
          * Enforce using type parameter when calling Array#reduce instead of casting 🔒 🔧 💭
@@ -657,7 +660,7 @@ export default {
          * Off: not really needed
          * https://typescript-eslint.io/rules/restrict-plus-operands.
          */
-        "@typescript-eslint/restrict-plus-operands": "off",
+        // "@typescript-eslint/restrict-plus-operands": "off",
 
         /**
          * Enforce template literal expressions to be of string type ✅  💭
@@ -669,13 +672,13 @@ export default {
          * Enforce members of a type union/intersection to be sorted alphabetically 🔧 💡
          * https://typescript-eslint.io/rules/sort-type-union-intersection-members.
          */
-        "@typescript-eslint/sort-type-union-intersection-members": "off",
+        // "@typescript-eslint/sort-type-union-intersection-members": "off",
 
         /**
          * Disallow certain types in boolean expressions 🔧 💡 💭
          * https://typescript-eslint.io/rules/strict-boolean-expressions.
          */
-        "@typescript-eslint/strict-boolean-expressions": "off",
+        // "@typescript-eslint/strict-boolean-expressions": "off",
 
         /**
          * Require switch-case statements to be exhaustive with union type 💡 💭
@@ -707,7 +710,7 @@ export default {
          * While this rule should be enabled, it gives to many problems with external libraries
          * https://typescript-eslint.io/rules/unbound-method.
          */
-        "@typescript-eslint/unbound-method": "off",
+        // "@typescript-eslint/unbound-method": "off",
 
         /**
          * Disallow two overloads that could be unified into one with a union or an optional/rest parameter
@@ -735,19 +738,19 @@ export default {
             },
         ],
 
-        "import/no-extraneous-dependencies": [
-            importRules.rules["import/no-extraneous-dependencies"][0],
-            {
-                ...importRules.rules["import/no-extraneous-dependencies"][1],
-                devDependencies: importRules.rules["import/no-extraneous-dependencies"][1].devDependencies.reduce(
-                    (result, devDep) => {
-                        const toAppend = [devDep];
-                        const devDepWithTs = devDep.replace(/\bjs(x?)\b/g, "ts$1");
-                        if (devDepWithTs !== devDep) toAppend.push(devDepWithTs);
-                        return [...result, ...toAppend];
-                    },
-                ),
-            },
-        ],
+        // "import/no-extraneous-dependencies": [
+        //     importRules.rules["import/no-extraneous-dependencies"][0],
+        //     {
+        //         ...importRules.rules["import/no-extraneous-dependencies"][1],
+        //         devDependencies: importRules.rules["import/no-extraneous-dependencies"][1].devDependencies.reduce(
+        //             (result, devDep) => {
+        //                 const toAppend = [devDep];
+        //                 const devDepWithTs = devDep.replace(/\bjs(x?)\b/g, "ts$1");
+        //                 if (devDepWithTs !== devDep) toAppend.push(devDepWithTs);
+        //                 return [...result, ...toAppend];
+        //             },
+        //         ),
+        //     },
+        // ],
     },
 };

package/rules/plugin-vitest-rules.js

@@ -30,13 +30,13 @@ export default {
          * Forbidden test file pattern: default only "test" accepted
          * https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/consistent-test-filename.md
          */
-        "vitest/consistent-test-filename": ["off", { pattern: ".*\\.test\\.[tj]sx?$" }],
+        "vitest/consistent-test-filename": ["warn", { pattern: ".*\\.test\\.[tj]sx?$" }],
 
         /**
          * Do not use conditionals to run tests
          * https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-tests.md
          */
-        "vitest/no-conditional-tests": "off",
+        // "vitest/no-conditional-tests": "off",
 
         /**
          * Disallow importing node:test ✅ 🔧
@@ -48,25 +48,25 @@ export default {
          * Disallow specific vi. methods
          * https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-restricted-vi-methods.md
          */
-        "vitest/no-restricted-vi-methods": "off",
+        // "vitest/no-restricted-vi-methods": "off",
 
         /**
          * Suggest using toBeFalsy() 🔧
          * https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be-falsy.md
          */
-        "vitest/prefer-to-be-falsy)": "off",
+        // "vitest/prefer-to-be-falsy)": "off",
 
         /**
          * Prefer toBeObject() 🔧
          * https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be-object.md
          */
-        "vitest/prefer-to-be-object": "off",
+        // "vitest/prefer-to-be-object": "off",
 
         /**
          * Suggest using toBeTruthy 🔧
          * https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be-truthy.md
          */
-        "vitest/prefer-to-be-truthy": "off",
+        // "vitest/prefer-to-be-truthy": "off",
 
         /**
          * Require local Test Context for concurrent snapshot tests ✅

package/rules/test-rules.js

@@ -28,7 +28,7 @@ const rules = {
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/max-expects.md
      * Rule turned off: gives too many false positives
      */
-    "max-expects": ["off", { max: 10 }],
+    // "max-expects": ["off", { max: 10 }],
 
     /**
      * Enforces a maximum depth to nested describe calls
@@ -63,7 +63,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-conditional-in-test.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-in-test.md
      */
-    "no-conditional-in-test": "off",
+    // "no-conditional-in-test": "off",
 
     /**
      * Disallow disabled tests ✅
@@ -91,7 +91,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-hooks.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-hooks.md
      */
-    "no-hooks": "off",
+    // "no-hooks": "off",
 
     /**
      * Disallow identical titles ✅
@@ -126,7 +126,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-restricted-matchers.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-restricted-matchers.md
      */
-    "no-restricted-matchers": "off",
+    // "no-restricted-matchers": "off",
 
     /**
      * Disallow using expect outside of it or test blocks ✅
@@ -168,7 +168,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-each.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-each.md
      */
-    "prefer-each": "off",
+    // "prefer-each": "off",
 
     /**
      * Suggest using the built-in equality matchers
@@ -182,7 +182,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-expect-assertions.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-expect-assertions.md
      */
-    "prefer-expect-assertions": "off",
+    // "prefer-expect-assertions": "off",
 
     /**
      * Suggest using expect().resolves over expect(await ...) syntax 🔧
@@ -222,7 +222,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-snapshot-hint.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-snapshot-hint.md
      */
-    "prefer-snapshot-hint": "off",
+    // "prefer-snapshot-hint": "off",
 
     /**
      * Suggest using .spyOn()
@@ -236,7 +236,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-strict-equal.md
      * Vitest https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-strict-equal.md
      */
-    "prefer-strict-equal": "off",
+    // "prefer-strict-equal": "off",
 
     /**
      * Suggest using toBe() for primitive literals 🔧
@@ -271,7 +271,7 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-hook.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/require-hook.md
      */
-    "require-hook": "off",
+    // "require-hook": "off",
 
     /**
      * Require a message for toThrow()
@@ -285,14 +285,14 @@ const rules = {
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-top-level-describe.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/require-top-level-describe.md
      */
-    "require-top-level-describe": "off",
+    // "require-top-level-describe": "off",
 
     /**
      * Enforce unbound methods are called with their expected scope
      * Jest:   https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.md
      * Vitest: https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/unbound-method.md
      */
-    "unbound-method": "off",
+    // "unbound-method": "off",
 
     /**
      * Enforce valid describe() ✅

package/rules/plugin-react-hooks-rules.js

@@ -1,18 +0,0 @@
-export default {
-    plugins: {},
-
-    rules: {
-        // TODO: enable when compatible with eslint version 9
-        /**
-         * Enforce Rules of Hooks
-         * https://reactjs.org/docs/hooks-rules.html.
-         */
-        // "react-hooks/rules-of-hooks": "error",
-
-        /**
-         * Verify the list of the dependencies for Hooks like useEffect and similar
-         * https://reactjs.org/docs/hooks-rules.html.
-         */
-        // "react-hooks/exhaustive-deps": "error",
-    },
-};