@prowise/eslint-config-linting-rules 2.0.0 → 2.0.2

package/rules/{base-rules.js → baseSettings.js}

@@ -1,10 +1,12 @@
-const confusingBrowserGlobals = require("confusing-browser-globals");
+import confusingBrowserGlobals from "confusing-browser-globals";
 
-module.exports = {
+export default {
     /*
      * ✅ recommended
+     * 🔒 strict
      * 🔧 fixable
      * 💡 has suggestion
+     * 💭 requires type information
      */
 
     rules: {
@@ -148,6 +150,11 @@ module.exports = {
          */
         "no-empty-pattern": "error",
 
+        /**
+         * Disallow empty destructuring patterns ✅
+         * https://eslint.org/docs/latest/rules/no-empty-pattern.
+         */
+        "no-empty-static-block": "off",
         /**
          * Disallow assigning to the exception in a catch block ✅
          * https://eslint.org/docs/latest/rules/no-ex-assign.
@@ -204,9 +211,9 @@ module.exports = {
 
         /**
          * Disallow symbol constructor ✅
-         * https://eslint.org/docs/latest/rules/no-new-symbol.
+         * https://eslint.org/docs/latest/rules/no-new-native-nonconstructor.
          */
-        "no-new-symbol": "error",
+        "no-new-native-nonconstructor": "error",
 
         /**
          * Disallow the use of object properties of the global object (Math and JSON) as functions ✅
@@ -404,7 +411,29 @@ module.exports = {
          * Enforce that class methods use "this"
          * https://eslint.org/docs/latest/rules/class-methods-use-this.
          */
-        "class-methods-use-this": "off",
+        "class-methods-use-this": [
+            "off",
+            {
+                exceptMethods: [
+                    "render",
+                    "getInitialState",
+                    "getDefaultProps",
+                    "getChildContext",
+                    "componentWillMount",
+                    "UNSAFE_componentWillMount",
+                    "componentDidMount",
+                    "componentWillReceiveProps",
+                    "UNSAFE_componentWillReceiveProps",
+                    "shouldComponentUpdate",
+                    "componentWillUpdate",
+                    "UNSAFE_componentWillUpdate",
+                    "componentDidUpdate",
+                    "componentWillUnmount",
+                    "componentDidCatch",
+                    "getSnapshotBeforeUpdate",
+                ],
+            },
+        ],
 
         /**
          * Specify the maximum cyclomatic complexity allowed in a program
@@ -499,7 +528,7 @@ module.exports = {
          * Disallow specified identifiers
          * https://eslint.org/docs/latest/rules/id-denylist.
          */
-        "id-blacklist": ["error", "any", "Undefined"],
+        "id-denylist": ["error", "any", "Undefined"],
 
         /**
          * This option enforces minimum and maximum identifier lengths
@@ -571,12 +600,6 @@ module.exports = {
          */
         "max-statements": ["off", 10],
 
-        /**
-         * Enforce a particular style for multiline comments 🔧
-         * https://eslint.org/docs/latest/rules/multiline-comment-style.
-         */
-        "multiline-comment-style": ["off", "starred-block"],
-
         /**
          * Require a capital letter for constructors
          * https://eslint.org/docs/latest/rules/new-cap.
@@ -621,12 +644,6 @@ module.exports = {
          */
         "no-case-declarations": "error",
 
-        /**
-         * Disallow arrow functions where they could be confused with comparisons 🔧
-         * https://eslint.org/docs/latest/rules/no-confusing-arrow.
-         */
-        "no-confusing-arrow": "warn",
-
         /**
          * Disallow use of console
          * https://eslint.org/docs/latest/rules/no-console.
@@ -710,18 +727,6 @@ module.exports = {
          */
         "no-extra-label": "error",
 
-        /**
-         * Disallow unnecessary semicolons ✅  🔧
-         * https://eslint.org/docs/latest/rules/no-extra-semi.
-         */
-        "no-extra-semi": "error",
-
-        /**
-         * Disallow the use of leading or trailing decimal points in numeric literals 🔧
-         * https://eslint.org/docs/latest/rules/no-floating-decimal.
-         */
-        "no-floating-decimal": "error",
-
         /**
          * Disallow reassignments of native objects or read-only globals ✅
          * https://eslint.org/docs/latest/rules/no-global-assign.
@@ -816,30 +821,6 @@ module.exports = {
             },
         ],
 
-        /**
-         * Disallow un-paren"d mixes of different operators
-         * https://eslint.org/docs/latest/rules/no-mixed-operators.
-         */
-        "no-mixed-operators": [
-            "error",
-            {
-                // the list of arithmetic groups disallows mixing `%` and `**`
-                // with other arithmetic operators.
-                groups: [
-                    ["%", "**"],
-                    ["%", "+"],
-                    ["%", "-"],
-                    ["%", "*"],
-                    ["%", "/"],
-                    ["/", "*"],
-                    ["&", "|", "<<", ">>", ">>>"],
-                    ["==", "!=", "===", "!=="],
-                    ["&&", "||"],
-                ],
-                allowSamePrecedence: false,
-            },
-        ],
-
         /**
          * Disallow use of chained assignment expressions
          * https://eslint.org/docs/latest/rules/no-multi-assign.
@@ -878,9 +859,9 @@ module.exports = {
 
         /**
          * Disallow use of the Object constructor
-         * https://eslint.org/docs/latest/rules/no-new-object.
+         * https://eslint.org/docs/latest/rules/no-object-constructor.
          */
-        "no-new-object": "error",
+        "no-object-constructor": "error",
 
         /**
          * Disallows creating new instances of String, Number, and Boolean
@@ -1052,12 +1033,6 @@ module.exports = {
          */
         "no-return-assign": "off",
 
-        /**
-         * Disallow redundant `return await`
-         * https://eslint.org/docs/latest/rules/no-return-await.
-         */
-        "no-return-await": "error",
-
         /**
          * Disallow use of `javascript:` urls.
          * Https://eslint.org/docs/latest/rules/no-script-url.
@@ -1238,12 +1213,6 @@ module.exports = {
          */
         "one-var": ["error", "never"],
 
-        /**
-         * Require a newline around variable declaration 🔧
-         * https://eslint.org/docs/latest/rules/one-var-declaration-per-line.
-         */
-        "one-var-declaration-per-line": ["error", "always"],
-
         /**
          * Require assignment operator shorthand where possible or prohibit it entirely 🔧
          * https://eslint.org/docs/latest/rules/operator-assignment.
@@ -1338,12 +1307,6 @@ module.exports = {
          */
         "prefer-template": "error",
 
-        /**
-         * Require quotes around object literal property names 🔧
-         * https://eslint.org/docs/latest/rules/quote-props.
-         */
-        "quote-props": ["error", "as-needed", { keywords: false, unnecessary: true, numbers: false }],
-
         /**
          * Require use of the second argument for parseInt()
          * https://eslint.org/docs/latest/rules/radix.
@@ -1406,471 +1369,6 @@ module.exports = {
          */
         "symbol-description": "error",
 
-        /**
-         * Requires to declare all vars on top of their containing scope
-         * https://eslint.org/docs/latest/rules/vars-on-top.
-         */
-        "vars-on-top": "error",
-
-        /**
-         * Require or disallow Yoda conditions 🔧
-         * https://eslint.org/docs/latest/rules/yoda.
-         */
-        yoda: "error",
-
-        // ======================= Styling & formatting =======================
-
-        /**
-         * Enforce line breaks after opening and before closing array brackets 🔧
-         * https://eslint.org/docs/latest/rules/array-bracket-newline.
-         */
-        "array-bracket-newline": ["off", "consistent"], // object option alternative: { multiline: true, minItems: 3 }
-
-        /**
-         * Enforce spacing inside array brackets 🔧
-         * https://eslint.org/docs/latest/rules/array-bracket-spacing.
-         */
-        "array-bracket-spacing": ["error", "never"],
-
-        /**
-         * Enforce line breaks between array elements 🔧
-         * https://eslint.org/docs/latest/rules/array-element-newline.
-         */
-        "array-element-newline": ["off", { multiline: true, minItems: 3 }],
-
-        /**
-         * Require parens in arrow function arguments 🔧
-         * https://eslint.org/docs/latest/rules/arrow-parens.
-         */
-        "arrow-parens": ["error", "always"],
-
-        /**
-         * Require space before/after arrow function"s arrow 🔧
-         * https://eslint.org/docs/latest/rules/arrow-spacing.
-         */
-        "arrow-spacing": ["error", { before: true, after: true }],
-
-        /**
-         * Enforce spacing inside single-line blocks 🔧
-         * https://eslint.org/docs/latest/rules/block-spacing.
-         */
-        "block-spacing": ["error", "always"],
-
-        /**
-         * Enforce one true brace style 🔧
-         * https://eslint.org/docs/latest/rules/brace-style.
-         */
-        "brace-style": ["error", "1tbs", { allowSingleLine: true }],
-
-        /**
-         * Require trailing commas in multiline object literals 🔧
-         * https://eslint.org/docs/latest/rules/comma-dangle.
-         */
-        "comma-dangle": [
-            "error",
-            {
-                arrays: "always-multiline",
-                objects: "always-multiline",
-                imports: "always-multiline",
-                exports: "always-multiline",
-                functions: "always-multiline",
-            },
-        ],
-
-        /**
-         * Enforce spacing before and after comma 🔧
-         * https://eslint.org/docs/latest/rules/comma-spacing.
-         */
-        "comma-spacing": ["error", { before: false, after: true }],
-
-        /**
-         * Enforce one true comma style 🔧
-         * https://eslint.org/docs/latest/rules/comma-style.
-         */
-        "comma-style": [
-            "error",
-            "last",
-            {
-                exceptions: {
-                    ArrayExpression: false,
-                    ArrayPattern: false,
-                    ArrowFunctionExpression: false,
-                    CallExpression: false,
-                    FunctionDeclaration: false,
-                    FunctionExpression: false,
-                    ImportDeclaration: false,
-                    ObjectExpression: false,
-                    ObjectPattern: false,
-                    VariableDeclaration: false,
-                    NewExpression: false,
-                },
-            },
-        ],
-
-        /**
-         * Disallow padding inside computed properties 🔧
-         * https://eslint.org/docs/latest/rules/computed-property-spacing.
-         */
-        "computed-property-spacing": ["error", "never"],
-
-        /**
-         * Enforces consistent newlines before or after dots 🔧
-         * https://eslint.org/docs/latest/rules/dot-location.
-         */
-        "dot-location": ["error", "property"],
-
-        /**
-         * Enforce newline at the end of file, with no multiple empty lines 🔧
-         * https://eslint.org/docs/latest/rules/eol-last.
-         */
-        "eol-last": ["error", "always"],
-
-        /**
-         * Enforce spacing between functions and their invocations 🔧
-         * https://eslint.org/docs/latest/rules/func-call-spacing.
-         */
-        "func-call-spacing": ["error", "never"],
-
-        /**
-         * Enforce line breaks between arguments of a function call 🔧
-         * https://eslint.org/docs/latest/rules/function-call-argument-newline.
-         */
-        "function-call-argument-newline": ["error", "consistent"],
-
-        /**
-         * Require line breaks inside function parentheses if there are line breaks between parameters. 🔧
-         * https://eslint.org/docs/latest/rules/function-paren-newline.
-         */
-        "function-paren-newline": "off",
-
-        /**
-         * Enforce the spacing around the * in generator functions 🔧
-         * https://eslint.org/docs/latest/rules/generator-star-spacing.
-         */
-        "generator-star-spacing": ["error", { before: false, after: true }],
-
-        /**
-         * Enforce the location of arrow function bodies with implicit returns 🔧
-         * https://eslint.org/docs/latest/rules/implicit-arrow-linebreak.
-         */
-        "implicit-arrow-linebreak": "off",
-
-        /**
-         * This option sets a specific tab width for your code 🔧
-         * https://eslint.org/docs/latest/rules/indent.
-         */
-        indent: ["error", 4, { SwitchCase: 1 }],
-
-        /**
-         * Specify whether double or single quotes should be used in JSX attributes 🔧
-         * https://eslint.org/docs/latest/rules/jsx-quotes.
-         */
-        "jsx-quotes": ["error", "prefer-double"],
-
-        /**
-         * Enforces spacing between keys and values in object literal properties 🔧
-         * https://eslint.org/docs/latest/rules/key-spacing.
-         */
-        "key-spacing": ["error", { beforeColon: false, afterColon: true }],
-
-        /**
-         * Require a space before & after certain keywords 🔧
-         * https://eslint.org/docs/latest/rules/keyword-spacing.
-         */
-        "keyword-spacing": [
-            "error",
-            {
-                before: true,
-                after: true,
-                overrides: {
-                    return: { after: true },
-                    throw: { after: true },
-                    case: { after: true },
-                },
-            },
-        ],
-
-        /**
-         * Enforce position of line comments
-         * https://eslint.org/docs/latest/rules/line-comment-position.
-         */
-        "line-comment-position": [
-            "off",
-            {
-                position: "above",
-                ignorePattern: "",
-                applyDefaultPatterns: true,
-            },
-        ],
-
-        /**
-         * Disallow mixed "LF" and "CRLF" as linebreaks 🔧
-         * https://eslint.org/docs/latest/rules/linebreak-style.
-         */
-        "linebreak-style": ["error", "unix"],
-
-        /**
-         * Enforces empty lines around comments 🔧
-         * https://eslint.org/docs/latest/rules/lines-around-comment.
-         */
-        "lines-around-comment": "off",
-
-        /**
-         * Require or disallow an empty line between class members 🔧
-         * https://eslint.org/docs/latest/rules/lines-between-class-members.
-         */
-        "lines-between-class-members": ["error", "always", { exceptAfterSingleLine: true }],
-
-        /**
-         * Specify the maximum length of a line in your program
-         * https://eslint.org/docs/latest/rules/max-len.
-         */
-        "max-len": [
-            "error",
-            {
-                code: 120,
-                tabWidth: 4,
-                ignoreUrls: true,
-                ignoreComments: false,
-                ignoreRegExpLiterals: true,
-                ignoreStrings: true,
-                ignoreTemplateLiterals: true,
-            },
-        ],
-
-        /**
-         * Restrict the number of statements per line
-         * https://eslint.org/docs/latest/rules/max-statements-per-line.
-         */
-        "max-statements-per-line": ["off", { max: 1 }],
-
-        /**
-         * Require multiline ternary 🔧
-         * https://eslint.org/docs/latest/rules/multiline-ternary.
-         */
-        "multiline-ternary": ["off", "never"],
-
-        /**
-         * Disallow the omission of parentheses when invoking a constructor with no arguments 🔧
-         * https://eslint.org/docs/latest/rules/new-parens.
-         */
-        "new-parens": "error",
-
-        /**
-         * Enforces new line after each method call in the chain to make it more readable and easy to maintain 🔧
-         * https://eslint.org/docs/latest/rules/newline-per-chained-call.
-         */
-        "newline-per-chained-call": ["error", { ignoreChainWithDepth: 3 }],
-
-        /**
-         * Disallow unnecessary parentheses 🔧
-         * https://eslint.org/docs/latest/rules/no-extra-parens.
-         */
-        "no-extra-parens": [
-            "off",
-            "all",
-            {
-                conditionalAssign: true,
-                nestedBinaryExpressions: false,
-                returnAssign: false,
-                ignoreJSX: "all", // delegate to eslint-plugin-react
-                enforceForArrowConditionals: false,
-            },
-        ],
-
-        /**
-         * Disallow mixed spaces and tabs for indentation ✅
-         * https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs.
-         */
-        "no-mixed-spaces-and-tabs": "error",
-
-        /**
-         * Disallow use of multiple spaces 🔧
-         * https://eslint.org/docs/latest/rules/no-multi-spaces.
-         */
-        "no-multi-spaces": ["error", { ignoreEOLComments: false }],
-
-        /**
-         * Disallow multiple empty lines, only one newline at the end, and no new lines at the beginning 🔧
-         * https://eslint.org/docs/latest/rules/no-multiple-empty-lines.
-         */
-        "no-multiple-empty-lines": ["error", { max: 1, maxBOF: 0, maxEOF: 0 }],
-
-        /**
-         * Disallow tab characters entirely
-         * https://eslint.org/docs/latest/rules/no-tabs.
-         */
-        "no-tabs": "error",
-
-        /**
-         * Disallow trailing whitespace at the end of lines 🔧
-         * https://eslint.org/docs/latest/rules/no-trailing-spaces.
-         */
-        "no-trailing-spaces": ["error", { skipBlankLines: false, ignoreComments: false }],
-
-        /**
-         * Disallow whitespace before properties 🔧
-         * https://eslint.org/docs/latest/rules/no-whitespace-before-property.
-         */
-        "no-whitespace-before-property": "error",
-
-        /**
-         * Enforce the location of single-line statements 🔧
-         * https://eslint.org/docs/latest/rules/nonblock-statement-body-position.
-         */
-        "nonblock-statement-body-position": ["error", "any", { overrides: {} }],
-
-        /**
-         * Enforce line breaks between braces. 🔧
-         * https://eslint.org/docs/latest/rules/object-curly-newline.
-         */
-        "object-curly-newline": [
-            "error",
-            {
-                ObjectExpression: { minProperties: 10, multiline: true, consistent: true },
-                ObjectPattern: { minProperties: 10, multiline: true, consistent: true },
-                ImportDeclaration: { minProperties: 10, multiline: true, consistent: true },
-                ExportDeclaration: { minProperties: 10, multiline: true, consistent: true },
-            },
-        ],
-
-        /**
-         * Require padding inside curly braces 🔧
-         * https://eslint.org/docs/latest/rules/object-curly-spacing.
-         */
-        "object-curly-spacing": ["error", "always"],
-
-        /**
-         * Enforce "same line" or "multiple line" on object properties. 🔧
-         * https://eslint.org/docs/latest/rules/object-property-newline.
-         */
-        "object-property-newline": ["error", { allowAllPropertiesOnSameLine: true }],
-
-        /**
-         * Requires operator at the beginning of the line in multiline statements 🔧
-         * https://eslint.org/docs/latest/rules/operator-linebreak.
-         */
-        "operator-linebreak": ["error", "after", { overrides: { "?": "before", ":": "before" } }],
-
-        /**
-         * Disallow padding within blocks 🔧
-         * https://eslint.org/docs/latest/rules/padded-blocks.
-         */
-        "padded-blocks": [
-            "error",
-            {
-                blocks: "never",
-                classes: "never",
-                switches: "never",
-            },
-            {
-                allowSingleLineBlocks: true,
-            },
-        ],
-
-        /**
-         * Require or disallow padding lines between statements 🔧
-         * https://eslint.org/docs/latest/rules/padding-line-between-statements.
-         */
-        "padding-line-between-statements": "off",
-
-        /**
-         * Specifies double quotes should be used 🔧
-         * https://eslint.org/docs/latest/rules/quotes.
-         */
-        quotes: ["error", "double", { avoidEscape: true }],
-
-        /**
-         * Enforce spacing between object rest-spread 🔧
-         * https://eslint.org/docs/latest/rules/rest-spread-spacing.
-         */
-        "rest-spread-spacing": ["error", "never"],
-
-        /**
-         * Require or disallow use of semicolons instead of ASI.
-         */
-        semi: ["error", "always"],
-
-        /**
-         * Enforce spacing before and after semicolons 🔧
-         * https://eslint.org/docs/latest/rules/semi-spacing.
-         */
-        "semi-spacing": ["error", { before: false, after: true }],
-
-        /**
-         * Enforce location of semicolons 🔧
-         * https://eslint.org/docs/latest/rules/semi-style.
-         */
-        "semi-style": ["error", "last"],
-
-        /**
-         * Require or disallow space before blocks 🔧
-         * https://eslint.org/docs/latest/rules/space-before-blocks.
-         */
-        "space-before-blocks": "error",
-
-        /**
-         * Require or disallow space before function opening parenthesis 🔧
-         * https://eslint.org/docs/latest/rules/space-before-function-paren.
-         */
-        "space-before-function-paren": ["error", { anonymous: "always", named: "never", asyncArrow: "always" }],
-
-        /**
-         * Require or disallow spaces inside parentheses 🔧
-         * https://eslint.org/docs/latest/rules/space-in-parens.
-         */
-        "space-in-parens": ["error", "never"],
-
-        /**
-         * Require spacing around infix operators 🔧
-         * https://eslint.org/docs/latest/rules/space-infix-ops.
-         */
-        "space-infix-ops": ["error", { int32Hint: false }],
-
-        /**
-         * Require or disallow spaces before/after unary operators 🔧
-         * https://eslint.org/docs/latest/rules/space-unary-ops.
-         */
-        "space-unary-ops": ["error", { words: true, nonwords: false, overrides: {} }],
-
-        /**
-         * Require or disallow a space immediately following the // or /* in a comment 🔧
-         * https://eslint.org/docs/latest/rules/spaced-comment.
-         */
-        "spaced-comment": [
-            "error",
-            "always",
-            {
-                line: {
-                    exceptions: ["-", "+"],
-                    markers: ["=", "!", "/"], // space here to support sprockets directives, slash for TS /// comments
-                },
-                block: {
-                    exceptions: ["-", "+"],
-                    markers: ["=", "!", ":", "::"], // space here to support sprockets directives and flow comment types
-                    balanced: true,
-                },
-            },
-        ],
-
-        /**
-         * Enforce spacing around colons of switch statements 🔧
-         * https://eslint.org/docs/latest/rules/switch-colon-spacing.
-         */
-        "switch-colon-spacing": ["error", { after: true, before: false }],
-
-        /**
-         * Enforce usage of spacing in template strings 🔧
-         * https://eslint.org/docs/latest/rules/template-curly-spacing.
-         */
-        "template-curly-spacing": "error",
-
-        /**
-         * Require or disallow spacing between template tags and their literals 🔧
-         * https://eslint.org/docs/latest/rules/template-tag-spacing.
-         */
-        "template-tag-spacing": ["error", "never"],
-
         /**
          * Require or disallow the Unicode Byte Order Mark 🔧
          * https://eslint.org/docs/latest/rules/unicode-bom.
@@ -1878,21 +1376,15 @@ module.exports = {
         "unicode-bom": ["error", "never"],
 
         /**
-         * Require immediate function invocation to be wrapped in parentheses 🔧
-         * https://eslint.org/docs/latest/rules/wrap-iife.
-         */
-        "wrap-iife": ["error", "inside", { functionPrototypeMethods: false }],
-
-        /**
-         * Require regex literals to be wrapped in parentheses 🔧
-         * https://eslint.org/docs/latest/rules/wrap-regex.
+         * Requires to declare all vars on top of their containing scope
+         * https://eslint.org/docs/latest/rules/vars-on-top.
          */
-        "wrap-regex": "off",
+        "vars-on-top": "error",
 
         /**
-         * Enforce spacing around the * in yield* expressions 🔧
-         * https://eslint.org/docs/latest/rules/yield-star-spacing.
+         * Require or disallow Yoda conditions 🔧
+         * https://eslint.org/docs/latest/rules/yoda.
          */
-        "yield-star-spacing": ["error", "after"],
+        yoda: "error",
     },
 };