@prowise/eslint-config-linting-rules 0.0.3 → 0.0.5

package/backend.js

@@ -5,11 +5,6 @@ module.exports = {
 
     env: { node: true },
 
-    globals: {
-        Atomics: "readonly",
-        SharedArrayBuffer: "readonly",
-    },
-
     plugins: ["eslint-plugin-node"],
 
     rules: { ...nodeRules },

package/frontend.js

@@ -6,6 +6,12 @@ module.exports = {
 
     env: { browser: true },
 
+    settings: {
+        react: {
+            version: "detect",
+        },
+    },
+
     globals: {
         Atomics: "readonly",
         SharedArrayBuffer: "readonly",

package/index.js

@@ -39,6 +39,14 @@ module.exports = {
         "jest/no-identical-title": "error",
         "jest/prefer-to-have-length": "warn",
         "jest/valid-expect": "error",
-        "prettier/prettier": ["error", { singleQuote: false, tabWidth: 4, printWidth: 120, trailingComma: "all" }],
+        "prettier/prettier": [
+            "error",
+            {
+                singleQuote: false,
+                tabWidth: 4,
+                printWidth: 120,
+                trailingComma: "all",
+            },
+        ],
     },
 };

package/package.json

@@ -1 +1 @@
-{"name":"@prowise/eslint-config-linting-rules","version":"0.0.3","description":"Default Prowise linting rules for npm packages.","main":"index.js","exports":{"./typescript":"./typescript.js","./backend":"./backend.js","./frontend":"./frontend.js"},"scripts":{"lint":"eslint ."},"repository":{"type":"git","url":"git+ssh://git@bitbucket.org/prowise/npm-linting-rules.git"},"author":"Prowise B.V.","license":"UNLICENSED","homepage":"https://bitbucket.org/prowise/npm-linting-rules#readme","dependencies":{"@typescript-eslint/eslint-plugin":"^5.36.2","@typescript-eslint/parser":"^5.36.2","confusing-browser-globals":"^1.0.11","eslint":"^8.23.0","eslint-import-resolver-typescript":"^3.5.1","eslint-plugin-import":"^2.26.0","eslint-plugin-jest":"^27.0.1","eslint-plugin-jsdoc":"^39.3.6","eslint-plugin-node":"^11.1.0","eslint-plugin-prefer-arrow":"^1.2.3","eslint-plugin-prettier":"^4.2.1","eslint-plugin-react":"^7.31.7","eslint-plugin-react-hooks":"^4.6.0","object.assign":"^4.1.4","prettier":"^2.7.1","semver":"^7.3.7"}}
+{"name":"@prowise/eslint-config-linting-rules","version":"0.0.5","description":"Default Prowise linting rules for npm packages.","main":"index.js","exports":{"./typescript":"./typescript.js","./backend":"./backend.js","./frontend":"./frontend.js"},"scripts":{"lint":"eslint ."},"repository":{"type":"git","url":"git+ssh://git@bitbucket.org/prowise/npm-linting-rules.git"},"author":"Prowise B.V.","license":"UNLICENSED","homepage":"https://bitbucket.org/prowise/npm-linting-rules#readme","dependencies":{"@typescript-eslint/eslint-plugin":"^5.36.2","@typescript-eslint/parser":"^5.36.2","confusing-browser-globals":"^1.0.11","eslint":"^8.23.0","eslint-import-resolver-typescript":"^3.5.1","eslint-plugin-import":"^2.26.0","eslint-plugin-jest":"^27.0.1","eslint-plugin-jsdoc":"^39.3.6","eslint-plugin-node":"^11.1.0","eslint-plugin-prefer-arrow":"^1.2.3","eslint-plugin-prettier":"^4.2.1","eslint-plugin-react":"^7.31.7","eslint-plugin-react-hooks":"^4.6.0","object.assign":"^4.1.4","prettier":"^2.7.1","semver":"^7.3.7"}}

package/src/rules/base-rules.js

@@ -482,7 +482,7 @@ module.exports = {
          * Enforces use of function declarations
          * https://eslint.org/docs/latest/rules/func-style.
          */
-        "func-style": ["error", "declaration"],
+        "func-style": ["error", "declaration", { allowArrowFunctions: true }],
 
         /**
          * Require grouped accessor pairs in object literals and classes
@@ -545,7 +545,15 @@ module.exports = {
          * Enforce a maximum function length
          * https://eslint.org/docs/latest/rules/max-lines-per-function.
          */
-        "max-lines-per-function": ["off", { max: 50, skipBlankLines: true, skipComments: true, IIFEs: true }],
+        "max-lines-per-function": [
+            "off",
+            {
+                max: 50,
+                skipBlankLines: true,
+                skipComments: true,
+                IIFEs: true,
+            },
+        ],
 
         /**
          * Specify the maximum depth callbacks can be nested
@@ -1786,10 +1794,10 @@ module.exports = {
         "object-curly-newline": [
             "error",
             {
-                ObjectExpression: { minProperties: 5, multiline: true, consistent: true },
-                ObjectPattern: { minProperties: 5, multiline: true, consistent: true },
-                ImportDeclaration: { minProperties: 5, multiline: true, consistent: true },
-                ExportDeclaration: { minProperties: 5, multiline: true, consistent: true },
+                ObjectExpression: { minProperties: 4, multiline: true, consistent: true },
+                ObjectPattern: { minProperties: 4, multiline: true, consistent: true },
+                ImportDeclaration: { minProperties: 4, multiline: true, consistent: true },
+                ExportDeclaration: { minProperties: 4, multiline: true, consistent: true },
             },
         ],
 

package/src/rules/plugin-import-rules.js

@@ -293,7 +293,13 @@ module.exports = {
             "error",
             {
                 groups: [["builtin", "external", "internal"]],
-                alphabetize: { order: "asc", caseInsensitive: true },
+                pathGroups: [
+                    {
+                        pattern: "react",
+                        group: "external",
+                        position: "before",
+                    },
+                ],
             },
         ],
 
@@ -301,7 +307,7 @@ module.exports = {
          * Require modules with a single export to use a default export
          * https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/prefer-default-export.md.
          */
-        "import/prefer-default-export": "error",
+        "import/prefer-default-export": "off",
 
         /**
          * Warn if a module could be mistakenly parsed as a script by a consumer

package/src/rules/plugin-react-rules.js

@@ -130,7 +130,7 @@ module.exports = {
         "react/function-component-definition": [
             "error",
             {
-                namedComponents: ["function-declaration", "function-expression"],
+                namedComponents: ["function-declaration", "function-expression", "arrow-function"],
                 unnamedComponents: "function-expression",
             },
         ],
@@ -540,7 +540,7 @@ module.exports = {
          * Disallow file extensions that may contain JSX
          * https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md.
          */
-        "react/jsx-filename-extension": ["error", { extensions: [".jsx"] }],
+        "react/jsx-filename-extension": ["error", { extensions: [".jsx", ".tsx"] }],
 
         /**
          * Enforce proper position of the first property in JSX

package/src/rules/plugin-typescript-rules.js

@@ -676,13 +676,13 @@ module.exports = {
          * Require private members to be marked as readonly if they"re never modified outside of the constructor 🔧 💭
          * https://typescript-eslint.io/rules/prefer-readonly.
          */
-        "@typescript-eslint/prefer-readonly": "warn",
+        "@typescript-eslint/prefer-readonly": ["warn", { ignoreInferredTypes: true }],
 
         /**
          * Require function parameters to be typed as readonly to prevent accidental mutation of inputs 💭
          * https://typescript-eslint.io/rules/prefer-readonly-parameter-types.
          */
-        "@typescript-eslint/prefer-readonly-parameter-types": "warn",
+        "@typescript-eslint/prefer-readonly-parameter-types": ["warn", { ignoreInferredTypes: true }],
 
         /**
          * Enforce using type parameter when calling Array#reduce instead of casting 🔒 🔧 💭