@prowi/deskcheck 0.3.0 → 0.4.0

package/build/services/review/ReviewPartitionerService.js

@@ -0,0 +1,208 @@
+import { query, createSdkMcpServer, tool } from "@anthropic-ai/claude-agent-sdk";
+import { z } from "zod";
+import { buildPartitionerPrompt } from "../../prompts/PartitionerPrompt.js";
+// =============================================================================
+// Errors
+// =============================================================================
+/** Thrown when the partitioner agent fails or produces invalid output. */
+export class PartitionerError extends Error {
+    /** The criterion id this failure was scoped to. */
+    reviewId;
+    constructor(reviewId, message) {
+        super(`Partitioner failed for criterion "${reviewId}": ${message}`);
+        this.name = "PartitionerError";
+        this.reviewId = reviewId;
+    }
+}
+// =============================================================================
+// ReviewPartitionerService
+// =============================================================================
+/**
+ * Spawns one fresh Claude agent per criterion to decide how to split the
+ * matched files into reviewer subtasks. The agent reads the criterion's
+ * `partition` instruction (natural language) and uses built-in tools
+ * (Read, Grep, Glob, Bash) to inspect files when grouping requires it.
+ *
+ * Output is delivered via an in-process MCP tool `submit_partition`. If the
+ * agent never calls the tool, or calls it with invalid output (e.g. drops a
+ * file), this service throws — partitioner failures fail the whole run.
+ */
+export class ReviewPartitionerService {
+    config;
+    projectRoot;
+    constructor(config, projectRoot) {
+        this.config = config;
+        this.projectRoot = projectRoot;
+    }
+    /**
+     * Run the partitioner for one criterion. Returns the validated partition
+     * result, or throws on failure.
+     */
+    async partition(criterion, matchedFiles, scope) {
+        if (matchedFiles.length === 0) {
+            throw new PartitionerError(criterion.id, "matchedFiles is empty");
+        }
+        let captured = null;
+        let captureError = null;
+        const inputFileSet = new Set(matchedFiles);
+        // In-process MCP tool the partitioner agent calls to deliver its output.
+        const partitionerServer = createSdkMcpServer({
+            name: "deskcheck-partitioner",
+            version: "0.1.0",
+            tools: [
+                tool("submit_partition", "Submit the final partition for this criterion. Call exactly once.", {
+                    reasoning: z
+                        .string()
+                        .describe("Short overall explanation of how you split the files."),
+                    subtasks: z
+                        .array(z.object({
+                        files: z
+                            .array(z.string())
+                            .describe("Files assigned to this subtask. At least one."),
+                        focus: z
+                            .string()
+                            .nullable()
+                            .optional()
+                            .describe("Optional sub-file narrowing (method name, class name, region). Null if the whole file is the unit."),
+                        hint: z
+                            .string()
+                            .nullable()
+                            .optional()
+                            .describe("One short sentence explaining why these files belong together."),
+                    }))
+                        .min(1)
+                        .describe("Non-empty list of subtasks."),
+                }, async (args) => {
+                    // Validate locally so we can return a useful error to the agent
+                    // (and abort with a clear message if it never recovers).
+                    const normalized = args.subtasks.map((s) => ({
+                        files: s.files,
+                        focus: s.focus ?? null,
+                        hint: s.hint ?? null,
+                    }));
+                    const validationError = validatePartition(normalized, inputFileSet);
+                    if (validationError) {
+                        captureError = validationError;
+                        return {
+                            content: [{
+                                    type: "text",
+                                    text: `Error: ${validationError}. Please call submit_partition again with a corrected partition.`,
+                                }],
+                            isError: true,
+                        };
+                    }
+                    captured = { reasoning: args.reasoning, subtasks: normalized };
+                    captureError = null;
+                    return {
+                        content: [{
+                                type: "text",
+                                text: `Accepted: ${normalized.length} subtask(s).`,
+                            }],
+                    };
+                }),
+            ],
+        });
+        const partitionerModel = this.config.agents.partitioner.model ?? "haiku";
+        const systemPrompt = buildPartitionerPrompt(criterion, matchedFiles, scope);
+        const abortController = new AbortController();
+        const timeout = setTimeout(() => abortController.abort(), 5 * 60 * 1000);
+        let usage = null;
+        const messages = [];
+        try {
+            for await (const message of query({
+                prompt: `Partition the files for criterion ${criterion.id}.`,
+                options: {
+                    model: partitionerModel,
+                    systemPrompt,
+                    tools: [
+                        "Read",
+                        "Grep",
+                        "Glob",
+                        "Bash",
+                        "mcp__deskcheck-partitioner__*",
+                    ],
+                    permissionMode: "bypassPermissions",
+                    maxTurns: 15,
+                    cwd: this.projectRoot,
+                    persistSession: false,
+                    abortController,
+                    mcpServers: {
+                        "deskcheck-partitioner": partitionerServer,
+                    },
+                },
+            })) {
+                messages.push(message);
+                if (message.type === "result") {
+                    const msg = message;
+                    const u = msg.usage;
+                    usage = {
+                        input_tokens: u?.input_tokens ?? 0,
+                        output_tokens: u?.output_tokens ?? 0,
+                        cache_read_tokens: u?.cache_read_input_tokens ?? 0,
+                        cache_creation_tokens: u?.cache_creation_input_tokens ?? 0,
+                        cost_usd: msg.total_cost_usd ?? 0,
+                        duration_ms: msg.duration_ms ?? 0,
+                        duration_api_ms: msg.duration_api_ms ?? 0,
+                        num_turns: msg.num_turns ?? 0,
+                        model: partitionerModel,
+                    };
+                    if (message.subtype !== "success") {
+                        throw new PartitionerError(criterion.id, `agent ended with subtype "${message.subtype}"`);
+                    }
+                }
+            }
+        }
+        finally {
+            clearTimeout(timeout);
+        }
+        // TS narrows `captured` to `never` because all assignments happen inside
+        // the MCP tool handler closure — control-flow analysis doesn't follow
+        // those. Cast through unknown to read the runtime value.
+        const finalCaptured = captured;
+        if (!finalCaptured) {
+            const detail = captureError
+                ? `agent never produced a valid partition. Last validation error: ${captureError}`
+                : "agent did not call submit_partition";
+            throw new PartitionerError(criterion.id, detail);
+        }
+        return {
+            reasoning: finalCaptured.reasoning,
+            subtasks: finalCaptured.subtasks,
+            model: partitionerModel,
+            usage,
+            messages,
+        };
+    }
+}
+// =============================================================================
+// Validation
+// =============================================================================
+/**
+ * Verify a candidate partition covers every input file at least once and
+ * has well-formed subtasks. Returns a human-readable error string or null
+ * if the partition is valid.
+ */
+export function validatePartition(subtasks, inputFiles) {
+    if (subtasks.length === 0) {
+        return "subtasks must be non-empty";
+    }
+    const seen = new Set();
+    for (let i = 0; i < subtasks.length; i++) {
+        const sub = subtasks[i];
+        if (!Array.isArray(sub.files) || sub.files.length === 0) {
+            return `subtask ${i} has no files`;
+        }
+        for (const file of sub.files) {
+            if (!inputFiles.has(file)) {
+                return `subtask ${i} references file "${file}" which is not in the input list`;
+            }
+            seen.add(file);
+        }
+    }
+    const missing = [...inputFiles].filter((f) => !seen.has(f));
+    if (missing.length > 0) {
+        return `${missing.length} input file(s) missing from partition: ${missing.slice(0, 5).join(", ")}${missing.length > 5 ? "…" : ""}`;
+    }
+    return null;
+}
+//# sourceMappingURL=ReviewPartitionerService.js.map

package/build/services/review/ReviewPartitionerService.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ReviewPartitionerService.js","sourceRoot":"","sources":["../../../src/services/review/ReviewPartitionerService.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,kBAAkB,EAAE,IAAI,EAAE,MAAM,gCAAgC,CAAC;AACjF,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EAAE,sBAAsB,EAAE,MAAM,oCAAoC,CAAC;AAwB5E,gFAAgF;AAChF,SAAS;AACT,gFAAgF;AAEhF,0EAA0E;AAC1E,MAAM,OAAO,gBAAiB,SAAQ,KAAK;IACzC,mDAAmD;IAC1C,QAAQ,CAAS;IAE1B,YAAY,QAAgB,EAAE,OAAe;QAC3C,KAAK,CAAC,qCAAqC,QAAQ,MAAM,OAAO,EAAE,CAAC,CAAC;QACpE,IAAI,CAAC,IAAI,GAAG,kBAAkB,CAAC;QAC/B,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC3B,CAAC;CACF;AAED,gFAAgF;AAChF,2BAA2B;AAC3B,gFAAgF;AAEhF;;;;;;;;;GASG;AACH,MAAM,OAAO,wBAAwB;IAClB,MAAM,CAAe;IACrB,WAAW,CAAS;IAErC,YAAY,MAAoB,EAAE,WAAmB;QACnD,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;IACjC,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,SAAS,CACb,SAAuB,EACvB,YAAsB,EACtB,KAAY;QAEZ,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC9B,MAAM,IAAI,gBAAgB,CAAC,SAAS,CAAC,EAAE,EAAE,uBAAuB,CAAC,CAAC;QACpE,CAAC;QAMD,IAAI,QAAQ,GAA6B,IAAI,CAAC;QAC9C,IAAI,YAAY,GAAkB,IAAI,CAAC;QACvC,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC,YAAY,CAAC,CAAC;QAE3C,yEAAyE;QACzE,MAAM,iBAAiB,GAAG,kBAAkB,CAAC;YAC3C,IAAI,EAAE,uBAAuB;YAC7B,OAAO,EAAE,OAAO;YAChB,KAAK,EAAE;gBACL,IAAI,CACF,kBAAkB,EAClB,mEAAmE,EACnE;oBACE,SAAS,EAAE,CAAC;yBACT,MAAM,EAAE;yBACR,QAAQ,CAAC,uDAAuD,CAAC;oBACpE,QAAQ,EAAE,CAAC;yBACR,KAAK,CACJ,CAAC,CAAC,MAAM,CAAC;wBACP,KAAK,EAAE,CAAC;6BACL,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;6BACjB,QAAQ,CAAC,+CAA+C,CAAC;wBAC5D,KAAK,EAAE,CAAC;6BACL,MAAM,EAAE;6BACR,QAAQ,EAAE;6BACV,QAAQ,EAAE;6BACV,QAAQ,CACP,oGAAoG,CACrG;wBACH,IAAI,EAAE,CAAC;6BACJ,MAAM,EAAE;6BACR,QAAQ,EAAE;6BACV,QAAQ,EAAE;6BACV,QAAQ,CAAC,gEAAgE,CAAC;qBAC9E,CAAC,CACH;yBACA,GAAG,CAAC,CAAC,CAAC;yBACN,QAAQ,CAAC,6BAA6B,CAAC;iBAC3C,EACD,KAAK,EAAE,IAAI,EAAE,EAAE;oBACb,gEAAgE;oBAChE,yDAAyD;oBACzD,MAAM,UAAU,GAAyB,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;wBACjE,KAAK,EAAE,CAAC,CAAC,KAAK;wBACd,KAAK,EAAE,CAAC,CAAC,KAAK,IAAI,IAAI;wBACtB,IAAI,EAAE,CAAC,CAAC,IAAI,IAAI,IAAI;qBACrB,CAAC,CAAC,CAAC;oBAEJ,MAAM,eAAe,GAAG,iBAAiB,CAAC,UAAU,EAAE,YAAY,CAAC,CAAC;oBACpE,IAAI,eAAe,EAAE,CAAC;wBACpB,YAAY,GAAG,eAAe,CAAC;wBAC/B,OAAO;4BACL,OAAO,EAAE,CAAC;oCACR,IAAI,EAAE,MAAe;oCACrB,IAAI,EAAE,UAAU,eAAe,kEAAkE;iCAClG,CAAC;4BACF,OAAO,EAAE,IAAI;yBACd,CAAC;oBACJ,CAAC;oBAED,QAAQ,GAAG,EAAE,SAAS,EAAE,IAAI,CAAC,SAAS,EAAE,QAAQ,EAAE,UAAU,EAAE,CAAC;oBAC/D,YAAY,GAAG,IAAI,CAAC;oBAEpB,OAAO;wBACL,OAAO,EAAE,CAAC;gCACR,IAAI,EAAE,MAAe;gCACrB,IAAI,EAAE,aAAa,UAAU,CAAC,MAAM,cAAc;6BACnD,CAAC;qBACH,CAAC;gBACJ,CAAC,CACF;aACF;SACF,CAAC,CAAC;QAEH,MAAM,gBAAgB,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,KAAK,IAAI,OAAO,CAAC;QACzE,MAAM,YAAY,GAAG,sBAAsB,CAAC,SAAS,EAAE,YAAY,EAAE,KAAK,CAAC,CAAC;QAE5E,MAAM,eAAe,GAAG,IAAI,eAAe,EAAE,CAAC;QAC9C,MAAM,OAAO,GAAG,UAAU,CAAC,GAAG,EAAE,CAAC,eAAe,CAAC,KAAK,EAAE,EAAE,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;QAEzE,IAAI,KAAK,GAAqB,IAAI,CAAC;QACnC,MAAM,QAAQ,GAAc,EAAE,CAAC;QAE/B,IAAI,CAAC;YACH,IAAI,KAAK,EAAE,MAAM,OAAO,IAAI,KAAK,CAAC;gBAChC,MAAM,EAAE,qCAAqC,SAAS,CAAC,EAAE,GAAG;gBAC5D,OAAO,EAAE;oBACP,KAAK,EAAE,gBAAgB;oBACvB,YAAY;oBACZ,KAAK,EAAE;wBACL,MAAM;wBACN,MAAM;wBACN,MAAM;wBACN,MAAM;wBACN,+BAA+B;qBAChC;oBACD,cAAc,EAAE,mBAAmB;oBACnC,QAAQ,EAAE,EAAE;oBACZ,GAAG,EAAE,IAAI,CAAC,WAAW;oBACrB,cAAc,EAAE,KAAK;oBACrB,eAAe;oBACf,UAAU,EAAE;wBACV,uBAAuB,EAAE,iBAAiB;qBAC3C;iBACF;aACF,CAAC,EAAE,CAAC;gBACH,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;gBACvB,IAAI,OAAO,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBAC9B,MAAM,GAAG,GAAG,OAAkC,CAAC;oBAC/C,MAAM,CAAC,GAAG,GAAG,CAAC,KAA2C,CAAC;oBAC1D,KAAK,GAAG;wBACN,YAAY,EAAE,CAAC,EAAE,YAAY,IAAI,CAAC;wBAClC,aAAa,EAAE,CAAC,EAAE,aAAa,IAAI,CAAC;wBACpC,iBAAiB,EAAE,CAAC,EAAE,uBAAuB,IAAI,CAAC;wBAClD,qBAAqB,EAAE,CAAC,EAAE,2BAA2B,IAAI,CAAC;wBAC1D,QAAQ,EAAG,GAAG,CAAC,cAAyB,IAAI,CAAC;wBAC7C,WAAW,EAAG,GAAG,CAAC,WAAsB,IAAI,CAAC;wBAC7C,eAAe,EAAG,GAAG,CAAC,eAA0B,IAAI,CAAC;wBACrD,SAAS,EAAG,GAAG,CAAC,SAAoB,IAAI,CAAC;wBACzC,KAAK,EAAE,gBAAgB;qBACxB,CAAC;oBAEF,IAAI,OAAO,CAAC,OAAO,KAAK,SAAS,EAAE,CAAC;wBAClC,MAAM,IAAI,gBAAgB,CACxB,SAAS,CAAC,EAAE,EACZ,6BAA6B,OAAO,CAAC,OAAO,GAAG,CAChD,CAAC;oBACJ,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,OAAO,CAAC,CAAC;QACxB,CAAC;QAED,yEAAyE;QACzE,sEAAsE;QACtE,yDAAyD;QACzD,MAAM,aAAa,GAAG,QAA+C,CAAC;QACtE,IAAI,CAAC,aAAa,EAAE,CAAC;YACnB,MAAM,MAAM,GAAG,YAAY;gBACzB,CAAC,CAAC,kEAAkE,YAAY,EAAE;gBAClF,CAAC,CAAC,qCAAqC,CAAC;YAC1C,MAAM,IAAI,gBAAgB,CAAC,SAAS,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;QACnD,CAAC;QAED,OAAO;YACL,SAAS,EAAE,aAAa,CAAC,SAAS;YAClC,QAAQ,EAAE,aAAa,CAAC,QAAQ;YAChC,KAAK,EAAE,gBAAgB;YACvB,KAAK;YACL,QAAQ;SACT,CAAC;IACJ,CAAC;CACF;AAED,gFAAgF;AAChF,aAAa;AACb,gFAAgF;AAEhF;;;;GAIG;AACH,MAAM,UAAU,iBAAiB,CAC/B,QAA8B,EAC9B,UAAuB;IAEvB,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC1B,OAAO,4BAA4B,CAAC;IACtC,CAAC;IAED,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACzC,MAAM,GAAG,GAAG,QAAQ,CAAC,CAAC,CAAE,CAAC;QACzB,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,GAAG,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACxD,OAAO,WAAW,CAAC,eAAe,CAAC;QACrC,CAAC;QACD,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,KAAK,EAAE,CAAC;YAC7B,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC1B,OAAO,WAAW,CAAC,qBAAqB,IAAI,kCAAkC,CAAC;YACjF,CAAC;YACD,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACjB,CAAC;IACH,CAAC;IAED,MAAM,OAAO,GAAG,CAAC,GAAG,UAAU,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5D,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACvB,OAAO,GAAG,OAAO,CAAC,MAAM,0CAA0C,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,OAAO,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;IACrI,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC"}

package/build/services/review/ReviewPlanBuilderService.d.ts

@@ -1,13 +1,31 @@
 import { ReviewStorageService } from "./ReviewStorageService.js";
+import { ReviewPartitionerService } from "./ReviewPartitionerService.js";
 import type { ReviewModule } from "../../types/criteria.js";
-import type { ReviewPlan, ReviewSource } from "../../types/review.js";
+import type { PartitionDecision, PlanInvocation, ReviewPlan, Scope } from "../../types/review.js";
 /**
- * Build a complete review plan: create the plan, match files to modules,
- * generate tasks, and finalize.
+ * Hooks called as the plan builder progresses through its steps. Used by
+ * the CLI to print live status. Optional.
+ */
+export interface PartitionProgressEvents {
+    /** Fires once after glob matching, before partitioning starts. */
+    onMatchingComplete?: (matchedCriteria: number, matchedFiles: number) => void;
+    /** Fires when each per-criterion partitioner starts. */
+    onPartitionStarted?: (reviewId: string, fileCount: number) => void;
+    /** Fires when each per-criterion partitioner finishes successfully. */
+    onPartitionCompleted?: (decision: PartitionDecision) => void;
+}
+/**
+ * Build a complete review plan: create the plan, glob-match files to
+ * criteria, run one partitioner agent per matched criterion to produce
+ * subtasks, write everything to storage, and finalize.
+ *
+ * Partitioners run concurrently with `Promise.all`. ALL partitioners must
+ * complete before any tasks are added — this is a deliberate barrier so
+ * that downstream reviewers see a fully-partitioned plan and so that the
+ * partitioning step can be inspected as a unit (e.g. via `--dry-run`).
  *
- * This is the single authoritative implementation of plan+task creation,
- * shared by both the planner agent's in-process MCP tool and any other
- * entry point that needs to create a plan from a file list.
+ * If any partitioner throws, the error propagates and the plan is left in
+ * its pre-finalized state. Per design, partitioner failures fail the run.
  */
-export declare function buildPlanWithTasks(storage: ReviewStorageService, name: string, source: ReviewSource, files: string[], modules: ReviewModule[]): ReviewPlan;
+export declare function buildPlanWithTasks(storage: ReviewStorageService, partitioner: ReviewPartitionerService, name: string, scope: Scope, invocation: PlanInvocation, files: string[], modules: ReviewModule[], events?: PartitionProgressEvents): Promise<ReviewPlan>;
 //# sourceMappingURL=ReviewPlanBuilderService.d.ts.map

package/build/services/review/ReviewPlanBuilderService.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ReviewPlanBuilderService.d.ts","sourceRoot":"","sources":["../../../src/services/review/ReviewPlanBuilderService.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAC5D,OAAO,KAAK,EAEV,UAAU,EACV,YAAY,EACb,MAAM,uBAAuB,CAAC;AAE/B;;;;;;;GAOG;AACH,wBAAgB,kBAAkB,CAChC,OAAO,EAAE,oBAAoB,EAC7B,IAAI,EAAE,MAAM,EACZ,MAAM,EAAE,YAAY,EACpB,KAAK,EAAE,MAAM,EAAE,EACf,OAAO,EAAE,YAAY,EAAE,GACtB,UAAU,CA6DZ"}
+{"version":3,"file":"ReviewPlanBuilderService.d.ts","sourceRoot":"","sources":["../../../src/services/review/ReviewPlanBuilderService.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,wBAAwB,EAAoB,MAAM,+BAA+B,CAAC;AAC3F,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAC5D,OAAO,KAAK,EAEV,iBAAiB,EACjB,cAAc,EACd,UAAU,EACV,KAAK,EACN,MAAM,uBAAuB,CAAC;AAE/B;;;GAGG;AACH,MAAM,WAAW,uBAAuB;IACtC,kEAAkE;IAClE,kBAAkB,CAAC,EAAE,CAAC,eAAe,EAAE,MAAM,EAAE,YAAY,EAAE,MAAM,KAAK,IAAI,CAAC;IAC7E,wDAAwD;IACxD,kBAAkB,CAAC,EAAE,CAAC,QAAQ,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,KAAK,IAAI,CAAC;IACnE,uEAAuE;IACvE,oBAAoB,CAAC,EAAE,CAAC,QAAQ,EAAE,iBAAiB,KAAK,IAAI,CAAC;CAC9D;AAED;;;;;;;;;;;;GAYG;AACH,wBAAsB,kBAAkB,CACtC,OAAO,EAAE,oBAAoB,EAC7B,WAAW,EAAE,wBAAwB,EACrC,IAAI,EAAE,MAAM,EACZ,KAAK,EAAE,KAAK,EACZ,UAAU,EAAE,cAAc,EAC1B,KAAK,EAAE,MAAM,EAAE,EACf,OAAO,EAAE,YAAY,EAAE,EACvB,MAAM,CAAC,EAAE,uBAAuB,GAC/B,OAAO,CAAC,UAAU,CAAC,CA8HrB"}

package/build/services/review/ReviewPlanBuilderService.js

@@ -1,17 +1,24 @@
 import { findMatchingModules } from "../criteria/glob-matcher.js";
+import { PartitionerError } from "./ReviewPartitionerService.js";
 /**
- * Build a complete review plan: create the plan, match files to modules,
- * generate tasks, and finalize.
+ * Build a complete review plan: create the plan, glob-match files to
+ * criteria, run one partitioner agent per matched criterion to produce
+ * subtasks, write everything to storage, and finalize.
  *
- * This is the single authoritative implementation of plan+task creation,
- * shared by both the planner agent's in-process MCP tool and any other
- * entry point that needs to create a plan from a file list.
+ * Partitioners run concurrently with `Promise.all`. ALL partitioners must
+ * complete before any tasks are added — this is a deliberate barrier so
+ * that downstream reviewers see a fully-partitioned plan and so that the
+ * partitioning step can be inspected as a unit (e.g. via `--dry-run`).
+ *
+ * If any partitioner throws, the error propagates and the plan is left in
+ * its pre-finalized state. Per design, partitioner failures fail the run.
  */
-export function buildPlanWithTasks(storage, name, source, files, modules) {
-    // Create the plan shell
-    const plan = storage.createPlan(name, source);
-    // Match files against criteria
+export async function buildPlanWithTasks(storage, partitioner, name, scope, invocation, files, modules, events) {
+    // Create the plan shell — already at step "matching" by default.
+    const plan = storage.createPlan(name, scope, invocation);
+    // Match files against criteria (programmatic, no LLM)
     const matches = findMatchingModules(files, modules);
+    events?.onMatchingComplete?.(matches.length, new Set(matches.flatMap((m) => m.matchedFiles)).size);
     // Track coverage
     const matchedFileSet = new Set();
     for (const match of matches) {
@@ -28,39 +35,90 @@ export function buildPlanWithTasks(storage, name, source, files, modules) {
         moduleSummaries[match.module.id] = {
             review_id: match.module.id,
             description: match.module.description,
-            severity: match.module.severity,
             model: match.module.model,
+            partition: match.module.partition,
             task_count: 0,
             matched_files: match.matchedFiles,
         };
     }
     storage.setModules(plan.plan_id, moduleSummaries);
-    // Create tasks based on module mode
-    for (const match of matches) {
-        const isGrouped = match.module.mode.toLowerCase().includes("grouped") ||
-            match.module.mode.toLowerCase().includes("all files");
-        if (isGrouped) {
+    // ---------------------------------------------------------------------------
+    // Partition step — one fresh agent per matched criterion, all in parallel.
+    // Must complete entirely before any tasks are added. If anything throws,
+    // we stamp the failure on the plan so the UI can render it before
+    // re-raising for the CLI to surface.
+    // ---------------------------------------------------------------------------
+    storage.setStep(plan.plan_id, "partitioning");
+    let decisions;
+    try {
+        decisions = await Promise.all(matches.map(async (match) => {
+            events?.onPartitionStarted?.(match.module.id, match.matchedFiles.length);
+            const result = await partitioner.partition(match.module, match.matchedFiles, scope);
+            // Persist the partitioner's full SDK transcript as a side-file.
+            try {
+                storage.writePartitionerLog(plan.plan_id, match.module.id, result.messages);
+            }
+            catch (logErr) {
+                console.error(`[deskcheck] Warning: failed to write partitioner log for ${match.module.id}: ${logErr instanceof Error ? logErr.message : String(logErr)}`);
+            }
+            const decision = {
+                review_id: match.module.id,
+                matched_files: match.matchedFiles,
+                reasoning: result.reasoning,
+                subtasks: result.subtasks,
+                completed_at: new Date().toISOString(),
+                model: result.model,
+                usage: result.usage,
+            };
+            storage.setPartitionDecision(plan.plan_id, decision);
+            events?.onPartitionCompleted?.(decision);
+            return decision;
+        }));
+    }
+    catch (err) {
+        const message = err instanceof Error ? err.message : String(err);
+        const reviewId = err instanceof PartitionerError ? err.reviewId : null;
+        storage.setFailure(plan.plan_id, {
+            step: "partitioning",
+            review_id: reviewId,
+            message,
+        });
+        throw err;
+    }
+    // ---------------------------------------------------------------------------
+    // Materialize partitioner output as ReviewTasks. We do this after all
+    // partitioners finish so storage writes are batched and the plan is never
+    // half-partitioned on disk.
+    // ---------------------------------------------------------------------------
+    for (let i = 0; i < matches.length; i++) {
+        const match = matches[i];
+        const decision = decisions[i];
+        for (const subtask of decision.subtasks) {
             storage.addTask(plan.plan_id, {
                 review_id: match.module.id,
                 review_file: match.module.file,
-                files: match.matchedFiles,
-                hint: null,
+                files: subtask.files,
+                focus: subtask.focus,
+                hint: subtask.hint,
                 model: match.module.model,
+                tools: match.module.tools,
+                prompt: match.module.prompt,
             });
         }
-        else {
-            for (const file of match.matchedFiles) {
-                storage.addTask(plan.plan_id, {
-                    review_id: match.module.id,
-                    review_file: match.module.file,
-                    files: [file],
-                    hint: null,
-                    model: match.module.model,
-                });
-            }
-        }
     }
-    // Finalize the plan (sets status to "ready", recounts tasks per module)
-    return storage.finalizePlan(plan.plan_id);
+    // Finalize the plan (sets status to "ready", recounts tasks per module).
+    // After finalize, the orchestrator takes over — it flips step to "complete"
+    // when all tasks reach a terminal state. We set "reviewing" here as the
+    // intermediate so the UI sees the transition immediately on plan load.
+    const finalized = storage.finalizePlan(plan.plan_id);
+    if (Object.keys(finalized.tasks).length > 0) {
+        storage.setStep(plan.plan_id, "reviewing");
+    }
+    else {
+        // No tasks (no criteria matched, or all partitioners produced empty
+        // sets — though the validator forbids the latter). Mark complete.
+        storage.setStep(plan.plan_id, "complete");
+    }
+    return storage.getPlan(plan.plan_id);
 }
 //# sourceMappingURL=ReviewPlanBuilderService.js.map

package/build/services/review/ReviewPlanBuilderService.js.map

@@ -1 +1 @@
-{"version":3,"file":"ReviewPlanBuilderService.js","sourceRoot":"","sources":["../../../src/services/review/ReviewPlanBuilderService.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAC;AASlE;;;;;;;GAOG;AACH,MAAM,UAAU,kBAAkB,CAChC,OAA6B,EAC7B,IAAY,EACZ,MAAoB,EACpB,KAAe,EACf,OAAuB;IAEvB,wBAAwB;IACxB,MAAM,IAAI,GAAG,OAAO,CAAC,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IAE9C,+BAA+B;IAC/B,MAAM,OAAO,GAAG,mBAAmB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC;IAEpD,iBAAiB;IACjB,MAAM,cAAc,GAAG,IAAI,GAAG,EAAU,CAAC;IACzC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,KAAK,MAAM,IAAI,IAAI,KAAK,CAAC,YAAY,EAAE,CAAC;YACtC,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC;IACH,CAAC;IACD,MAAM,YAAY,GAAG,CAAC,GAAG,cAAc,CAAC,CAAC,IAAI,EAAE,CAAC;IAChD,MAAM,cAAc,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC1E,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC,OAAO,EAAE,YAAY,EAAE,cAAc,CAAC,CAAC;IAEpE,uBAAuB;IACvB,MAAM,eAAe,GAAkC,EAAE,CAAC;IAC1D,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,eAAe,CAAC,KAAK,CAAC,MAAM,CAAC,EAAE,CAAC,GAAG;YACjC,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE;YAC1B,WAAW,EAAE,KAAK,CAAC,MAAM,CAAC,WAAW;YACrC,QAAQ,EAAE,KAAK,CAAC,MAAM,CAAC,QAAQ;YAC/B,KAAK,EAAE,KAAK,CAAC,MAAM,CAAC,KAAK;YACzB,UAAU,EAAE,CAAC;YACb,aAAa,EAAE,KAAK,CAAC,YAAY;SAClC,CAAC;IACJ,CAAC;IACD,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,OAAO,EAAE,eAAe,CAAC,CAAC;IAElD,oCAAoC;IACpC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,MAAM,SAAS,GACb,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC;YACnD,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC;QAExD,IAAI,SAAS,EAAE,CAAC;YACd,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,EAAE;gBAC5B,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE;gBAC1B,WAAW,EAAE,KAAK,CAAC,MAAM,CAAC,IAAI;gBAC9B,KAAK,EAAE,KAAK,CAAC,YAAY;gBACzB,IAAI,EAAE,IAAI;gBACV,KAAK,EAAE,KAAK,CAAC,MAAM,CAAC,KAAK;aAC1B,CAAC,CAAC;QACL,CAAC;aAAM,CAAC;YACN,KAAK,MAAM,IAAI,IAAI,KAAK,CAAC,YAAY,EAAE,CAAC;gBACtC,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,EAAE;oBAC5B,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE;oBAC1B,WAAW,EAAE,KAAK,CAAC,MAAM,CAAC,IAAI;oBAC9B,KAAK,EAAE,CAAC,IAAI,CAAC;oBACb,IAAI,EAAE,IAAI;oBACV,KAAK,EAAE,KAAK,CAAC,MAAM,CAAC,KAAK;iBAC1B,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC;IAED,wEAAwE;IACxE,OAAO,OAAO,CAAC,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;AAC5C,CAAC"}
+{"version":3,"file":"ReviewPlanBuilderService.js","sourceRoot":"","sources":["../../../src/services/review/ReviewPlanBuilderService.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAC;AAElE,OAAO,EAA4B,gBAAgB,EAAE,MAAM,+BAA+B,CAAC;AAuB3F;;;;;;;;;;;;GAYG;AACH,MAAM,CAAC,KAAK,UAAU,kBAAkB,CACtC,OAA6B,EAC7B,WAAqC,EACrC,IAAY,EACZ,KAAY,EACZ,UAA0B,EAC1B,KAAe,EACf,OAAuB,EACvB,MAAgC;IAEhC,iEAAiE;IACjE,MAAM,IAAI,GAAG,OAAO,CAAC,UAAU,CAAC,IAAI,EAAE,KAAK,EAAE,UAAU,CAAC,CAAC;IAEzD,sDAAsD;IACtD,MAAM,OAAO,GAAG,mBAAmB,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC;IACpD,MAAM,EAAE,kBAAkB,EAAE,CAC1B,OAAO,CAAC,MAAM,EACd,IAAI,GAAG,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CACrD,CAAC;IAEF,iBAAiB;IACjB,MAAM,cAAc,GAAG,IAAI,GAAG,EAAU,CAAC;IACzC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,KAAK,MAAM,IAAI,IAAI,KAAK,CAAC,YAAY,EAAE,CAAC;YACtC,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC;IACH,CAAC;IACD,MAAM,YAAY,GAAG,CAAC,GAAG,cAAc,CAAC,CAAC,IAAI,EAAE,CAAC;IAChD,MAAM,cAAc,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC1E,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC,OAAO,EAAE,YAAY,EAAE,cAAc,CAAC,CAAC;IAEpE,uBAAuB;IACvB,MAAM,eAAe,GAAkC,EAAE,CAAC;IAC1D,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,eAAe,CAAC,KAAK,CAAC,MAAM,CAAC,EAAE,CAAC,GAAG;YACjC,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE;YAC1B,WAAW,EAAE,KAAK,CAAC,MAAM,CAAC,WAAW;YACrC,KAAK,EAAE,KAAK,CAAC,MAAM,CAAC,KAAK;YACzB,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,SAAS;YACjC,UAAU,EAAE,CAAC;YACb,aAAa,EAAE,KAAK,CAAC,YAAY;SAClC,CAAC;IACJ,CAAC;IACD,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,OAAO,EAAE,eAAe,CAAC,CAAC;IAElD,8EAA8E;IAC9E,2EAA2E;IAC3E,yEAAyE;IACzE,kEAAkE;IAClE,qCAAqC;IACrC,8EAA8E;IAE9E,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,EAAE,cAAc,CAAC,CAAC;IAE9C,IAAI,SAA8B,CAAC;IACnC,IAAI,CAAC;QACH,SAAS,GAAG,MAAM,OAAO,CAAC,GAAG,CAC3B,OAAO,CAAC,GAAG,CAAC,KAAK,EAAE,KAAK,EAA8B,EAAE;YACtD,MAAM,EAAE,kBAAkB,EAAE,CAAC,KAAK,CAAC,MAAM,CAAC,EAAE,EAAE,KAAK,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC;YACzE,MAAM,MAAM,GAAG,MAAM,WAAW,CAAC,SAAS,CACxC,KAAK,CAAC,MAAM,EACZ,KAAK,CAAC,YAAY,EAClB,KAAK,CACN,CAAC;YAEF,gEAAgE;YAChE,IAAI,CAAC;gBACH,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,OAAO,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,QAAQ,CAAC,CAAC;YAC9E,CAAC;YAAC,OAAO,MAAM,EAAE,CAAC;gBAChB,OAAO,CAAC,KAAK,CACX,4DAA4D,KAAK,CAAC,MAAM,CAAC,EAAE,KAAK,MAAM,YAAY,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,EAAE,CAC5I,CAAC;YACJ,CAAC;YAED,MAAM,QAAQ,GAAsB;gBAClC,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE;gBAC1B,aAAa,EAAE,KAAK,CAAC,YAAY;gBACjC,SAAS,EAAE,MAAM,CAAC,SAAS;gBAC3B,QAAQ,EAAE,MAAM,CAAC,QAAQ;gBACzB,YAAY,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;gBACtC,KAAK,EAAE,MAAM,CAAC,KAAK;gBACnB,KAAK,EAAE,MAAM,CAAC,KAAK;aACpB,CAAC;YACF,OAAO,CAAC,oBAAoB,CAAC,IAAI,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;YACrD,MAAM,EAAE,oBAAoB,EAAE,CAAC,QAAQ,CAAC,CAAC;YACzC,OAAO,QAAQ,CAAC;QAClB,CAAC,CAAC,CACH,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,MAAM,QAAQ,GAAG,GAAG,YAAY,gBAAgB,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC;QACvE,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,OAAO,EAAE;YAC/B,IAAI,EAAE,cAAc;YACpB,SAAS,EAAE,QAAQ;YACnB,OAAO;SACR,CAAC,CAAC;QACH,MAAM,GAAG,CAAC;IACZ,CAAC;IAED,8EAA8E;IAC9E,sEAAsE;IACtE,0EAA0E;IAC1E,4BAA4B;IAC5B,8EAA8E;IAE9E,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACxC,MAAM,KAAK,GAAG,OAAO,CAAC,CAAC,CAAE,CAAC;QAC1B,MAAM,QAAQ,GAAG,SAAS,CAAC,CAAC,CAAE,CAAC;QAC/B,KAAK,MAAM,OAAO,IAAI,QAAQ,CAAC,QAAQ,EAAE,CAAC;YACxC,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,EAAE;gBAC5B,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE;gBAC1B,WAAW,EAAE,KAAK,CAAC,MAAM,CAAC,IAAI;gBAC9B,KAAK,EAAE,OAAO,CAAC,KAAK;gBACpB,KAAK,EAAE,OAAO,CAAC,KAAK;gBACpB,IAAI,EAAE,OAAO,CAAC,IAAI;gBAClB,KAAK,EAAE,KAAK,CAAC,MAAM,CAAC,KAAK;gBACzB,KAAK,EAAE,KAAK,CAAC,MAAM,CAAC,KAAK;gBACzB,MAAM,EAAE,KAAK,CAAC,MAAM,CAAC,MAAM;aAC5B,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,yEAAyE;IACzE,4EAA4E;IAC5E,wEAAwE;IACxE,uEAAuE;IACvE,MAAM,SAAS,GAAG,OAAO,CAAC,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACrD,IAAI,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5C,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,EAAE,WAAW,CAAC,CAAC;IAC7C,CAAC;SAAM,CAAC;QACN,oEAAoE;QACpE,kEAAkE;QAClE,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;IAC5C,CAAC;IACD,OAAO,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;AACvC,CAAC"}

package/build/services/review/ReviewStorageService.d.ts

@@ -1,4 +1,4 @@
-import type { ContextType, Issue, ModuleSummary, ReviewPlan, ReviewResults, ReviewSource, ReviewTask, TaskUsage } from "../../types/review.js";
+import type { Issue, ModuleSummary, PartitionDecision, PipelineStep, PlanFailure, PlanInvocation, ReviewPlan, ReviewResults, ReviewTask, Scope, TaskUsage } from "../../types/review.js";
 /**
  * Manages the two-file storage format (plan.json + results.json) for deskcheck runs.
  *
@@ -29,7 +29,7 @@ export declare class ReviewStorageService {
      * Creates the timestamped directory and writes an initial plan.json with
      * status "planning" and empty collections.
      */
-    createPlan(name: string, source: ReviewSource): ReviewPlan;
+    createPlan(name: string, scope: Scope, invocation: PlanInvocation): ReviewPlan;
     /** Read the plan.json for a given plan ID. */
     getPlan(planId: string): ReviewPlan;
     /**
@@ -56,18 +56,42 @@ export declare class ReviewStorageService {
      * appending a zero-padded incrementing suffix (e.g., "-001", "-002").
      * The task is created with status "pending" and null context fields.
      */
-    addTask(planId: string, task: Omit<ReviewTask, "task_id" | "status" | "created_at" | "started_at" | "completed_at" | "context" | "context_type" | "symbol" | "prompt">): ReviewTask;
+    addTask(planId: string, task: Omit<ReviewTask, "task_id" | "status" | "created_at" | "started_at" | "completed_at" | "scope" | "focus" | "tools" | "error" | "prompt"> & {
+        focus?: string | null;
+        tools?: string[];
+        prompt?: string | null;
+    }): ReviewTask;
+    /** Record a partitioner decision for one criterion. */
+    setPartitionDecision(planId: string, decision: PartitionDecision): void;
+    /**
+     * Update the pipeline step the plan is currently in. When transitioning
+     * to a terminal step (`complete`/`failed`), also promotes `status` to the
+     * matching terminal value and stamps `completed_at` if not already set —
+     * this keeps the invariant `step terminal ⟺ status terminal`.
+     */
+    setStep(planId: string, step: PipelineStep): void;
+    /**
+     * Mark the plan as failed at a specific step. Sets `status = "failed"`,
+     * `step = "failed"`, and stamps the failure details. Idempotent — if the
+     * plan is already failed, the new failure overwrites the old.
+     */
+    setFailure(planId: string, failure: PlanFailure): void;
+    /** Persist the full SDK message stream from one reviewer's run. */
+    writeTaskLog(planId: string, taskId: string, messages: unknown[]): void;
+    /** Read a previously persisted reviewer transcript. */
+    getTaskLog(planId: string, taskId: string): unknown[];
+    /** Persist the full SDK message stream from one partitioner's run. */
+    writePartitionerLog(planId: string, reviewId: string, messages: unknown[]): void;
+    /** Read a previously persisted partitioner transcript. */
+    getPartitionerLog(planId: string, reviewId: string): unknown[];
     /**
      * Claim a pending task for execution.
      *
-     * Sets the task status to "in_progress", fills in the context fields
-     * (context type, content, symbol, prompt), and records the start time.
+     * Sets the task status to "in_progress", records the start time, and
+     * optionally stores the criterion prompt for later inspection.
      */
-    claimTask(planId: string, taskId: string, context: {
-        contextType: ContextType;
-        content: string;
-        symbol?: string;
-        prompt: string;
+    claimTask(planId: string, taskId: string, options?: {
+        prompt?: string;
     }): ReviewTask;
     /**
      * Return tasks eligible for execution: those with status "pending" or

package/build/services/review/ReviewStorageService.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ReviewStorageService.d.ts","sourceRoot":"","sources":["../../../src/services/review/ReviewStorageService.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EACV,WAAW,EACX,KAAK,EAGL,aAAa,EACb,UAAU,EACV,aAAa,EACb,YAAY,EACZ,UAAU,EAEV,SAAS,EAEV,MAAM,uBAAuB,CAAC;AAsC/B;;;;;;GAMG;AACH,qBAAa,oBAAoB;IAC/B,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAS;IAEpC,+EAA+E;IAC/E,OAAO,CAAC,MAAM,CAAC,WAAW,CAAqB;gBAanC,UAAU,EAAE,MAAM;IAI9B;;;;;;;;OAQG;IACH,OAAO,CAAC,QAAQ;IAoDhB,yCAAyC;IACzC,OAAO,CAAC,OAAO;IAQf;;;;;OAKG;IACH,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,MAAM,EAAE,YAAY,GAAG,UAAU;IA0B1D,8CAA8C;IAC9C,OAAO,CAAC,MAAM,EAAE,MAAM,GAAG,UAAU;IAMnC;;;OAGG;IACH,eAAe,IAAI,MAAM,GAAG,IAAI;IAsBhC,0CAA0C;IAC1C,SAAS,IAAI,KAAK,CAAC;QACjB,MAAM,EAAE,MAAM,CAAC;QACf,IAAI,EAAE,MAAM,CAAC;QACb,MAAM,EAAE,MAAM,CAAC;QACf,SAAS,EAAE,MAAM,CAAC;KACnB,CAAC;IAqCF;;;OAGG;IACH,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,UAAU;IAsBxC;;;;;;OAMG;IACH,OAAO,CACL,MAAM,EAAE,MAAM,EACd,IAAI,EAAE,IAAI,CACR,UAAU,EACR,SAAS,GACT,QAAQ,GACR,YAAY,GACZ,YAAY,GACZ,cAAc,GACd,SAAS,GACT,cAAc,GACd,QAAQ,GACR,QAAQ,CACX,GACA,UAAU;IAkCb;;;;;OAKG;IACH,SAAS,CACP,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,MAAM,EACd,OAAO,EAAE;QACP,WAAW,EAAE,WAAW,CAAC;QACzB,OAAO,EAAE,MAAM,CAAC;QAChB,MAAM,CAAC,EAAE,MAAM,CAAC;QAChB,MAAM,EAAE,MAAM,CAAC;KAChB,GACA,UAAU;IA6Bb;;;OAGG;IACH,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,UAAU,EAAE;IAkB7C;;;;;;OAMG;IACH,YAAY,CACV,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,KAAK,EAAE,EACf,KAAK,CAAC,EAAE,SAAS,GAAG,IAAI,GACvB,IAAI;IAiDP;;;;;;OAMG;IACH,SAAS,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,YAAY,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,SAAS,GAAG,IAAI,GAAG,IAAI;IA8C/F,iDAAiD;IACjD,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,aAAa;IAgBzC,4DAA4D;IAC5D,eAAe,CACb,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,EAAE,EACjB,SAAS,EAAE,MAAM,EAAE,GAClB,IAAI;IASP,gDAAgD;IAChD,UAAU,CACR,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,CAAC,GACrC,IAAI;IAYP,OAAO,CAAC,QAAQ;IAIhB,OAAO,CAAC,WAAW;IAInB,OAAO,CAAC,SAAS;IAOjB,OAAO,CAAC,YAAY;IAOpB,OAAO,CAAC,kBAAkB;IAkC1B;;OAEG;IACH,OAAO,CAAC,mBAAmB;IAW3B;;;;;;;OAOG;IACH,OAAO,CAAC,qBAAqB;CAkI9B"}
+{"version":3,"file":"ReviewStorageService.d.ts","sourceRoot":"","sources":["../../../src/services/review/ReviewStorageService.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EACV,KAAK,EAGL,aAAa,EACb,iBAAiB,EACjB,YAAY,EACZ,WAAW,EACX,cAAc,EACd,UAAU,EACV,aAAa,EACb,UAAU,EACV,KAAK,EAEL,SAAS,EAEV,MAAM,uBAAuB,CAAC;AAsC/B;;;;;;GAMG;AACH,qBAAa,oBAAoB;IAC/B,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAS;IAEpC,+EAA+E;IAC/E,OAAO,CAAC,MAAM,CAAC,WAAW,CAAqB;gBAanC,UAAU,EAAE,MAAM;IAI9B;;;;;;;;OAQG;IACH,OAAO,CAAC,QAAQ;IAoDhB,yCAAyC;IACzC,OAAO,CAAC,OAAO;IAQf;;;;;OAKG;IACH,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,KAAK,EAAE,UAAU,EAAE,cAAc,GAAG,UAAU;IA8B9E,8CAA8C;IAC9C,OAAO,CAAC,MAAM,EAAE,MAAM,GAAG,UAAU;IAMnC;;;OAGG;IACH,eAAe,IAAI,MAAM,GAAG,IAAI;IAsBhC,0CAA0C;IAC1C,SAAS,IAAI,KAAK,CAAC;QACjB,MAAM,EAAE,MAAM,CAAC;QACf,IAAI,EAAE,MAAM,CAAC;QACb,MAAM,EAAE,MAAM,CAAC;QACf,SAAS,EAAE,MAAM,CAAC;KACnB,CAAC;IAqCF;;;OAGG;IACH,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,UAAU;IAsBxC;;;;;;OAMG;IACH,OAAO,CACL,MAAM,EAAE,MAAM,EACd,IAAI,EAAE,IAAI,CACR,UAAU,EACR,SAAS,GACT,QAAQ,GACR,YAAY,GACZ,YAAY,GACZ,cAAc,GACd,OAAO,GACP,OAAO,GACP,OAAO,GACP,OAAO,GACP,QAAQ,CACX,GAAG;QAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,EAAE,CAAC;QAAC,MAAM,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;KAAE,GACtE,UAAU;IAmCb,uDAAuD;IACvD,oBAAoB,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,iBAAiB,GAAG,IAAI;IAQvE;;;;;OAKG;IACH,OAAO,CAAC,MAAM,EAAE,MAAM,EAAE,IAAI,EAAE,YAAY,GAAG,IAAI;IAejD;;;;OAIG;IACH,UAAU,CAAC,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,WAAW,GAAG,IAAI;IAoBtD,mEAAmE;IACnE,YAAY,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,OAAO,EAAE,GAAG,IAAI;IAOvE,uDAAuD;IACvD,UAAU,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,GAAG,OAAO,EAAE;IAMrD,sEAAsE;IACtE,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,QAAQ,EAAE,OAAO,EAAE,GAAG,IAAI;IAUhF,0DAA0D;IAC1D,iBAAiB,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,GAAG,OAAO,EAAE;IAS9D;;;;;OAKG;IACH,SAAS,CACP,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,MAAM,EACd,OAAO,CAAC,EAAE;QAAE,MAAM,CAAC,EAAE,MAAM,CAAA;KAAE,GAC5B,UAAU;IA4Bb;;;OAGG;IACH,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,UAAU,EAAE;IAkB7C;;;;;;OAMG;IACH,YAAY,CACV,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,KAAK,EAAE,EACf,KAAK,CAAC,EAAE,SAAS,GAAG,IAAI,GACvB,IAAI;IAkDP;;;;;;OAMG;IACH,SAAS,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,YAAY,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,SAAS,GAAG,IAAI,GAAG,IAAI;IAgD/F,iDAAiD;IACjD,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,aAAa;IAgBzC,4DAA4D;IAC5D,eAAe,CACb,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,EAAE,EACjB,SAAS,EAAE,MAAM,EAAE,GAClB,IAAI;IASP,gDAAgD;IAChD,UAAU,CACR,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,aAAa,CAAC,GACrC,IAAI;IAYP,OAAO,CAAC,QAAQ;IAIhB,OAAO,CAAC,WAAW;IAInB,OAAO,CAAC,SAAS;IAOjB,OAAO,CAAC,YAAY;IAOpB,OAAO,CAAC,kBAAkB;IAkC1B;;OAEG;IACH,OAAO,CAAC,mBAAmB;IAW3B;;;;;;;OAOG;IACH,OAAO,CAAC,qBAAqB;CAiI9B"}