@protontech/drive-sdk 0.14.1 → 0.14.3

package/src/internal/upload/fileUploader.ts

@@ -5,6 +5,7 @@ import { UploadController } from './controller';
 import { UploadCryptoService } from './cryptoService';
 import { NodeRevisionDraft } from './interface';
 import { UploadManager } from './manager';
+import { SmallFileRevisionUploader, SmallFileUploader } from './smallFileUploader';
 import { StreamUploader } from './streamUploader';
 import { UploadTelemetry } from './telemetry';
 
@@ -26,6 +27,7 @@ export abstract class Uploader {
         protected manager: UploadManager,
         protected metadata: UploadMetadata,
         protected onFinish: () => void,
+        protected shouldUseSmallFileUpload: (expectedSize: number) => Promise<boolean>,
         protected signal?: AbortSignal,
     ) {
         this.telemetry = telemetry;
@@ -34,6 +36,7 @@ export abstract class Uploader {
         this.manager = manager;
         this.metadata = metadata;
         this.onFinish = onFinish;
+        this.shouldUseSmallFileUpload = shouldUseSmallFileUpload;
 
         this.signal = signal;
         this.abortController = new AbortController();
@@ -97,10 +100,28 @@ export abstract class Uploader {
         thumbnails: Thumbnail[],
         onProgress?: (uploadedBytes: number) => void,
     ): Promise<{ nodeRevisionUid: string; nodeUid: string }> {
+        const expectedEncryptedTotalSize = this.getExpectedEncryptedTotalSize(thumbnails);
+        if (await this.shouldUseSmallFileUpload(expectedEncryptedTotalSize)) {
+            return this.initSmallFileUploader(stream, thumbnails, onProgress);
+        }
+
         const uploader = await this.initStreamUploader();
         return uploader.start(stream, thumbnails, onProgress);
     }
 
+    private getExpectedEncryptedTotalSize(thumbnails: Thumbnail[]): number {
+        const thumbnailSize = thumbnails.reduce((acc, thumbnail) => acc + thumbnail.thumbnail.length, 0);
+        const totalSize = this.metadata.expectedSize + thumbnailSize;
+        const expectedEncryptedTotalSize = totalSize * 1.1; // 10% margin for encryption overhead
+        return expectedEncryptedTotalSize;
+    }
+
+    protected abstract initSmallFileUploader(
+        stream: ReadableStream,
+        thumbnails: Thumbnail[],
+        onProgress?: (uploadedBytes: number) => void,
+    ): Promise<{ nodeRevisionUid: string; nodeUid: string }>;
+
     protected async initStreamUploader(): Promise<StreamUploader> {
         const { revisionDraft, blockVerifier } = await this.createRevisionDraft();
 
@@ -154,9 +175,10 @@ export class FileUploader extends Uploader {
         private name: string,
         metadata: UploadMetadata,
         onFinish: () => void,
+        protected shouldUseSmallFileUpload: (expectedSize: number) => Promise<boolean>,
         signal?: AbortSignal,
     ) {
-        super(telemetry, apiService, cryptoService, manager, metadata, onFinish, signal);
+        super(telemetry, apiService, cryptoService, manager, metadata, onFinish, shouldUseSmallFileUpload, signal);
 
         this.parentFolderUid = parentFolderUid;
         this.name = name;
@@ -192,6 +214,24 @@ export class FileUploader extends Uploader {
     protected async deleteRevisionDraft(revisionDraft: NodeRevisionDraft): Promise<void> {
         await this.manager.deleteDraftNode(revisionDraft.nodeUid);
     }
+
+    protected async initSmallFileUploader(
+        stream: ReadableStream,
+        thumbnails: Thumbnail[],
+        onProgress?: (uploadedBytes: number) => void,
+    ): Promise<{ nodeRevisionUid: string; nodeUid: string }> {
+        const uploader = new SmallFileUploader(
+            this.telemetry,
+            this.cryptoService,
+            this.manager,
+            this.metadata,
+            this.onFinish,
+            this.signal,
+            this.parentFolderUid,
+            this.name,
+        );
+        return uploader.upload(stream, thumbnails, onProgress);
+    }
 }
 
 /**
@@ -206,9 +246,10 @@ export class FileRevisionUploader extends Uploader {
         private nodeUid: string,
         metadata: UploadMetadata,
         onFinish: () => void,
+        protected shouldUseSmallFileUpload: (expectedSize: number) => Promise<boolean>,
         signal?: AbortSignal,
     ) {
-        super(telemetry, apiService, cryptoService, manager, metadata, onFinish, signal);
+        super(telemetry, apiService, cryptoService, manager, metadata, onFinish, shouldUseSmallFileUpload, signal);
 
         this.nodeUid = nodeUid;
     }
@@ -243,4 +284,21 @@ export class FileRevisionUploader extends Uploader {
     protected async deleteRevisionDraft(revisionDraft: NodeRevisionDraft): Promise<void> {
         await this.manager.deleteDraftRevision(revisionDraft.nodeRevisionUid);
     }
+
+    protected async initSmallFileUploader(
+        stream: ReadableStream,
+        thumbnails: Thumbnail[],
+        onProgress?: (uploadedBytes: number) => void,
+    ): Promise<{ nodeRevisionUid: string; nodeUid: string }> {
+        const uploader = new SmallFileRevisionUploader(
+            this.telemetry,
+            this.cryptoService,
+            this.manager,
+            this.metadata,
+            this.onFinish,
+            this.signal,
+            this.nodeUid,
+        );
+        return uploader.upload(stream, thumbnails, onProgress);
+    }
 }

package/src/internal/upload/index.test.ts

@@ -1,18 +1,23 @@
-import { FeatureFlagProvider, FeatureFlags, UploadMetadata } from '../../interface';
+import { FeatureFlagProvider, ThumbnailType, UploadMetadata } from '../../interface';
 import { getMockTelemetry } from '../../tests/telemetry';
-import { FileRevisionUploader, FileUploader } from './fileUploader';
+import { FileRevisionUploader, FileUploader, Uploader } from './fileUploader';
 import { initUploadModule } from './index';
-import { SmallFileRevisionUploader, SmallFileUploader } from './smallFileUploader';
 
-const SMALL_FILE_SIZE_LIMIT = 128 * 1024; // 128 KiB, must match index.ts
+const RAW_SMALL_FILE_SIZE_LIMIT = (128 * 1024) / 1.1; // 128 KiB, must match index.ts
 
-describe('initUploadModule - uploader selection', () => {
+describe('initUploadModule', () => {
     const parentFolderUid = 'parent-folder-uid';
     const name = 'test-file.txt';
     const nodeUid = 'node-uid';
 
     let featureFlagProvider: jest.Mocked<FeatureFlagProvider>;
     let uploadModule: ReturnType<typeof initUploadModule>;
+    let initSmallFileSpy: jest.SpyInstance;
+    let initSmallRevisionSpy: jest.SpyInstance;
+    let initStreamSpy: jest.SpyInstance;
+
+    let stream: ReadableStream;
+    const thumbnail100k = { type: ThumbnailType.Type1, thumbnail: new Uint8Array(100_000) };
 
     beforeEach(() => {
         const apiService = {};
@@ -31,69 +36,122 @@ describe('initUploadModule - uploader selection', () => {
             nodesService as any,
             featureFlagProvider as any,
         );
-    });
-
-    describe('getFileUploader', () => {
-        it('returns SmallFileUploader when feature flag is enabled and file size is below limit', async () => {
-            featureFlagProvider.isEnabled.mockResolvedValue(true);
 
-            const metadata: UploadMetadata = { expectedSize: 1, mediaType: 'text/plain' };
-            const uploader = await uploadModule.getFileUploader(parentFolderUid, name, metadata);
-
-            expect(uploader).toBeInstanceOf(SmallFileUploader);
+        initSmallFileSpy = jest.spyOn(FileUploader.prototype as any, 'initSmallFileUploader').mockResolvedValue({
+            nodeRevisionUid: 'revision-uid',
+            nodeUid: 'node-uid',
         });
-
-        it('returns FileUploader when feature flag is enabled but file size exceeds limit', async () => {
-            featureFlagProvider.isEnabled.mockResolvedValue(true);
-
-            const metadata: UploadMetadata = {
-                expectedSize: SMALL_FILE_SIZE_LIMIT,
-                mediaType: 'text/plain',
-            };
-            const uploader = await uploadModule.getFileUploader(parentFolderUid, name, metadata);
-
-            expect(uploader).toBeInstanceOf(FileUploader);
-        });
-
-        it('returns FileUploader when feature flag is disabled even for small file', async () => {
-            featureFlagProvider.isEnabled.mockResolvedValue(false);
-
-            const metadata: UploadMetadata = { expectedSize: 1, mediaType: 'text/plain' };
-            const uploader = await uploadModule.getFileUploader(parentFolderUid, name, metadata);
-
-            expect(uploader).toBeInstanceOf(FileUploader);
+        initSmallRevisionSpy = jest
+            .spyOn(FileRevisionUploader.prototype as any, 'initSmallFileUploader')
+            .mockResolvedValue({
+                nodeRevisionUid: 'revision-uid',
+                nodeUid: 'node-uid',
+            });
+        initStreamSpy = jest.spyOn(Uploader.prototype as any, 'initStreamUploader').mockResolvedValue({
+            start: jest.fn().mockResolvedValue({
+                nodeRevisionUid: 'revision-uid',
+                nodeUid: 'node-uid',
+            }),
+        } as any);
+
+        stream = new ReadableStream({
+            start(controller) {
+                controller.close();
+            },
         });
     });
 
-    describe('getFileRevisionUploader', () => {
-        it('returns SmallFileRevisionUploader when feature flag is enabled and file size is below limit', async () => {
-            featureFlagProvider.isEnabled.mockResolvedValue(true);
-
-            const metadata: UploadMetadata = { expectedSize: 1, mediaType: 'text/plain' };
-            const uploader = await uploadModule.getFileRevisionUploader(nodeUid, metadata);
-
-            expect(uploader).toBeInstanceOf(SmallFileRevisionUploader);
-        });
-
-        it('returns FileRevisionUploader when feature flag is enabled but file size exceeds limit', async () => {
-            featureFlagProvider.isEnabled.mockResolvedValue(true);
-
-            const metadata: UploadMetadata = {
-                expectedSize: SMALL_FILE_SIZE_LIMIT + 1,
-                mediaType: 'text/plain',
-            };
-            const uploader = await uploadModule.getFileRevisionUploader(nodeUid, metadata);
-
-            expect(uploader).toBeInstanceOf(FileRevisionUploader);
-        });
-
-        it('returns FileRevisionUploader when feature flag is disabled even for small file', async () => {
-            featureFlagProvider.isEnabled.mockResolvedValue(false);
-
-            const metadata: UploadMetadata = { expectedSize: 1, mediaType: 'text/plain' };
-            const uploader = await uploadModule.getFileRevisionUploader(nodeUid, metadata);
+    afterEach(() => {
+        jest.restoreAllMocks();
+    });
 
-            expect(uploader).toBeInstanceOf(FileRevisionUploader);
+    async function drainUpload(controller: { completion(): Promise<unknown> }) {
+        await controller.completion();
+    }
+
+    const suites = [
+        {
+            method: 'getFileUploader',
+            getUploader: (metadata: UploadMetadata) => uploadModule.getFileUploader(parentFolderUid, name, metadata),
+            expect: (option: 'small' | 'stream') => {
+                if (option === 'stream') {
+                    expect(initStreamSpy).toHaveBeenCalled();
+                    expect(initSmallFileSpy).not.toHaveBeenCalled();
+                    expect(initSmallRevisionSpy).not.toHaveBeenCalled();
+                } else {
+                    expect(initSmallFileSpy).toHaveBeenCalled();
+                    expect(initStreamSpy).not.toHaveBeenCalled();
+                    expect(initSmallRevisionSpy).not.toHaveBeenCalled();
+                }
+            },
+        },
+        {
+            method: 'getFileRevisionUploader',
+            getUploader: (metadata: UploadMetadata) => uploadModule.getFileRevisionUploader(nodeUid, metadata),
+            expect: (option: 'small' | 'stream') => {
+                if (option === 'stream') {
+                    expect(initStreamSpy).toHaveBeenCalled();
+                    expect(initSmallFileSpy).not.toHaveBeenCalled();
+                    expect(initSmallRevisionSpy).not.toHaveBeenCalled();
+                } else {
+                    expect(initSmallRevisionSpy).toHaveBeenCalled();
+                    expect(initSmallFileSpy).not.toHaveBeenCalled();
+                    expect(initStreamSpy).not.toHaveBeenCalled();
+                }
+            },
+        },
+    ];
+    for (const suite of suites) {
+        describe(suite.method, () => {
+            it('uses stream path when feature flag is disabled even for small file', async () => {
+                featureFlagProvider.isEnabled.mockResolvedValue(false);
+
+                const metadata: UploadMetadata = { expectedSize: 1, mediaType: 'text/plain' };
+                const uploader = await suite.getUploader(metadata);
+                await drainUpload(await uploader.uploadFromStream(stream, []));
+
+                suite.expect('stream');
+            });
+
+            it('uses small-file path when flag is on and encrypted total size is below cap', async () => {
+                featureFlagProvider.isEnabled.mockResolvedValue(true);
+
+                const metadata: UploadMetadata = { expectedSize: 100, mediaType: 'text/plain' };
+                const uploader = await suite.getUploader(metadata);
+                await drainUpload(await uploader.uploadFromStream(stream, []));
+
+                suite.expect('small');
+            });
+
+            it('uses small-file path when flag is on and encrypted total size with thumbnails is below cap', async () => {
+                featureFlagProvider.isEnabled.mockResolvedValue(true);
+
+                const metadata: UploadMetadata = { expectedSize: 100, mediaType: 'image/jpeg' };
+                const uploader = await suite.getUploader(metadata);
+                await drainUpload(await uploader.uploadFromStream(stream, [thumbnail100k]));
+
+                suite.expect('small');
+            });
+
+            it('uses stream path when feature flag is enabled but raw file size exceeds limit', async () => {
+                featureFlagProvider.isEnabled.mockResolvedValue(true);
+
+                const metadata: UploadMetadata = { expectedSize: RAW_SMALL_FILE_SIZE_LIMIT, mediaType: 'text/plain' };
+                const uploader = await suite.getUploader(metadata);
+                await drainUpload(await uploader.uploadFromStream(stream, []));
+
+                suite.expect('stream');
+            });
+
+            it('uses stream path when thumbnail bytes push encrypted total size with thumbnail exceeds limit', async () => {
+                featureFlagProvider.isEnabled.mockResolvedValue(true);
+
+                const metadata: UploadMetadata = { expectedSize: 100_000, mediaType: 'image/jpeg' };
+                const uploader = await suite.getUploader(metadata);
+                await drainUpload(await uploader.uploadFromStream(stream, [thumbnail100k]));
+
+                suite.expect('stream');
+            });
         });
-    });
+    }
 });

package/src/internal/upload/index.ts

@@ -8,7 +8,6 @@ import { FileUploader as FileUploaderClass, FileRevisionUploader } from './fileU
 import { NodesService, SharesService } from './interface';
 import { UploadManager } from './manager';
 import { UploadQueue } from './queue';
-import { SmallFileRevisionUploader, SmallFileUploader } from './smallFileUploader';
 import { UploadTelemetry } from './telemetry';
 
 const SMALL_FILE_SIZE_LIMIT = 128 * 1024; // 128 KiB
@@ -38,13 +37,13 @@ export function initUploadModule(
 
     const queue = new UploadQueue();
 
-    async function useSmallFileUpload(metadata: UploadMetadata): Promise<boolean> {
+    async function shouldUseSmallFileUpload(expectedSize: number): Promise<boolean> {
         const isEnabled =
             allowSmallFileUpload && (await featureFlagProvider.isEnabled(FeatureFlags.DriveSmallFileUpload));
         if (!isEnabled) {
             return false;
         }
-        return metadata.expectedSize < SMALL_FILE_SIZE_LIMIT;
+        return expectedSize < SMALL_FILE_SIZE_LIMIT;
     }
 
     /**
@@ -66,20 +65,6 @@ export function initUploadModule(
             queue.releaseCapacity(metadata.expectedSize);
         };
 
-        if (await useSmallFileUpload(metadata)) {
-            return new SmallFileUploader(
-                uploadTelemetry,
-                api,
-                cryptoService,
-                manager,
-                metadata,
-                onFinish,
-                signal,
-                parentFolderUid,
-                name,
-            );
-        }
-
         return new FileUploaderClass(
             uploadTelemetry,
             api,
@@ -89,6 +74,7 @@ export function initUploadModule(
             name,
             metadata,
             onFinish,
+            shouldUseSmallFileUpload,
             signal,
         );
     }
@@ -111,19 +97,6 @@ export function initUploadModule(
             queue.releaseCapacity(metadata.expectedSize);
         };
 
-        if (await useSmallFileUpload(metadata)) {
-            return new SmallFileRevisionUploader(
-                uploadTelemetry,
-                api,
-                cryptoService,
-                manager,
-                metadata,
-                onFinish,
-                signal,
-                nodeUid,
-            );
-        }
-
         return new FileRevisionUploader(
             uploadTelemetry,
             api,
@@ -132,6 +105,7 @@ export function initUploadModule(
             nodeUid,
             metadata,
             onFinish,
+            shouldUseSmallFileUpload,
             signal,
         );
     }

package/src/internal/upload/smallFileUploader.test.ts

@@ -6,9 +6,10 @@ import { UploadAPIService } from './apiService';
 import { UploadCryptoService } from './cryptoService';
 import { UploadManager } from './manager';
 import { NodeCrypto } from './interface';
+import { mergeUint8Arrays } from '../utils';
 
-const MOCK_BLOCK_HASH = new Uint8Array(32).fill(1);
-const MOCK_VERIFICATION_TOKEN = new Uint8Array(16).fill(2);
+const MOCK_BLOCK_HASH = new Uint8Array(32).fill(4);
+const MOCK_VERIFICATION_TOKEN = new Uint8Array(16).fill(5);
 
 function createStream(bytes: number[]): ReadableStream<Uint8Array> {
     return new ReadableStream({
@@ -108,7 +109,7 @@ describe('SmallFileUploader', () => {
                 encryptedData: new Uint8Array(thumbnail.thumbnail),
                 originalSize: thumbnail.thumbnail.length,
                 encryptedSize: thumbnail.thumbnail.length + 100,
-                hash: 'thumbnailHash',
+                hashPromise: Promise.resolve(new Uint8Array(32).fill(thumbnail.type)),
             })),
             encryptBlock: jest.fn().mockImplementation(mockEncryptBlock),
             verifyBlock: jest.fn().mockResolvedValue({ verificationToken: MOCK_VERIFICATION_TOKEN }),
@@ -138,7 +139,6 @@ describe('SmallFileUploader', () => {
     function createUploader() {
         return new SmallFileUploader(
             telemetry,
-            apiService,
             cryptoService,
             uploadManager,
             metadata,
@@ -157,24 +157,13 @@ describe('SmallFileUploader', () => {
             const uploader = createUploader();
             const stream = createStream([1, 2, 3]);
 
-            const controller = await uploader.uploadFromStream(stream, thumbnails, onProgress);
-            const result = await controller.completion();
+            const result = await uploader.upload(stream, thumbnails, onProgress);
 
             expect(uploadManager.generateNewFileCrypto).toHaveBeenCalledWith(parentFolderUid, name);
             expect(uploadManager.uploadFile).toHaveBeenCalledTimes(1);
             expect(result).toEqual({ nodeUid: 'nodeUid', nodeRevisionUid: 'nodeRevisionUid' });
             expect(onProgress).toHaveBeenCalledWith(metadata.expectedSize);
         });
-
-        it('should throw if upload already started', async () => {
-            const uploader = createUploader();
-            const stream = createStream([1, 2, 3]);
-
-            await uploader.uploadFromStream(stream, thumbnails, onProgress);
-            await expect(uploader.uploadFromStream(stream, thumbnails, onProgress)).rejects.toThrow(
-                'Upload already started',
-            );
-        });
     });
 
     describe('buildPayloads (via upload flow)', () => {
@@ -186,8 +175,7 @@ describe('SmallFileUploader', () => {
                 { type: ThumbnailType.Type2, thumbnail: new Uint8Array([30, 40, 50]) },
             ];
 
-            await uploader.uploadFromStream(stream, thumbnails, undefined);
-            await (uploader as any).controller.completion();
+            await uploader.upload(stream, thumbnails, undefined);
 
             expect(uploadManager.uploadFile).toHaveBeenCalledWith(
                 parentFolderUid,
@@ -203,8 +191,16 @@ describe('SmallFileUploader', () => {
                     verificationToken: MOCK_VERIFICATION_TOKEN,
                 }),
                 [
-                    { type: ThumbnailType.Type1, encryptedData: expect.any(Uint8Array) },
-                    { type: ThumbnailType.Type2, encryptedData: expect.any(Uint8Array) },
+                    {
+                        type: ThumbnailType.Type1,
+                        encryptedData: expect.any(Uint8Array),
+                        blockHash: new Uint8Array(32).fill(ThumbnailType.Type1),
+                    },
+                    {
+                        type: ThumbnailType.Type2,
+                        encryptedData: expect.any(Uint8Array),
+                        blockHash: new Uint8Array(32).fill(ThumbnailType.Type2),
+                    },
                 ],
             );
 
@@ -212,7 +208,11 @@ describe('SmallFileUploader', () => {
             expect(cryptoService.encryptThumbnail).toHaveBeenCalledTimes(2);
             expect(cryptoService.commitFile).toHaveBeenCalledWith(
                 expect.anything(),
-                MOCK_BLOCK_HASH,
+                mergeUint8Arrays([
+                    new Uint8Array(32).fill(ThumbnailType.Type1),
+                    new Uint8Array(32).fill(ThumbnailType.Type2),
+                    MOCK_BLOCK_HASH,
+                ]),
                 expect.any(String),
             );
         });
@@ -223,8 +223,7 @@ describe('SmallFileUploader', () => {
             metadata.expectedSize = content.length;
             const stream = createStream(content);
 
-            await uploader.uploadFromStream(stream, [], undefined);
-            await (uploader as any).controller.completion();
+            await uploader.upload(stream, [], undefined);
 
             expect(cryptoService.encryptBlock).toHaveBeenCalledWith(
                 expect.any(Function),
@@ -241,8 +240,7 @@ describe('SmallFileUploader', () => {
             ];
             const stream = createStream([1, 2, 3]);
 
-            await uploader.uploadFromStream(stream, thumbnails, undefined);
-            await (uploader as any).controller.completion();
+            await uploader.upload(stream, thumbnails, undefined);
 
             expect(cryptoService.encryptThumbnail).toHaveBeenCalledWith(
                 expect.objectContaining({
@@ -259,8 +257,7 @@ describe('SmallFileUploader', () => {
             const uploader = createUploader();
             const stream = createStream([1, 2, 3]);
 
-            await uploader.uploadFromStream(stream, [], undefined);
-            await (uploader as any).controller.completion();
+            await uploader.upload(stream, [], undefined);
 
             const [nodeKeys, manifest, extendedAttributes] = (cryptoService.commitFile as jest.Mock).mock.calls[0];
             expect(manifest).toEqual(MOCK_BLOCK_HASH);
@@ -275,10 +272,10 @@ describe('SmallFileUploader', () => {
             metadata.expectedSize = 5;
             const stream = createStream([1, 2, 3]); // only 3 bytes
 
-            const controller = await uploader.uploadFromStream(stream, [], undefined);
+            const promise = uploader.upload(stream, [], undefined);
 
-            await expect(controller.completion()).rejects.toThrow(IntegrityError);
-            await expect(controller.completion()).rejects.toMatchObject({
+            await expect(promise).rejects.toThrow(IntegrityError);
+            await expect(promise).rejects.toMatchObject({
                 debug: { actual: 3, expected: 5 },
             });
         });
@@ -288,10 +285,10 @@ describe('SmallFileUploader', () => {
             metadata.expectedSha1 = 'a'.repeat(40); // wrong sha1
             const stream = createStream([1, 2, 3]);
 
-            const controller = await uploader.uploadFromStream(stream, [], undefined);
+            const promise = uploader.upload(stream, [], undefined);
 
-            await expect(controller.completion()).rejects.toThrow(IntegrityError);
-            await expect(controller.completion()).rejects.toMatchObject({
+            await expect(promise).rejects.toThrow(IntegrityError);
+            await expect(promise).rejects.toMatchObject({
                 debug: expect.objectContaining({
                     expectedSha1: 'a'.repeat(40),
                 }),
@@ -306,8 +303,7 @@ describe('SmallFileUploader', () => {
             const stream = createStream([]);
             const onProgress = jest.fn();
 
-            const controller = await uploader.uploadFromStream(stream, [], onProgress);
-            const result = await controller.completion();
+            const result = await uploader.upload(stream, [], onProgress);
 
             expect(result).toEqual({ nodeUid: 'nodeUid', nodeRevisionUid: 'nodeRevisionUid' });
             expect(cryptoService.encryptBlock).not.toHaveBeenCalled();
@@ -430,7 +426,6 @@ describe('SmallFileRevisionUploader', () => {
     function createUploader() {
         return new SmallFileRevisionUploader(
             telemetry,
-            apiService,
             cryptoService,
             uploadManager,
             metadata,
@@ -444,8 +439,7 @@ describe('SmallFileRevisionUploader', () => {
         const uploader = createUploader();
         const stream = createStream([1, 2, 3]);
 
-        const controller = await uploader.uploadFromStream(stream, [], undefined);
-        const result = await controller.completion();
+        const result = await uploader.upload(stream, [], undefined);
 
         expect(result).toEqual({ nodeUid: 'nodeUid', nodeRevisionUid: 'nodeRevisionUid' });
         expect(cryptoService.encryptBlock).toHaveBeenCalledWith(expect.any(Function), expect.anything(), Uint8Array.from([1, 2, 3]), 0);
@@ -471,8 +465,7 @@ describe('SmallFileRevisionUploader', () => {
         const uploader = createUploader();
         const stream = createStream([]);
 
-        const controller = await uploader.uploadFromStream(stream, [], undefined);
-        const result = await controller.completion();
+        const result = await uploader.upload(stream, [], undefined);
 
         expect(result).toEqual({ nodeUid: 'nodeUid', nodeRevisionUid: 'nodeRevisionUid' });
         expect(cryptoService.encryptBlock).not.toHaveBeenCalled();