@proteinjs/user-server 1.22.0 → 1.22.1

package/test/ExecutePasswordReset.test.ts

@@ -1,11 +1,14 @@
+import { createHash } from 'crypto';
 import moment, { Moment } from 'moment';
 import { getDbAsSystem } from '@proteinjs/db';
-import { Logger } from '@proteinjs/logger';
 import { tables, User } from '@proteinjs/user';
 import { executePasswordReset } from '../src/routes/executePasswordReset';
 import { PasswordHasher } from '../src/authentication/PasswordHasher';
 import { PasswordResetToken } from '../src/authentication/PasswordResetToken';
 import { UserServerTestEnvironment } from './UserServerTestEnvironment';
+import { DbTraffic } from './DbTraffic';
+import { LogCapture } from './LogCapture';
+import { MalformedResetTokens } from './MalformedResetTokens';
 
 const testEnv = new UserServerTestEnvironment();
 
@@ -14,21 +17,36 @@ const testEnv = new UserServerTestEnvironment();
  * the lookup must never be built from anything but a well-formed token: a `null` in the body
  * renders as `IS NULL` and matches every account with no pending reset, an empty string matches
  * an emptied column, and other types reach the driver. Covered here, outcomes only (rows
- * written), against the Spanner emulator:
- * - an absent, null, empty or malformed token: 400, and no password in the table changes — an
- *   account with no pending reset is never matched, whatever the request carries;
+ * written, statements run, lines logged), against the Spanner emulator:
+ * - an absent, null, empty or malformed token — every type a body can carry and every near-miss
+ *   cut from a live token: 400, nothing in the table changes, and nothing reaches the database
+ *   (no lookup built, no statement run); the live token still works afterwards. With a digest
+ *   lookup a wrongly admitted value still matches no row and still answers 400, so the response
+ *   alone proves nothing about the shape check — the absence of database traffic does;
+ * - a request with no body at all: 400, and nothing changes;
+ * - the row stores the token's SHA-256 digest, never the token: the stored digest presented as
+ *   a token is refused — it has a token's shape, so one lookup is built, by the digest OF the
+ *   presented value, and nothing is written — and so is a token an earlier release stored in clear;
  * - a live token resets the password once: the row verifies the new password, the token and its
  *   expiry are cleared, and the same token presented again is refused;
+ * - two simultaneous presentations of one token: exactly one 200, and the row verifies only the
+ *   winner's password;
  * - an expired token, or a token whose row carries no expiry, is refused;
  * - a blank new password is refused without consuming the token;
- * - the presented token never reaches the log;
- * - the token owner's own contract: mint shape, the stored-vs-presented match, liveness, and the
- *   conditional redemption.
+ * - no token, no leading characters of a token and no full digest reach the log, on any path
+ *   through the route;
+ * - the token owner's own contract: mint shape and what it stores, the shape refusal, the
+ *   stored-vs-presented digest match, liveness, the conditional redemption (one at a time and
+ *   concurrent), the withdrawal, the mint time, and the log reference.
+ *
+ * Every live token is seeded through `PasswordResetToken.mint`, so the suite moves with what the
+ * owner stores. Only the two named column states the owner never writes are seeded raw: an
+ * emptied column, and a token stored in clear by a release that predates the digest.
  */
 
 type RouteOutcome = { status: number; body?: any };
 
-const invokeExecute = async (body: Record<string, unknown>): Promise<RouteOutcome> => {
+const invokeExecuteRequest = async (request: Record<string, unknown>): Promise<RouteOutcome> => {
   const outcome: RouteOutcome = { status: 200 };
   const response = {
     status(code: number) {
@@ -39,35 +57,68 @@ const invokeExecute = async (body: Record<string, unknown>): Promise<RouteOutcom
       outcome.body = body;
     },
   };
-  await executePasswordReset.onRequest({ body } as never, response as never);
+  await executePasswordReset.onRequest(request as never, response as never);
   return outcome;
 };
 
-const mintToken = () => new PasswordResetToken().mint();
+const invokeExecute = async (body: Record<string, unknown>) => await invokeExecuteRequest({ body });
 
-const armResetToken = async (email: string, token: string | null, expiration: Moment | null): Promise<User> => {
+/** The digest a row must hold for `token`, computed here independently of the owner. */
+const sha256Hex = (value: string) => createHash('sha256').update(value).digest('hex');
+
+/** A well-formed token that was never issued to anyone. */
+const unissuedToken = () => sha256Hex(`never issued ${Math.random()}`);
+
+/** A user with a token minted by the owner; `expiration` (when given) replaces the expiry the mint stored. */
+const armResetToken = async (email: string, expiration?: Moment | null): Promise<{ user: User; token: string }> => {
+  const user = await testEnv.createUser({ name: 'Reset User', email });
+  const token = await new PasswordResetToken().mint(user);
+  if (expiration !== undefined) {
+    await getDbAsSystem().update(tables.User, { id: user.id, passwordResetTokenExpiration: expiration });
+  }
+  return { user, token };
+};
+
+/** A user whose token column is written raw — only for the column states the owner never writes. */
+const armRawTokenColumn = async (email: string, stored: string): Promise<User> => {
   const user = await testEnv.createUser({ name: 'Reset User', email });
   await getDbAsSystem().update(tables.User, {
     id: user.id,
-    passwordResetToken: token,
-    passwordResetTokenExpiration: expiration,
+    passwordResetToken: stored,
+    passwordResetTokenExpiration: moment().add(1, 'hour'),
   });
   return user;
 };
 
 const userRow = async (id: string) => await getDbAsSystem().get(tables.User, { id });
 
-/** Every password in the table, by email — the whole-table outcome a refused request must leave untouched. */
-const passwordsByEmail = async (): Promise<Record<string, string>> => {
-  const byEmail: Record<string, string> = {};
+/** Every password, stored token and expiry in the table, by email — the whole-table outcome a refused request must leave untouched. */
+const resetStateByEmail = async (): Promise<Record<string, unknown[]>> => {
+  const byEmail: Record<string, unknown[]> = {};
   for (const user of await getDbAsSystem().query(tables.User, {})) {
-    byEmail[user.email] = user.password;
+    byEmail[user.email] = [
+      user.password,
+      user.passwordResetToken ?? null,
+      user.passwordResetTokenExpiration ? moment(user.passwordResetTokenExpiration).toISOString() : null,
+    ];
   }
   return byEmail;
 };
 
+/** Which of `candidates` the stored password hash verifies. */
+const verifiedPasswords = async (storedHash: string, candidates: string[]): Promise<string[]> => {
+  const verified: string[] = [];
+  for (const candidate of candidates) {
+    if (await new PasswordHasher().verify(storedHash, candidate)) {
+      verified.push(candidate);
+    }
+  }
+  return verified;
+};
+
 type TokenInternals = {
-  matches(stored: string | null | undefined, presented: string): boolean;
+  digest(token: string): string;
+  matches(storedDigest: string | null | undefined, presentedDigest: string): boolean;
   isLive(expiration: Moment | null | undefined): boolean;
 };
 
@@ -77,7 +128,7 @@ describe('executePasswordReset route', () => {
     // No pending reset — the account a `null` token's `IS NULL` filter would match.
     await testEnv.createUser({ name: 'Idle User', email: 'reset-idle@test.local' });
     // An emptied token column — the account an empty token would match.
-    await armResetToken('reset-emptied@test.local', '', moment().add(1, 'hour'));
+    await armRawTokenColumn('reset-emptied@test.local', '');
   });
 
   afterAll(async () => {
@@ -85,28 +136,55 @@ describe('executePasswordReset route', () => {
   });
 
   describe('a request without a well-formed token is refused before any lookup', () => {
-    it.each([
-      ['absent', {}],
-      ['null', { token: null }],
-      ['empty', { token: '' }],
-      ['not a token string', { token: 'tok-valid-1' }],
-      ['a number', { token: 123 }],
-      ['an array', { token: ['a', 'b'] }],
-      ['an object', { token: { passwordResetToken: null } }],
-    ])('%s: 400, and no password in the table changes', async (_label, tokenField) => {
-      const before = await passwordsByEmail();
-
-      const outcome = await invokeExecute({ ...tokenField, newPassword: 'hijacked' });
+    let liveUser: User;
+    let liveToken: string;
 
-      expect(outcome.status).toBe(400);
-      expect(outcome.body).toEqual({ error: 'Invalid or expired reset token' });
-      expect(await passwordsByEmail()).toEqual(before);
+    beforeAll(async () => {
+      ({ user: liveUser, token: liveToken } = await armResetToken('reset-shapes@test.local'));
     });
+
+    it.each(MalformedResetTokens.CASES)(
+      '%s: 400, nothing in the table changes, and nothing reaches the database',
+      async (_label, tokenField) => {
+        const before = await resetStateByEmail();
+
+        const { result: outcome, traffic } = await DbTraffic.during(
+          testEnv.spannerDriver,
+          async () => await invokeExecute({ ...tokenField(liveToken), newPassword: 'hijacked' })
+        );
+
+        expect(outcome.status).toBe(400);
+        expect(outcome.body).toEqual({ error: 'Invalid or expired reset token' });
+        expect(traffic).toEqual(DbTraffic.NONE);
+        expect(await resetStateByEmail()).toEqual(before);
+      }
+    );
+
+    it('after every refusal the live token still resets the password', async () => {
+      const outcome = await invokeExecute({ token: liveToken, newPassword: 'still live' });
+
+      expect(outcome.status).toBe(200);
+      const row = await userRow(liveUser.id);
+      await expect(new PasswordHasher().verify(row.password, 'still live')).resolves.toBe(true);
+    });
+  });
+
+  it.each([
+    ['no body', 'reset-no-body@test.local', {}],
+    ['a null body', 'reset-null-body@test.local', { body: null }],
+  ])('a request with %s: 400, and nothing changes', async (_label, email, request) => {
+    const { user, token } = await armResetToken(email);
+    const before = await resetStateByEmail();
+
+    const outcome = await invokeExecuteRequest(request);
+
+    expect(outcome.status).toBe(400);
+    expect(await resetStateByEmail()).toEqual(before);
+    expect((await userRow(user.id)).passwordResetToken).toBe(sha256Hex(token));
   });
 
   it('a live token resets the password once: the row verifies it, the token clears, a re-presentation is refused', async () => {
-    const token = mintToken();
-    const user = await armResetToken('reset-live@test.local', token, moment().add(1, 'hour'));
+    const { user, token } = await armResetToken('reset-live@test.local');
 
     const first = await invokeExecute({ token, newPassword: 'first new password' });
 
@@ -123,9 +201,79 @@ describe('executePasswordReset route', () => {
     expect((await userRow(user.id)).password).toBe(afterFirst.password);
   });
 
+  it("two simultaneous presentations of one token: exactly one 200, and the row verifies only the winner's password", async () => {
+    const { user, token } = await armResetToken('reset-race@test.local');
+    const candidates = ['racer one password', 'racer two password'];
+    // Both requests resolve the token as live and hash their password; the barrier then releases
+    // them into the redemption together, so neither has written when the other arrives.
+    const hashPassword = PasswordHasher.prototype.hash;
+    let release: () => void = () => undefined;
+    const bothHashed = new Promise<void>((resolve) => (release = resolve));
+    let hashed = 0;
+    const hash = jest.spyOn(PasswordHasher.prototype, 'hash').mockImplementation(async function (
+      this: PasswordHasher,
+      password: string
+    ) {
+      const hashedPassword = await hashPassword.call(this, password);
+      if (++hashed === candidates.length) {
+        release();
+      }
+      await bothHashed;
+      return hashedPassword;
+    });
+    let outcomes: RouteOutcome[];
+    try {
+      outcomes = await Promise.all(candidates.map((newPassword) => invokeExecute({ token, newPassword })));
+    } finally {
+      hash.mockRestore();
+    }
+
+    expect(outcomes.map((outcome) => outcome.status).sort()).toEqual([200, 400]);
+    const winner = candidates[outcomes.findIndex((outcome) => outcome.status === 200)];
+    const row = await userRow(user.id);
+    expect(await verifiedPasswords(row.password, candidates)).toEqual([winner]);
+    expect(row.passwordResetToken).toBeNull();
+    expect(row.passwordResetTokenExpiration).toBeNull();
+  });
+
+  it('the row stores the SHA-256 digest of the token, never the token — and the digest presented as a token is refused', async () => {
+    const { user, token } = await armResetToken('reset-digest@test.local');
+    const armed = await userRow(user.id);
+
+    expect(armed.passwordResetToken).toBe(sha256Hex(token));
+    expect(JSON.stringify(armed)).not.toContain(token);
+
+    // A digest has a token's shape, so this presentation does reach the lookup — which is built
+    // from the digest OF the presented value, so what the row stores never equals it.
+    const { result: outcome, traffic } = await DbTraffic.during(
+      testEnv.spannerDriver,
+      async () => await invokeExecute({ token: armed.passwordResetToken, newPassword: 'hijacked' })
+    );
+
+    expect(outcome.status).toBe(400);
+    expect(outcome.body).toEqual({ error: 'Invalid or expired reset token' });
+    expect(traffic.lookups).toEqual([{ passwordResetToken: sha256Hex(sha256Hex(token)) }]);
+    expect(traffic.statements).toBe(1);
+    expect(traffic.writes).toBe(0);
+    const row = await userRow(user.id);
+    expect(row.password).toBe(armed.password);
+    expect(row.passwordResetToken).toBe(sha256Hex(token));
+  });
+
+  it('a token an earlier release stored in clear is refused — it fails for the rest of its hour, no migration', async () => {
+    const clearToken = unissuedToken();
+    const user = await armRawTokenColumn('reset-stored-in-clear@test.local', clearToken);
+    const before = (await userRow(user.id)).password;
+
+    const outcome = await invokeExecute({ token: clearToken, newPassword: 'hijacked' });
+
+    expect(outcome.status).toBe(400);
+    expect(outcome.body).toEqual({ error: 'Invalid or expired reset token' });
+    expect((await userRow(user.id)).password).toBe(before);
+  });
+
   it('an expired token is refused and changes nothing', async () => {
-    const token = mintToken();
-    const user = await armResetToken('reset-expired@test.local', token, moment().subtract(1, 'minute'));
+    const { user, token } = await armResetToken('reset-expired@test.local', moment().subtract(1, 'minute'));
     const before = (await userRow(user.id)).password;
 
     const outcome = await invokeExecute({ token, newPassword: 'hijacked' });
@@ -134,12 +282,11 @@ describe('executePasswordReset route', () => {
     expect(outcome.body).toEqual({ error: 'Reset token has expired' });
     const row = await userRow(user.id);
     expect(row.password).toBe(before);
-    expect(row.passwordResetToken).toBe(token);
+    expect(row.passwordResetToken).toBe(sha256Hex(token));
   });
 
   it('a token whose row carries no expiry is refused — never live by omission', async () => {
-    const token = mintToken();
-    const user = await armResetToken('reset-no-expiry@test.local', token, null);
+    const { user, token } = await armResetToken('reset-no-expiry@test.local', null);
     const before = (await userRow(user.id)).password;
 
     const outcome = await invokeExecute({ token, newPassword: 'hijacked' });
@@ -149,8 +296,7 @@ describe('executePasswordReset route', () => {
   });
 
   it('a blank new password is refused without consuming the token', async () => {
-    const token = mintToken();
-    const user = await armResetToken('reset-blank@test.local', token, moment().add(1, 'hour'));
+    const { user, token } = await armResetToken('reset-blank@test.local');
     const before = (await userRow(user.id)).password;
 
     for (const newPassword of ['', undefined, 42]) {
@@ -160,42 +306,98 @@ describe('executePasswordReset route', () => {
 
     const row = await userRow(user.id);
     expect(row.password).toBe(before);
-    expect(row.passwordResetToken).toBe(token);
+    expect(row.passwordResetToken).toBe(sha256Hex(token));
   });
 
-  it('the presented token never reaches the log', async () => {
-    const token = mintToken(); // well-formed, never issued
-    const info = jest.spyOn(Logger.prototype, 'info');
-    try {
-      await invokeExecute({ token, newPassword: 'hijacked' });
+  it('no token, no leading characters of one and no full digest reach the log — every path through the route', async () => {
+    const { token: live } = await armResetToken('reset-log-live@test.local');
+    const { token: expired } = await armResetToken('reset-log-expired@test.local', moment().subtract(1, 'minute'));
+    const unissued = unissuedToken();
+
+    const log = await LogCapture.during(async () => {
+      await invokeExecute({ token: unissued, newPassword: 'hijacked' });
+      await invokeExecute({ token: live.toUpperCase(), newPassword: 'hijacked' });
+      await invokeExecute({ token: sha256Hex(live), newPassword: 'hijacked' });
+      await invokeExecute({ token: expired, newPassword: 'hijacked' });
+      await invokeExecute({ token: live, newPassword: 'a logged password' });
+      await invokeExecute({ token: live, newPassword: 'a second logged password' });
+    });
 
-      expect(info).toHaveBeenCalled();
-      for (const [entry] of info.mock.calls) {
-        expect(JSON.stringify(entry)).not.toContain(token);
-      }
-    } finally {
-      info.mockRestore();
+    // The capture saw the route's lines: each path above logged.
+    expect(log.text).toContain('Invalid reset token used');
+    expect(log.text).toContain('Expired reset token used');
+    expect(log.text).toContain('Password successfully reset');
+    expect(log.lines.length).toBeGreaterThanOrEqual(6);
+    // The digest presented as a token is covered by `live`: its full digest is what was presented.
+    for (const token of [unissued, live, expired]) {
+      log.expectFreeOf(token);
     }
   });
 
   describe('PasswordResetToken', () => {
     const internals = new PasswordResetToken() as unknown as TokenInternals;
 
-    it('mints 64 lowercase hex characters, fresh each time', () => {
-      const token = mintToken();
+    it('mints 64 lowercase hex characters, fresh each time, and stores the digest with an expiry an hour out', async () => {
+      const user = await testEnv.createUser({ name: 'Reset User', email: 'reset-mint@test.local' });
+
+      const first = await new PasswordResetToken().mint(user);
+      const afterFirst = await userRow(user.id);
+      const second = await new PasswordResetToken().mint(user);
+      const afterSecond = await userRow(user.id);
+
+      expect(first).toMatch(/^[0-9a-f]{64}$/);
+      expect(second).toMatch(/^[0-9a-f]{64}$/);
+      expect(second).not.toBe(first);
+      expect(afterFirst.passwordResetToken).toBe(sha256Hex(first));
+      expect(afterSecond.passwordResetToken).toBe(sha256Hex(second));
+      const minutesOut = moment(afterSecond.passwordResetTokenExpiration).diff(moment(), 'minutes', true);
+      expect(minutesOut).toBeGreaterThan(59);
+      expect(minutesOut).toBeLessThanOrEqual(60);
+    });
+
+    it.each(MalformedResetTokens.CASES)(
+      'resolve refuses %s as malformed without touching the database, and gives it no log reference',
+      async (_label, tokenField) => {
+        const presented = tokenField(unissuedToken()).token;
+
+        const { result: resolution, traffic } = await DbTraffic.during(
+          testEnv.spannerDriver,
+          async () => await new PasswordResetToken().resolve(presented)
+        );
+
+        expect(resolution).toEqual({ status: 'malformed' });
+        expect(traffic).toEqual(DbTraffic.NONE);
+        expect(new PasswordResetToken().fingerprint(presented)).toBeUndefined();
+      }
+    );
+
+    it('the log reference to a token is cut from its digest, never from the token: the same token reads the same, another reads differently', () => {
+      const token = unissuedToken();
+      const another = unissuedToken();
+
+      const reference = new PasswordResetToken().fingerprint(token);
 
-      expect(token).toMatch(/^[0-9a-f]{64}$/);
-      expect(mintToken()).not.toBe(token);
+      expect(reference).toBe(sha256Hex(token).slice(0, 12));
+      expect(reference).not.toBe(token.slice(0, 12));
+      expect(new PasswordResetToken().fingerprint(token)).toBe(reference);
+      expect(new PasswordResetToken().fingerprint(another)).not.toBe(reference);
     });
 
-    it('a stored token matches only the same string — never an absent or emptied one', () => {
-      const token = mintToken();
+    it('the digest is the SHA-256 of the token, hex-encoded', () => {
+      const token = unissuedToken();
 
-      expect(internals.matches(token, token)).toBe(true);
-      expect(internals.matches(mintToken(), token)).toBe(false);
-      expect(internals.matches(null, token)).toBe(false);
-      expect(internals.matches(undefined, token)).toBe(false);
-      expect(internals.matches('', token)).toBe(false);
+      expect(internals.digest(token)).toBe(sha256Hex(token));
+      expect(internals.digest(token)).not.toBe(token);
+    });
+
+    it('a stored digest matches only the same digest — never an absent or emptied one', () => {
+      const digest = sha256Hex('one token');
+
+      expect(internals.matches(digest, digest)).toBe(true);
+      expect(internals.matches(sha256Hex('another token'), digest)).toBe(false);
+      expect(internals.matches(null, digest)).toBe(false);
+      expect(internals.matches(undefined, digest)).toBe(false);
+      expect(internals.matches('', digest)).toBe(false);
     });
 
     it('an expiry is live only as a valid timestamp in the future', () => {
@@ -206,12 +408,12 @@ describe('executePasswordReset route', () => {
       expect(internals.isLive(moment.invalid())).toBe(false);
     });
 
-    it('redeem writes only while the row still carries the token', async () => {
-      const live = mintToken();
-      const user = await armResetToken('reset-redeem@test.local', live, moment().add(1, 'hour'));
+    it("redeem writes only while the row still carries the token's digest", async () => {
+      const { user, token: live } = await armResetToken('reset-redeem@test.local');
       const before = (await userRow(user.id)).password;
 
-      await expect(new PasswordResetToken().redeem(user, mintToken(), 'other-hash')).resolves.toBe(false);
+      await expect(new PasswordResetToken().redeem(user, unissuedToken(), 'other-hash')).resolves.toBe(false);
+      await expect(new PasswordResetToken().redeem(user, sha256Hex(live), 'other-hash')).resolves.toBe(false);
       expect((await userRow(user.id)).password).toBe(before);
 
       await expect(new PasswordResetToken().redeem(user, live, 'new-hash')).resolves.toBe(true);
@@ -220,5 +422,41 @@ describe('executePasswordReset route', () => {
       expect(row.passwordResetToken).toBeNull();
       expect(row.passwordResetTokenExpiration).toBeNull();
     });
+
+    it('concurrent redeems of one token: exactly one resolves true, and the row holds the winner', async () => {
+      const { user, token } = await armResetToken('reset-redeem-race@test.local');
+      const hashes = ['hash-1', 'hash-2', 'hash-3', 'hash-4', 'hash-5', 'hash-6', 'hash-7', 'hash-8'];
+
+      const results = await Promise.all(hashes.map((hash) => new PasswordResetToken().redeem(user, token, hash)));
+
+      expect(results.filter((redeemed) => redeemed)).toHaveLength(1);
+      const row = await userRow(user.id);
+      expect(row.password).toBe(hashes[results.indexOf(true)]);
+      expect(row.passwordResetToken).toBeNull();
+    });
+
+    it('revoke clears the row only while it still carries the token — a newer token is left alone', async () => {
+      const { user, token: withdrawn } = await armResetToken('reset-revoke@test.local');
+      const newer = await new PasswordResetToken().mint(user);
+
+      await new PasswordResetToken().revoke(user, withdrawn);
+      expect((await userRow(user.id)).passwordResetToken).toBe(sha256Hex(newer));
+
+      await new PasswordResetToken().revoke(user, newer);
+      const row = await userRow(user.id);
+      expect(row.passwordResetToken).toBeNull();
+      expect(row.passwordResetTokenExpiration).toBeNull();
+      expect(row.password).toBe('test');
+    });
+
+    it('mintedAt is the moment the outstanding token was minted — undefined when the row carries none', async () => {
+      const idle = await testEnv.createUser({ name: 'Reset User', email: 'reset-minted-at-idle@test.local' });
+      const { user } = await armResetToken('reset-minted-at@test.local');
+
+      expect(new PasswordResetToken().mintedAt(idle)).toBeUndefined();
+      const mintedAt = new PasswordResetToken().mintedAt(await userRow(user.id));
+      expect(mintedAt).toBeDefined();
+      expect(Math.abs(moment().diff(mintedAt, 'seconds'))).toBeLessThan(30);
+    });
   });
 });