@proprioo/salatim 35.7.0 → 35.9.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## Changelog
 
+**35.9.0**
+
+    * Docs: update Readme.md
+
+**35.8.0**
+
+    * Feat(Phone): add Colombia
+
 **35.7.0**
 
     * Feat(Phone): add Liberia

package/README.md

@@ -73,3 +73,16 @@ If you have to backport something to an old version of salatim :
 5. run `yarn publish --access=public --non-interactive --tag 15.2.4` locally. **Don't forget the `--tag` argument to prevent overriding the latest version.**
 
 You can then bump your project with this new version of salatim. ;)
+
+## Update phone metadata
+
+We cannot accept every phone numbers in the application, mainly due to some optimization (Metadata JSON is a big file).
+When an error is triggered on AppSales (`Failed to parse phone number +XXXX`), we need to update the phone Metadata to accept it.
+
+1. Find the country calling code, to do so:
+   1. Go to [Phone.tsx](./packages/phone//src/phoneInput/PhoneInput.tsx), change `PhoneInput` import to `'react-phone-number-input'` and remove metadata attribute in JSX (like this we're accepting every possible phone numbers)
+   2. Start locally Storybook and copy / paste your troublesome phone number to find the country calling code.
+2. Go to [CountryCode.org](https://countrycode.org/) and find your country calling code.
+3. Use the 2 digit ISO found to update the script [generate-phone-metadata](./package.json), then run this script (Metadata will be automatically generated).
+4. We also need to update the Phone component to accept this new option, go to [constants](./packages/phone/src/phoneInput/constants.ts) and add this 2 digit ISO in both constants.
+5. Do not forget to rollback your changes in `PhoneInput.tsx`, then update Changelog.md and package.json version and you're up to go.