@propriety/court-calendar 1.0.145 → 1.0.147

package/dist/index.mjs

@@ -15619,7 +15619,7 @@ const AH = Ml(function({
         mt,
         {
           label: "Negotiator",
-          value: o && !isNaN(o) ? `${r[o].UserFirstName} ${r[o].UserLastName}` : "—"
+          value: o && !isNaN(o) && r[o] ? `${r[o].UserFirstName} ${r[o].UserLastName}` : "—"
         }
       ),
       v != null && /* @__PURE__ */ a(
@@ -19778,7 +19778,7 @@ function v1(t, e, n, r) {
     if (!e.showOnlyUnsettled && !e.showOnlyWithoutEvidence && !e.showOnlyUnreviewed)
       return !0;
     const u = n[Kt(f)];
-    if (u === void 0 || u.length === 0) return !1;
+    if (u === void 0 || u.length === 0) return !0;
     const d = Qt(f.MuniCode), l = e.searchTerm ? { ...e, searchTerm: "" } : e;
     return Ou(u, l, d).length > 0;
   }).filter((f) => e.dateTypeFilter === "negotiations" ? f.DateType === Fe.NEGOTIATIONS : e.dateTypeFilter === "collections" ? f.DateType === Fe.COLLECTIONS : e.dateTypeFilter === "scar" ? f.DateType !== Fe.NEGOTIATIONS && f.DateType !== Fe.COLLECTIONS : !0);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@propriety/court-calendar",
   "private": false,
-  "version": "1.0.145",
+  "version": "1.0.147",
   "type": "module",
   "main": "dist/index.js",
   "module": "./dist/index.mjs",

package/src/__tests__/filtering.test.ts

@@ -428,17 +428,31 @@ describe('filterCourtDates — case-based filters (showOnlyUnsettled et al.
         expect(result).toHaveLength(0);
     });
 
-    it('hides date when cases not yet loaded (undefined) and case filter is active', () => {
+    it('keeps date when cases not yet loaded (undefined) and case filter is active (pending guard hides the event downstream)', () => {
         const cd = makeCourtDate({ CourtDateID: 1 });
         const result = filterCourtDates([cd], makeFilter({ showOnlyUnsettled: true }), {}, null);
-        expect(result).toHaveLength(0);
+        expect(result).toHaveLength(1);
     });
 
-    it('hides date when cases array is empty and case filter is active', () => {
+    it('keeps date with an empty (loaded) case list when case filter is active — nothing to hide', () => {
         const cd = makeCourtDate({ CourtDateID: 1 });
         const cases = { '1': [] };
         const result = filterCourtDates([cd], makeFilter({ showOnlyUnsettled: true }), cases, null);
-        expect(result).toHaveLength(0);
+        expect(result).toHaveLength(1);
+    });
+
+    it('regression AVE-1689: case-less negotiation date survives default Hide Settled on both all and negotiations tabs', () => {
+        const neg = makeCourtDate({ CourtDateID: 227, DateType: DateType.NEGOTIATIONS, MuniCode: 'W18' });
+        const cases = { neg_227: [] };
+        for (const tab of ['all', 'negotiations'] as const) {
+            const result = filterCourtDates(
+                [neg],
+                makeFilter({ dateTypeFilter: tab, showOnlyUnsettled: true }),
+                cases,
+                null,
+            );
+            expect(result).toHaveLength(1);
+        }
     });
 
     it('shows date with no filters active even when cases are empty', () => {
@@ -505,12 +519,19 @@ describe('filterCourtDates — case-based filters (showOnlyUnsettled et al.
         expect(result).toHaveLength(1);
     });
 
-    it('NEGOTIATIONS date is hidden when cases loaded under wrong key', () => {
+    it('NEGOTIATIONS date does not inherit cases loaded under the un-prefixed SCAR key', () => {
         const cd = makeCourtDate({ CourtDateID: 5, DateType: DateType.NEGOTIATIONS });
         // Wrong key: '5' instead of 'neg_5'
         const cases = { '5': [makeCase({ SCARDeterminationAction: '' })] };
+        // The date itself passes the date-level filter (its own bucket is simply
+        // not loaded), but the SCAR cases must not leak into its event: the
+        // bucket stays empty/pending, so the event is suppressed downstream.
         const result = filterCourtDates([cd], makeFilter({ showOnlyUnsettled: true }), cases, null);
-        expect(result).toHaveLength(0);
+        expect(result).toHaveLength(1);
+        const [event] = buildCalEvents(result, cases);
+        expect(event.cases).toHaveLength(0);
+        expect(event.casesLoaded).toBe(false);
+        expect(shouldSkipEvent(event, makeFilter({ showOnlyUnsettled: true }))).toBe(true);
     });
 });
 

package/src/_components/Modal/CaseDetails/CaseDetails.tsx

@@ -152,7 +152,7 @@ const CaseDetails = memo(function CaseDetails({
                     <InfoField
                         label='Negotiator'
                         value={
-                            Negotiator && !isNaN(Negotiator)
+                            Negotiator && !isNaN(Negotiator) && allUsers[Negotiator]
                                 ? `${allUsers[Negotiator].UserFirstName} ${allUsers[Negotiator].UserLastName}`
                                 : '—'
                         }

package/src/helpers/filtering.ts

@@ -41,8 +41,12 @@ export function filterCourtDates(
             if (!filterCtx.showOnlyUnsettled && !filterCtx.showOnlyWithoutEvidence && !filterCtx.showOnlyUnreviewed)
                 return true;
             const casesEntry = allCases[caseKey(cd)];
-            if (casesEntry === undefined) return false;
-            if (casesEntry.length === 0) return false;
+            // An empty (or not-yet-loaded) case bucket has nothing for a case-level
+            // filter to act on — keep the date visible so genuinely case-less dates
+            // (e.g. manually created negotiation dates) aren't hidden by the
+            // default-on unsettled filter. Not-yet-loaded buckets are still
+            // suppressed at the event layer by shouldSkipEvent's casesLoaded guard.
+            if (casesEntry === undefined || casesEntry.length === 0) return true;
             const isVillage = isVillageDate(cd.MuniCode);
             // searchTerm selects court dates via searchedDateIDs — strip it from
             // the case-level filter so township name searches don't hide all cases.