@promptbook/cli 0.114.0-48 → 0.114.0-49

package/src/cli/cli-commands/common/validateCoderRunOptions.ts

@@ -1,6 +1,6 @@
 import { spaceTrim } from 'spacetrim';
 import type { RunOptions } from '../../../../scripts/run-codex-prompts/cli/RunOptions';
-import { isTestBeforeMode } from '../../../../scripts/run-codex-prompts/testing/TestBeforeMode';
+import { isCheckBeforeMode } from '../../../../scripts/run-codex-prompts/checks/CheckBeforeMode';
 import { DatabaseError } from '../../../errors/DatabaseError';
 import { NotAllowed } from '../../../errors/NotAllowed';
 
@@ -9,10 +9,17 @@ import { NotAllowed } from '../../../errors/NotAllowed';
  * @private shared validation for Coder execution commands
  */
 export function validateCoderRunOptions(options: RunOptions): void {
-    if (!isTestBeforeMode(options.testBefore ?? 'no')) {
+    if (options.checkCommand !== undefined && !options.checkCommand.trim()) {
         throw new NotAllowed(
             spaceTrim(`
-                Invalid ${'`--test-before`'} mode: \`${String(options.testBefore)}\`.
+            Option \`--check\` requires a non-empty shell command, for example \`npm run check\`.
+        `),
+        );
+    }
+    if (!isCheckBeforeMode(options.checkBefore ?? 'no')) {
+        throw new NotAllowed(
+            spaceTrim(`
+                Invalid ${'`--check-before`'} mode: \`${String(options.checkBefore)}\`.
 
                 Use one of: \`no\`, \`yes-and-fail\`, \`yes-and-fix\`.
             `),
@@ -67,10 +74,10 @@ export function validateCoderRunOptions(options: RunOptions): void {
         );
     }
 
-    if (options.gitChanges === 'continue' && options.testBefore === 'yes-and-fix') {
+    if (options.gitChanges === 'continue' && options.checkBefore === 'yes-and-fix') {
         throw new NotAllowed(
             spaceTrim(`
-                Flag \`--git-changes continue\` cannot be combined with \`--test-before yes-and-fix\`.
+                Flag \`--git-changes continue\` cannot be combined with \`--check-before yes-and-fix\`.
 
                 An interrupted prompt already has changes in progress, so there is no unmodified project state for pre-coding verification to repair.
             `),

package/src/cli/cli-commands/common/workspaceRepository.ts

@@ -1,12 +1,13 @@
 import { execFile } from 'child_process';
-import { lstat, realpath, stat } from 'fs/promises';
-import { dirname, join, resolve } from 'path';
+import { lstat, realpath } from 'fs/promises';
+import { dirname, join } from 'path';
 import { spaceTrim } from 'spacetrim';
 import { promisify } from 'util';
 import { EnvironmentMismatchError } from '../../../errors/EnvironmentMismatchError';
 import { NotAllowed } from '../../../errors/NotAllowed';
 import { loadPromptsModule } from '../../common/loadPromptsModule';
 import type { NormalizedQuestionsCliOptions } from './questionsCliOptions';
+import { resolveProjectDirectory } from './projectCliOptions';
 
 /** Shell-free Git execution, also usable from the packaged CLI. */
 const EXECUTE_FILE = promisify(execFile);
@@ -40,22 +41,7 @@ export type WorkspaceRepositoryPolicy = 'initialize' | 'mutate' | 'read-only';
 export async function $resolveWorkspaceRepository(
     projectDirectory = process.cwd(),
 ): Promise<WorkspaceRepositoryContext> {
-    const requestedPath = resolve(projectDirectory);
-    let projectPath: string;
-    try {
-        projectPath = await realpath(requestedPath);
-        if (!(await stat(projectPath)).isDirectory()) {
-            throw new EnvironmentMismatchError(`The project path \`${requestedPath}\` is not a directory.`);
-        }
-    } catch (error) {
-        throw new EnvironmentMismatchError(
-            spaceTrim(
-                `Cannot access project directory \`${requestedPath}\`. Check that it exists and is accessible.\n\n${describeWorkspaceError(
-                    error,
-                )}`,
-            ),
-        );
-    }
+    const projectPath = await resolveProjectDirectory(projectDirectory);
     return $inspectWorkspaceRepository(projectPath);
 }
 
@@ -192,7 +178,9 @@ async function $inspectWorkspaceRepository(projectPath: string): Promise<Workspa
         // Git may skip damaged inner metadata and find a valid parent. Do not silently use that parent
         // for a project whose own checkout needs repair.
         await $assertNoBrokenRepositoryMetadata(projectPath, repositoryRoot);
-        const gitDirectory = (await $runWorkspaceGit(projectPath, ['rev-parse', '--absolute-git-dir'])).trim();
+        const gitDirectory = await realpath(
+            (await $runWorkspaceGit(projectPath, ['rev-parse', '--absolute-git-dir'])).trim(),
+        );
         // Also validate the index and metadata, without refreshing the index or depending on an existing commit.
         await $runWorkspaceGit(projectPath, ['status', '--porcelain', '--untracked-files=no']);
         return { projectPath, repositoryRoot, gitDirectory, repositoryStatus: 'reused' };

package/src/cli/cli-commands/common/workspaceRepositoryCliOptions.ts

@@ -1,6 +1,7 @@
 import type { Command } from 'commander';
 import { spaceTrim } from 'spacetrim';
 import { addQuestionsOption } from './questionsCliOptions';
+import { addProjectPathOption } from './projectCliOptions';
 
 /**
  * Shared explanation of the workspace prerequisite, independent of commit and synchronization settings.
@@ -21,6 +22,7 @@ export const WORKSPACE_REPOSITORY_DESCRIPTION = spaceTrim(`
  * @private internal registration helper for workspace CLI commands
  */
 export function addWorkspaceRepositoryOptions(command: Command): void {
+    addProjectPathOption(command);
     if (!command.options.some((option) => option.long === '--no-questions')) addQuestionsOption(command);
     command.addHelpText('after', `\n${WORKSPACE_REPOSITORY_DESCRIPTION}\n`);
 }

package/src/execution/translation/automatic-translate/translateMessages.ts

@@ -19,9 +19,7 @@ export async function translateMessages({
     from,
     to,
 }: { automaticTranslator: AutomaticTranslator } & TranslatorOptions) {
-    for (const filename of await findFilesByGlob(
-        join(__dirname, '../../translations/', from || 'en', '/**/*.json5'),
-    )) {
+    for (const filename of await findFilesByGlob(join(__dirname, '../../translations/', from || 'en', '/**/*.json5'))) {
         //                       <- TODO: [😶]
         const fileData = JSON5.parse(await promisify(readFile)(filename, 'utf-8'));