@promptbook/cli 0.113.0-9 → 0.114.0-0

package/apps/agents-server/src/components/UsersList/UsersList.tsx

@@ -1,12 +1,15 @@
 'use client';
 
 import Link from 'next/link';
-import { FormEvent, useState } from 'react';
+import { ShieldCheck, UserRound, UserPlus } from 'lucide-react';
+import { FormEvent, useMemo, useState } from 'react';
 import { Card } from '../Homepage/Card';
 import { Section } from '../Homepage/Section';
 import { useServerLanguage } from '../ServerLanguage/ServerLanguageProvider';
-import { SecretInput } from '@/src/components/SecretInput/SecretInput';
+import { isAnonymousUsername } from '../../utils/anonymousUser';
 import { formatServerLanguageHumanReadableDate } from '@/src/utils/localization/formatServerLanguageHumanReadableDate';
+import { generateSecurePassword } from './generateSecurePassword';
+import { CreateUserDialog } from './CreateUserDialog';
 import { useUsersAdmin } from './useUsersAdmin';
 
 /**
@@ -29,25 +32,72 @@ export function UsersList({ allowCreate = true }: UsersListProps) {
     const { users, loading, error, createUser, deleteUser, toggleAdmin } = useUsersAdmin();
     const { language, t } = useServerLanguage();
 
+    const [isCreateDialogOpen, setIsCreateDialogOpen] = useState(false);
+    const [isCreatingUser, setIsCreatingUser] = useState(false);
     const [newUsername, setNewUsername] = useState('');
     const [newPassword, setNewPassword] = useState('');
     const [newIsAdmin, setNewIsAdmin] = useState(false);
 
-    const handleCreateUser = async (e: FormEvent) => {
-        e.preventDefault();
+    const sortedUsers = useMemo(
+        () =>
+            [...users].sort((userA, userB) => {
+                const isUserAAnonymous = isAnonymousUsername(userA.username);
+                const isUserBAnonymous = isAnonymousUsername(userB.username);
+
+                if (isUserAAnonymous !== isUserBAnonymous) {
+                    return isUserAAnonymous ? 1 : -1;
+                }
+
+                if (isUserAAnonymous && isUserBAnonymous) {
+                    return Date.parse(userB.createdAt) - Date.parse(userA.createdAt);
+                }
+
+                return userA.username.localeCompare(userB.username);
+            }),
+        [users],
+    );
+
+    const resetCreateUserForm = () => {
+        setNewUsername('');
+        setNewPassword('');
+        setNewIsAdmin(false);
+    };
+
+    const handleOpenCreateDialog = () => {
+        resetCreateUserForm();
+        const generatedPassword = generateSecurePassword();
+        if (generatedPassword) {
+            setNewPassword(generatedPassword);
+        }
+        setIsCreateDialogOpen(true);
+    };
+
+    const handleCloseCreateDialog = () => {
+        if (isCreatingUser) {
+            return;
+        }
+
+        setIsCreateDialogOpen(false);
+        resetCreateUserForm();
+    };
+
+    const handleCreateUser = async (event: FormEvent<HTMLFormElement>) => {
+        event.preventDefault();
+        setIsCreatingUser(true);
 
         try {
             await createUser({
-                username: newUsername,
+                username: newUsername.trim(),
                 password: newPassword,
                 isAdmin: newIsAdmin,
             });
 
-            setNewUsername('');
-            setNewPassword('');
-            setNewIsAdmin(false);
+            setIsCreateDialogOpen(false);
+            resetCreateUserForm();
         } catch {
             // Error is already handled and exposed via `error` state from the hook
+        } finally {
+            setIsCreatingUser(false);
         }
     };
 
@@ -65,103 +115,179 @@ export function UsersList({ allowCreate = true }: UsersListProps) {
         <div className="space-y-6">
             {error && <div className="bg-red-100 text-red-700 p-3 rounded">{error}</div>}
 
-            <Section title={t('users.sectionTitle', { count: users.length })}>
-                {users.map((user) => (
-                    <Card key={user.id}>
-                        <div className="flex justify-between items-start">
-                            <div>
-                                <h3 className="text-xl font-semibold text-gray-900">{user.username}</h3>
-                                <div className="mt-1 flex flex-wrap gap-2">
-                                    {user.isAdmin && (
-                                        <span className="inline-block bg-blue-100 text-blue-800 text-xs px-2 py-1 rounded">
-                                            {t('users.adminRole')}
-                                        </span>
-                                    )}
-                                    {user.authenticationProvider?.includes('SHIBBOLETH') && (
-                                        <Link
-                                            href="/admin/login-methods/shibboleth"
-                                            className="inline-block bg-emerald-100 text-emerald-800 text-xs px-2 py-1 rounded hover:bg-emerald-200"
-                                        >
-                                            Shibboleth
-                                        </Link>
-                                    )}
-                                </div>
-                                {(user.displayName || user.email) && (
-                                    <p className="text-gray-600 text-sm mt-2">
-                                        {[user.displayName, user.email].filter(Boolean).join(' / ')}
-                                    </p>
-                                )}
-                                <p className="text-gray-500 text-sm mt-2">
-                                    {t('users.createdLabel')}:{' '}
-                                    {formatServerLanguageHumanReadableDate(user.createdAt, language)}
-                                </p>
-                            </div>
-                            <div className="space-x-2">
-                                <button
-                                    onClick={() => handleToggleAdmin(user.username, user.isAdmin)}
-                                    className="text-sm text-blue-600 hover:text-blue-800"
-                                >
-                                    {user.isAdmin ? t('users.removeAdmin') : t('users.makeAdmin')}
-                                </button>
-                                <button
-                                    onClick={() => handleDeleteUser(user.username)}
-                                    className="text-sm text-red-600 hover:text-red-800"
-                                >
-                                    {t('users.delete')}
-                                </button>
-                            </div>
-                        </div>
-                    </Card>
-                ))}
-
-                {allowCreate && (
-                    <div
-                        id="create-user"
-                        className="block p-6 bg-gray-50 rounded-lg border border-dashed border-gray-300"
-                    >
-                        <h3 className="text-lg font-semibold text-gray-700 mb-4">{t('users.addNewUser')}</h3>
-                        <form onSubmit={handleCreateUser} className="space-y-3">
-                            <div>
-                                <input
-                                    type="text"
-                                    placeholder={t('users.usernamePlaceholder')}
-                                    value={newUsername}
-                                    onChange={(e) => setNewUsername(e.target.value)}
-                                    className="w-full p-2 border border-gray-300 rounded"
-                                    required
-                                />
-                            </div>
-                            <div>
-                                <SecretInput
-                                    placeholder={t('users.passwordPlaceholder')}
-                                    value={newPassword}
-                                    onChange={(e) => setNewPassword(e.target.value)}
-                                    required
-                                    aria-label={t('users.passwordAriaLabel')}
-                                />
-                            </div>
-                            <div className="flex items-center">
-                                <input
-                                    type="checkbox"
-                                    id="newIsAdmin"
-                                    checked={newIsAdmin}
-                                    onChange={(e) => setNewIsAdmin(e.target.checked)}
-                                    className="mr-2"
-                                />
-                                <label htmlFor="newIsAdmin" className="text-gray-700">
-                                    {t('users.isAdminCheckbox')}
-                                </label>
-                            </div>
-                            <button
-                                type="submit"
-                                className="w-full bg-blue-600 text-white p-2 rounded hover:bg-blue-700 transition-colors"
-                            >
-                                {t('users.createUser')}
-                            </button>
-                        </form>
+            <Section
+                title={t('users.sectionTitle', { count: users.length })}
+                gridClassName="block"
+                sectionClassName="mt-4"
+            >
+                <div className="mb-4 flex flex-col gap-3 sm:flex-row sm:items-center sm:justify-between">
+                    <p className="text-sm text-gray-500">{t('users.tableDescription')}</p>
+                    {allowCreate ? (
+                        <button
+                            type="button"
+                            onClick={handleOpenCreateDialog}
+                            className="inline-flex items-center justify-center gap-2 rounded-md bg-blue-600 px-3 py-2 text-sm font-semibold text-white hover:bg-blue-700"
+                        >
+                            <UserPlus className="h-4 w-4" />
+                            {t('users.addNewUser')}
+                        </button>
+                    ) : null}
+                </div>
+
+                <Card className="overflow-hidden p-0 hover:border-gray-200 hover:shadow-md">
+                    <div className="overflow-x-auto">
+                        <table className="min-w-full divide-y divide-gray-200 text-sm">
+                            <thead className="bg-gray-50">
+                                <tr>
+                                    <th className="px-4 py-3 text-left font-medium text-gray-500">
+                                        {t('users.userColumn')}
+                                    </th>
+                                    <th className="px-4 py-3 text-left font-medium text-gray-500">
+                                        {t('users.roleColumn')}
+                                    </th>
+                                    <th className="px-4 py-3 text-left font-medium text-gray-500">
+                                        {t('users.createdLabel')}
+                                    </th>
+                                    <th className="px-4 py-3 text-left font-medium text-gray-500">
+                                        {t('users.activityColumn')}
+                                    </th>
+                                    <th className="px-4 py-3 text-right font-medium text-gray-500">
+                                        {t('users.actionsColumn')}
+                                    </th>
+                                </tr>
+                            </thead>
+                            <tbody className="divide-y divide-gray-200 bg-white">
+                                {sortedUsers.map((user) => {
+                                    const isAnonymous = isAnonymousUsername(user.username);
+                                    const userHref = `/admin/users/${encodeURIComponent(user.username)}`;
+                                    const chatHistoryHref = `/admin/chat-history?userId=${encodeURIComponent(
+                                        String(user.id),
+                                    )}`;
+
+                                    return (
+                                        <tr key={user.id} className="align-top hover:bg-gray-50">
+                                            <td className="px-4 py-4">
+                                                <Link href={userHref} className="flex min-w-56 items-start gap-3">
+                                                    <span className="mt-0.5 flex h-8 w-8 shrink-0 items-center justify-center rounded-full bg-blue-50 text-blue-700">
+                                                        {isAnonymous ? (
+                                                            <UserRound className="h-4 w-4" />
+                                                        ) : (
+                                                            user.username.slice(0, 1).toUpperCase()
+                                                        )}
+                                                    </span>
+                                                    <span className="min-w-0">
+                                                        <span className="block truncate font-semibold text-gray-900 hover:text-blue-700">
+                                                            {isAnonymous
+                                                                ? t('users.anonymousUser')
+                                                                : user.displayName || user.username}
+                                                        </span>
+                                                        <span className="mt-1 block truncate font-mono text-xs text-gray-500">
+                                                            {user.username}
+                                                        </span>
+                                                        {user.email ? (
+                                                            <span className="mt-1 block truncate text-xs text-gray-500">
+                                                                {user.email}
+                                                            </span>
+                                                        ) : null}
+                                                    </span>
+                                                </Link>
+                                            </td>
+                                            <td className="whitespace-nowrap px-4 py-4">
+                                                <div className="flex flex-wrap gap-2">
+                                                    <span
+                                                        className={`inline-flex items-center gap-1 rounded-full px-2.5 py-1 text-xs font-medium ${
+                                                            user.isAdmin
+                                                                ? 'bg-blue-100 text-blue-800'
+                                                                : 'bg-gray-100 text-gray-700'
+                                                        }`}
+                                                    >
+                                                        {user.isAdmin ? <ShieldCheck className="h-3.5 w-3.5" /> : null}
+                                                        {user.isAdmin ? t('users.adminRole') : t('users.userRole')}
+                                                    </span>
+                                                    {isAnonymous ? (
+                                                        <span className="inline-flex rounded-full bg-amber-100 px-2.5 py-1 text-xs font-medium text-amber-800">
+                                                            {t('users.anonymousLabel')}
+                                                        </span>
+                                                    ) : null}
+                                                    {user.authenticationProvider?.includes('SHIBBOLETH') ? (
+                                                        <Link
+                                                            href="/admin/login-methods/shibboleth"
+                                                            className="inline-flex rounded-full bg-emerald-100 px-2.5 py-1 text-xs font-medium text-emerald-800 hover:bg-emerald-200"
+                                                        >
+                                                            Shibboleth
+                                                        </Link>
+                                                    ) : null}
+                                                </div>
+                                            </td>
+                                            <td className="whitespace-nowrap px-4 py-4 text-gray-600">
+                                                {formatServerLanguageHumanReadableDate(user.createdAt, language)}
+                                            </td>
+                                            <td className="whitespace-nowrap px-4 py-4">
+                                                <Link
+                                                    href={chatHistoryHref}
+                                                    className="font-medium text-blue-600 hover:text-blue-800"
+                                                >
+                                                    {t('users.viewChatHistory')}
+                                                </Link>
+                                                <Link
+                                                    href={userHref}
+                                                    className="mt-1 block text-xs text-gray-500 hover:text-blue-700"
+                                                >
+                                                    {t('users.viewProfile')}
+                                                </Link>
+                                            </td>
+                                            <td className="whitespace-nowrap px-4 py-4 text-right text-xs font-medium">
+                                                <div className="flex flex-col items-end gap-2">
+                                                    <button
+                                                        type="button"
+                                                        onClick={() =>
+                                                            void handleToggleAdmin(user.username, user.isAdmin)
+                                                        }
+                                                        className="text-blue-600 hover:text-blue-800"
+                                                    >
+                                                        {user.isAdmin ? t('users.removeAdmin') : t('users.makeAdmin')}
+                                                    </button>
+                                                    <button
+                                                        type="button"
+                                                        onClick={() => void handleDeleteUser(user.username)}
+                                                        className="text-red-600 hover:text-red-800"
+                                                    >
+                                                        {t('users.delete')}
+                                                    </button>
+                                                </div>
+                                            </td>
+                                        </tr>
+                                    );
+                                })}
+                            </tbody>
+                        </table>
                     </div>
-                )}
+                    {sortedUsers.length === 0 ? (
+                        <div className="p-8 text-center text-sm text-gray-500">{t('users.noUsers')}</div>
+                    ) : null}
+                </Card>
             </Section>
+
+            {allowCreate ? (
+                <CreateUserDialog
+                    isAdmin={newIsAdmin}
+                    isOpen={isCreateDialogOpen}
+                    isSubmitting={isCreatingUser}
+                    onClose={handleCloseCreateDialog}
+                    onGeneratePassword={() => {
+                        const generatedPassword = generateSecurePassword();
+                        if (generatedPassword) {
+                            setNewPassword(generatedPassword);
+                        }
+                    }}
+                    onSubmit={handleCreateUser}
+                    password={newPassword}
+                    setIsAdmin={setNewIsAdmin}
+                    setPassword={setNewPassword}
+                    setUsername={setNewUsername}
+                    username={newUsername}
+                />
+            ) : null}
         </div>
     );
 }

package/apps/agents-server/src/components/UsersList/generateSecurePassword.ts

@@ -0,0 +1,50 @@
+/**
+ * Default length of passwords generated for new admin users.
+ */
+const GENERATED_PASSWORD_LENGTH = 20;
+
+/**
+ * Characters used by generated passwords.
+ */
+const GENERATED_PASSWORD_CHARACTERS = 'ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz23456789!@#$%^&*+-_=~';
+
+/**
+ * Generates a password using the browser Web Crypto API.
+ *
+ * Rejection sampling keeps every character equally likely even though the
+ * alphabet length is not a power of two.
+ *
+ * @returns A cryptographically random password, or an empty string when a secure random source is unavailable.
+ *
+ * @private utility of <CreateUserDialog/>
+ */
+export function generateSecurePassword(): string {
+    const secureRandomSource = globalThis.crypto;
+
+    if (!secureRandomSource?.getRandomValues) {
+        return '';
+    }
+
+    const characterCount = GENERATED_PASSWORD_CHARACTERS.length;
+    const largestAcceptableRandomValue = Math.floor(0x1_0000_0000 / characterCount) * characterCount;
+    const passwordCharacters: Array<string> = [];
+    const randomValues = new Uint32Array(64);
+
+    while (passwordCharacters.length < GENERATED_PASSWORD_LENGTH) {
+        secureRandomSource.getRandomValues(randomValues);
+
+        for (const randomValue of randomValues) {
+            if (randomValue >= largestAcceptableRandomValue) {
+                continue;
+            }
+
+            passwordCharacters.push(GENERATED_PASSWORD_CHARACTERS.charAt(randomValue % characterCount));
+
+            if (passwordCharacters.length === GENERATED_PASSWORD_LENGTH) {
+                break;
+            }
+        }
+    }
+
+    return passwordCharacters.join('');
+}

package/apps/agents-server/src/components/UsersList/useUserActivity.ts

@@ -0,0 +1,78 @@
+'use client';
+
+import { useEffect, useState } from 'react';
+import { $fetchChatHistory, type ChatHistoryRow } from '../../utils/chatHistoryAdmin';
+
+/**
+ * Number of recent messages shown in the user activity preview.
+ */
+const USER_ACTIVITY_PAGE_SIZE = 10;
+
+/**
+ * State returned by the user activity hook.
+ *
+ * @private internal user administration state
+ */
+export type UserActivityState = {
+    readonly error: string | null;
+    readonly isLoading: boolean;
+    readonly items: ChatHistoryRow[];
+    readonly total: number;
+};
+
+/**
+ * Loads recent recorded chat activity for one user.
+ *
+ * @param userId - Database id of the user to inspect.
+ * @returns Recent chat activity and loading state.
+ *
+ * @private hook of <UserDetailClient/>
+ */
+export function useUserActivity(userId: number): UserActivityState {
+    const [items, setItems] = useState<ChatHistoryRow[]>([]);
+    const [total, setTotal] = useState(0);
+    const [isLoading, setIsLoading] = useState(false);
+    const [error, setError] = useState<string | null>(null);
+
+    useEffect(() => {
+        let isCancelled = false;
+
+        async function loadUserActivity(): Promise<void> {
+            setIsLoading(true);
+            setError(null);
+
+            try {
+                const response = await $fetchChatHistory({
+                    userId,
+                    page: 1,
+                    pageSize: USER_ACTIVITY_PAGE_SIZE,
+                    sortBy: 'createdAt',
+                    sortOrder: 'desc',
+                });
+
+                if (isCancelled) {
+                    return;
+                }
+
+                setItems(response.items);
+                setTotal(response.total);
+            } catch (loadError) {
+                if (!isCancelled) {
+                    setError(loadError instanceof Error ? loadError.message : 'Failed to load user activity.');
+                }
+            } finally {
+                if (!isCancelled) {
+                    setIsLoading(false);
+                }
+            }
+        }
+
+        void loadUserActivity();
+
+        return () => {
+            isCancelled = true;
+        };
+    }, [userId]);
+
+    return { error, isLoading, items, total };
+}

package/apps/agents-server/src/constants/harnessAuthRoutes.ts

@@ -0,0 +1,20 @@
+/**
+ * Admin page path for configuring standalone harness authentication.
+ *
+ * @private internal route constant for Agents Server Harness Auth UI
+ */
+export const HARNESS_AUTH_ADMIN_PATH = '/superadmin/harness-auth';
+
+/**
+ * Admin API path for configuring standalone harness authentication.
+ *
+ * @private internal route constant for Agents Server Harness Auth UI
+ */
+export const HARNESS_AUTH_API_PATH = '/api/admin/harness-auth';
+
+/**
+ * Admin API path for the interactive harness authentication terminal.
+ *
+ * @private internal route constant for Agents Server Harness Auth UI
+ */
+export const HARNESS_AUTHENTICATION_API_PATH = `${HARNESS_AUTH_API_PATH}/authentication`;

package/apps/agents-server/src/constants/serverLimits.ts

@@ -37,7 +37,7 @@ export const DEFAULT_SPAWN_AGENT_RATE_LIMIT_WINDOW_MS = 10 * 60 * 1000;
  *
  * @private shared Agents Server constant
  */
-export const DEFAULT_LOCAL_AGENT_RUNNER_MAX_FAILED_ATTEMPTS = 3;
+export const DEFAULT_LOCAL_AGENT_RUNNER_MAX_FAILED_ATTEMPTS = 1;
 
 /**
  * Default maximum number of local runner harness instances allowed to answer queued messages at once.
@@ -182,7 +182,7 @@ export const SERVER_LIMIT_DEFINITIONS = [
         key: SERVER_LIMIT_KEYS.LOCAL_AGENT_RUNNER_MAX_FAILED_ATTEMPTS,
         category: 'Local agent runner',
         title: 'Max failed message attempts',
-        description: 'Stops the local coding-agent watcher from retrying the same queued chat message forever.',
+        description: 'Fails the chat completion task after this many failed local coding-agent attempts.',
         unit: 'count',
         defaultValue: DEFAULT_LOCAL_AGENT_RUNNER_MAX_FAILED_ATTEMPTS,
         minimumValue: 1,

package/apps/agents-server/src/constants/shibbolethAuth.ts

@@ -101,6 +101,19 @@ export type ShibbolethAuthenticationMenuStatus = {
     readonly isConfigured: boolean;
 };
 
+/**
+ * Shibboleth menu status shown to viewers who are not allowed to see login-method configuration.
+ *
+ * The Shibboleth menu entry and its misconfiguration warning are meant for administrators only, so
+ * non-admin viewers receive this inert status instead of the real activation/configuration values.
+ *
+ * @private internal Shibboleth menu default
+ */
+export const SHIBBOLETH_AUTHENTICATION_MENU_STATUS_HIDDEN: ShibbolethAuthenticationMenuStatus = {
+    isActive: false,
+    isConfigured: false,
+};
+
 /**
  * Parses a metadata boolean value.
  *

package/apps/agents-server/src/database/$provideDatabaseAdminExecutor.ts

@@ -2,10 +2,8 @@ import type { StudioBFFSqlLintDetails, StudioBFFSqlLintResult } from '@prisma/st
 import { Pool, type PoolClient } from 'pg';
 import { isAgentsServerSqliteMode } from './agentsServerDatabaseMode';
 import { resolvePostgresConnectionString } from './resolvePostgresConnectionString';
-import {
-    $provideAgentsServerSqliteDatabase,
-    type AgentsServerSqliteDatabase,
-} from './sqlite/$provideAgentsServerSqliteDatabase';
+import { $provideCurrentServerSqliteDatabase } from './sqlite/$provideCurrentServerSqliteDatabase';
+import type { AgentsServerSqliteDatabase } from './sqlite/$provideAgentsServerSqliteDatabase';
 
 /**
  * Query shape sent by Embedded Prisma Studio adapters.
@@ -65,19 +63,20 @@ function $providePostgresDatabaseAdminExecutor(): DatabaseAdminExecutor {
 /**
  * Provides the SQLite raw SQL executor used by Embedded Prisma Studio.
  *
+ * The executor targets the isolated database of the server handling the current
+ * request, so one server's admin can never inspect another server's data.
+ *
  * @returns SQLite-backed database admin executor.
  */
 function $provideSqliteDatabaseAdminExecutor(): DatabaseAdminExecutor {
-    const database = $provideAgentsServerSqliteDatabase();
-
     return {
-        execute: (query) => Promise.resolve(executeSqliteDatabaseAdminQuery(database, query)),
-        executeTransaction: (queries) =>
-            Promise.resolve(
-                database.transaction((transactionQueries: ReadonlyArray<DatabaseAdminQuery>) =>
-                    transactionQueries.map((query) => executeSqliteDatabaseAdminQuery(database, query)),
-                )(queries),
-            ),
+        execute: async (query) => executeSqliteDatabaseAdminQuery(await $provideCurrentServerSqliteDatabase(), query),
+        executeTransaction: async (queries) => {
+            const database = await $provideCurrentServerSqliteDatabase();
+            return database.transaction((transactionQueries: ReadonlyArray<DatabaseAdminQuery>) =>
+                transactionQueries.map((query) => executeSqliteDatabaseAdminQuery(database, query)),
+            )(queries);
+        },
         lintSql: (details) => Promise.resolve({ diagnostics: [], schemaVersion: details.schemaVersion }),
     };
 }