@proletariat/cli 0.3.92 → 0.3.94

package/dist/commands/work/start.js

@@ -3,7 +3,6 @@ import { Args, Flags } from '@oclif/core';
 import * as fs from 'node:fs';
 import * as path from 'node:path';
 import { execSync } from 'node:child_process';
-import Database from 'better-sqlite3';
 import { PMOCommand, pmoBaseFlags, autoExportToBoard } from '../../lib/pmo/index.js';
 import { trackAgentSpawned, trackPrimitiveExecuted } from '../../lib/telemetry/analytics.js';
 import { enrichAgentSession } from '../../lib/telemetry/telemetry-bridge.js';
@@ -13,6 +12,7 @@ import { FlagResolver } from '../../lib/flags/index.js';
 import { getWorkColumnSetting, findColumnByName, getTicketExternalMetadata, resolveExternalTicketId, resolveReviewGate } from '../../lib/pmo/utils.js';
 import { styles } from '../../lib/styles.js';
 import { getWorkspaceInfo, createEphemeralAgent, getTicketTmuxSession, killTmuxSession, findWorktreeForBranch, resolveAgentDir, } from '../../lib/agents/commands.js';
+import { openWorkspaceDatabase } from '../../lib/database/index.js';
 import { generateBranchName, DEFAULT_EXECUTION_CONFIG, } from '../../lib/execution/types.js';
 import { runExecution, isDockerRunning, isGitHubTokenAvailable, isDevcontainerCliInstalled, dockerCredentialsExist, getDockerCredentialInfo, isClaudeExecutor, getExecutorDisplayName } from '../../lib/execution/runners.js';
 import { ExecutionStorage, ContainerStorage } from '../../lib/execution/storage.js';
@@ -41,7 +41,7 @@ function tryGitCommand(cmd, cwd) {
         return true;
     }
     catch {
-        return false;
+        return false; /* git command failed — caller uses boolean to branch logic */
     }
 }
 /**
@@ -137,6 +137,7 @@ function buildExternalSpawnContextMessage(envelope, additionalMessage) {
 }
 export default class WorkStart extends PMOCommand {
     static description = 'Start work on a ticket (launches an agent to implement it)';
+    static strict = false; // Allow multiple ticket ID args for batch spawn
     static examples = [
         '<%= config.bin %> <%= command.id %> TKT-001',
         '<%= config.bin %> <%= command.id %> TKT-001 --create-pr  # Create PR when work is ready',
@@ -157,10 +158,12 @@ export default class WorkStart extends PMOCommand {
         '<%= config.bin %> <%= command.id %> --from-issue                       # Uses workspace default source',
         '<%= config.bin %> <%= command.id %> TKT-001 --review-gate auto        # Ship directly, no approval needed',
         '<%= config.bin %> <%= command.id %> TKT-001 --review-gate post        # Ship then human reviews after',
+        '<%= config.bin %> <%= command.id %> PRLT-1085 PRLT-1086 PRLT-1087 --action implement --create-pr  # Batch spawn in parallel',
+        '<%= config.bin %> <%= command.id %> TKT-001 TKT-002 TKT-003 --max-parallel 2  # Limit concurrent spawns',
     ];
     static args = {
         ticketId: Args.string({
-            description: 'Ticket ID - prompts with dropdown if not provided',
+            description: 'Ticket ID(s) - prompts with dropdown if not provided. Pass multiple IDs for batch spawn.',
             required: false,
         }),
     };
@@ -309,6 +312,10 @@ export default class WorkStart extends PMOCommand {
             description: 'Repository to mount in agent workspace (can be specified multiple times, first is primary)',
             multiple: true,
         }),
+        'max-parallel': Flags.integer({
+            description: 'Maximum number of concurrent spawns when starting multiple tickets (default: unlimited)',
+            min: 1,
+        }),
     };
     async findLinkedTicketByEnvelope(projectId, envelope) {
         const tickets = await this.storage.listTickets(projectId);
@@ -444,7 +451,7 @@ export default class WorkStart extends PMOCommand {
         };
     }
     async execute() {
-        const { args, flags } = await this.parse(WorkStart);
+        const { args, flags, argv } = await this.parse(WorkStart);
         let projectId = flags.project;
         // Check for conflicting PR flags
         if (flags['create-pr'] && flags['no-pr']) {
@@ -492,8 +499,7 @@ export default class WorkStart extends PMOCommand {
             return handleError('NOT_IN_WORKSPACE', 'Not in a workspace. Run "prlt new" first.');
         }
         // Open database for execution storage
-        const dbPath = path.join(workspaceInfo.path, '.proletariat', 'workspace.db');
-        const db = new Database(dbPath);
+        const db = openWorkspaceDatabase(workspaceInfo.path);
         const executionStorage = new ExecutionStorage(db);
         try {
             // Handle batch mode (--all)
@@ -501,6 +507,12 @@ export default class WorkStart extends PMOCommand {
                 await this.runBatchMode(workspaceInfo, db, executionStorage, flags);
                 return;
             }
+            // Handle multi-ticket batch spawn: prlt work start TICKET1 TICKET2 TICKET3
+            const ticketIdArgs = argv.filter(a => !a.startsWith('-'));
+            if (ticketIdArgs.length > 1) {
+                await this.runMultiTicketBatch(ticketIdArgs, workspaceInfo, db, executionStorage, flags);
+                return;
+            }
             // Get ticketId - prompt if not provided
             let ticketId = args.ticketId;
             let externalIssueContextMessage;
@@ -1484,9 +1496,10 @@ export default class WorkStart extends PMOCommand {
                     this.log(styles.warning('Docker daemon is not running. Start Docker Desktop or use --run-on-host.'));
                     this.log('');
                     if (flags.yes || !process.stdout.isTTY) {
-                        // Non-interactive mode: auto-switch to host
-                        environment = 'host';
-                        this.log(styles.muted('Switched to host environment (Docker not running).'));
+                        // Non-interactive mode: error instead of silently falling back to host
+                        db.close();
+                        this.error('Cannot start in Docker — Docker daemon is not running.\n' +
+                            'Start Docker Desktop, or use --run-on-host to explicitly run on host.');
                     }
                     else {
                         const dockerChoices = [
@@ -1538,10 +1551,10 @@ export default class WorkStart extends PMOCommand {
                         const hasCredentials = dockerCredentialsExist();
                         if (!hasCredentials) {
                             if (flags.yes || !process.stdout.isTTY) {
-                                // Non-interactive mode: auto-fallback to host
-                                this.log(styles.warning('⚠️  Saved auth method is "oauth" but no OAuth credentials found.'));
-                                environment = 'host';
-                                this.log(styles.muted('Switched to host environment (OAuth credentials missing).'));
+                                // Non-interactive mode: error instead of silently falling back to host
+                                db.close();
+                                this.error('Cannot start in Docker — OAuth credentials not found.\n' +
+                                    `Run \`${this.config.bin} agent auth\` to set up credentials, or use --run-on-host to explicitly run on host.`);
                             }
                             else {
                                 this.log('');
@@ -1563,9 +1576,10 @@ export default class WorkStart extends PMOCommand {
                         else {
                             // No saved preference and no OAuth credentials — prompt user
                             if (flags.yes || !process.stdout.isTTY) {
-                                // Non-interactive mode: auto-fallback to host
-                                environment = 'host';
-                                this.log(styles.warning('⚠️  No OAuth credentials found. Switched to host environment.'));
+                                // Non-interactive mode: error instead of silently falling back to host
+                                db.close();
+                                this.error('Cannot start in Docker — OAuth credentials not found.\n' +
+                                    `Run \`${this.config.bin} agent auth\` to set up credentials, or use --run-on-host to explicitly run on host.`);
                             }
                             else {
                                 this.log('');
@@ -2278,6 +2292,158 @@ export default class WorkStart extends PMOCommand {
             throw error;
         }
     }
+    /**
+     * Run multi-ticket batch spawn: prlt work start TICKET1 TICKET2 TICKET3
+     * Spawns agents in parallel with optional --max-parallel concurrency limit.
+     */
+    async runMultiTicketBatch(ticketIds, workspaceInfo, db, executionStorage, flags) {
+        const jsonMode = shouldOutputJson(flags);
+        const maxParallel = flags['max-parallel'] || ticketIds.length;
+        if (!jsonMode) {
+            this.log('');
+            this.log(styles.header(`Batch spawn: ${ticketIds.length} ticket(s)${maxParallel < ticketIds.length ? ` (max ${maxParallel} concurrent)` : ''}`));
+            this.log('');
+        }
+        // Resolve project ID (needed for ticket lookups)
+        let projectId = flags.project;
+        projectId = projectId || await this.requireProject({
+            jsonMode: jsonMode ? { flags, commandName: 'work start', baseCommand: `prlt work start ${ticketIds.join(' ')}` } : undefined,
+        });
+        const tickets = [];
+        for (const rawId of ticketIds) {
+            // Try direct lookup first
+            let ticket = await this.storage.getTicket(rawId);
+            // If not found, try resolving as external ticket ID
+            if (!ticket) {
+                const resolved = resolveExternalTicketId({ id: rawId, metadata: {} });
+                if (resolved !== rawId) {
+                    ticket = await this.storage.getTicket(resolved);
+                }
+            }
+            // Still not found — try searching by external key in metadata
+            if (!ticket) {
+                const allTickets = await this.storage.listTickets(projectId);
+                ticket = allTickets.find(t => {
+                    const ext = getTicketExternalMetadata(t);
+                    return ext.key === rawId;
+                }) ?? null;
+            }
+            if (!ticket) {
+                if (jsonMode) {
+                    outputErrorAsJson('TICKET_NOT_FOUND', `Ticket "${rawId}" not found.`, createMetadata('work start', flags));
+                    db.close();
+                    return;
+                }
+                this.error(`Ticket "${rawId}" not found.`);
+                return; // unreachable but helps TS narrowing
+            }
+            tickets.push({ ticket, originalId: rawId });
+        }
+        // Build start args that apply to all tickets (same flags for all)
+        const buildStartArgs = (ticketId, projId) => {
+            const startArgs = [ticketId, '--project', projId, '--ephemeral'];
+            if (flags.action)
+                startArgs.push('--action', flags.action);
+            if (flags.prompt)
+                startArgs.push('--prompt', flags.prompt);
+            if (flags.message)
+                startArgs.push('--message', flags.message);
+            if (flags.display)
+                startArgs.push('--display', flags.display);
+            if (flags['run-on-host'])
+                startArgs.push('--run-on-host');
+            if (flags.executor)
+                startArgs.push('--executor', flags.executor);
+            if (flags['permission-mode'])
+                startArgs.push('--permission-mode', flags['permission-mode']);
+            if (flags['skip-permissions'])
+                startArgs.push('--skip-permissions');
+            if (flags['create-pr'])
+                startArgs.push('--create-pr');
+            if (flags['no-pr'])
+                startArgs.push('--no-pr');
+            if (flags.session)
+                startArgs.push('--session', flags.session);
+            if (flags.force)
+                startArgs.push('--force');
+            if (flags.focus)
+                startArgs.push('--focus');
+            if (flags.clone)
+                startArgs.push('--clone');
+            if (flags['review-gate'])
+                startArgs.push('--review-gate', flags['review-gate']);
+            if (flags['tool-policy'])
+                startArgs.push('--tool-policy', flags['tool-policy']);
+            if (flags['keep-alive'])
+                startArgs.push('--keep-alive');
+            if (flags.cleanup)
+                startArgs.push('--cleanup', flags.cleanup);
+            if (flags['allow-network'])
+                startArgs.push('--allow-network', flags['allow-network']);
+            if (flags['use-api-key'])
+                startArgs.push('--use-api-key');
+            if (flags.yes)
+                startArgs.push('--yes');
+            return startArgs;
+        };
+        let successCount = 0;
+        let failCount = 0;
+        const executionResults = [];
+        // Spawn agents with concurrency control
+        const spawnOne = async (entry) => {
+            const { ticket, originalId } = entry;
+            try {
+                if (!jsonMode) {
+                    this.log(styles.muted(`Starting ${ticket.id}...`));
+                }
+                const startArgs = buildStartArgs(ticket.id, ticket.projectId || projectId);
+                await this.config.runCommand('work:start', startArgs);
+                successCount++;
+                executionResults.push({
+                    workId: `WORK-${ticket.id}`,
+                    ticketId: ticket.id,
+                    agent: 'ephemeral',
+                    status: 'running',
+                });
+            }
+            catch (error) {
+                failCount++;
+                if (!jsonMode) {
+                    this.log(styles.error(`Failed to start ${originalId}: ${error instanceof Error ? error.message : error}`));
+                }
+                executionResults.push({
+                    workId: '',
+                    ticketId: ticket.id,
+                    agent: '',
+                    status: 'failed',
+                });
+            }
+        };
+        // Run with concurrency limit
+        if (maxParallel >= tickets.length) {
+            // Unlimited: spawn all in parallel
+            await Promise.all(tickets.map(entry => spawnOne(entry)));
+        }
+        else {
+            // Limited concurrency: process in batches
+            for (let i = 0; i < tickets.length; i += maxParallel) {
+                const batch = tickets.slice(i, i + maxParallel);
+                // eslint-disable-next-line no-await-in-loop
+                await Promise.all(batch.map(entry => spawnOne(entry)));
+            }
+        }
+        await autoExportToBoard(this.pmoPath, this.storage, () => { });
+        db.close();
+        // Output results
+        if (jsonMode) {
+            const metadata = createMetadata('work start', flags);
+            outputExecutionResultAsJson(executionResults, successCount, failCount, metadata);
+        }
+        else {
+            this.log('');
+            this.log(styles.success(`Batch complete: ${successCount} started, ${failCount} failed`));
+        }
+    }
     /**
      * Run batch mode: spawn work for all unassigned backlog tickets
      */
@@ -2413,9 +2579,10 @@ export default class WorkStart extends PMOCommand {
                 this.log(styles.warning('Docker daemon is not running. Start Docker Desktop or use --run-on-host.'));
                 this.log('');
                 if (!process.stdout.isTTY) {
-                    // Non-interactive mode: auto-switch to host
-                    flags['run-on-host'] = true;
-                    this.log(styles.muted('All agents will run on host (Docker not running).'));
+                    // Non-interactive mode: error instead of silently falling back to host
+                    db.close();
+                    this.error('Cannot start in Docker — Docker daemon is not running.\n' +
+                        'Start Docker Desktop, or use --run-on-host to explicitly run on host.');
                 }
                 else {
                     const { dockerAction } = await this.prompt([
@@ -2442,9 +2609,10 @@ export default class WorkStart extends PMOCommand {
                 const hasCredentials = dockerCredentialsExist();
                 if (!hasCredentials) {
                     if (!process.stdout.isTTY) {
-                        // Non-interactive mode: auto-fallback to host
-                        this.log(styles.warning('⚠️  No OAuth credentials found. Switched to host environment.'));
-                        flags['run-on-host'] = true;
+                        // Non-interactive mode: error instead of silently falling back to host
+                        db.close();
+                        this.error('Cannot start in Docker — OAuth credentials not found.\n' +
+                            `Run \`${this.config.bin} agent auth\` to set up credentials, or use --run-on-host to explicitly run on host.`);
                     }
                     else {
                         const hasApiKey = !!process.env.ANTHROPIC_API_KEY;