@proletariat/cli 0.3.71 → 0.3.73

package/dist/commands/work/start.js

@@ -30,6 +30,7 @@ import { LinearMapper } from '../../lib/linear/mapper.js';
 import { ExternalIssueAdapterError } from '../../lib/external-issues/types.js';
 import { loadDefaultWorkSource, getConnectedIntegrations, isLocalTicketId, } from '../../lib/work-source/index.js';
 import { pruneWorktrees, checkoutBranchSafe } from '../../lib/branch/index.js';
+import { handlePostExecutionTransition } from '../../lib/work-lifecycle/index.js';
 /**
  * Try to execute a git command, return true if successful
  */
@@ -428,6 +429,7 @@ export default class WorkStart extends PMOCommand {
         if (flags['create-pr'] && flags['no-pr']) {
             if (shouldOutputJson(flags)) {
                 outputErrorAsJson('CONFLICTING_FLAGS', '--create-pr and --no-pr are mutually exclusive', createMetadata('work start', flags));
+                return;
             }
             this.error('--create-pr and --no-pr are mutually exclusive');
         }
@@ -440,6 +442,7 @@ export default class WorkStart extends PMOCommand {
         if (flags['skip-permissions'] && flags['permission-mode']) {
             if (shouldOutputJson(flags)) {
                 outputErrorAsJson('CONFLICTING_FLAGS', 'Cannot use both --skip-permissions and --permission-mode flags. Use only one: --skip-permissions OR --permission-mode danger/safe', createMetadata('work start', flags));
+                return;
             }
             this.error('Cannot use both --skip-permissions and --permission-mode flags.\n' +
                 'Use only one: --skip-permissions OR --permission-mode danger/safe');
@@ -455,7 +458,7 @@ export default class WorkStart extends PMOCommand {
         const handleError = (code, message) => {
             if (jsonMode) {
                 outputErrorAsJson(code, message, createMetadata('work start', flags));
-                this.exit(1);
+                return;
             }
             this.error(message);
         };
@@ -849,9 +852,48 @@ export default class WorkStart extends PMOCommand {
                 if (activeStaffAgents.length > 0) {
                     // Clean up stale executions before checking availability (TKT-604)
                     // This fixes agents appearing as "busy" when their sessions have terminated
-                    const cleanedUp = executionStorage.cleanupStaleExecutions();
-                    if (cleanedUp > 0 && !jsonMode) {
-                        this.log(styles.muted(`   Cleaned up ${cleanedUp} stale execution(s)`));
+                    const cleanedExecutions = executionStorage.cleanupStaleExecutionsDetailed();
+                    if (cleanedExecutions.length > 0 && !jsonMode) {
+                        this.log(styles.muted(`   Cleaned up ${cleanedExecutions.length} stale execution(s)`));
+                    }
+                    // Post-execution hook: validate commits and auto-transition tickets that have PRs to Review
+                    if (cleanedExecutions.length > 0) {
+                        for (const cleaned of cleanedExecutions) {
+                            try {
+                                // Resolve agent directory for commit validation (PRLT-984)
+                                let agentDir;
+                                let repoWorktrees;
+                                if (cleaned.agentName) {
+                                    try {
+                                        agentDir = resolveAgentDir(workspaceInfo, cleaned.agentName);
+                                        repoWorktrees = detectRepoWorktrees(agentDir);
+                                    }
+                                    catch {
+                                        // Agent dir resolution may fail for ephemeral agents that were cleaned up
+                                    }
+                                }
+                                const result = await handlePostExecutionTransition({
+                                    ticketId: cleaned.ticketId,
+                                    agentName: cleaned.agentName,
+                                    branch: cleaned.branch,
+                                    agentDir,
+                                    repoWorktrees,
+                                }, this.storage, db);
+                                if (result.blockedByValidation && !jsonMode) {
+                                    this.log(styles.warning(`   ⚠ ${cleaned.ticketId}: agent completed without meaningful code — ${result.validation?.details}`));
+                                    // Persist validation failure on the execution record
+                                    executionStorage.updateStatus(cleaned.executionId, 'failed', undefined, `Commit validation failed: ${result.validation?.details}`);
+                                }
+                                else if (result.transitioned && !jsonMode) {
+                                    const via = result.provider && result.provider !== 'pmo' ? ` via ${result.provider}` : '';
+                                    const validationInfo = result.validation ? ` (${result.validation.details})` : '';
+                                    this.log(styles.muted(`   Auto-transitioned ${cleaned.ticketId}: ${result.fromState} → ${result.toState}${via}${validationInfo}`));
+                                }
+                            }
+                            catch {
+                                // Non-fatal — don't block work start for transition failures
+                            }
+                        }
                     }
                     // Get list of busy agents (already running something)
                     const busyAgentNames = new Set();
@@ -1037,7 +1079,11 @@ export default class WorkStart extends PMOCommand {
             // Get coder name for branch naming (prompts on first use)
             const coderName = await getOrPromptCoderName(db);
             // Use ticket's existing branch or generate a new one
-            const branch = ticket.branch || generateBranchName(ticket.id, ticket.title, coderName, assignedAgent, ticket.category);
+            // When ticket was imported from an external source, use the external key
+            // (e.g. PRLT-962) instead of the internal PMO ID (e.g. TKT-134) for branch naming
+            const externalMeta = getTicketExternalMetadata(ticket);
+            const branchTicketId = externalMeta.key || ticket.id;
+            const branch = ticket.branch || generateBranchName(branchTicketId, ticket.title, coderName, assignedAgent, ticket.category);
             const isExistingBranch = !!ticket.branch;
             // Get epic info if linked
             let epicTitle;
@@ -1069,16 +1115,16 @@ export default class WorkStart extends PMOCommand {
                 // Interactive action selection
                 // Get ticket's current status to determine suggested action
                 const ticketStatus = await this.storage.getStatus(ticket.statusId || '');
-                const currentCategory = ticketStatus?.category || 'unstarted';
-                // Get suggested action for this category
-                const suggestedAction = await this.storage.getSuggestedAction(currentCategory);
+                const currentStateName = ticketStatus?.name || ticket.statusName || 'Todo';
+                // Get suggested action for this state
+                const suggestedAction = await this.storage.getSuggestedAction(currentStateName);
                 // Get all actions for selection
                 const allActions = await this.storage.listActions();
                 // Build choices with suggested action at top
                 const actionChoiceList = [];
                 if (suggestedAction) {
                     actionChoiceList.push({
-                        name: `${suggestedAction.name} - ${suggestedAction.description || 'Suggested for ' + currentCategory} (Recommended)`,
+                        name: `${suggestedAction.name} - ${suggestedAction.description || 'Suggested for ' + currentStateName} (Recommended)`,
                         value: suggestedAction.id,
                     });
                 }
@@ -1126,7 +1172,7 @@ export default class WorkStart extends PMOCommand {
                         description: 'Unstructured exploration and debugging',
                         prompt: 'You are working on an ad-hoc session for exploration and debugging. Help the user with whatever they need.',
                         modifiesCode: false,
-                        defaultMoveToCategory: 'started',
+                        toState: 'In Progress',
                         isBuiltin: false,
                         createdAt: new Date(),
                     };
@@ -2051,19 +2097,32 @@ export default class WorkStart extends PMOCommand {
                     await this.storage.updateTicket(ticket.id, { assignee: assignedAgent });
                     this.log(styles.muted(`   Assigned to: ${assignedAgent}`));
                 }
-                // Move ticket to target column based on action's defaultMoveToCategory
-                // If action has a target category, find the matching column; otherwise use "started" default
-                const targetCategory = selectedAction?.defaultMoveToCategory || 'started';
+                // Move ticket to target column based on action's toState
+                // If action has a to_state, use that state name directly; otherwise fall back to "In Progress" default
+                const targetStateName = selectedAction?.toState;
                 const board = ticket.projectId ? await this.storage.getProjectBoard(ticket.projectId) : null;
                 const columnNames = board ? board.columns.map(col => col.name) : [];
-                // Map category to column type for lookup
-                const columnType = targetCategory === 'started' ? 'in_progress' :
-                    targetCategory === 'unstarted' ? 'planned' :
-                        targetCategory === 'completed' ? 'done' : 'in_progress';
-                // Get the configured column name for this type (e.g., "In Progress" for in_progress)
-                const workColumnName = getWorkColumnSetting(db, columnType);
-                // Find the actual column on the board (case-insensitive, partial match)
-                const targetColumnName = findColumnByName(columnNames, workColumnName);
+                let targetColumnName = null;
+                if (targetStateName) {
+                    // Try direct state name match first
+                    targetColumnName = findColumnByName(columnNames, targetStateName);
+                    if (!targetColumnName) {
+                        const categoryMap = {
+                            'Backlog': 'planned',
+                            'Todo': 'planned',
+                            'In Progress': 'in_progress',
+                            'Done': 'done',
+                        };
+                        const columnType = categoryMap[targetStateName] || 'in_progress';
+                        const workColumnName = getWorkColumnSetting(db, columnType);
+                        targetColumnName = findColumnByName(columnNames, workColumnName);
+                    }
+                }
+                else {
+                    // No target state specified — default to "In Progress"
+                    const workColumnName = getWorkColumnSetting(db, 'in_progress');
+                    targetColumnName = findColumnByName(columnNames, workColumnName);
+                }
                 if (targetColumnName && ticket.statusName !== targetColumnName) {
                     try {
                         await this.storage.moveTicket(ticket.projectId, ticket.id, targetColumnName);
@@ -2160,9 +2219,46 @@ export default class WorkStart extends PMOCommand {
         // Get staff agents that exist on disk (warns about missing directories)
         const activeStaffAgents = getActiveStaffAgents(workspaceInfo, (msg) => this.log(msg));
         // Clean up stale executions before checking availability (TKT-604)
-        const cleanedUp = executionStorage.cleanupStaleExecutions();
-        if (cleanedUp > 0) {
-            this.log(styles.muted(`   Cleaned up ${cleanedUp} stale execution(s)`));
+        const batchCleanedExecutions = executionStorage.cleanupStaleExecutionsDetailed();
+        if (batchCleanedExecutions.length > 0) {
+            this.log(styles.muted(`   Cleaned up ${batchCleanedExecutions.length} stale execution(s)`));
+            // Post-execution hook: validate commits and auto-transition tickets that have PRs to Review
+            for (const cleaned of batchCleanedExecutions) {
+                try {
+                    // Resolve agent directory for commit validation (PRLT-984)
+                    let agentDir;
+                    let repoWorktrees;
+                    if (cleaned.agentName) {
+                        try {
+                            agentDir = resolveAgentDir(workspaceInfo, cleaned.agentName);
+                            repoWorktrees = detectRepoWorktrees(agentDir);
+                        }
+                        catch {
+                            // Agent dir resolution may fail for ephemeral agents that were cleaned up
+                        }
+                    }
+                    const result = await handlePostExecutionTransition({
+                        ticketId: cleaned.ticketId,
+                        agentName: cleaned.agentName,
+                        branch: cleaned.branch,
+                        agentDir,
+                        repoWorktrees,
+                    }, this.storage, db);
+                    if (result.blockedByValidation) {
+                        this.log(styles.warning(`   ⚠ ${cleaned.ticketId}: agent completed without meaningful code — ${result.validation?.details}`));
+                        // Persist validation failure on the execution record
+                        executionStorage.updateStatus(cleaned.executionId, 'failed', undefined, `Commit validation failed: ${result.validation?.details}`);
+                    }
+                    else if (result.transitioned) {
+                        const via = result.provider && result.provider !== 'pmo' ? ` via ${result.provider}` : '';
+                        const validationInfo = result.validation ? ` (${result.validation.details})` : '';
+                        this.log(styles.muted(`   Auto-transitioned ${cleaned.ticketId}: ${result.fromState} → ${result.toState}${via}${validationInfo}`));
+                    }
+                }
+                catch {
+                    // Non-fatal
+                }
+            }
         }
         const busyAgentNames = new Set();
         for (const agent of activeStaffAgents) {
@@ -2176,6 +2272,7 @@ export default class WorkStart extends PMOCommand {
             db.close();
             if (batchJsonMode) {
                 outputErrorAsJson('NO_AVAILABLE_AGENTS', 'No available agents. All agents are busy with other work.', createMetadata('work start', flags));
+                return;
             }
             this.error('No available agents. All agents are busy with other work.');
         }