@proletariat/cli 0.3.25 → 0.3.27

package/dist/commands/workspace/prune.d.ts

@@ -1,9 +1,10 @@
-import { Command } from '@oclif/core';
-export default class WorkspacePrune extends Command {
+import { PromptCommand } from '../../lib/prompt-command.js';
+export default class WorkspacePrune extends PromptCommand {
     static description: string;
     static examples: string[];
     static flags: {
         'dry-run': import("@oclif/core/interfaces").BooleanFlag<boolean>;
+        force: import("@oclif/core/interfaces").BooleanFlag<boolean>;
         json: import("@oclif/core/interfaces").BooleanFlag<boolean>;
     };
     run(): Promise<void>;

package/dist/commands/workspace/prune.js

@@ -1,14 +1,17 @@
-import { Command, Flags } from '@oclif/core';
+import { Flags } from '@oclif/core';
 import * as fs from 'node:fs';
 import * as path from 'node:path';
+import { PromptCommand } from '../../lib/prompt-command.js';
 import { styles } from '../../lib/styles.js';
 import { getRegisteredHeadquarters, unregisterHeadquarters, } from '../../lib/machine-config.js';
 import { getWorkspaceAgents, removeAgentsFromDatabase, getDatabasePath, } from '../../lib/database/index.js';
-export default class WorkspacePrune extends Command {
+import { outputConfirmationNeededAsJson, createMetadata, } from '../../lib/prompt-json.js';
+export default class WorkspacePrune extends PromptCommand {
     static description = 'Remove stale workspace entries and agents with deleted worktrees';
     static examples = [
         '<%= config.bin %> <%= command.id %> --dry-run',
         '<%= config.bin %> <%= command.id %>',
+        '<%= config.bin %> <%= command.id %> --force',
     ];
     static flags = {
         'dry-run': Flags.boolean({
@@ -16,6 +19,11 @@ export default class WorkspacePrune extends Command {
             description: 'Show what would be removed without removing',
             default: false,
         }),
+        force: Flags.boolean({
+            char: 'f',
+            description: 'Skip confirmation prompt and prune immediately',
+            default: false,
+        }),
         json: Flags.boolean({
             description: 'Output as JSON',
             default: false,
@@ -23,6 +31,10 @@ export default class WorkspacePrune extends Command {
     };
     async run() {
         const { flags } = await this.parse(WorkspacePrune);
+        // In non-TTY mode without --json (CI, scripts, piped), default to dry-run unless --force is set.
+        // In --json mode, we use confirmation_needed output instead of auto-dry-run so agents can review and confirm.
+        const isNonTTY = !process.stdout.isTTY;
+        const effectiveDryRun = flags['dry-run'] || (!flags.json && isNonTTY && !flags.force);
         // Find stale entries
         const staleWorkspaces = this.findStaleWorkspaces();
         const staleAgents = this.findStaleAgents();
@@ -30,7 +42,7 @@ export default class WorkspacePrune extends Command {
         // JSON output
         if (flags.json) {
             const output = {
-                dryRun: flags['dry-run'],
+                dryRun: effectiveDryRun,
                 staleWorkspaces: staleWorkspaces.map(w => ({
                     name: w.name,
                     path: w.path,
@@ -40,13 +52,22 @@ export default class WorkspacePrune extends Command {
                     agentName: a.agentName,
                     expectedPath: a.expectedPath,
                 })),
-                totalRemoved: flags['dry-run'] ? 0 : totalStale,
+                totalRemoved: effectiveDryRun ? 0 : totalStale,
                 totalFound: totalStale,
             };
-            this.log(JSON.stringify(output, null, 2));
-            if (!flags['dry-run'] && totalStale > 0) {
+            if (!effectiveDryRun && totalStale > 0 && !flags.force) {
+                // In JSON mode without --force, output confirmation needed
+                outputConfirmationNeededAsJson({
+                    staleWorkspaces: staleWorkspaces.map(w => ({ name: w.name, path: w.path })),
+                    staleAgents: staleAgents.map(a => ({ workspaceName: a.workspaceName, agentName: a.agentName })),
+                    totalFound: totalStale,
+                }, 'prlt workspace prune --force --json', `Found ${totalStale} stale entries. Run with --force to remove them.`, createMetadata('workspace prune', flags));
+                return;
+            }
+            if (!effectiveDryRun && totalStale > 0) {
                 this.performPrune(staleWorkspaces, staleAgents);
             }
+            this.log(JSON.stringify(output, null, 2));
             return;
         }
         // Human-readable output
@@ -84,7 +105,7 @@ export default class WorkspacePrune extends Command {
         }
         // Summary
         this.log('');
-        if (flags['dry-run']) {
+        if (effectiveDryRun) {
             this.log(styles.warning(`[DRY RUN] Would remove:`));
             if (staleWorkspaces.length > 0) {
                 this.log(styles.muted(`  • ${staleWorkspaces.length} workspace registration(s)`));
@@ -93,10 +114,15 @@ export default class WorkspacePrune extends Command {
                 this.log(styles.muted(`  • ${staleAgents.length} agent record(s)`));
             }
             this.log('');
-            this.log(styles.muted('Run without --dry-run to remove these entries.'));
+            if (isNonTTY) {
+                this.log(styles.muted('Non-TTY environment detected. Run with --force to remove these entries.'));
+            }
+            else {
+                this.log(styles.muted('Run without --dry-run to remove these entries.'));
+            }
         }
-        else {
-            // Perform the actual prune
+        else if (flags.force) {
+            // --force: skip confirmation
             this.performPrune(staleWorkspaces, staleAgents);
             this.log(styles.success('Pruned:'));
             if (staleWorkspaces.length > 0) {
@@ -106,6 +132,40 @@ export default class WorkspacePrune extends Command {
                 this.log(styles.muted(`  • ${staleAgents.length} agent record(s)`));
             }
         }
+        else {
+            // Interactive confirmation
+            const summary = [];
+            if (staleWorkspaces.length > 0) {
+                summary.push(`${staleWorkspaces.length} workspace registration(s)`);
+            }
+            if (staleAgents.length > 0) {
+                summary.push(`${staleAgents.length} agent record(s)`);
+            }
+            const choices = [
+                { name: 'Yes', value: true },
+                { name: 'No', value: false },
+            ];
+            const message = `Remove ${summary.join(' and ')}?`;
+            const { confirmed } = await this.prompt([{
+                    type: 'list',
+                    name: 'confirmed',
+                    message,
+                    choices,
+                }], { flags: flags, commandName: 'workspace prune' });
+            if (confirmed) {
+                this.performPrune(staleWorkspaces, staleAgents);
+                this.log(styles.success('\nPruned:'));
+                if (staleWorkspaces.length > 0) {
+                    this.log(styles.muted(`  • ${staleWorkspaces.length} workspace registration(s)`));
+                }
+                if (staleAgents.length > 0) {
+                    this.log(styles.muted(`  • ${staleAgents.length} agent record(s)`));
+                }
+            }
+            else {
+                this.log(styles.muted('\nPrune cancelled.'));
+            }
+        }
         this.log('');
     }
     findStaleWorkspaces() {

package/dist/hooks/init.js

@@ -13,6 +13,10 @@ const hook = async function ({ id, config }) {
     if (id === 'init') {
         return;
     }
+    // Skip when --help flag is present - help should always be available
+    if (process.argv.includes('--help') || process.argv.includes('-h')) {
+        return;
+    }
     // Skip for help-related commands/flags
     // When user runs just `prlt` with no args, id is undefined
     if (!id || id === 'help') {

package/dist/lib/agents/commands.js

@@ -8,6 +8,7 @@ import inquirer from 'inquirer';
 import { getWorkspaceConfig, getWorkspaceAgents, getWorkspaceRepositories, getAgentWorktrees, addAgentsToDatabase, removeAgentsFromDatabase, addEphemeralAgentToDatabase, getEphemeralAgentNames, getActiveTheme, markAgentCleaned, discoverAgentsOnDisk } from '../database/index.js';
 import { isValidAgentName, getSuggestedAgentNames, generateEphemeralAgentName, getThemePersistentDir, getThemeEphemeralDir, extractBaseName, getAgentBaseName, } from '../themes.js';
 import { createDevcontainerConfig } from '../execution/devcontainer.js';
+import { getGitIdentity } from '../pr/index.js';
 import { getPMOContext } from '../pmo/index.js';
 /**
  * Format a list of agents for display in error messages.
@@ -508,11 +509,14 @@ export async function createEphemeralAgent(workspaceInfo, options) {
     if (!options?.skipDevcontainer) {
         const devcontainerDir = path.join(agentDir, '.devcontainer');
         if (!fs.existsSync(devcontainerDir)) {
+            const gitIdentity = getGitIdentity();
             createDevcontainerConfig({
                 agentName,
                 agentDir,
                 repoWorktrees: mountMode === 'worktree' ? workspaceInfo.repositories.map(r => r.name) : undefined,
                 mountMode,
+                gitUserName: gitIdentity.name || undefined,
+                gitUserEmail: gitIdentity.email || undefined,
             });
         }
     }

package/dist/lib/agents/index.js

@@ -7,6 +7,7 @@ import { isValidAgentName, getSuggestedAgentNames, BUILTIN_THEMES, getThemePersi
 import { getWorkspaceRepositories, getActiveTheme } from '../database/index.js';
 import { styles } from '../styles.js';
 import { createDevcontainerConfig } from '../execution/devcontainer.js';
+import { getGitIdentity } from '../pr/index.js';
 /**
  * Detect the current agent name from environment or directory structure.
  * Returns null if not running in an agent context.
@@ -93,6 +94,11 @@ function getRemoteUrl(repoPath) {
 export async function createAgentWorktrees(workspacePath, agents, hqPath, options) {
     const mountMode = options?.mountMode || 'worktree'; // Default to worktree for real-time file sync
     const modeLabel = mountMode === 'worktree' ? 'worktree' : 'clone';
+    // Detect git identity once for all agents (TKT-934)
+    const gitIdentity = getGitIdentity();
+    if (!gitIdentity.name && !gitIdentity.email) {
+        console.log(chalk.yellow('Warning: Could not detect git identity for devcontainer. Commits may use default identity.'));
+    }
     if (hqPath) {
         // HQ mode - create worktrees/clones for all repos in repos/ directory
         const reposDir = path.join(hqPath, 'repos');
@@ -227,6 +233,8 @@ export async function createAgentWorktrees(workspacePath, agents, hqPath, option
                             agentDir,
                             repoWorktrees: mountMode === 'worktree' && createdRepos.length > 0 ? createdRepos : undefined,
                             mountMode,
+                            gitUserName: gitIdentity.name || undefined,
+                            gitUserEmail: gitIdentity.email || undefined,
                         });
                     }
                     console.log(chalk.green(`✅ Agent ${agent} created with ${createdRepos.length} ${modeLabel}(s)`));
@@ -249,6 +257,8 @@ export async function createAgentWorktrees(workspacePath, agents, hqPath, option
                         agentName: agent,
                         agentDir,
                         mountMode: mountMode,
+                        gitUserName: gitIdentity.name || undefined,
+                        gitUserEmail: gitIdentity.email || undefined,
                     });
                 }
                 console.log(chalk.green(`✅ Placeholder agent ${agent} created`));
@@ -367,6 +377,8 @@ export async function createAgentWorktrees(workspacePath, agents, hqPath, option
                         agentDir,
                         repoWorktrees: mountMode === 'worktree' ? [repoName] : undefined, // Only pass repos for worktree mode
                         mountMode,
+                        gitUserName: gitIdentity.name || undefined,
+                        gitUserEmail: gitIdentity.email || undefined,
                     });
                 }
                 console.log(chalk.green(`✅ Agent ${agent} created with ${modeLabel}`));

package/dist/lib/execution/devcontainer.d.ts

@@ -17,6 +17,10 @@ export interface DevcontainerOptions {
     prltChannel?: string;
     /** Mount mode: 'worktree' needs parent repo mounts + git wrapper, 'clone' is self-contained */
     mountMode?: MountMode;
+    /** Git user.name for commit attribution (detected from gh/git config on host) */
+    gitUserName?: string;
+    /** Git user.email for commit attribution (detected from gh/git config on host) */
+    gitUserEmail?: string;
 }
 export interface DevcontainerJson {
     name: string;

package/dist/lib/execution/devcontainer.js

@@ -106,6 +106,9 @@ export function generateDevcontainerJson(options, config) {
             PRLT_HOST_PATH: options.agentDir,
             // Mount mode - allows scripts to know if git wrapper is needed
             PRLT_MOUNT_MODE: mountMode,
+            // Git identity for commit attribution (detected from host's gh/git config)
+            ...(options.gitUserName ? { PRLT_GIT_USER_NAME: options.gitUserName } : {}),
+            ...(options.gitUserEmail ? { PRLT_GIT_USER_EMAIL: options.gitUserEmail } : {}),
             // /hq/.proletariat/bin contains prlt wrapper with ESM loader for native modules
             PATH: '/hq/.proletariat/bin:/home/node/.npm-global/bin:/usr/local/bin:/usr/bin:/bin',
         },
@@ -452,6 +455,66 @@ else
     echo "Warning: No GitHub token found, git push will require manual auth"
 fi
 
+# Configure git user identity for commit attribution
+# Uses env vars set by host (from gh/git config), with fallback detection
+configure_git_identity() {
+    local git_name="\${PRLT_GIT_USER_NAME:-}"
+    local git_email="\${PRLT_GIT_USER_EMAIL:-}"
+
+    # Fallback: try gh api user if env vars are empty and gh is authenticated
+    if { [ -z "$git_name" ] || [ -z "$git_email" ]; } && command -v gh &> /dev/null && gh auth status &>/dev/null; then
+        if [ -z "$git_name" ]; then
+            git_name=$(gh api user -q '.name // .login' 2>/dev/null || true)
+        fi
+        if [ -z "$git_email" ]; then
+            git_email=$(gh api user -q '.email // empty' 2>/dev/null || true)
+            # Try emails API if public email is not set
+            if [ -z "$git_email" ]; then
+                git_email=$(gh api user/emails -q '[.[] | select(.primary)] | .[0].email' 2>/dev/null || true)
+            fi
+        fi
+    fi
+
+    # Fallback: try git config from mounted repos
+    if [ -z "$git_name" ] || [ -z "$git_email" ]; then
+        for repo_dir in /workspace/*/; do
+            if [ -d "$repo_dir/.git" ] || [ -f "$repo_dir/.git" ]; then
+                if [ -z "$git_name" ]; then
+                    git_name=$(/usr/bin/git -C "$repo_dir" config user.name 2>/dev/null || true)
+                fi
+                if [ -z "$git_email" ]; then
+                    git_email=$(/usr/bin/git -C "$repo_dir" config user.email 2>/dev/null || true)
+                fi
+                if [ -n "$git_name" ] && [ -n "$git_email" ]; then
+                    break
+                fi
+            fi
+        done
+    fi
+
+    # Apply git config
+    if [ -n "$git_name" ]; then
+        /usr/bin/git config --global user.name "$git_name"
+        echo "Git user.name set to: $git_name"
+    fi
+    if [ -n "$git_email" ]; then
+        /usr/bin/git config --global user.email "$git_email"
+        echo "Git user.email set to: $git_email"
+    fi
+
+    # Warning if identity could not be determined
+    if [ -z "$git_name" ] && [ -z "$git_email" ]; then
+        echo "Warning: Could not determine git identity. Commits may use default identity."
+        echo "  To fix: run 'gh auth login' or set git config user.name/user.email in your repo"
+    elif [ -z "$git_name" ]; then
+        echo "Warning: Could not determine git user.name"
+    elif [ -z "$git_email" ]; then
+        echo "Warning: Could not determine git user.email"
+    fi
+}
+
+configure_git_identity
+
 # Check if prlt is already installed globally (via npm from GitHub Packages)
 if command -v prlt &> /dev/null; then
     PRLT_PATH=$(which prlt)

package/dist/lib/mcp/helpers.d.ts

@@ -1,8 +1,23 @@
 /**
  * MCP Helper Functions
  */
+import { z } from 'zod';
+import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
+import type { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
+import type { RequestHandlerExtra } from '@modelcontextprotocol/sdk/shared/protocol.js';
+import type { ServerRequest, ServerNotification } from '@modelcontextprotocol/sdk/types.js';
 import type { Ticket } from '../pmo/types.js';
 import type { McpToolResult } from './types.js';
+/**
+ * Register an MCP tool with strict parameter validation.
+ *
+ * Uses z.object().strict() so that unknown/extra parameters are rejected
+ * with a clear error instead of being silently stripped.
+ * See: https://github.com/anthropics/proletariat/issues/366
+ */
+export declare function strictTool<T extends Record<string, z.ZodType>>(server: McpServer, name: string, description: string, shape: T, handler: (params: {
+    [K in keyof T]: z.infer<T[K]>;
+}, extra: RequestHandlerExtra<ServerRequest, ServerNotification>) => CallToolResult | Promise<CallToolResult>): void;
 export declare function formatTicket(t: Ticket): {
     id: string;
     title: string;

package/dist/lib/mcp/helpers.js

@@ -1,6 +1,21 @@
 /**
  * MCP Helper Functions
  */
+import { z } from 'zod';
+/**
+ * Register an MCP tool with strict parameter validation.
+ *
+ * Uses z.object().strict() so that unknown/extra parameters are rejected
+ * with a clear error instead of being silently stripped.
+ * See: https://github.com/anthropics/proletariat/issues/366
+ */
+export function strictTool(server, name, description, shape, handler) {
+    const strictSchema = z.object(shape).strict();
+    server.registerTool(name, {
+        description,
+        inputSchema: strictSchema,
+    }, handler);
+}
 export function formatTicket(t) {
     return {
         id: t.id,

package/dist/lib/mcp/tools/action.js

@@ -2,9 +2,9 @@
  * MCP Action Tools
  */
 import { z } from 'zod';
-import { errorResponse } from '../helpers.js';
+import { errorResponse, strictTool } from '../helpers.js';
 export function registerActionTools(server, ctx) {
-    server.tool('action_list', 'List work actions', { include_builtin: z.boolean().optional() }, async (params) => {
+    strictTool(server, 'action_list', 'List work actions', { include_builtin: z.boolean().optional() }, async (params) => {
         try {
             const actions = await ctx.storage.listActions({
                 isBuiltin: params.include_builtin ? undefined : false,
@@ -29,7 +29,7 @@ export function registerActionTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('action_show', 'Get action details', { id: z.string().describe('Action ID') }, async (params) => {
+    strictTool(server, 'action_show', 'Get action details', { id: z.string().describe('Action ID') }, async (params) => {
         try {
             const action = await ctx.storage.getAction(params.id);
             if (!action)
@@ -45,7 +45,7 @@ export function registerActionTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('action_create', 'Create a work action', {
+    strictTool(server, 'action_create', 'Create a work action', {
         name: z.string().describe('Action name'),
         prompt: z.string().describe('Start prompt'),
         description: z.string().optional(),
@@ -71,7 +71,7 @@ export function registerActionTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('action_delete', 'Delete an action', { id: z.string().describe('Action ID') }, async (params) => {
+    strictTool(server, 'action_delete', 'Delete an action', { id: z.string().describe('Action ID') }, async (params) => {
         try {
             await ctx.storage.deleteAction(params.id);
             return {

package/dist/lib/mcp/tools/board.js

@@ -2,9 +2,9 @@
  * MCP Board Tools
  */
 import { z } from 'zod';
-import { errorResponse } from '../helpers.js';
+import { errorResponse, strictTool } from '../helpers.js';
 export function registerBoardTools(server, ctx) {
-    server.tool('board_show', 'Show the kanban board', { project: z.string().optional().describe('Project ID') }, async (params) => {
+    strictTool(server, 'board_show', 'Show the kanban board', { project: z.string().optional().describe('Project ID') }, async (params) => {
         try {
             let projectId = params.project;
             if (!projectId) {
@@ -43,7 +43,7 @@ export function registerBoardTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('board_columns', 'Get column names for a project', { project: z.string().optional().describe('Project ID') }, async (params) => {
+    strictTool(server, 'board_columns', 'Get column names for a project', { project: z.string().optional().describe('Project ID') }, async (params) => {
         try {
             let projectId = params.project;
             if (!projectId) {
@@ -64,7 +64,7 @@ export function registerBoardTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('board_create_column', 'Add a new column to the board', {
+    strictTool(server, 'board_create_column', 'Add a new column to the board', {
         project: z.string().describe('Project ID'),
         name: z.string().describe('Column name'),
         position: z.number().optional().describe('Position'),
@@ -82,7 +82,7 @@ export function registerBoardTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('board_rename_column', 'Rename a column', {
+    strictTool(server, 'board_rename_column', 'Rename a column', {
         project: z.string().describe('Project ID'),
         column_id: z.string().describe('Column ID'),
         name: z.string().describe('New name'),
@@ -100,7 +100,7 @@ export function registerBoardTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('board_move_column', 'Reorder a column', {
+    strictTool(server, 'board_move_column', 'Reorder a column', {
         project: z.string().describe('Project ID'),
         column_id: z.string().describe('Column ID'),
         position: z.number().describe('New position'),
@@ -118,7 +118,7 @@ export function registerBoardTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('board_delete_column', 'Delete a column', {
+    strictTool(server, 'board_delete_column', 'Delete a column', {
         project: z.string().describe('Project ID'),
         column_id: z.string().describe('Column ID'),
         cascade: z.boolean().optional().describe('Delete tickets in column'),

package/dist/lib/mcp/tools/category.js

@@ -2,9 +2,9 @@
  * MCP Category Tools
  */
 import { z } from 'zod';
-import { errorResponse } from '../helpers.js';
+import { errorResponse, strictTool } from '../helpers.js';
 export function registerCategoryTools(server, ctx) {
-    server.tool('category_list', 'List categories', { type: z.enum(['ticket', 'status']).optional() }, async (params) => {
+    strictTool(server, 'category_list', 'List categories', { type: z.enum(['ticket', 'status']).optional() }, async (params) => {
         try {
             const categories = await ctx.storage.listCategories({ type: params.type });
             return {
@@ -26,7 +26,7 @@ export function registerCategoryTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('category_create', 'Create a category', {
+    strictTool(server, 'category_create', 'Create a category', {
         name: z.string().describe('Category name'),
         type: z.enum(['ticket', 'status']).describe('Category type'),
         description: z.string().optional(),
@@ -50,7 +50,7 @@ export function registerCategoryTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('category_rename', 'Rename a category', {
+    strictTool(server, 'category_rename', 'Rename a category', {
         id: z.string().describe('Category ID'),
         name: z.string().describe('New name'),
     }, async (params) => {
@@ -67,7 +67,7 @@ export function registerCategoryTools(server, ctx) {
             return errorResponse(error);
         }
     });
-    server.tool('category_delete', 'Delete a category', { id: z.string().describe('Category ID') }, async (params) => {
+    strictTool(server, 'category_delete', 'Delete a category', { id: z.string().describe('Category ID') }, async (params) => {
         try {
             await ctx.storage.deleteCategory(params.id);
             return {