@projectcaluma/ember-form 14.3.0 → 14.3.1

package/addon/lib/document.js

@@ -6,9 +6,9 @@ import { cached } from "tracked-toolbox";
 
 import { decodeId } from "@projectcaluma/ember-core/helpers/decode-id";
 import {
+  flatten,
   intersects,
   mapby,
-  flatten,
 } from "@projectcaluma/ember-core/utils/jexl";
 import Base from "@projectcaluma/ember-form/lib/base";
 
@@ -280,7 +280,7 @@ export default class Document extends Base {
     }
 
     if (field.hidden || [undefined, null].includes(field.value)) {
-      return (defaultValue ?? field.question.isMultipleChoice) ? [] : null;
+      return defaultValue ?? (field.question.isMultipleChoice ? [] : null);
     }
 
     if (field.question.isTable) {

package/addon/lib/field.js

@@ -6,7 +6,7 @@ import { camelize } from "@ember/string";
 import { isEmpty } from "@ember/utils";
 import { tracked } from "@glimmer/tracking";
 import { queryManager } from "ember-apollo-client";
-import { restartableTask, lastValue, dropTask } from "ember-concurrency";
+import { dropTask, lastValue, restartableTask } from "ember-concurrency";
 import { validate } from "ember-validators";
 import isEqual from "lodash.isequal";
 import { cached } from "tracked-toolbox";
@@ -50,14 +50,21 @@ const MUTATION_MAP = {
   TableAnswer: saveDocumentTableAnswerMutation,
 };
 
-const fieldIsHiddenOrEmpty = (field) => {
+const fieldIsHidden = (field) => {
+  return field.hidden;
+};
+
+const fieldIsEmpty = (field) => {
   return (
-    field.hidden ||
-    (!field.question.isTable &&
-      (field.answer.value === null || field.answer.value === undefined))
+    !field.question.isTable &&
+    (field.answer.value === null || field.answer.value === undefined)
   );
 };
 
+const fieldIsHiddenOrEmpty = (field) => {
+  return fieldIsHidden(field) || fieldIsEmpty(field);
+};
+
 /**
  * An object which represents a combination of a question and an answer.
  *
@@ -521,7 +528,7 @@ export default class Field extends Base {
     if (
       this.fieldset.field?.hidden ||
       (this.hiddenDependencies.length &&
-        this.hiddenDependencies.every(fieldIsHiddenOrEmpty))
+        this.hiddenDependencies.every(fieldIsHidden))
     ) {
       return true;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@projectcaluma/ember-form",
-  "version": "14.3.0",
+  "version": "14.3.1",
   "description": "Ember addon for rendering Caluma forms.",
   "keywords": [
     "ember-addon"
@@ -41,7 +41,7 @@
     "luxon": "^3.5.0",
     "reactiveweb": "^1.3.0",
     "tracked-toolbox": "^2.0.0",
-    "@projectcaluma/ember-core": "^14.3.0"
+    "@projectcaluma/ember-core": "^14.3.1"
   },
   "devDependencies": {
     "@ember/optional-features": "2.2.0",
@@ -72,12 +72,12 @@
     "uikit": "3.23.7",
     "uuid": "11.1.0",
     "webpack": "5.99.8",
-    "@projectcaluma/ember-testing": "14.3.0",
-    "@projectcaluma/ember-workflow": "14.3.0"
+    "@projectcaluma/ember-testing": "14.3.1",
+    "@projectcaluma/ember-workflow": "14.3.1"
   },
   "peerDependencies": {
     "ember-source": ">= 4.0.0",
-    "@projectcaluma/ember-workflow": "^14.3.0"
+    "@projectcaluma/ember-workflow": "^14.3.1"
   },
   "dependenciesMeta": {
     "@projectcaluma/ember-core": {