@progress/kendo-typescript-tasks 10.0.22-dev.0 → 10.0.22-dev.4

package/api.js

@@ -12,15 +12,13 @@ module.exports = (gulp, userConfig) => {
     const series = gulp.series;
 
     const config = merge({}, apiConfig, userConfig);
-    const DECLARATIONS = ["typings/index.d.ts", "node_modules/@types/core-js/index.d.ts"];
+    const DECLARATIONS = [ "typings/index.d.ts", "node_modules/@types/core-js/index.d.ts" ];
 
-    gulp.task('api-json', () => {
-        return gulp.src(["src/**/*.{ts,tsx}", ...DECLARATIONS, ...(config.externalApi || [])], { "allowEmpty": true })
-            .pipe(typedoc(config.typedoc));
-    });
+    gulp.task('api-json', () => gulp.src([ "src/**/*.{ts,tsx}", ...DECLARATIONS, ...(config.externalApi || []) ], { "allowEmpty": true })
+        .pipe(typedoc(config.typedoc)));
 
     gulp.task('api-clean', (done) => {
-        execSync(`rm -rf docs/api`, {stdio:[0,1,2]});
+        execSync(`rm -rf docs/api`, { stdio: [ 0,1,2 ] });
         done();
     });
 
@@ -31,7 +29,7 @@ module.exports = (gulp, userConfig) => {
     }));
 
     gulp.task('api-check', series('api', (done) => {
-        execSync(`git diff --exit-code --color -- ${config.outPath}`,{stdio:[0,1,2]});
+        execSync(`git diff --exit-code --color -- ${config.outPath}`,{ stdio: [ 0,1,2 ] });
         done();
     }));
 };

package/gulp-tasks.js

@@ -27,17 +27,17 @@ module.exports = (gulp, libraryName, compilerPath, options, webpackConfigPath) =
 
         childProcess.exec(`${cmd} -p ${tsConfigPath}`, err => {
             del.sync([ 'src/**/*.ngfactory.*', 'src/**/*.ngsummary.*',
-                       'dist/**/*.ngfactory.*', 'dist/**/*.ngsummary.*' ]);
-            done(err)
+                'dist/**/*.ngfactory.*', 'dist/**/*.ngsummary.*' ]);
+            done(err);
         });
     };
 
     gulp.task('check-compilation', (done) => {
-        childProcess.execSync(`${tscPath} --noEmit`, {stdio:[0,1,2]});
-        done()
+        childProcess.execSync(`${tscPath} --noEmit`, { stdio: [ 0,1,2 ] });
+        done();
     });
 
-    gulp.task('lint', series('check-compilation', (done) => {
+    gulp.task('lint', series('check-compilation', () => {
         const program = tslint.Linter.createProgram('./tsconfig.json', '.');
 
         return gulp.src([ 'src/**/*.{ts,tsx}', 'test/**/*.{ts,tsx}', 'e2e/**/*.{ts,tsx}' ])
@@ -51,7 +51,7 @@ module.exports = (gulp, libraryName, compilerPath, options, webpackConfigPath) =
     gulp.task('lint-docs', () => {
         const program = tslint.Linter.createProgram('./tsconfig.docs.json', '.');
 
-        return gulp.src([ 'docs/examples/**/*.{ts,tsx}'])
+        return gulp.src([ 'docs/examples/**/*.{ts,tsx}' ])
             .pipe(gulpTsLint({
                 formatter: 'prose',
                 program: program,
@@ -68,10 +68,10 @@ module.exports = (gulp, libraryName, compilerPath, options, webpackConfigPath) =
 
         const config = Object.assign({}, webpackConfig.dev);
         config.resolve = Object.assign({}, config.resolve, {
-          alias: {
-            [packageInfo.name]: process.cwd() + '/src/main'
-          },
-          modules: [ path.join(process.cwd(), 'node_modules') ]
+            alias: {
+                [packageInfo.name]: process.cwd() + '/src/main'
+            },
+            modules: [ path.join(process.cwd(), 'node_modules') ]
         });
 
         const webpack = commonTasks.webpack(config);
@@ -86,7 +86,7 @@ module.exports = (gulp, libraryName, compilerPath, options, webpackConfigPath) =
         server.listen(webpackPort, host, err => {
             if (err) {
                 done();
-                throw new $.util.PluginError('webpack-dev-server', err);
+                throw new $.util.PluginError('webpack-dev-server', err); // eslint-disable-line no-undef
             }
         });
     });
@@ -95,5 +95,5 @@ module.exports = (gulp, libraryName, compilerPath, options, webpackConfigPath) =
     gulp.task('build-es-bundle', compile('tsconfig.es.json'));
     gulp.task('build-es2015-bundle', compile('tsconfig.es2015.json'));
     gulp.task('build-npm-bundle', compile('tsconfig.npm.json'));
-    gulp.task('build-package', series.apply(null, ['build-npm-bundle', 'build-es-bundle', 'build-cdn', 'build-systemjs-bundle']));
- };
+    gulp.task('build-package', series([ 'build-npm-bundle', 'build-es-bundle', 'build-cdn', 'build-systemjs-bundle' ]));
+};

package/gulpfile.js

@@ -3,13 +3,10 @@
 const gulp = require('gulp');
 const jasmine = require('gulp-jasmine');
 
-// kendo-common-task linter is ancient, skip it for now
-gulp.task('lint', (done) => done());
-
 gulp.task('test', () =>
     gulp.src('test/**/*.js')
-    .pipe(jasmine({
-        includeStackTrace: true
-    }))
+        .pipe(jasmine({
+            includeStackTrace: true
+        }))
 );
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "@progress/kendo-typescript-tasks",
   "description": "Kendo UI TypeScript package gulp tasks",
   "main": "gulp-tasks.js",
-  "version": "10.0.22-dev.0+312a5e9",
+  "version": "10.0.22-dev.4+28182b5",
   "author": "Telerik",
   "license": "Apache-2.0",
   "scripts": {
@@ -18,7 +18,7 @@
     "typescript": "^3.4.5"
   },
   "dependencies": {
-    "@progress/kendo-common-tasks": "7.9.5-dev.3+312a5e9",
+    "@progress/kendo-common-tasks": "7.9.5-dev.8+28182b5",
     "core-js": "^2.2.2",
     "del": "2.2.2",
     "gulp": "^4.0.0",
@@ -46,5 +46,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "312a5e97951ec3e69926d909e573bf5aafff222f"
+  "gitHead": "28182b56d4b5969becc7e346d5fc13ac995b0426"
 }

package/spec-bundle.js

@@ -31,5 +31,5 @@ function requireAll(requireContext) {
     return requireContext.keys().map(requireContext);
 }
 
-var modules = requireAll(testContext);
+let modules = requireAll(testContext); // eslint-disable-line no-unused-vars
 // requires and returns all modules that match

package/src/api/component-page.js

@@ -22,12 +22,14 @@ const findDecorator = (decorators) => ((decorators || []).find(d =>
 const decoratorProp = (prop) => (decorators) => {
     const compDecorator = findDecorator(decorators);
 
-if (compDecorator) {
+    if (compDecorator) {
         const regExp = new RegExp(`${prop}:\\s?['"](.+?)['"]`);
         const match = compDecorator.arguments.obj.match(regExp);
 
         return match ? match[1] : undefined;
     }
+
+    return undefined;
 };
 
 const selector = decoratorProp('selector');

package/src/api/enum-page.js

@@ -9,7 +9,7 @@ function enumValues(member) {
             comment: comment(child),
             name: child.name
         };
-    })
+    });
 }
 
 const enumTemplate = template.compileFrom('enum-page.hbs');

package/src/api/generator.js

@@ -71,7 +71,7 @@ const associateTypes = (elements, knownTypes) => {
     traverseElements(elements, element => {
         addTypeSlug(element, knownTypes);
     });
-}
+};
 
 const normalizeUnionReferences = (element, members) => {
     if (element.kind === 'union') {
@@ -79,19 +79,17 @@ const normalizeUnionReferences = (element, members) => {
         for (let idx = types.length - 1; idx >= 0; idx--) {
             const type = types[idx];
             if (type.type === 'reference') {
-                const unionReference = members.find((child) => {
-                    return child.name === type.name;
-                });
+                const unionReference = members.find((child) => child.name === type.name);
 
                 if (unionReference && unionReference.kind === 'union') {
                     normalizeUnionReferences(unionReference, members);
                     const toReplace = unionReference.type.types;
-                    types.splice.apply(types, [idx, 1].concat(toReplace));
+                    types.splice.apply(types, [ idx, 1 ].concat(toReplace));
                 }
             }
         }
     }
-}
+};
 
 const normalizeMembers = (members) => {
     traverseElements(members, (element) => {
@@ -99,9 +97,7 @@ const normalizeMembers = (members) => {
 
         if (!element.comment && element.implementationOf) {
             const interfaceName = element.implementationOf.name.split('.')[0];
-            const interfaceOptions = members.find((child) => {
-                return child.name === interfaceName;
-            });
+            const interfaceOptions = members.find((child) => child.name === interfaceName);
 
             if (interfaceOptions) {
                 const baseOption = interfaceOptions.children.find(child => child.name === element.name);
@@ -111,7 +107,7 @@ const normalizeMembers = (members) => {
             }
         }
     });
-}
+};
 
 const mergeComments = (root, src) => {
     if (!root.comment && src.comment) {
@@ -123,23 +119,20 @@ const mergeComments = (root, src) => {
             mergeComments(root[key], src[key]);
         }
     });
-}
-
-const moduleRoot = (moduleName, rootModules) => {
-    return rootModules.includes(moduleName) ? moduleName :
-        rootModules.find(rootModule => moduleName.indexOf(rootModule) > -1);
 };
 
+const moduleRoot = (moduleName, rootModules) => (rootModules.includes(moduleName) ? moduleName :
+    rootModules.find(rootModule => moduleName.indexOf(rootModule) > -1));
+
 const moduleFullName = (moduleName, packageName, rootModules) => {
     const rootModule = moduleRoot(moduleName, rootModules);
     let fullName = packageName;
-    if (rootModule)
-    {
+    if (rootModule) {
         fullName += '_' + rootModule;
     }
 
     return fullName;
-}
+};
 
 const extractMembers = (packageName, modules, config) => {
     const knownTypes = {};
@@ -182,7 +175,7 @@ const extractMembers = (packageName, modules, config) => {
     const members = utils.flatten(models)
         .sort(utils.nameComparer)
         .map(model => {
-            associateTypes([model], knownTypes);
+            associateTypes([ model ], knownTypes);
             return model;
         });
 
@@ -227,6 +220,18 @@ const groupMembers = (members) => {
     return membersByModule;
 };
 
+const packagePlatform = (packageInfo) => {
+    let platform = '';
+
+    if (/-angular-/.test(packageInfo.name)) {
+        platform = 'Angular';
+    } else if (/-react-/.test(packageInfo.name)) {
+        platform = 'React';
+    }
+
+    return platform;
+};
+
 const generate = (done, config, packageInfo) => {
     const meta = require(config.jsonPath);
     const namespaces = namespacesAsModules(meta.children);
@@ -234,8 +239,7 @@ const generate = (done, config, packageInfo) => {
     const membersByModule = config.reorderModules ?
         config.reorderModules(groupMembers(members)) : groupMembers(members);
     const outPath = config.outPath;
-    const platform = /-angular-/.test(packageInfo.name) ? 'Angular' :
-                       /-react-/.test(packageInfo.name) ? 'React'   : '';
+    const platform = packagePlatform(packageInfo);
     const info = Object.assign({ platform }, packageInfo['@progress']);
 
     writeFile(`${outPath}/index.md`, indexPage(packageInfo.name, membersByModule, info));

package/src/api/map-constructors.js

@@ -2,7 +2,6 @@
 
 const comment = require('./comment');
 const isPublic = require('./is-public');
-const isInput = require('./is-input');
 const types = require('./type-utils');
 const utils = require('./utils');
 
@@ -11,7 +10,6 @@ const isConstructor = (prop) =>
 
 const mapConstructors = (member) =>
     utils.flatten(member.children.filter(isConstructor).map(ctr => {
-        const name = ctr.name;
         const source = `${member.name}.constructor`;
 
         return ctr.signatures.map((signature) => ({

package/src/api/map-props.js

@@ -15,7 +15,7 @@ const defaultValue = prop => {
     return text && ` (default: ${text.trim()})`;
 };
 
-const accessor = signature => Array.isArray(signature) ? signature[0] : signature;
+const accessor = signature => (Array.isArray(signature) ? signature[0] : signature);
 
 const isProp = (prop) => isPublic(prop) && !isConstructor(prop) && !isMethod(prop);
 const mapProps = (children, parentName) =>

package/src/api/member-page.js

@@ -1,7 +1,6 @@
 "use strict";
 
 const path = require('path');
-const template = require('./template-utils');
 const componentPage = require('./component-page');
 const constantPage = require('./constant-page');
 const classPage = require('./class-page');

package/src/api/return-type.js

@@ -16,7 +16,7 @@ const returnType = (definition, parentName) => {
     if (!comment && definition.type.name !== 'void') {
         let source = `${definition.name}`;
         if (parentName) {
-          source = `${parentName } - ${source}`;
+            source = `${parentName } - ${source}`;
         }
         utils.warn('Undocumented return type', source);
     }

package/src/api/template-utils.js

@@ -8,7 +8,7 @@ hbs.registerHelper('capitalize',
     s => s.slice(0,1).toUpperCase() + s.slice(1));
 
 hbs.registerHelper('contains',
-    (s, chars, options) => s.includes(chars) ? options.fn(s) : options.inverse(s));
+    (s, chars, options) => (s.includes(chars) ? options.fn(s) : options.inverse(s)));
 
 const readLocal = (src) =>
     fs.readFileSync(path.join(__dirname, src), { encoding: 'utf-8' });

package/src/api/type-utils.js

@@ -118,7 +118,7 @@ const singleTypeString = (type) => {
     if (type.typeArguments) {
         suffix = `<${singleTypeString(type.typeArguments[0])}>`;
     }
-    
+
     if (type.type === 'array') {
         suffix += '[]';
     }
@@ -153,7 +153,7 @@ const fullName = (member) => {
     }
 
     return member.name + suffix;
-}
+};
 
 module.exports = {
     callSignature: callSignature,

package/src/api/utils.js

@@ -9,15 +9,15 @@ const not = predicate => member => !predicate(member);
 
 const ignore = predicate => props => (props || []).filter(predicate);
 
-const hasProp = prop => obj => !!obj[prop];
+const hasProp = prop => obj => Boolean(obj[prop]);
 
 const groupBy = (predicate, list) =>
     list.reduce((acc, item) => {
-      const field = predicate(item);
-      acc[field] = acc[field] || [];
-      acc[field].push(item);
-      return acc;
-    }, {})
+        const field = predicate(item);
+        acc[field] = acc[field] || [];
+        acc[field].push(item);
+        return acc;
+    }, {});
 
 const WARNINGS = [];
 const warn = (type, text) => {

package/stub-loader.js

@@ -1,4 +1,4 @@
 
 module.exports = function() {
-  return '{}';
+    return '{}';
 };

package/test/api.js

@@ -51,7 +51,7 @@ describe('API generation', () => {
 
     describe('for modules', () => {
         const pkg = require('./package.json');
-        const members = generator.extractMembers(pkg.name, pkg.children, { modules: ['module1'] });
+        const members = generator.extractMembers(pkg.name, pkg.children, { modules: [ 'module1' ] });
 
         it('adds module to slug', () => {
             expect(members[0].slug).toEqual('api_package-name_module1_foo');
@@ -325,22 +325,22 @@ describe('API generation', () => {
     describe('index', () => {
         const page = indexPage('foo/bar', {
             '': {
-                'Function': [{
+                'Function': [ {
                     'slug': 'root-f',
                     'name': 'root-f'
-                }]
+                } ]
             },
             'a': {
-                'Function': [{
+                'Function': [ {
                     'slug': 'a-f',
                     'name': 'a-f'
-                }]
+                } ]
             },
             'b': {
-                'Function': [{
+                'Function': [ {
                     'slug': 'b-f',
                     'name': 'b-f'
-                }]
+                } ]
             }
         }, {
             friendlyName: 'Foo',
@@ -348,7 +348,7 @@ describe('API generation', () => {
         });
 
         const assertModule = name => {
-            expect(new RegExp(`<h2 class=\"module-name\">\\s*${name}\\s*<\\/h2>`).test(page)).toBeTruthy();
+            expect(new RegExp(`<h2 class="module-name">\\s*${name}\\s*<\\/h2>`).test(page)).toBeTruthy();
         };
 
         it('renders default group', () => {