@produtype/core 1.9.1 → 1.9.3

package/dist/utils/textSearch.js

@@ -26,6 +26,36 @@ const blockComments_1 = require("../analyzer/blockComments");
  * and is left alone.
  */
 const PATTERN_DECLARATION = /^(?:const\s+\w+(?:\s*:[^=]+)?\s*=\s*)?\/(?:[^/\\]|\\.)+\/[gimsuy]*\s*[,;]?$/;
+/**
+ * A name given a type, rather than a value.
+ *
+ * pocketbase's report cited three lines for its cross-origin policy: `AllowedOrigins
+ * []string` — a field in a Go struct — `var allowedOrigins []string` in the command
+ * that parses the flag, and `allowedOrigins: Array<string>` in a generated `.d.ts`.
+ * Not one of them is a decision about origins. The line that is,
+ * `config.AllowedOrigins = []string{"*"}` twenty lines further down, was never
+ * reached, so a reader was given three declarations to argue with instead of the
+ * default that actually applies.
+ *
+ * It is the same rule as the regex table above, for the same reason: a declaration
+ * says what a thing is, and this analyzer claims to say what the code does.
+ *
+ * The right-hand side has to look like a type, not a value, because `AllowOrigins:
+ * config.AllowedOrigins,` is a use and reads almost identically. A type starts with a
+ * capital or is one of the primitives, and carries no quotes, no call and no digits —
+ * and an object-literal member ends in a comma, which a field signature does not.
+ */
+/**
+ * `import SwiftUI` has the shape and is not a declaration of anything.
+ *
+ * A keyword followed by a capitalised word reads exactly like a field given a type,
+ * and the first version of this rule hid every Swift and Kotlin import — which is how
+ * the native toolkits are detected, so an iOS application lost its interface. The
+ * statement keywords are excluded by name; `var`, `let` and `readonly` stay, because
+ * those really do introduce a declaration.
+ */
+const STATEMENT_KEYWORD = /^(?:import|package|from|export|return|case|new|type|class|struct|interface|enum|func|fun|def|public|private|protected|internal|throw|throws|extends|implements|use|using|namespace|module|require|await|yield|delete|typeof|instanceof|in|is|as|if|else|for|while|switch|do|try|catch|finally|with|assert|raise|lambda|val|const)\b/;
+const TYPE_DECLARATION = /^(?:var\s+|let\s+|readonly\s+)?\w+\??\s*(?::\s*|\s+)(?:\[\]|\*|Array<|Map<|\bstring\b|\bnumber\b|\bboolean\b|\bbool\b|\bany\b|\bunknown\b|\bvoid\b|[A-Z])[\w.<>[\]|&\s]*;?$/;
 /**
  * Prose about the code, rather than the code.
  *
@@ -56,9 +86,13 @@ const COMMENT_LINE = /^(?:\/\/|\/\*|\*\/?|#(?![![])(?!!)|<!--|--\s)/;
  *
  * Nothing in the shape of the line tells the two apart, so the rule is not made.
  */
+function declaresAType(trimmed) {
+    const withoutDeclarator = trimmed.replace(/^(?:var|let|readonly)\s+/, '');
+    return !STATEMENT_KEYWORD.test(withoutDeclarator) && TYPE_DECLARATION.test(trimmed);
+}
 function declaresRatherThanDoes(line) {
     const trimmed = line.trim();
-    return COMMENT_LINE.test(trimmed) || PATTERN_DECLARATION.test(trimmed);
+    return COMMENT_LINE.test(trimmed) || PATTERN_DECLARATION.test(trimmed) || declaresAType(trimmed);
 }
 /**
  * Whether this line may be quoted back to the reader as something the code does.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@produtype/core",
-  "version": "1.9.1",
+  "version": "1.9.3",
   "description": "Deterministic CLI and library that analyzes a web application repository and reports how far it is from production-ready for the kind of product it is meant to be.",
   "license": "MIT",
   "bin": {
@@ -37,7 +37,7 @@
     "docs:stacks": "npm run build && node scripts/sync-readme-stacks.mjs",
     "prepare": "npm run build",
     "clean": "node -e \"require('fs').rmSync('dist',{recursive:true,force:true})\"",
-    "prepublishOnly": "npm run build && node scripts/assert-no-ai.mjs && npm test"
+    "prepublishOnly": "npm run build && npm run lint && node scripts/assert-no-ai.mjs && npm test"
   },
   "engines": {
     "node": ">=18"