@produtype/core 0.92.0 → 0.94.0

package/dist/analyzer/analyzeProject.js

@@ -161,18 +161,48 @@ function parsePyprojectSections(text, runtimeOnly) {
  * Everything after `src/main/java` is a package name, not a project layout.
  *
  * spring-petclinic lives in `org.springframework.samples.petclinic`, so every one of
- * its thirty Java files sits under a path segment called `samples` — and the rule that
- * removes sample code removed the whole application. The report saw a project with no
- * Java in it at all: twelve files, an HTML front end, no backend, and a profile of
- * `client-app` at high confidence for a Spring Boot server.
+ * its thirty Java files sat under a path segment called `samples`, and the rule that
+ * removes sample code removed the whole application: twelve files, an HTML front end,
+ * no backend, and `client-app` at high confidence for a Spring Boot server.
  *
- * Maven and Gradle both fix that prefix, so the segments after it are the author's
- * package and mean nothing about the layout. A real sample directory sits beside
- * `src`, not inside its source root — ktor-documentation keeps its under
- * `codeSnippets/snippets/`, which this still removes.
+ * It was not only `samples`. `spring-test/src/main/java/org/springframework/mock/`
+ * holds forty-four files — `MockHttpServletRequest` and its neighbours, shipped in the
+ * jar and the whole point of that module — and the rule that removes `mocks/` removed
+ * every one of them. A package can be called anything: `vendor`, `testing`, `fixtures`
+ * are all ordinary domain words.
+ *
+ * Maven and Gradle fix the `src/main/<language>` prefix, so directory rules are
+ * applied to the path *up to* it and never to the package below.
+ *
+ * Only `main` is named, and that is a statement of intent rather than a rule doing
+ * work: `src/test/java/...` stays excluded either way, because the boundary itself
+ * contains `test` and the directory rule matches it. Writing `main|test` here fails
+ * no test, which is worth saying instead of implying a protection that is not there.
+ */
+const JVM_MAIN_SOURCE_ROOT = /(^|\/)src\/main\/(java|kotlin|scala|groovy)\//;
+/** The part of the path that describes layout rather than package. */
+function layoutPartOf(file) {
+    const root = JVM_MAIN_SOURCE_ROOT.exec(file);
+    return root ? file.slice(0, root.index + root[0].length) : file;
+}
+/**
+ * Go names its tests by file, never by directory.
+ *
+ * `_test.go` is the suffix the toolchain compiles separately; a directory called
+ * `mock`, `testing` or `fixtures` is just a package. testify's own `mock/mock.go` —
+ * half of what that library is for — was removed by the rule that drops `mocks/`, and
+ * the analyzer saw 38 of its Go files with the two biggest missing.
+ *
+ * One directory convention is left here, and it is the toolchain's: a directory whose
+ * name begins with `_` or `.` is skipped when building, which is why testify keeps
+ * `_codegen` and `_readme-gofmt` under those names.
+ *
+ * `vendor/` and `testdata/` are not repeated: the file scanner never hands them over
+ * in the first place. Both were written here and both survived being deleted in a
+ * mutation run, which is how the duplication came to light.
  */
-function isAPackageName(file) {
-    return /(^|\/)src\/(main|test)\/(java|kotlin|scala|groovy)\//.test(file);
+function isGoToolchainExclusion(file) {
+    return /(^|\/)[_.][^/]+\//.test(file);
 }
 function isTestOrExamplePath(file) {
     // `__mocks__` was missing, and a mock is the most misleading file in a repository:
@@ -181,7 +211,14 @@ function isTestOrExamplePath(file) {
     // `fixtures` was listed and `fixture` was not, so `extra/fixture/authsources.php`
     // made PHP one of the languages of an Elixir analytics product — and of cal.com,
     // which is TypeScript.
-    return /(^|\/)(__tests__|__mocks__|mocks?|tests?|test-data|fixtures?|frontend-example)(\/|$)/i.test(file)
+    /**
+     * A Go file answers to Go's conventions and to none of the directory rules below:
+     * every one of those names is a package name there.
+     */
+    if (/\.go$/.test(file))
+        return isGoToolchainExclusion(file) || /_test\.go$/.test(file);
+    const layout = layoutPartOf(file);
+    return /(^|\/)(__tests__|__mocks__|mocks?|tests?|test-data|fixtures?|frontend-example)(\/|$)/i.test(layout)
         /**
          * The conventions other ecosystems use, which this list did not know.
          *
@@ -192,7 +229,7 @@ function isTestOrExamplePath(file) {
          * would have parsed the same files and reached the same wrong conclusion, which is
          * the argument for fixing what gets read before fixing how.
          */
-        || /(^|\/)(spec|specs|e2e|integration-tests?|cypress|playwright|testing)(\/|$)/i.test(file)
+        || /(^|\/)(spec|specs|e2e|integration-tests?|cypress|playwright|testing)(\/|$)/i.test(layout)
         || /\.(e2e|e2e-spec|cy|stories)\.(ts|tsx|js|jsx|mjs|cjs)$/i.test(file)
         || /_spec\.rb$/i.test(file)
         || /_test\.(go|py|rb|java|cs|php)$/i.test(file)
@@ -236,7 +273,7 @@ function isTestOrExamplePath(file) {
          * spell it. A repository whose every source file is a sample now has no source
          * files, and says so — which is the honest answer for one.
          */
-        || (/(^|\/)(samples?|snippets?|codesnippets)(\/|$)/i.test(file) && !isAPackageName(file))
+        || /(^|\/)(samples?|snippets?|codesnippets)(\/|$)/i.test(layout)
         /**
          * Somebody else's code, vendored in.
          *
@@ -245,7 +282,7 @@ function isTestOrExamplePath(file) {
          * crate copied in whole. A manifest under a vendor directory is a statement about
          * that library, not about this product.
          */
-        || /(^|\/)(vendor|vendored|third[-_]?party|external[-_]crates)(\/|$)/i.test(file);
+        || /(^|\/)(vendor|vendored|third[-_]?party|external[-_]crates)(\/|$)/i.test(layout);
 }
 /**
  * Extensions the detectors can read.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@produtype/core",
-  "version": "0.92.0",
+  "version": "0.94.0",
   "description": "Deterministic CLI and library that analyzes a web application repository and reports how far it is from production-ready for the kind of product it is meant to be.",
   "license": "MIT",
   "bin": {