@produtype/core 0.89.0 → 0.91.0

package/dist/analyzer/detectSecurity.js

@@ -18,6 +18,8 @@ const ORIGIN_HANDLING = [/Access-Control-Allow-Origin/i, /ALLOWED_ORIGINS/, /all
  * `ALLOWED_ORIGINS = ["*"]` are the same decision written in two frameworks, and only
  * the first was being caught.
  */
+/** `== StatusCode::TOO_MANY_REQUESTS` and its spellings: a status being read. */
+const COMPARES_A_STATUS = /[=!]==?\s*(?:StatusCode::TOO_MANY_REQUESTS|http\.StatusTooManyRequests|HttpStatus\.TOO_MANY_REQUESTS|HttpStatusCode\.TooManyRequests|Status429TooManyRequests)|(?:StatusCode::TOO_MANY_REQUESTS|http\.StatusTooManyRequests|HttpStatus\.TOO_MANY_REQUESTS|HttpStatusCode\.TooManyRequests)\s*[=!]==?/;
 const WILDCARD_ORIGIN = /(Access-Control-Allow-Origin["'\s:,]+\*)|(["']\*["'])/i;
 /**
  * A line that names an origin somebody chose.
@@ -194,7 +196,45 @@ async function detectSecurity(ctx) {
         /^\s*SECURE_CROSS_ORIGIN_OPENER_POLICY\s*=/m,
         /^\s*CSP_DEFAULT_SRC\s*=/m,
     ], 20);
-    const helmet = helmetDep || headerSignals.length > 0;
+    /**
+     * Spring Security, which writes the headers without being asked.
+     *
+     * Adding `spring-boot-starter-security` and configuring an `HttpSecurity` chain
+     * gives every response `X-Content-Type-Options: nosniff`, `X-Frame-Options: DENY`
+     * and a no-store `Cache-Control` — the framework's defaults, applied whether or not
+     * anybody writes a line about headers. shopizer does exactly that and was told it
+     * has none.
+     *
+     * Unlike Django's `SecurityMiddleware`, which is deliberately not counted a few
+     * lines down: `django-admin startproject` writes that into every new project, so it
+     * distinguishes nothing, and its HSTS and nosniff behaviour still waits on
+     * `SECURE_*` settings. This starter is not in every Spring project — petclinic has
+     * no security at all — and its defaults need no settings.
+     *
+     * The chain is what is required. A project can pull the starter for method-level
+     * authorization in something that serves no requests, and then there is no filter
+     * chain and no headers — which is what the second fixture holds.
+     *
+     * The dependency check in front of it is a pre-filter and nothing more: it keeps
+     * this search off every file of every non-Spring repository. Removing it fails no
+     * test, and the comment says so rather than implying a safety it does not provide.
+     */
+    const springSecurity = (0, detectContext_1.hasAnyGradleDep)(ctx, ['spring-boot-starter-security', 'spring-security-config']);
+    const springFilterChain = springSecurity.length > 0
+        ? await (0, textSearch_1.searchInFiles)(ctx.root, source, [/HttpSecurity\s+\w+|\bhttp\s*\n?\s*\.\s*(?:authorizeHttpRequests|authorizeRequests|securityMatcher|antMatcher)/], 2)
+        : [];
+    if (springFilterChain.length > 0) {
+        for (const dep of springSecurity)
+            evidence.push({ type: 'dependency', value: dep, claim: 'headers' });
+        evidence.push({
+            type: 'snippet',
+            value: springFilterChain[0].snippet,
+            file: springFilterChain[0].file,
+            line: springFilterChain[0].line,
+            claim: 'headers',
+        });
+    }
+    const helmet = helmetDep || headerSignals.length > 0 || springFilterChain.length > 0;
     /**
      * The packages the ecosystem names, as distinct from the variables authors do.
      * Shared between the dependency check below and the binding walk further down.
@@ -252,8 +292,36 @@ async function detectSecurity(ctx) {
         /HTTPException\(\s*429/,
         /['"`]Retry-After['"`]\s*[,:]/i,
         /setHeader\(\s*['"`]Retry-After/i,
+        /**
+         * The same refusal, spelled the way each platform spells it.
+         *
+         * Every shape above is JavaScript or Python, so a service that throttles in any
+         * other language had to declare a package to be seen at all. crates.io writes
+         * its own limiter — `src/rate_limiter.rs`, no crate — and refuses with
+         * `StatusCode::TOO_MANY_REQUESTS`; it was told at `high` that it does not
+         * throttle.
+         *
+         * These are constants the standard library or the framework defines for one
+         * number in RFC 6585. Nobody picks the name, and each of them is the server
+         * issuing the refusal rather than reading one: a constant is what you construct
+         * a response from, where receiving is a comparison against `.status`.
+         */
+        /StatusCode::TOO_MANY_REQUESTS/,
+        /http\.StatusTooManyRequests/,
+        /HttpStatus\.TOO_MANY_REQUESTS/,
+        /HttpStatusCode\.TooManyRequests/,
+        /Status429TooManyRequests/,
     ], 20);
-    const rateLimit = rateLimitDep || rateLimitSignals.length > 0;
+    /**
+     * Still issuing, not receiving — the constants need the same test the numbers got.
+     *
+     * `res.status(429)` can only be a server refusing, but
+     * `if resp.status() == StatusCode::TOO_MANY_REQUESTS` is this project being
+     * refused by somebody else's, which is what nocodb's webhook invoker does. A
+     * comparison is the reading direction; an argument is the writing one.
+     */
+    const issuedRateLimits = rateLimitSignals.filter((hit) => !COMPARES_A_STATUS.test(hit.snippet));
+    const rateLimit = rateLimitDep || issuedRateLimits.length > 0;
     /**
      * Rate limiting where the brute force happens.
      *
@@ -297,14 +365,14 @@ async function detectSecurity(ctx) {
     const coversAnAuthMount = mountedPaths.some((prefix) => authMountPaths.some((mount) => mount === prefix || mount.startsWith(`${prefix}/`)));
     const rateLimitNearAuth = coversAnAuthMount
         || (boundLimiterUses ?? []).some((use) => authSurfaceFiles.has(use.file))
-        || rateLimitSignals.some((match) => authSurfaceFiles.has(match.file));
+        || issuedRateLimits.some((match) => authSurfaceFiles.has(match.file));
     if (helmetDep)
         evidence.push({ type: 'dependency', value: 'helmet', claim: 'headers' });
     if (rateLimitDep)
         evidence.push({ type: 'dependency', value: 'rate limiting package', claim: 'rate-limit' });
     for (const m of headerSignals)
         evidence.push({ type: 'snippet', value: m.snippet, file: m.file, line: m.line, claim: 'headers' });
-    for (const m of rateLimitSignals)
+    for (const m of issuedRateLimits)
         evidence.push({ type: 'snippet', value: m.snippet, file: m.file, line: m.line, claim: 'rate-limit' });
     /**
      * Every identifier the `cors` package reaches, per file.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@produtype/core",
-  "version": "0.89.0",
+  "version": "0.91.0",
   "description": "Deterministic CLI and library that analyzes a web application repository and reports how far it is from production-ready for the kind of product it is meant to be.",
   "license": "MIT",
   "bin": {