@produtype/core 0.86.0 → 0.88.0

package/dist/analyzer/detectObservability.js

@@ -38,7 +38,7 @@ async function detectObservability(ctx) {
         evidence.push({ type: 'dependency', value: d, claim: 'logging' });
     for (const d of sentryDeps)
         evidence.push({ type: 'dependency', value: d, claim: 'logging' });
-    const hits = await (0, textSearch_1.searchInFiles)(ctx.root, ctx.files.source, [/\/(health|healthz|readyz)\b/i, /x-request-id/i, /correlation-id/i, /error\s*handler/i, /RotatingFileHandler/i], 25);
+    const hits = await (0, textSearch_1.searchInFiles)(ctx.root, ctx.files.source, [/\/(health|healthz|readyz|livez|alive)\b/i, /x-request-id/i, /correlation-id/i, /error\s*handler/i, /RotatingFileHandler/i], 25);
     /**
      * One search, three answers, so the claim is decided per hit rather than per search.
      *
@@ -47,7 +47,7 @@ async function detectObservability(ctx) {
      * is what the line is evidence of.
      */
     for (const m of hits) {
-        const claim = /\/(health|healthz|readyz)\b/i.test(m.snippet)
+        const claim = /\/(health|healthz|readyz|livez|alive)\b/i.test(m.snippet)
             ? 'health'
             : /x-request-id|correlation-id/i.test(m.snippet)
                 ? 'request-id'
@@ -60,7 +60,7 @@ async function detectObservability(ctx) {
     const healthFiles = ctx.files.all.filter((file) => /(^|\/)(health|healthz|readyz|liveness|readiness)(\/route|\.[a-z]+)?$|(^|\/)(health|healthz|readyz)\//i.test(file));
     for (const file of healthFiles)
         evidence.push({ type: 'file', value: file, claim: 'health' });
-    const hasHealth = healthFiles.length > 0 || hits.some((h) => /\/(health|healthz|readyz)\b/i.test(h.snippet));
+    const hasHealth = healthFiles.length > 0 || hits.some((h) => /\/(health|healthz|readyz|livez|alive)\b/i.test(h.snippet));
     const hasReqId = hits.some((h) => /x-request-id|correlation-id/i.test(h.snippet));
     // Structured logging without a logging library is still structured logging. What
     // matters is that entries are machine-readable and correlated, not which package

package/dist/analyzer/detectSecurity.js

@@ -19,6 +19,42 @@ const ORIGIN_HANDLING = [/Access-Control-Allow-Origin/i, /ALLOWED_ORIGINS/, /all
  * the first was being caught.
  */
 const WILDCARD_ORIGIN = /(Access-Control-Allow-Origin["'\s:,]+\*)|(["']\*["'])/i;
+/**
+ * A line that names an origin somebody chose.
+ *
+ * The test is that the value is written down: a quoted string that is not `*`, or a
+ * list of them. Everything else — a variable, a concatenation, a method call — is a
+ * value the reader of this line cannot see, and a security check does not get to
+ * assume it is an allowlist.
+ */
+function allowsAChosenOrigin(line, file) {
+    /**
+     * The line itself asks whether the origin belongs.
+     *
+     * `!ALLOWED_ORIGINS.includes(origin)` is the allowlist being enforced, and it is
+     * the strongest evidence there is — stronger than the declaration it checks
+     * against, which may live in an environment variable.
+     */
+    if (MEMBERSHIP_TEST.test(line))
+        return true;
+    const assigned = /(?:Access-Control-Allow-Origin|ALLOWED_ORIGINS|allowedOrigins)[^=:,]*[=:,]\s*(.+)$/i.exec(line);
+    if (!assigned)
+        return false;
+    // An origin written down: it has a scheme or a dotted host, which `","` does not.
+    if (/["'`](?:https?:\/\/|\*\.)[^"'`]*["'`]|["'`][^"'`]*\.[a-z]{2,}[^"'`]*["'`]/i.test(assigned[1]))
+        return true;
+    /**
+     * Or a value this line cannot see, checked somewhere else in the same file.
+     *
+     * A list kept in an environment variable is still an allowlist, so the test cannot
+     * be "is the value a literal". What separates it from reflection is that somebody
+     * asks whether the origin belongs before answering yes — and shopizer never does:
+     * `origin = request.getHeader("origin")` goes straight into the header.
+     */
+    return MEMBERSHIP_TEST.test(file);
+}
+/** `includes`, `contains`, `indexOf`, `has` — asking whether a value belongs. */
+const MEMBERSHIP_TEST = /\.(includes|contains|indexOf|has)\s*\(/i;
 /**
  * Flask's answer, which was invisible.
  *
@@ -163,12 +199,24 @@ async function detectSecurity(ctx) {
      * The packages the ecosystem names, as distinct from the variables authors do.
      * Shared between the dependency check below and the binding walk further down.
      */
+    /**
+     * Two of these were checked against the wrong manifest for as long as they existed.
+     *
+     * `hasDep` reads `package.json` and nothing else, so `django-ratelimit` and
+     * `slowapi` — a Python package and a Python package — were being looked for among a
+     * project's npm dependencies, where they can never be. Written as though they
+     * worked, never able to match.
+     *
+     * Rust joins them, measured: vaultwarden declares `governor` and calls
+     * `check_limit_login(&ip.ip)` on its login route, and was told at `high` that it
+     * does not throttle authentication.
+     */
     const rateLimitDep = (0, detectContext_1.hasDep)(ctx, 'express-rate-limit') ||
         (0, detectContext_1.hasDep)(ctx, '@upstash/ratelimit') ||
         (0, detectContext_1.hasDep)(ctx, 'rate-limiter-flexible') ||
         (0, detectContext_1.hasDep)(ctx, 'next-rate-limit') ||
-        (0, detectContext_1.hasDep)(ctx, 'django-ratelimit') ||
-        (0, detectContext_1.hasDep)(ctx, 'slowapi');
+        (0, detectContext_1.hasAnyPyDep)(ctx, ['django-ratelimit', 'slowapi', 'flask-limiter']).length > 0 ||
+        (0, detectContext_1.hasAnyRustDep)(ctx, ['governor', 'tower_governor', 'tower-governor', 'actix-governor', 'ratelimit']).length > 0;
     /**
      * Throttling by what the protocol says, not by what the variable is called.
      *
@@ -287,8 +335,25 @@ async function detectSecurity(ctx) {
         for (const m of (0, textSearch_1.matchLines)(text, ORIGIN_HANDLING, file)) {
             if (WILDCARD_ORIGIN.test(m.snippet))
                 corsLoose.push(m);
-            else
+            else if (allowsAChosenOrigin(m.snippet, text))
                 corsStrict.push(m);
+            /**
+             * Anything else sets the header to a value this cannot see.
+             *
+             * shopizer writes `origin = request.getHeader("origin")` and then
+             * `setHeader("Access-Control-Allow-Origin", origin)` — reflecting whatever the
+             * caller asked for, which allows every origin there is. The report called it
+             * "configured with explicit origins" and passed it: a clean verdict on the one
+             * shape this check exists to catch.
+             *
+             * An allowlist is a fixed set, so it is written down. A variable, a
+             * concatenation or a call cannot be shown to be one — it may be a value from
+             * configuration, and it may be the request's own header, and nothing in the line
+             * says which. `partial` is what that deserves: something is configured and
+             * nothing here shows it restricted.
+             */
+            else
+                corsLoose.push(m);
         }
         // Only where the middleware is actually imported. A sentence in this tool's own
         // remediation catalogue — "Replace cors() defaults with an explicit allowlist." —

package/dist/utils/textSearch.js

@@ -36,8 +36,14 @@ const PATTERN_DECLARATION = /^(?:const\s+\w+(?:\s*:[^=]+)?\s*=\s*)?\/(?:[^/\\]|\
  * A signal that appears only in a comment was never evidence of behaviour, which is the
  * whole argument: the report cites a line and says "this is what your code does", and a
  * sentence about the code is not that.
+ *
+ * `#` is where this went wrong for a whole language. It opens a comment in Python, YAML
+ * and shell, and in Rust `#[get("/alive")]` is the route itself — so every Rust
+ * attribute was invisible to every search this analyzer makes. vaultwarden declares its
+ * liveness endpoint that way and was told it has none; the same blindness covered
+ * `#[post(...)]`, every derive and every `#[cfg]`.
  */
-const COMMENT_LINE = /^(?:\/\/|\/\*|\*\/?|#(?!!)|<!--|--\s)/;
+const COMMENT_LINE = /^(?:\/\/|\/\*|\*\/?|#(?![![])(?!!)|<!--|--\s)/;
 /**
  * A table of strings is not a third rule, and that was a mistake worth recording.
  *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@produtype/core",
-  "version": "0.86.0",
+  "version": "0.88.0",
   "description": "Deterministic CLI and library that analyzes a web application repository and reports how far it is from production-ready for the kind of product it is meant to be.",
   "license": "MIT",
   "bin": {