@produtype/core 0.55.0 → 0.57.0

package/dist/planner/buildPlan.js

@@ -167,9 +167,18 @@ function sortStates(states) {
     }
     return ordered;
 }
-function summarizePlan(tasks, actionableFindingCount) {
+function summarizePlan(tasks, actionableFindingCount, inconclusive) {
     if (tasks.length === 0) {
-        return 'ProdKit found no actionable remediation tasks from the current deterministic findings.';
+        /**
+         * An empty plan means two different things and said one sentence for both.
+         *
+         * "Found no actionable remediation tasks" reads as "there is nothing to do". On a
+         * repository this analyzer could not read, there is nothing to do *because it
+         * could not look* — and that is the opposite advice.
+         */
+        return inconclusive
+            ? 'No plan: too little of this repository could be read to say what it needs.'
+            : 'ProdKit found no actionable remediation tasks from the current deterministic findings.';
     }
     const quickWins = tasks.filter((task) => task.effort === 'small' && (task.risk === 'low' || task.risk === 'medium')).length;
     const highRisk = tasks.filter((task) => task.risk === 'high').length;
@@ -234,7 +243,7 @@ function buildPlan(report) {
         generatedAt: new Date().toISOString(),
         score: report.overallScore,
         maturityLevel: report.maturityLevel,
-        summary: summarizePlan(tasks, actionableFindings.length),
+        summary: summarizePlan(tasks, actionableFindings.length, report.inconclusive),
         phases,
         tasks,
         quickWins,

package/dist/report/buildReport.js

@@ -279,9 +279,19 @@ function buildReport(analysis, options) {
      * band can be refused and both must reach the number, not only the label.
      */
     const openCriticals = findings.filter((f) => f.severity === 'critical' && f.status !== 'passed' && f.status !== 'unknown').length;
+    /**
+     * A required capability the profile cannot find is the third bar.
+     *
+     * Not counted for a profile that requires nothing, and not counted where no profile
+     * was applied: both of those are the absence of a question rather than a failed
+     * answer, which is the distinction the rest of this report now draws everywhere.
+     */
+    const blockingRequired = productProfile && productProfile.selectedProfile !== 'auto'
+        ? productProfile.gap.requiredMissing + productProfile.gap.requiredPartial
+        : 0;
     const overallScore = inconclusive
         ? null
-        : (0, score_1.mayClaimTopBand)(coverage, openCriticals)
+        : (0, score_1.mayClaimTopBand)(coverage, openCriticals, blockingRequired)
             ? scoreAfterInconclusive
             : Math.min(scoreAfterInconclusive, score_1.TOP_BAND_CEILING);
     const maturityLevel = overallScore === null

package/dist/report/executiveSummary.js

@@ -66,8 +66,26 @@ const DAYS_BY_SEVERITY = {
     low: 0.5,
     info: 0,
 };
-function estimateEffort(findings, profile) {
-    if (!profile)
+function estimateEffort(findings, profile, inconclusive) {
+    /**
+     * "Nothing outstanding to estimate" is a claim about the work, and a report that
+     * could not read the repository has no basis for it.
+     *
+     * A Python transcription script whose verdict says "ProdKit could not judge this
+     * project" was told there was nothing to do. It is the last number in the report and
+     * the same mistake as all the others: an empty list of findings read as an empty
+     * list of problems.
+     */
+    if (inconclusive)
+        return 'Not estimated: too little of this repository could be read.';
+    /**
+     * The inconclusive-inference profile is no profile.
+     *
+     * It carries an empty capability set, so estimating against it measures the observed
+     * findings and calls the answer an estimate of the gap. The sentence for having no
+     * profile already exists and is the true one.
+     */
+    if (!profile || profile.selectedProfile === 'auto')
         return 'Not estimated without a product profile.';
     const open = findings.filter((f) => f.status !== 'passed' && f.status !== 'unknown');
     if (open.length === 0)
@@ -265,7 +283,7 @@ function buildExecutiveSummary(args) {
          * the same praise.
          */
         strengths: args.inconclusive ? [] : buildStrengths(args.categoryScores, args.findings),
-        estimatedEffort: estimateEffort(args.findings, args.profile),
+        estimatedEffort: estimateEffort(args.findings, args.profile, args.inconclusive),
         scoreExplanation,
     };
 }

package/dist/report/score.d.ts

@@ -46,7 +46,7 @@ export declare function coverageSupportsTopBand(coverage: ScoreCoverage): boolea
  * apart again: they did, and the number went on reading 98 above every real product in
  * the corpus while the label said `partial`.
  */
-export declare function mayClaimTopBand(coverage: ScoreCoverage, openCriticals: number): boolean;
+export declare function mayClaimTopBand(coverage: ScoreCoverage, openCriticals: number, blockingRequired?: number): boolean;
 /**
  * How many critical findings are open.
  *
@@ -57,4 +57,18 @@ export declare function mayClaimTopBand(coverage: ScoreCoverage, openCriticals:
  * severity ceiling was added — "a category with one critical and nine passing checks is
  * not 90% healthy" — and the report's own headline had not learned it.
  */
+/**
+ * A capability the profile calls essential, missing or half-built.
+ *
+ * The third bar on the top band, and the one a reader could see for themselves.
+ * firefly-iii was labelled "Production ready" directly above the sentence "This
+ * project is not ready to launch as B2C App: 3 essential capabilities are missing or
+ * incomplete" — two labels on one page contradicting each other. Five of the
+ * eighty-two repositories measured read that way, this product's own web application
+ * among them.
+ *
+ * The two answer different questions and the words do not care: "production ready" is
+ * a claim about readiness, and something the profile calls essential and cannot find
+ * is by definition blocking. The band is the thing that has to give.
+ */
 export declare function computeMaturity(score: number, coverage?: ScoreCoverage, openCriticals?: number): MaturityLevel;

package/dist/report/score.js

@@ -66,8 +66,8 @@ function coverageSupportsTopBand(coverage) {
  * apart again: they did, and the number went on reading 98 above every real product in
  * the corpus while the label said `partial`.
  */
-function mayClaimTopBand(coverage, openCriticals) {
-    return coverageSupportsTopBand(coverage) && openCriticals === 0;
+function mayClaimTopBand(coverage, openCriticals, blockingRequired = 0) {
+    return coverageSupportsTopBand(coverage) && openCriticals === 0 && blockingRequired === 0;
 }
 /**
  * How many critical findings are open.
@@ -79,6 +79,20 @@ function mayClaimTopBand(coverage, openCriticals) {
  * severity ceiling was added — "a category with one critical and nine passing checks is
  * not 90% healthy" — and the report's own headline had not learned it.
  */
+/**
+ * A capability the profile calls essential, missing or half-built.
+ *
+ * The third bar on the top band, and the one a reader could see for themselves.
+ * firefly-iii was labelled "Production ready" directly above the sentence "This
+ * project is not ready to launch as B2C App: 3 essential capabilities are missing or
+ * incomplete" — two labels on one page contradicting each other. Five of the
+ * eighty-two repositories measured read that way, this product's own web application
+ * among them.
+ *
+ * The two answer different questions and the words do not care: "production ready" is
+ * a claim about readiness, and something the profile calls essential and cannot find
+ * is by definition blocking. The band is the thing that has to give.
+ */
 function computeMaturity(score, coverage, openCriticals = 0) {
     if (score <= 39)
         return 'prototype';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@produtype/core",
-  "version": "0.55.0",
+  "version": "0.57.0",
   "description": "Deterministic CLI and library that analyzes a web application repository and reports how far it is from production-ready for the kind of product it is meant to be.",
   "license": "MIT",
   "bin": {