@productbrain/mcp 0.0.1-beta.8754 → 0.0.1-beta.8762

package/dist/{chunk-4GJ3KH6Q.js → chunk-ZY4ORNVP.js}

@@ -1171,23 +1171,29 @@ function verdictQualityPhrase(result2) {
   if (!v || criteria.length === 0) {
     return "Quality: not evaluated (no rubric for this type).";
   }
-  const total = criteria.length;
-  const passed = criteria.filter((c) => c.passed).length;
-  return v.passed ? `Quality: all ${total} rubric criteria pass.` : `Quality: ${passed}/${total} rubric criteria pass \u2014 see the coaching above.`;
+  const gating = criteria.filter((c) => c.gating !== false);
+  const total = gating.length;
+  const passed = gating.filter((c) => c.passed).length;
+  return v.passed ? `Quality: all ${total} gating criteria pass.` : `Quality: ${passed}/${total} gating criteria pass \u2014 see the coaching above.`;
+}
+function hintLines(criteria) {
+  const hints = (criteria ?? []).filter((c) => c.gating === false && !c.passed);
+  return hints.length === 0 ? [] : ["", ...hints.map((c) => `hint (does not block): ${c.id} \u2014 ${c.hint}`)];
 }
 function formatRubricCoaching(result2) {
   const { verdict, rogerMartin } = result2;
   if (!verdict || verdict.criteria.length === 0) return "";
   const lines = ["## Semantic Quality"];
-  const failed = (verdict.criteria ?? []).filter((c) => !c.passed);
-  const total = verdict.criteria?.length ?? 0;
+  const gating = (verdict.criteria ?? []).filter((c) => c.gating !== false);
+  const failed = gating.filter((c) => !c.passed);
+  const total = gating.length;
   const passedCount = total - failed.length;
   if (verdict.passed) {
-    lines.push(`All ${total} rubric criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier).`);
+    lines.push(`All ${total} gating criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier).`);
   } else {
-    lines.push(`${passedCount}/${total} criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier)`);
+    lines.push(`${passedCount}/${total} gating criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier)`);
     lines.push("");
-    for (const c of verdict.criteria) {
+    for (const c of gating) {
       const icon = c.passed ? "[x]" : "[ ]";
       const extra = c.passed ? "" : ` \u2014 ${c.hint}`;
       lines.push(`${icon} ${c.id}${extra}`);
@@ -1198,6 +1204,7 @@ function formatRubricCoaching(result2) {
       lines.push(`_Question to consider:_ ${verdict.weakest.questionTemplate}`);
     }
   }
+  lines.push(...hintLines(verdict.criteria));
   if (rogerMartin) {
     lines.push("");
     lines.push("### Roger Martin Test");
@@ -1215,17 +1222,18 @@ function formatRubricCoaching(result2) {
 function formatRubricVerdictSection(verdict) {
   if (!verdict || !verdict.criteria || verdict.criteria.length === 0) return "";
   const lines = ["## Semantic Quality"];
-  const failed = verdict.criteria.filter((c) => !c.passed);
-  const total = verdict.criteria.length;
+  const gating = verdict.criteria.filter((c) => c.gating !== false);
+  const failed = gating.filter((c) => !c.passed);
+  const total = gating.length;
   const passedCount = total - failed.length;
   const durationSuffix = verdict.llmDurationMs ? ` in ${(verdict.llmDurationMs / 1e3).toFixed(1)}s` : "";
   const statusNote = verdict.llmStatus === "pending" ? " \u2014 LLM evaluation in progress..." : verdict.llmStatus === "failed" ? ` \u2014 LLM evaluation failed${verdict.llmError ? `: ${verdict.llmError}` : ""}, showing heuristic results` : verdict.source === "llm" && durationSuffix ? ` \u2014 evaluated${durationSuffix}` : "";
   if (failed.length === 0) {
-    lines.push(`All ${total} rubric criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier, ${verdict.source} evaluation).${statusNote}`);
+    lines.push(`All ${total} gating criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier, ${verdict.source} evaluation).${statusNote}`);
   } else {
-    lines.push(`${passedCount}/${total} criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier, ${verdict.source} evaluation)${statusNote}`);
+    lines.push(`${passedCount}/${total} gating criteria pass for \`${verdict.canonicalKey}\` (${verdict.tier} tier, ${verdict.source} evaluation)${statusNote}`);
     lines.push("");
-    for (const c of verdict.criteria) {
+    for (const c of gating) {
       const icon = c.passed ? "[x]" : "[ ]";
       const extra = c.passed ? "" : ` \u2014 ${c.hint}`;
       lines.push(`${icon} ${c.id}${extra}`);
@@ -1235,6 +1243,7 @@ function formatRubricVerdictSection(verdict) {
       lines.push(`**Top improvement:** ${verdict.weakest.hint}`);
     }
   }
+  lines.push(...hintLines(verdict.criteria));
   if (verdict.rogerMartin) {
     const rm = verdict.rogerMartin;
     lines.push("");
@@ -2302,7 +2311,7 @@ Use \`entries action=get\` to inspect the existing entry, or \`entries action=up
     try {
       const wsForTracking = await getWorkspaceContext();
       const v = verdictResult.verdict;
-      const failedCount = (v.criteria ?? []).filter((c) => !c.passed).length;
+      const failedCount = (v.criteria ?? []).filter((c) => !c.passed && c.gating !== false).length;
       trackQualityVerdict(wsForTracking.workspaceId, {
         entry_id: finalEntryId,
         entry_type: v.canonicalKey ?? resolvedCollection,
@@ -2310,7 +2319,7 @@ Use \`entries action=get\` to inspect the existing entry, or \`entries action=up
         context: "capture",
         passed: v.passed,
         source: verdictResult.source ?? "heuristic",
-        criteria_total: v.criteria?.length ?? 0,
+        criteria_total: (v.criteria ?? []).filter((c) => c.gating !== false).length,
         criteria_failed: failedCount,
         llm_scheduled: v.tier !== "passive",
         methodology_version: v.methodologyVersion
@@ -2999,7 +3008,7 @@ No DB writes \u2014 call without \`preview:true\` to accept for real.` }],
   if (coachingResult?.verdict) {
     try {
       const v = coachingResult.verdict;
-      const failedCount = (v.criteria ?? []).filter((c) => !c.passed).length;
+      const failedCount = (v.criteria ?? []).filter((c) => !c.passed && c.gating !== false).length;
       trackQualityVerdict(wsCtx.workspaceId, {
         entry_id: entryId,
         entry_type: v.canonicalKey ?? entry.canonicalKey ?? "",
@@ -3007,7 +3016,7 @@ No DB writes \u2014 call without \`preview:true\` to accept for real.` }],
         context: "commit",
         passed: v.passed,
         source: coachingResult.source ?? "heuristic",
-        criteria_total: v.criteria?.length ?? 0,
+        criteria_total: (v.criteria ?? []).filter((c) => c.gating !== false).length,
         criteria_failed: failedCount,
         llm_scheduled: v.tier !== "passive",
         methodology_version: v.methodologyVersion
@@ -10531,7 +10540,9 @@ var qualityCheckOutputSchema = z21.object({
   criteria: z21.array(z21.object({
     id: z21.string(),
     passed: z21.boolean(),
-    hint: z21.string().optional()
+    hint: z21.string().optional(),
+    /** TASK-588 / DEC-1908: false = a coaching hint; an unmet one never fails the verdict. */
+    gating: z21.literal(false).optional()
   }))
 });
 var qualityReevaluateOutputSchema = z21.object({
@@ -10636,9 +10647,10 @@ Entry \`${entryId}\` not found. Use \`search\` to find the right ID.`,
   }
   const criteria = verdict.criteria ?? [];
   const lines = [`# Quality Check: ${entryId}`, ""];
+  const staleWhy = res.staleReason === "methodology_changed_since_judged" ? "the rubric changed since it was judged" : "the entry was edited since it was judged";
   if (res.stale) {
     lines.push(
-      `> STALE \u2014 this verdict was judged against an earlier version of \`${entryId}\`, which has been edited since. Run \`quality action=re-evaluate entryId="${entryId}"\` for a current verdict.`,
+      `> STALE \u2014 this verdict for \`${entryId}\` no longer counts: ${staleWhy}. Run \`quality action=re-evaluate entryId="${entryId}"\` for a current verdict.`,
       ""
     );
   }
@@ -10660,10 +10672,11 @@ Entry \`${entryId}\` not found. Use \`search\` to find the right ID.`,
     });
   } catch {
   }
-  const passedCount = criteria.filter((c) => c.passed).length;
+  const gatingCriteria = criteria.filter((c) => c.gating !== false);
+  const passedCount = gatingCriteria.filter((c) => c.passed).length;
   return successResult(
     lines.join("\n"),
-    `Quality check for ${entryId}: ${verdict.tier ?? "unknown"} tier, ${passedCount}/${criteria.length} criteria pass.` + (res.stale ? " STALE \u2014 the entry was edited after this verdict; re-evaluate for a current one." : ""),
+    `Quality check for ${entryId}: ${verdict.tier ?? "unknown"} tier, ${passedCount}/${gatingCriteria.length} gating criteria pass.` + (res.stale ? ` STALE \u2014 ${staleWhy}; re-evaluate for a current one.` : ""),
     {
       entryId,
       entryFound: true,
@@ -10671,7 +10684,7 @@ Entry \`${entryId}\` not found. Use \`search\` to find the right ID.`,
       stale: res.stale ?? false,
       tier: verdict.tier,
       passed: verdict.passed,
-      criteria: criteria.map((c) => ({ id: c.id, passed: c.passed, hint: c.hint }))
+      criteria: criteria.map((c) => ({ id: c.id, passed: c.passed, hint: c.hint, ...c.gating === false ? { gating: false } : {} }))
     },
     [
       { tool: "relations", description: "Suggest connections", parameters: { action: "suggest", entryId } }
@@ -10710,14 +10723,15 @@ async function handleReEvaluate(entryId, context) {
       context,
       passed: result2.verdict.passed ?? false,
       source: "heuristic",
-      criteria_total: result2.verdict.criteria?.length ?? 0,
-      criteria_failed: result2.verdict.criteria?.filter((c) => !c.passed).length ?? 0,
+      // TASK-588 / DEC-1908: totals and fails count gating criteria; a gating:false one is a hint.
+      criteria_total: result2.verdict.criteria?.filter((c) => c.gating !== false).length ?? 0,
+      criteria_failed: result2.verdict.criteria?.filter((c) => !c.passed && c.gating !== false).length ?? 0,
       llm_scheduled: llmScheduled,
       methodology_version: result2.verdict.methodologyVersion
     });
   } catch {
   }
-  const criteria = result2.verdict.criteria ?? [];
+  const criteria = (result2.verdict.criteria ?? []).filter((c) => c.gating !== false);
   const reEvalScore = criteria.filter((c) => c.passed).length;
   const reEvalMaxScore = criteria.length;
   return {
@@ -14143,4 +14157,4 @@ export {
   createProductBrainServer,
   initFeatureFlags
 };
-//# sourceMappingURL=chunk-4GJ3KH6Q.js.map
+//# sourceMappingURL=chunk-ZY4ORNVP.js.map