@productbrain/mcp 0.0.1-beta.70 → 0.0.1-beta.71

package/dist/{chunk-JOJWCU7A.js → chunk-2GMFQHAF.js}

@@ -2363,6 +2363,7 @@ function toSnapshot(report, maxTopGaps = 10) {
 import { readFileSync } from "fs";
 import { resolve } from "path";
 function resolveRegistries(projectRoot, manifest) {
+  if (!projectRoot) return {};
   const resolved = {};
   for (const ref of manifest) {
     try {
@@ -2374,7 +2375,10 @@ function resolveRegistries(projectRoot, manifest) {
       if (keys.size > 0) {
         resolved[ref.id] = keys;
       }
-    } catch {
+    } catch (err) {
+      if (process.env.DEBUG_COHERENCE) {
+        console.debug(`[coherence] Skipping ${ref.id} (${ref.path}):`, err instanceof Error ? err.message : err);
+      }
     }
   }
   return resolved;
@@ -2409,14 +2413,19 @@ function extractBalanced(content, openPos, openChar, closeChar) {
       i = skipString(content, i, ch);
       continue;
     }
-    if (ch === "/" && content[i + 1] === "/") {
+    if (ch === "/" && i + 1 < content.length && content[i + 1] === "/") {
       while (i < content.length && content[i] !== "\n") i++;
       continue;
     }
-    if (ch === "/" && content[i + 1] === "*") {
+    if (ch === "/" && i + 1 < content.length && content[i + 1] === "*") {
       i += 2;
-      while (i < content.length && !(content[i - 1] === "*" && content[i] === "/")) i++;
-      i++;
+      while (i < content.length) {
+        if (content[i] === "/" && i > 0 && content[i - 1] === "*") {
+          i++;
+          break;
+        }
+        i++;
+      }
       continue;
     }
     if (ch === openChar) depth++;
@@ -2429,11 +2438,12 @@ function extractBalanced(content, openPos, openChar, closeChar) {
 function skipString(content, start, quote) {
   let i = start + 1;
   while (i < content.length) {
-    if (content[i] === "\\" && quote !== "`") {
+    const ch = content[i];
+    if (ch === "\\") {
       i += 2;
       continue;
     }
-    if (content[i] === quote) return i + 1;
+    if (ch === quote) return i + 1;
     i++;
   }
   return i;
@@ -2454,14 +2464,19 @@ function extractObjectKeys(block) {
   let i = 0;
   while (i < block.length) {
     const ch = block[i];
-    if (ch === "/" && block[i + 1] === "/") {
+    if (ch === "/" && i + 1 < block.length && block[i + 1] === "/") {
       while (i < block.length && block[i] !== "\n") i++;
       continue;
     }
-    if (ch === "/" && block[i + 1] === "*") {
+    if (ch === "/" && i + 1 < block.length && block[i + 1] === "*") {
       i += 2;
-      while (i < block.length && !(block[i - 1] === "*" && block[i] === "/")) i++;
-      i++;
+      while (i < block.length) {
+        if (block[i] === "/" && i > 0 && block[i - 1] === "*") {
+          i++;
+          break;
+        }
+        i++;
+      }
       continue;
     }
     if (depth === 0) {
@@ -2515,6 +2530,7 @@ function extractSetValues(block) {
 // src/lib/coherence/git-detection.ts
 import { execSync } from "child_process";
 function detectTouchedRegistries(projectRoot) {
+  if (!projectRoot) return /* @__PURE__ */ new Set();
   const manifestPaths = new Set(REGISTRY_MANIFEST.map((r) => r.path));
   const touched = /* @__PURE__ */ new Set();
   try {
@@ -2529,7 +2545,10 @@ function detectTouchedRegistries(projectRoot) {
         touched.add(trimmed);
       }
     }
-  } catch {
+  } catch (err) {
+    if (process.env.DEBUG_COHERENCE) {
+      console.debug("[coherence] Git detection failed:", err instanceof Error ? err.message : err);
+    }
   }
   return touched;
 }
@@ -2599,13 +2618,16 @@ function computeDelta(before, after) {
 function renderCoherenceDelta(delta) {
   const lines = ["### Coherence Delta"];
   const p = (n) => n === 1 ? "" : "s";
+  const absNet = Math.abs(delta.netChange);
+  const approx = absNet > delta.gapsFixed + delta.gapsIntroduced;
+  const prefix = approx ? "at least " : "";
   if (delta.verdict === "improved") {
     lines.push(
-      `Registry coherence **improved**: ${delta.gapsFixed} gap${p(delta.gapsFixed)} fixed` + (delta.gapsIntroduced > 0 ? `, ${delta.gapsIntroduced} introduced` : "") + ` (net ${delta.netChange}). ${delta.after.totalGaps} gap${p(delta.after.totalGaps)} remain${delta.after.totalGaps === 1 ? "s" : ""}.`
+      `Registry coherence **improved**: ${prefix}${delta.gapsFixed} gap${p(delta.gapsFixed)} fixed` + (delta.gapsIntroduced > 0 ? `, ${delta.gapsIntroduced} introduced` : "") + ` (net ${delta.netChange}). ${delta.after.totalGaps} gap${p(delta.after.totalGaps)} remain${delta.after.totalGaps === 1 ? "s" : ""}.`
     );
   } else if (delta.verdict === "degraded") {
     lines.push(
-      `**Registry coherence degraded**: ${delta.gapsIntroduced} new gap${p(delta.gapsIntroduced)} introduced` + (delta.gapsFixed > 0 ? `, ${delta.gapsFixed} fixed` : "") + ` (net +${delta.netChange}). ${delta.after.totalGaps} gap${p(delta.after.totalGaps)} total.`
+      `**Registry coherence degraded**: ${prefix}${delta.gapsIntroduced} new gap${p(delta.gapsIntroduced)} introduced` + (delta.gapsFixed > 0 ? `, ${delta.gapsFixed} fixed` : "") + ` (net +${delta.netChange}). ${delta.after.totalGaps} gap${p(delta.after.totalGaps)} total.`
     );
   } else {
     lines.push(
@@ -2615,6 +2637,58 @@ function renderCoherenceDelta(delta) {
   lines.push("");
   return lines;
 }
+function findPersistentGaps(delta, currentViolations) {
+  const beforeSet = new Set(delta.before.topGaps.map((g) => `${g.registry}::${g.slug}`));
+  const afterSet = new Set(delta.after.topGaps.map((g) => `${g.registry}::${g.slug}`));
+  const persistentKeys = /* @__PURE__ */ new Set();
+  for (const key of beforeSet) {
+    if (afterSet.has(key)) persistentKeys.add(key);
+  }
+  if (persistentKeys.size === 0) return [];
+  const violationMap = /* @__PURE__ */ new Map();
+  for (const v of currentViolations) {
+    violationMap.set(`${v.registryId}::${v.collectionSlug}`, v);
+  }
+  return [...persistentKeys].map((key) => {
+    const [registry = "", slug = ""] = key.split("::", 2);
+    return {
+      registry,
+      slug,
+      severity: delta.after.topGaps.find((g) => g.registry === registry && g.slug === slug)?.severity ?? "warning",
+      violation: violationMap.get(key) ?? null
+    };
+  });
+}
+function renderPersistentGapOffers(gaps) {
+  if (gaps.length === 0) return [];
+  const lines = [
+    "### Persistent Coherence Gaps",
+    "",
+    "These gaps existed before and after this session \u2014 they represent structural registry drift.",
+    "Want me to capture them as tensions on the Chain?",
+    ""
+  ];
+  const SEVERITY_RANK2 = { error: 0, warning: 1, info: 2 };
+  const errorsFirst = [...gaps].sort(
+    (a, b) => SEVERITY_RANK2[a.severity] - SEVERITY_RANK2[b.severity]
+  );
+  for (const gap of errorsFirst.slice(0, 5)) {
+    const v = gap.violation;
+    const fixHint = v?.fix ? ` \u2014 ${v.fix}` : "";
+    lines.push(
+      `- **\`${gap.slug}\`** missing from \`${gap.registry}\` (${gap.severity})${fixHint}`
+    );
+  }
+  if (errorsFirst.length > 5) {
+    lines.push(`- ...and ${errorsFirst.length - 5} more`);
+  }
+  lines.push("");
+  lines.push(
+    '_Say "capture these as tensions" to commit them to the Chain, or skip to continue._'
+  );
+  lines.push("");
+  return lines;
+}
 
 // src/lib/resolve-project-root.ts
 import { existsSync } from "fs";
@@ -2623,6 +2697,8 @@ function resolveProjectRoot() {
   const candidates = [
     process.env.WORKSPACE_PATH,
     process.cwd(),
+    // Parent of cwd: handles monorepo subpackages (e.g. packages/mcp-server)
+    // where the Convex schema lives one level up.
     resolve2(process.cwd(), "..")
   ].filter(Boolean);
   for (const dir of candidates) {
@@ -2652,16 +2728,24 @@ async function mapWithConcurrency(items, mapper, concurrency = 3) {
   );
   return results;
 }
+function isValidTopGap(g) {
+  if (typeof g !== "object" || g === null) return false;
+  const obj = g;
+  return typeof obj.registry === "string" && typeof obj.slug === "string" && typeof obj.severity === "string" && (obj.severity === "error" || obj.severity === "warning" || obj.severity === "info");
+}
 async function fetchSessionCoherenceSnapshot(sessionId) {
   try {
     const session = await mcpCall("agent.getSession", {
       sessionId
     });
     const raw = session?.coherenceSnapshot;
-    if (raw && typeof raw.checkedAt === "number" && typeof raw.totalGaps === "number") {
+    if (raw && typeof raw.checkedAt === "number" && typeof raw.totalGaps === "number" && Array.isArray(raw.topGaps) && raw.topGaps.every(isValidTopGap)) {
       return raw;
     }
-  } catch {
+  } catch (err) {
+    if (process.env.DEBUG_COHERENCE) {
+      console.debug("[coherence] Snapshot fetch failed:", err instanceof Error ? err.message : err);
+    }
   }
   return null;
 }
@@ -2760,6 +2844,7 @@ async function runWrapupReview() {
     lines.push("");
   }
   let coherenceVerdict;
+  let persistentGaps;
   try {
     const projectRoot = resolveProjectRoot();
     if (projectRoot) {
@@ -2781,6 +2866,10 @@ async function runWrapupReview() {
               );
               lines.push("");
             }
+            persistentGaps = findPersistentGaps(delta, report.violations);
+            if (persistentGaps.length > 0) {
+              lines.push(...renderPersistentGapOffers(persistentGaps));
+            }
           } else if (touchedFiles.size > 0) {
             lines.push("### Coherence Check");
             lines.push(
@@ -2797,7 +2886,10 @@ async function runWrapupReview() {
         }
       }
     }
-  } catch {
+  } catch (err) {
+    if (process.env.DEBUG_COHERENCE) {
+      console.debug("[coherence] Wrapup coherence check failed:", err instanceof Error ? err.message : err);
+    }
   }
   if (data.drafts.length > 0) {
     const draftIds = data.drafts.map((d) => `\`${d.entryId}\``).join(", ");
@@ -2807,7 +2899,7 @@ async function runWrapupReview() {
     lines.push("- **Skip:** call `session action=close` \u2014 drafts remain for next session's orient recovery.");
   }
   const gapCount = getSessionGaps().length;
-  return { text: lines.join("\n"), data, suggestions, gapCount, coherenceVerdict };
+  return { text: lines.join("\n"), data, suggestions, gapCount, coherenceVerdict, persistentGaps };
 }
 async function runWrapupCommitAll(data, cachedSuggestions) {
   requireWriteAccess();
@@ -2932,7 +3024,7 @@ function registerWrapupTools(server) {
         }
       );
     }
-    const { text, data, suggestions, failureCode, gapCount, coherenceVerdict } = await runWrapupReview();
+    const { text, data, suggestions, failureCode, gapCount, coherenceVerdict, persistentGaps } = await runWrapupReview();
     lastReviewData = data;
     lastReviewSuggestions = suggestions;
     lastReviewSessionId = getAgentSessionId();
@@ -2945,16 +3037,18 @@ ${text}` : text;
     const next = data.drafts.length > 0 ? [{ tool: "session-wrapup", description: "Commit all drafts", parameters: { action: "commit-all" } }] : void 0;
     const gapsSummary = gapCount ? `, ${gapCount} knowledge gaps detected` : "";
     const coherenceSummary = coherenceVerdict ? `, coherence: ${coherenceVerdict}` : "";
+    const persistentSummary = persistentGaps?.length ? `, ${persistentGaps.length} persistent coherence gaps` : "";
     return successResult(
       fullText,
-      `Session review: ${data.drafts.length} uncommitted, ${data.committed.length} committed, ${suggestions.length} link suggestions${gapsSummary}${coherenceSummary}.`,
+      `Session review: ${data.drafts.length} uncommitted, ${data.committed.length} committed, ${suggestions.length} link suggestions${gapsSummary}${coherenceSummary}${persistentSummary}.`,
       {
         drafts: data.drafts.length,
         committed: data.committed.length,
         uncommitted: data.summary.uncommitted,
         suggestedLinks: suggestions.length,
         knowledgeGaps: gapCount ?? 0,
-        ...coherenceVerdict ? { coherenceVerdict } : {}
+        ...coherenceVerdict ? { coherenceVerdict } : {},
+        ...persistentGaps?.length ? { persistentCoherenceGaps: persistentGaps.length } : {}
       },
       next
     );
@@ -7687,16 +7781,19 @@ function buildCoherenceSection(projectRoot) {
   try {
     const root = projectRoot ?? resolveProjectRoot() ?? process.cwd();
     return checkAndRender(root);
-  } catch {
+  } catch (err) {
+    if (process.env.DEBUG_COHERENCE) {
+      console.debug("[coherence] buildCoherenceSection failed:", err instanceof Error ? err.message : err);
+    }
     return null;
   }
 }
 function runAlignmentCheck(task, activeBets, taskContextHits) {
   const betNames = activeBets.map((b) => b.name);
-  const taskWords = task.toLowerCase().split(/\s+/).filter((w) => w.length > 2);
+  const taskWords = extractKeywords(task);
   const matchingBet = activeBets.find((b) => {
-    const name = (b.name ?? "").toLowerCase();
-    return taskWords.some((w) => name.includes(w));
+    const words = (b.name ?? "").toLowerCase().split(/\s+/);
+    return taskWords.some((tw) => words.some((w) => w === tw || w.startsWith(tw + "-")));
   });
   if (matchingBet) {
     return { aligned: true, matchedBet: matchingBet.name, matchSource: "active_bet", betNames };
@@ -7711,11 +7808,11 @@ function runAlignmentCheck(task, activeBets, taskContextHits) {
 }
 function buildAlignmentCheckLines(result) {
   const lines = ["## Alignment Check"];
-  if (result.aligned && result.matchSource === "active_bet") {
+  if (result.aligned && result.matchSource === "active_bet" && result.matchedBet) {
     lines.push(
       `Task aligns with active bet: **${result.matchedBet}**. Proceed.`
     );
-  } else if (result.aligned && result.matchSource === "task_context") {
+  } else if (result.aligned && result.matchSource === "task_context" && result.matchedBet) {
     const noActiveBets = result.betNames.length === 0;
     lines.push(
       `Task related to **${result.matchedBet}** via task context${noActiveBets ? " (no active bets in horizon=now)" : ""}. Proceed with caution \u2014 confirm scope with the user if uncertain.`
@@ -7745,7 +7842,15 @@ var RULE5_COMPACT = '**Validate against governance.** Before proposing or buildi
 var MAX_ENTRIES_NO_TASK = 3;
 var MAX_ENTRIES_WITH_TASK = 5;
 function extractKeywords(text) {
-  return [...new Set(text.toLowerCase().split(/\s+/).filter((w) => w.length > 2))];
+  const normalized = text.toLowerCase().replace(/[^\w\s-]/g, " ");
+  const tokens = [];
+  for (const raw of normalized.split(/\s+/)) {
+    if (!raw) continue;
+    const parts = raw.split(/[-_]/);
+    if (parts.length > 1) tokens.push(raw.replace(/[-_]/g, ""));
+    for (const p of parts) if (p) tokens.push(p);
+  }
+  return [...new Set(tokens.filter((w) => w.length > 2))];
 }
 function scoreEntry(entry, keywords) {
   const text = `${entry.name} ${entry.description ?? ""}`.toLowerCase();
@@ -12457,4 +12562,4 @@ export {
   SERVER_VERSION,
   createProductBrainServer
 };
-//# sourceMappingURL=chunk-JOJWCU7A.js.map
+//# sourceMappingURL=chunk-2GMFQHAF.js.map