@productbrain/cli 0.1.0-beta.55 → 0.1.0-beta.5504

package/dist/commands/__tests__/connect-handoff.test.js

@@ -0,0 +1,111 @@
+/**
+ * WP-433 S4 — FEAT-1291: Tests for connect-handoff module.
+ *
+ * Contract:
+ * 1. Heuristic table: 5 cases, each asserts exact agent + message strings.
+ * 2. ≤200-char invariant: all 5 messages must be ≤200 characters.
+ * 3. No bare-repo undefined: bare-repo result is never undefined/empty.
+ * 4. detectHandoffMarkers integration: tmpdir with .claude/ → hasClaude=true.
+ */
+import { mkdirSync, rmSync, writeFileSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { resolveHandoff, detectHandoffMarkers, HANDOFF_MESSAGE_CLAUDE_OR_CURSOR, HANDOFF_MESSAGE_CLAUDE, HANDOFF_MESSAGE_CURSOR, HANDOFF_MESSAGE_CODEX, HANDOFF_MESSAGE_BARE_REPO, } from '../connect-handoff.js';
+// ── 1. Heuristic table (5 cases) ─────────────────────────────────────────────
+describe('resolveHandoff — heuristic table', () => {
+    it('.claude=Y, .cursor=Y → claude-or-cursor', () => {
+        const result = resolveHandoff({ hasClaude: true, hasCursor: true, hasCodexFile: false });
+        expect(result.agent).toBe('claude-or-cursor');
+        expect(result.message).toBe('Open Claude Code or Cursor in this project and type in chat: Start Product Brain');
+    });
+    it('.claude=Y, .cursor=N → claude', () => {
+        const result = resolveHandoff({ hasClaude: true, hasCursor: false, hasCodexFile: false });
+        expect(result.agent).toBe('claude');
+        expect(result.message).toBe('Open Claude Code in this project and type in chat: Start Product Brain');
+    });
+    it('.claude=N, .cursor=Y → cursor', () => {
+        const result = resolveHandoff({ hasClaude: false, hasCursor: true, hasCodexFile: false });
+        expect(result.agent).toBe('cursor');
+        expect(result.message).toBe('Open Cursor in this project and type in chat: Start Product Brain');
+    });
+    it('.claude=N, .cursor=N, AGENTS.md=Y → codex', () => {
+        const result = resolveHandoff({ hasClaude: false, hasCursor: false, hasCodexFile: true });
+        expect(result.agent).toBe('codex');
+        expect(result.message).toBe('Open Codex CLI in this project and type in chat: Start Product Brain');
+    });
+    it('.claude=N, .cursor=N, AGENTS.md=N → bare-repo', () => {
+        const result = resolveHandoff({ hasClaude: false, hasCursor: false, hasCodexFile: false });
+        expect(result.agent).toBe('bare-repo');
+        expect(result.message).toBe('No AI tool detected in this project. Visit productbrain.io/docs to set one up.');
+    });
+});
+// ── 2. Exhaustiveness: every boolean combination returns a defined HandoffResult ──
+describe('resolveHandoff — every boolean combination returns a defined HandoffResult', () => {
+    it('covers all 2^3 = 8 marker combinations', () => {
+        const bools = [false, true];
+        for (const hasClaude of bools) {
+            for (const hasCursor of bools) {
+                for (const hasCodexFile of bools) {
+                    const result = resolveHandoff({ hasClaude, hasCursor, hasCodexFile });
+                    expect(result.agent).toBeDefined();
+                    expect(result.message.length).toBeGreaterThan(0);
+                }
+            }
+        }
+    });
+});
+// ── 4. ≤200-char invariant ────────────────────────────────────────────────────
+describe('handoff message ≤200-char invariant', () => {
+    const allMessages = [
+        HANDOFF_MESSAGE_CLAUDE_OR_CURSOR,
+        HANDOFF_MESSAGE_CLAUDE,
+        HANDOFF_MESSAGE_CURSOR,
+        HANDOFF_MESSAGE_CODEX,
+        HANDOFF_MESSAGE_BARE_REPO,
+    ];
+    it.each(allMessages)('message is ≤200 chars: "%s"', (msg) => {
+        expect(msg.length).toBeLessThanOrEqual(200);
+    });
+});
+// ── 5. No bare-repo undefined ─────────────────────────────────────────────────
+describe('bare-repo result is never undefined or empty', () => {
+    it('resolveHandoff returns bare-repo with non-empty message when no markers', () => {
+        const result = resolveHandoff({ hasClaude: false, hasCursor: false, hasCodexFile: false });
+        expect(result.agent).toBe('bare-repo');
+        expect(result.message).toBeDefined();
+        expect(result.message.length).toBeGreaterThan(0);
+    });
+});
+// ── 6. detectHandoffMarkers integration ──────────────────────────────────────
+describe('detectHandoffMarkers integration', () => {
+    let tmp;
+    beforeEach(() => {
+        tmp = join(tmpdir(), `pb-handoff-test-${Date.now()}`);
+        mkdirSync(tmp, { recursive: true });
+    });
+    afterEach(() => {
+        rmSync(tmp, { recursive: true, force: true });
+    });
+    it('returns hasClaude=true when .claude/ dir exists', () => {
+        mkdirSync(join(tmp, '.claude'));
+        const markers = detectHandoffMarkers(tmp);
+        expect(markers).toEqual({ hasClaude: true, hasCursor: false, hasCodexFile: false });
+    });
+    it('returns hasCursor=true when .cursor/ dir exists', () => {
+        mkdirSync(join(tmp, '.cursor'));
+        const markers = detectHandoffMarkers(tmp);
+        expect(markers).toEqual({ hasClaude: false, hasCursor: true, hasCodexFile: false });
+    });
+    it('returns hasCodexFile=true when AGENTS.md exists', () => {
+        // Write a minimal file so existsSync resolves it as a file (not dir)
+        writeFileSync(join(tmp, 'AGENTS.md'), '');
+        const markers = detectHandoffMarkers(tmp);
+        expect(markers).toEqual({ hasClaude: false, hasCursor: false, hasCodexFile: true });
+    });
+    it('returns all false when directory is empty', () => {
+        const markers = detectHandoffMarkers(tmp);
+        expect(markers).toEqual({ hasClaude: false, hasCursor: false, hasCodexFile: false });
+    });
+});
+//# sourceMappingURL=connect-handoff.test.js.map

package/dist/commands/__tests__/connect-handoff.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"connect-handoff.test.js","sourceRoot":"","sources":["../../../src/commands/__tests__/connect-handoff.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,aAAa,EAAE,MAAM,IAAI,CAAC;AACtD,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAC;AAC5B,OAAO,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AAC5B,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACrE,OAAO,EACL,cAAc,EACd,oBAAoB,EACpB,gCAAgC,EAChC,sBAAsB,EACtB,sBAAsB,EACtB,qBAAqB,EACrB,yBAAyB,GAE1B,MAAM,uBAAuB,CAAC;AAE/B,gFAAgF;AAEhF,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;IAChD,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;QACjD,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;QACzF,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;QAC9C,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CACzB,kFAAkF,CACnF,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACvC,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;QAC1F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACpC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CACzB,wEAAwE,CACzE,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACvC,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;QAC1F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACpC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CACzB,mEAAmE,CACpE,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACnD,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,IAAI,EAAE,CAAC,CAAC;QAC1F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CACzB,sEAAsE,CACvE,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;QAC3F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACvC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CACzB,gFAAgF,CACjF,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,qFAAqF;AAErF,QAAQ,CAAC,4EAA4E,EAAE,GAAG,EAAE;IAC1F,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QAChD,MAAM,KAAK,GAAG,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC;QAC5B,KAAK,MAAM,SAAS,IAAI,KAAK,EAAE,CAAC;YAC9B,KAAK,MAAM,SAAS,IAAI,KAAK,EAAE,CAAC;gBAC9B,KAAK,MAAM,YAAY,IAAI,KAAK,EAAE,CAAC;oBACjC,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,SAAS,EAAE,YAAY,EAAE,CAAC,CAAC;oBACtE,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,WAAW,EAAE,CAAC;oBACnC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;gBACnD,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,QAAQ,CAAC,qCAAqC,EAAE,GAAG,EAAE;IACnD,MAAM,WAAW,GAAG;QAClB,gCAAgC;QAChC,sBAAsB;QACtB,sBAAsB;QACtB,qBAAqB;QACrB,yBAAyB;KAC1B,CAAC;IAEF,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,6BAA6B,EAAE,CAAC,GAAG,EAAE,EAAE;QAC1D,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,QAAQ,CAAC,8CAA8C,EAAE,GAAG,EAAE;IAC5D,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QACjF,MAAM,MAAM,GAAG,cAAc,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;QAC3F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACvC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,WAAW,EAAE,CAAC;QACrC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;IAChD,IAAI,GAAW,CAAC;IAEhB,UAAU,CAAC,GAAG,EAAE;QACd,GAAG,GAAG,IAAI,CAAC,MAAM,EAAE,EAAE,mBAAmB,IAAI,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC;QACtD,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,SAAS,CAAC,IAAI,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC,CAAC;QAChC,MAAM,OAAO,GAAG,oBAAoB,CAAC,GAAG,CAAC,CAAC;QAC1C,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;IACtF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,SAAS,CAAC,IAAI,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC,CAAC;QAChC,MAAM,OAAO,GAAG,oBAAoB,CAAC,GAAG,CAAC,CAAC;QAC1C,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;IACtF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,qEAAqE;QACrE,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,WAAW,CAAC,EAAE,EAAE,CAAC,CAAC;QAC1C,MAAM,OAAO,GAAG,oBAAoB,CAAC,GAAG,CAAC,CAAC;QAC1C,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,IAAI,EAAE,CAAC,CAAC;IACtF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACnD,MAAM,OAAO,GAAG,oBAAoB,CAAC,GAAG,CAAC,CAAC;QAC1C,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;IACvF,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/commands/__tests__/quality.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=quality.test.d.ts.map

package/dist/commands/__tests__/quality.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"quality.test.d.ts","sourceRoot":"","sources":["../../../src/commands/__tests__/quality.test.ts"],"names":[],"mappings":""}

package/dist/commands/__tests__/quality.test.js

@@ -0,0 +1,156 @@
+/**
+ * pb quality spine-check — unit tests (A2, WP-581/FEAT-1402).
+ *
+ * Verifies:
+ * 1. Calls quality.spineCheck with includeStory reflecting --story, then reads back via
+ *    quality.getLatestSpineVerdict (store-then-read-back, never the write's own return value).
+ * 2. Renders "no spine entries yet" for an empty spine.
+ * 3. Renders "no spine check has been run yet" when the read-back is null.
+ * 4. Renders the [stale] prefix when the read-back reports stale.
+ */
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { runQualitySpineCheck } from '../quality.js';
+import { setOutputMode } from '../../lib/runner.js';
+const kernelCallMock = vi.fn();
+vi.mock('../../lib/client.js', () => ({
+    kernelCall: (...args) => kernelCallMock(...args),
+}));
+vi.mock('../../lib/config.js', () => ({
+    getConfigOrGuide: vi.fn(() => Promise.resolve({ apiKey: 'pb_sk_test', siteUrl: 'https://test.convex.site' })),
+}));
+let stdoutOutput;
+let stdoutWriteSpy;
+beforeEach(() => {
+    stdoutOutput = '';
+    stdoutWriteSpy = vi.spyOn(process.stdout, 'write').mockImplementation((chunk) => {
+        stdoutOutput += String(chunk);
+        return true;
+    });
+    vi.clearAllMocks();
+});
+afterEach(() => {
+    stdoutWriteSpy.mockRestore();
+    setOutputMode('auto');
+});
+const PASSING_ROW = {
+    verdict: {
+        structural: {
+            passed: true, missing: [], duplicateSingletons: { purpose: null, vision: null }, unconnectedStrategyIds: [],
+            strategiesWithUnknownConnectivity: [], visionConnectedToPurpose: true, visionPurposeConnectivityTruncated: false,
+        },
+        noSpineEntries: false,
+        perStrategy: [{ entryId: 's1', refusal: { entryId: 's1', hasRefusalSignal: true }, rogerMartin: { isStrategicChoice: true, oppositeReasonable: true, reasoning: 'ok', suggestion: null } }],
+        story: null,
+        strategiesTruncated: false,
+    },
+    includesStoryPass: false,
+    createdAt: 123,
+    stale: false,
+    staleMemberIds: [],
+};
+describe('runQualitySpineCheck — call shape', () => {
+    it('calls quality.spineCheck with includeStory:false by default, then reads back via getLatestSpineVerdict', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce(PASSING_ROW);
+        setOutputMode('json');
+        await runQualitySpineCheck({});
+        expect(kernelCallMock).toHaveBeenNthCalledWith(1, 'quality.spineCheck', { includeStory: false });
+        expect(kernelCallMock).toHaveBeenNthCalledWith(2, 'quality.getLatestSpineVerdict', {});
+    });
+    it('passes includeStory:true when --story is set', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce(PASSING_ROW);
+        setOutputMode('json');
+        await runQualitySpineCheck({ story: true });
+        expect(kernelCallMock).toHaveBeenNthCalledWith(1, 'quality.spineCheck', { includeStory: true });
+    });
+});
+describe('runQualitySpineCheck — rendering', () => {
+    it('renders "no spine entries yet" for an empty spine', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce({
+            ...PASSING_ROW,
+            verdict: { ...PASSING_ROW.verdict, noSpineEntries: true },
+        });
+        setOutputMode('pretty');
+        await runQualitySpineCheck({});
+        expect(stdoutOutput).toMatch(/no spine entries yet/i);
+    });
+    it('renders "no spine check has been run yet" when the read-back is null', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce(null);
+        setOutputMode('pretty');
+        await runQualitySpineCheck({});
+        expect(stdoutOutput).toMatch(/no spine check has been run yet/i);
+    });
+    it('renders the [stale] prefix when the read-back reports stale', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce({
+            ...PASSING_ROW, stale: true, staleMemberIds: ['e1'],
+        });
+        setOutputMode('pretty');
+        await runQualitySpineCheck({});
+        expect(stdoutOutput).toMatch(/\[stale/);
+    });
+    it('names the failed story criterion on a FAIL', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce({
+            ...PASSING_ROW,
+            includesStoryPass: true,
+            verdict: {
+                ...PASSING_ROW.verdict,
+                story: {
+                    passed: false,
+                    failedCriterion: 'strategy_serves_vision',
+                    criteria: [{ id: 'strategy_serves_vision', passed: false, reasoning: 'unrelated' }],
+                },
+            },
+        });
+        setOutputMode('pretty');
+        await runQualitySpineCheck({ story: true });
+        expect(stdoutOutput).toMatch(/strategy_serves_vision/);
+        expect(stdoutOutput).toMatch(/unvalidated/i);
+    });
+    it('distinguishes a FAILED story pass (requested, LLM returned nothing usable) from one never requested (PR #530 P2)', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce({
+            ...PASSING_ROW,
+            includesStoryPass: true, // requested this row
+            verdict: { ...PASSING_ROW.verdict, story: null }, // but the LLM pass produced nothing usable
+        });
+        setOutputMode('pretty');
+        await runQualitySpineCheck({ story: true });
+        expect(stdoutOutput).toMatch(/requested, but the LLM pass did not return a usable result/i);
+        expect(stdoutOutput).not.toMatch(/not run this pass/i);
+    });
+    it('renders truncation and unknown-connectivity disclosures rather than silently omitting them (PR #530 P2)', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce({
+            ...PASSING_ROW,
+            verdict: {
+                ...PASSING_ROW.verdict,
+                structural: {
+                    ...PASSING_ROW.verdict.structural,
+                    strategiesWithUnknownConnectivity: ['s9'],
+                    visionConnectedToPurpose: false,
+                    visionPurposeConnectivityTruncated: true,
+                },
+                strategiesTruncated: true,
+            },
+        });
+        setOutputMode('pretty');
+        await runQualitySpineCheck({});
+        expect(stdoutOutput).toMatch(/connectivity unknown/i);
+        expect(stdoutOutput).toMatch(/no vision informs any purpose/i);
+        expect(stdoutOutput).toMatch(/vision.*purpose connectivity unknown/i);
+        expect(stdoutOutput).toMatch(/strategy set truncated/i);
+    });
+    it('renders a FAILED Roger Martin probe explicitly — never silently omitted as if not attempted (PR #530 round 2)', async () => {
+        kernelCallMock.mockResolvedValueOnce(undefined).mockResolvedValueOnce({
+            ...PASSING_ROW,
+            verdict: {
+                ...PASSING_ROW.verdict,
+                // runSpineCheck ALWAYS attempts a probe per strategy — null here is a
+                // failed attempt (timeout/budget-reject/malformed response), never "skipped".
+                perStrategy: [{ entryId: 's1', refusal: { entryId: 's1', hasRefusalSignal: false }, rogerMartin: null }],
+            },
+        });
+        setOutputMode('pretty');
+        await runQualitySpineCheck({});
+        expect(stdoutOutput).toMatch(/failed to evaluate/i);
+        expect(stdoutOutput).not.toMatch(/not attempted|not requested/i);
+    });
+});
+//# sourceMappingURL=quality.test.js.map

package/dist/commands/__tests__/quality.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"quality.test.js","sourceRoot":"","sources":["../../../src/commands/__tests__/quality.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AACH,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,oBAAoB,EAAE,MAAM,eAAe,CAAC;AACrD,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AAEpD,MAAM,cAAc,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAE/B,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,UAAU,EAAE,CAAC,GAAG,IAAe,EAAE,EAAE,CAAC,cAAc,CAAC,GAAG,IAAI,CAAC;CAC5D,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,gBAAgB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAC3B,OAAO,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,YAAY,EAAE,OAAO,EAAE,0BAA0B,EAAE,CAAC,CAC/E;CACF,CAAC,CAAC,CAAC;AAEJ,IAAI,YAAoB,CAAC;AACzB,IAAI,cAA2C,CAAC;AAEhD,UAAU,CAAC,GAAG,EAAE;IACd,YAAY,GAAG,EAAE,CAAC;IAClB,cAAc,GAAG,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,kBAAkB,CAAC,CAAC,KAAK,EAAE,EAAE;QAC9E,YAAY,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC;QAC9B,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,aAAa,EAAE,CAAC;AACrB,CAAC,CAAC,CAAC;AAEH,SAAS,CAAC,GAAG,EAAE;IACb,cAAc,CAAC,WAAW,EAAE,CAAC;IAC7B,aAAa,CAAC,MAAM,CAAC,CAAC;AACxB,CAAC,CAAC,CAAC;AAEH,MAAM,WAAW,GAAG;IAClB,OAAO,EAAE;QACP,UAAU,EAAE;YACV,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,EAAE,mBAAmB,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,sBAAsB,EAAE,EAAE;YAC3G,iCAAiC,EAAE,EAAE,EAAE,wBAAwB,EAAE,IAAI,EAAE,kCAAkC,EAAE,KAAK;SACjH;QACD,cAAc,EAAE,KAAK;QACrB,WAAW,EAAE,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,gBAAgB,EAAE,IAAI,EAAE,EAAE,WAAW,EAAE,EAAE,iBAAiB,EAAE,IAAI,EAAE,kBAAkB,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,IAAI,EAAE,EAAE,CAAC;QAC3L,KAAK,EAAE,IAAI;QACX,mBAAmB,EAAE,KAAK;KAC3B;IACD,iBAAiB,EAAE,KAAK;IACxB,SAAS,EAAE,GAAG;IACd,KAAK,EAAE,KAAK;IACZ,cAAc,EAAE,EAAE;CACnB,CAAC;AAEF,QAAQ,CAAC,mCAAmC,EAAE,GAAG,EAAE;IACjD,EAAE,CAAC,wGAAwG,EAAE,KAAK,IAAI,EAAE;QACtH,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC,WAAW,CAAC,CAAC;QACnF,aAAa,CAAC,MAAM,CAAC,CAAC;QACtB,MAAM,oBAAoB,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,cAAc,CAAC,CAAC,uBAAuB,CAAC,CAAC,EAAE,oBAAoB,EAAE,EAAE,YAAY,EAAE,KAAK,EAAE,CAAC,CAAC;QACjG,MAAM,CAAC,cAAc,CAAC,CAAC,uBAAuB,CAAC,CAAC,EAAE,+BAA+B,EAAE,EAAE,CAAC,CAAC;IACzF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;QAC5D,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC,WAAW,CAAC,CAAC;QACnF,aAAa,CAAC,MAAM,CAAC,CAAC;QACtB,MAAM,oBAAoB,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAC5C,MAAM,CAAC,cAAc,CAAC,CAAC,uBAAuB,CAAC,CAAC,EAAE,oBAAoB,EAAE,EAAE,YAAY,EAAE,IAAI,EAAE,CAAC,CAAC;IAClG,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;IAChD,EAAE,CAAC,mDAAmD,EAAE,KAAK,IAAI,EAAE;QACjE,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC;YACpE,GAAG,WAAW;YACd,OAAO,EAAE,EAAE,GAAG,WAAW,CAAC,OAAO,EAAE,cAAc,EAAE,IAAI,EAAE;SAC1D,CAAC,CAAC;QACH,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,uBAAuB,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;QACpF,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC,IAAI,CAAC,CAAC;QAC5E,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,kCAAkC,CAAC,CAAC;IACnE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;QAC3E,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC;YACpE,GAAG,WAAW,EAAE,KAAK,EAAE,IAAI,EAAE,cAAc,EAAE,CAAC,IAAI,CAAC;SACpD,CAAC,CAAC;QACH,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC;YACpE,GAAG,WAAW;YACd,iBAAiB,EAAE,IAAI;YACvB,OAAO,EAAE;gBACP,GAAG,WAAW,CAAC,OAAO;gBACtB,KAAK,EAAE;oBACL,MAAM,EAAE,KAAK;oBACb,eAAe,EAAE,wBAAwB;oBACzC,QAAQ,EAAE,CAAC,EAAE,EAAE,EAAE,wBAAwB,EAAE,MAAM,EAAE,KAAK,EAAE,SAAS,EAAE,WAAW,EAAE,CAAC;iBACpF;aACF;SACF,CAAC,CAAC;QACH,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAC5C,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,wBAAwB,CAAC,CAAC;QACvD,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kHAAkH,EAAE,KAAK,IAAI,EAAE;QAChI,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC;YACpE,GAAG,WAAW;YACd,iBAAiB,EAAE,IAAI,EAAE,qBAAqB;YAC9C,OAAO,EAAE,EAAE,GAAG,WAAW,CAAC,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,EAAE,2CAA2C;SAC9F,CAAC,CAAC;QACH,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAC5C,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,6DAA6D,CAAC,CAAC;QAC5F,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,oBAAoB,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yGAAyG,EAAE,KAAK,IAAI,EAAE;QACvH,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC;YACpE,GAAG,WAAW;YACd,OAAO,EAAE;gBACP,GAAG,WAAW,CAAC,OAAO;gBACtB,UAAU,EAAE;oBACV,GAAG,WAAW,CAAC,OAAO,CAAC,UAAU;oBACjC,iCAAiC,EAAE,CAAC,IAAI,CAAC;oBACzC,wBAAwB,EAAE,KAAK;oBAC/B,kCAAkC,EAAE,IAAI;iBACzC;gBACD,mBAAmB,EAAE,IAAI;aAC1B;SACF,CAAC,CAAC;QACH,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,uBAAuB,CAAC,CAAC;QACtD,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,gCAAgC,CAAC,CAAC;QAC/D,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,uCAAuC,CAAC,CAAC;QACtE,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,yBAAyB,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+GAA+G,EAAE,KAAK,IAAI,EAAE;QAC7H,cAAc,CAAC,qBAAqB,CAAC,SAAS,CAAC,CAAC,qBAAqB,CAAC;YACpE,GAAG,WAAW;YACd,OAAO,EAAE;gBACP,GAAG,WAAW,CAAC,OAAO;gBACtB,sEAAsE;gBACtE,8EAA8E;gBAC9E,WAAW,EAAE,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,gBAAgB,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;aACzG;SACF,CAAC,CAAC;QACH,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,oBAAoB,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAC;QACpD,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,8BAA8B,CAAC,CAAC;IACnE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/commands/__tests__/rework.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=rework.test.d.ts.map

package/dist/commands/__tests__/rework.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"rework.test.d.ts","sourceRoot":"","sources":["../../../src/commands/__tests__/rework.test.ts"],"names":[],"mappings":""}

package/dist/commands/__tests__/rework.test.js

@@ -0,0 +1,149 @@
+/**
+ * pb rework report — unit tests (WP-487 Slice 1 / FEAT-1373).
+ *
+ * Verifies:
+ * 1. Requires an active session (mirrors pb capture's DEC-9/BR-8 gate).
+ * 2. Requires a resolved conversationId on that session (TEN-2728 join-key precondition) —
+ *    fails client-side with actionable guidance rather than a generic server error.
+ * 3. Rejects an unknown --classification / --via value before ever calling the network.
+ * 4. On success, calls `rework.report` with exactly the expected args (conversationId sourced
+ *    from the session, entryId trimmed, classification/reportedVia passed through, optional
+ *    attributableToGovernanceMiss/task only present when supplied).
+ * 5. Codex P2 (round 2 post-merge review): passes `options.conversation` through to
+ *    readSession() so a caller who started the session with `pb session start --conversation
+ *    <id>` can find it here without needing PB_CONVERSATION_ID also exported.
+ */
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { runReworkReport } from '../rework.js';
+import { setOutputMode } from '../../lib/runner.js';
+const kernelCallWithSessionMock = vi.fn();
+const readSessionMock = vi.fn();
+vi.mock('../../lib/client.js', () => ({
+    kernelCallWithSession: (...args) => kernelCallWithSessionMock(...args),
+}));
+vi.mock('../../lib/session.js', () => ({
+    readSession: (...args) => readSessionMock(...args),
+}));
+vi.mock('../../lib/config.js', () => ({
+    getConfigOrGuide: vi.fn(() => Promise.resolve({ apiKey: 'pb_sk_test', siteUrl: 'https://test.convex.site' })),
+}));
+let stdoutOutput;
+let stdoutWriteSpy;
+beforeEach(() => {
+    stdoutOutput = '';
+    stdoutWriteSpy = vi.spyOn(process.stdout, 'write').mockImplementation((chunk) => {
+        stdoutOutput += String(chunk);
+        return true;
+    });
+    setOutputMode('json');
+    vi.clearAllMocks();
+    readSessionMock.mockReturnValue({
+        sessionId: 'sess-1',
+        workspaceId: 'ws-1',
+        workspaceName: 'Test WS',
+        startedAt: new Date().toISOString(),
+        entriesCaptured: [],
+        conversationId: 'conv-abc',
+    });
+    kernelCallWithSessionMock.mockResolvedValue({ recorded: true, rowId: 'row-1' });
+});
+afterEach(() => {
+    stdoutWriteSpy.mockRestore();
+    setOutputMode('auto');
+});
+describe('runReworkReport — validation gates', () => {
+    it('throws when no active session is present', async () => {
+        readSessionMock.mockReturnValue(null);
+        await expect(runReworkReport({ entryId: 'STD-12', classification: 'revision' })).rejects.toThrow(/No active session/);
+        expect(kernelCallWithSessionMock).not.toHaveBeenCalled();
+    });
+    it('throws when the session has no resolved conversationId', async () => {
+        readSessionMock.mockReturnValue({
+            sessionId: 'sess-1',
+            workspaceId: 'ws-1',
+            workspaceName: 'Test WS',
+            startedAt: new Date().toISOString(),
+            entriesCaptured: [],
+            // no conversationId
+        });
+        await expect(runReworkReport({ entryId: 'STD-12', classification: 'revision' })).rejects.toThrow(/conversation identity/);
+        expect(kernelCallWithSessionMock).not.toHaveBeenCalled();
+    });
+    it('rejects an unknown classification before calling the network', async () => {
+        await expect(runReworkReport({ entryId: 'STD-12', classification: 'bogus' })).rejects.toThrow(/--classification must be one of/);
+        expect(kernelCallWithSessionMock).not.toHaveBeenCalled();
+    });
+    it('rejects an unknown --via value before calling the network', async () => {
+        await expect(runReworkReport({ entryId: 'STD-12', classification: 'revision', reportedVia: 'bogus' })).rejects.toThrow(/--via must be one of/);
+        expect(kernelCallWithSessionMock).not.toHaveBeenCalled();
+    });
+    it('rejects an empty entryId', async () => {
+        await expect(runReworkReport({ entryId: '   ', classification: 'revision' })).rejects.toThrow(/entry ID is required/);
+        expect(kernelCallWithSessionMock).not.toHaveBeenCalled();
+    });
+});
+describe('runReworkReport — success path', () => {
+    it('calls rework.report with sessionId + conversationId from the session and default reportedVia', async () => {
+        await runReworkReport({ entryId: 'STD-12', classification: 'revision' });
+        expect(kernelCallWithSessionMock).toHaveBeenCalledWith('rework.report', {
+            sessionId: 'sess-1',
+            conversationId: 'conv-abc',
+            entryId: 'STD-12',
+            classification: 'revision',
+            reportedVia: 'manual',
+        });
+    });
+    it('passes attributableToGovernanceMiss only when --attributable is set', async () => {
+        await runReworkReport({
+            entryId: 'STD-12',
+            classification: 'ci_review_correction',
+            reportedVia: 'ci_rerun',
+            attributable: true,
+            task: 'fix the join key',
+        });
+        expect(kernelCallWithSessionMock).toHaveBeenCalledWith('rework.report', {
+            sessionId: 'sess-1',
+            conversationId: 'conv-abc',
+            entryId: 'STD-12',
+            classification: 'ci_review_correction',
+            reportedVia: 'ci_rerun',
+            attributableToGovernanceMiss: true,
+            task: 'fix the join key',
+        });
+    });
+    it('omits attributableToGovernanceMiss when --attributable is not set', async () => {
+        await runReworkReport({ entryId: 'STD-12', classification: 'user_override' });
+        const [, args] = kernelCallWithSessionMock.mock.calls[0];
+        expect(args).not.toHaveProperty('attributableToGovernanceMiss');
+        expect(args).not.toHaveProperty('task');
+    });
+    it('emits the recorded result as JSON in JSON mode', async () => {
+        await runReworkReport({ entryId: 'STD-12', classification: 'revision' });
+        const parsed = JSON.parse(stdoutOutput);
+        expect(parsed.recorded).toBe(true);
+    });
+});
+describe('runReworkReport — Codex P2 (round 2): --conversation override', () => {
+    it('passes options.conversation through to readSession()', async () => {
+        await runReworkReport({ entryId: 'STD-12', classification: 'revision', conversation: 'conv-explicit' });
+        expect(readSessionMock).toHaveBeenCalledWith('conv-explicit');
+    });
+    it('calls readSession() with undefined when no --conversation is supplied', async () => {
+        await runReworkReport({ entryId: 'STD-12', classification: 'revision' });
+        expect(readSessionMock).toHaveBeenCalledWith(undefined);
+    });
+    it('the "No active session" guidance mentions --conversation as a recovery path', async () => {
+        readSessionMock.mockReturnValue(null);
+        const err = await runReworkReport({ entryId: 'STD-12', classification: 'revision' }).catch((e) => e);
+        expect(err.guidance ?? err.message).toMatch(/--conversation/);
+    });
+});
+describe('runReworkReport — Codex P2 (round 2): retry dedup surfacing', () => {
+    it('reports a distinct message when the server reused an existing row (deduped)', async () => {
+        kernelCallWithSessionMock.mockResolvedValue({ recorded: true, rowId: 'row-1', deduped: true });
+        setOutputMode('pretty');
+        await runReworkReport({ entryId: 'STD-12', classification: 'revision' });
+        expect(stdoutOutput).toMatch(/already recorded|reused/);
+    });
+});
+//# sourceMappingURL=rework.test.js.map

package/dist/commands/__tests__/rework.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"rework.test.js","sourceRoot":"","sources":["../../../src/commands/__tests__/rework.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AACH,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,eAAe,EAAE,MAAM,cAAc,CAAC;AAC/C,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AAEpD,MAAM,yBAAyB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAC1C,MAAM,eAAe,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAEhC,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,qBAAqB,EAAE,CAAC,GAAG,IAAe,EAAE,EAAE,CAAC,yBAAyB,CAAC,GAAG,IAAI,CAAC;CAClF,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,sBAAsB,EAAE,GAAG,EAAE,CAAC,CAAC;IACrC,WAAW,EAAE,CAAC,GAAG,IAAe,EAAE,EAAE,CAAC,eAAe,CAAC,GAAG,IAAI,CAAC;CAC9D,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,gBAAgB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAC3B,OAAO,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,YAAY,EAAE,OAAO,EAAE,0BAA0B,EAAE,CAAC,CAC/E;CACF,CAAC,CAAC,CAAC;AAEJ,IAAI,YAAoB,CAAC;AACzB,IAAI,cAA2C,CAAC;AAEhD,UAAU,CAAC,GAAG,EAAE;IACd,YAAY,GAAG,EAAE,CAAC;IAClB,cAAc,GAAG,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,kBAAkB,CAAC,CAAC,KAAK,EAAE,EAAE;QAC9E,YAAY,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC;QAC9B,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;IACH,aAAa,CAAC,MAAM,CAAC,CAAC;IACtB,EAAE,CAAC,aAAa,EAAE,CAAC;IACnB,eAAe,CAAC,eAAe,CAAC;QAC9B,SAAS,EAAE,QAAQ;QACnB,WAAW,EAAE,MAAM;QACnB,aAAa,EAAE,SAAS;QACxB,SAAS,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;QACnC,eAAe,EAAE,EAAE;QACnB,cAAc,EAAE,UAAU;KAC3B,CAAC,CAAC;IACH,yBAAyB,CAAC,iBAAiB,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC,CAAC;AAClF,CAAC,CAAC,CAAC;AAEH,SAAS,CAAC,GAAG,EAAE;IACb,cAAc,CAAC,WAAW,EAAE,CAAC;IAC7B,aAAa,CAAC,MAAM,CAAC,CAAC;AACxB,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,oCAAoC,EAAE,GAAG,EAAE;IAClD,EAAE,CAAC,0CAA0C,EAAE,KAAK,IAAI,EAAE;QACxD,eAAe,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;QACtC,MAAM,MAAM,CACV,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CACnE,CAAC,OAAO,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC;QACvC,MAAM,CAAC,yBAAyB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QACtE,eAAe,CAAC,eAAe,CAAC;YAC9B,SAAS,EAAE,QAAQ;YACnB,WAAW,EAAE,MAAM;YACnB,aAAa,EAAE,SAAS;YACxB,SAAS,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;YACnC,eAAe,EAAE,EAAE;YACnB,oBAAoB;SACrB,CAAC,CAAC;QACH,MAAM,MAAM,CACV,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CACnE,CAAC,OAAO,CAAC,OAAO,CAAC,uBAAuB,CAAC,CAAC;QAC3C,MAAM,CAAC,yBAAyB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,MAAM,CACV,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,OAAO,EAAE,CAAC,CAChE,CAAC,OAAO,CAAC,OAAO,CAAC,iCAAiC,CAAC,CAAC;QACrD,MAAM,CAAC,yBAAyB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,KAAK,IAAI,EAAE;QACzE,MAAM,MAAM,CACV,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,WAAW,EAAE,OAAO,EAAE,CAAC,CACzF,CAAC,OAAO,CAAC,OAAO,CAAC,sBAAsB,CAAC,CAAC;QAC1C,MAAM,CAAC,yBAAyB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0BAA0B,EAAE,KAAK,IAAI,EAAE;QACxC,MAAM,MAAM,CACV,eAAe,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CAChE,CAAC,OAAO,CAAC,OAAO,CAAC,sBAAsB,CAAC,CAAC;QAC1C,MAAM,CAAC,yBAAyB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC3D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC9C,EAAE,CAAC,8FAA8F,EAAE,KAAK,IAAI,EAAE;QAC5G,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CAAC;QACzE,MAAM,CAAC,yBAAyB,CAAC,CAAC,oBAAoB,CAAC,eAAe,EAAE;YACtE,SAAS,EAAE,QAAQ;YACnB,cAAc,EAAE,UAAU;YAC1B,OAAO,EAAE,QAAQ;YACjB,cAAc,EAAE,UAAU;YAC1B,WAAW,EAAE,QAAQ;SACtB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,KAAK,IAAI,EAAE;QACnF,MAAM,eAAe,CAAC;YACpB,OAAO,EAAE,QAAQ;YACjB,cAAc,EAAE,sBAAsB;YACtC,WAAW,EAAE,UAAU;YACvB,YAAY,EAAE,IAAI;YAClB,IAAI,EAAE,kBAAkB;SACzB,CAAC,CAAC;QACH,MAAM,CAAC,yBAAyB,CAAC,CAAC,oBAAoB,CAAC,eAAe,EAAE;YACtE,SAAS,EAAE,QAAQ;YACnB,cAAc,EAAE,UAAU;YAC1B,OAAO,EAAE,QAAQ;YACjB,cAAc,EAAE,sBAAsB;YACtC,WAAW,EAAE,UAAU;YACvB,4BAA4B,EAAE,IAAI;YAClC,IAAI,EAAE,kBAAkB;SACzB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mEAAmE,EAAE,KAAK,IAAI,EAAE;QACjF,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,eAAe,EAAE,CAAC,CAAC;QAC9E,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,yBAAyB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAsC,CAAC;QAC9F,MAAM,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,cAAc,CAAC,8BAA8B,CAAC,CAAC;QAChE,MAAM,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAC9D,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CAAC;QACzE,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;QACxC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACrC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,+DAA+D,EAAE,GAAG,EAAE;IAC7E,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,YAAY,EAAE,eAAe,EAAE,CAAC,CAAC;QACxG,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAAC,eAAe,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,KAAK,IAAI,EAAE;QACrF,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CAAC;QACzE,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAAC,SAAS,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6EAA6E,EAAE,KAAK,IAAI,EAAE;QAC3F,eAAe,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;QACtC,MAAM,GAAG,GAAG,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC;QACrG,MAAM,CAAC,GAAG,CAAC,QAAQ,IAAI,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,6DAA6D,EAAE,GAAG,EAAE;IAC3E,EAAE,CAAC,6EAA6E,EAAE,KAAK,IAAI,EAAE;QAC3F,yBAAyB,CAAC,iBAAiB,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC;QAC/F,aAAa,CAAC,QAAQ,CAAC,CAAC;QACxB,MAAM,eAAe,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,UAAU,EAAE,CAAC,CAAC;QACzE,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,yBAAyB,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/commands/__tests__/setup-detect-surfaces.test.d.ts

@@ -0,0 +1,15 @@
+/**
+ * WP-433 S5 — `formatDetectSurfacesSummary` pure unit tests.
+ *
+ * Per INS-1420: runSetupDetectSurfaces makes live server calls via getConfigSafe()
+ * and kernelCall. These tests ONLY exercise the pure formatter on hand-crafted
+ * SetupDetectSurfacesResult objects — runSetupDetectSurfaces is never called.
+ *
+ * Test cases:
+ *  1. Bare-repo (zero detected, zero existing) → appends locked guidance question
+ *  2. Normal detect (new surfaces detected) → does NOT append
+ *  3. Idempotent re-run (existing surfaces, zero new) → does NOT append
+ *  4. Server-stamp-error case → surfaces error in summary, does NOT append extra question
+ */
+export {};
+//# sourceMappingURL=setup-detect-surfaces.test.d.ts.map

package/dist/commands/__tests__/setup-detect-surfaces.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"setup-detect-surfaces.test.d.ts","sourceRoot":"","sources":["../../../src/commands/__tests__/setup-detect-surfaces.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG"}

package/dist/commands/__tests__/setup-detect-surfaces.test.js

@@ -0,0 +1,149 @@
+/**
+ * WP-433 S5 — `formatDetectSurfacesSummary` pure unit tests.
+ *
+ * Per INS-1420: runSetupDetectSurfaces makes live server calls via getConfigSafe()
+ * and kernelCall. These tests ONLY exercise the pure formatter on hand-crafted
+ * SetupDetectSurfacesResult objects — runSetupDetectSurfaces is never called.
+ *
+ * Test cases:
+ *  1. Bare-repo (zero detected, zero existing) → appends locked guidance question
+ *  2. Normal detect (new surfaces detected) → does NOT append
+ *  3. Idempotent re-run (existing surfaces, zero new) → does NOT append
+ *  4. Server-stamp-error case → surfaces error in summary, does NOT append extra question
+ */
+import { describe, expect, it } from 'vitest';
+import { formatDetectSurfacesSummary, } from '../setup-detect-surfaces.js';
+const LOCKED_QUESTION = "I don't see Claude Code or Cursor — which AI tool do you use?";
+/** Helper: build a minimal SetupDetectSurfacesResult */
+function makeResult(overrides = {}) {
+    return {
+        detected: [],
+        existing: [],
+        newlyAdded: [],
+        union: [],
+        manifestUpdated: false,
+        manifestPath: '/repo/.productbrain/manifest.json',
+        serverStamp: null,
+        serverStampError: null,
+        ...overrides,
+    };
+}
+describe('formatDetectSurfacesSummary — WP-433 S5 bare-repo guidance', () => {
+    it('bare-repo (zero detected, zero existing) appends locked guidance question', () => {
+        const result = makeResult({
+            detected: [],
+            existing: [],
+            newlyAdded: [],
+            union: [],
+            manifestUpdated: false,
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        expect(summary).toContain(LOCKED_QUESTION);
+        // Confirm the question is on a separate line
+        expect(summary).toContain('\n' + LOCKED_QUESTION);
+    });
+    it('normal detect (new surfaces detected) does NOT append locked question', () => {
+        const result = makeResult({
+            detected: ['claude'],
+            existing: [],
+            newlyAdded: ['claude'],
+            union: ['claude'],
+            manifestUpdated: true,
+            serverStamp: { stamped: true, surfaces: ['claude'] },
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        expect(summary).not.toContain(LOCKED_QUESTION);
+        // Confirm surfaces are mentioned
+        expect(summary).toContain('claude');
+    });
+    it('STD-235 remnant (zero detected, existing surfaces remain in manifest) does NOT append locked question', () => {
+        // Marker dir deleted from disk; STD-235 forward-only keeps the surface in manifest.
+        // Detected is empty but existing is not — guard must NOT trigger bare-repo guidance.
+        const result = makeResult({
+            detected: [],
+            existing: ['claude'],
+            newlyAdded: [],
+            union: ['claude'],
+            manifestUpdated: false,
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        expect(summary).not.toContain(LOCKED_QUESTION);
+        expect(summary).toContain('Detected: none');
+        expect(summary).toContain('Existing: claude');
+    });
+    it('idempotent re-run (existing surfaces, zero new detected) does NOT append locked question', () => {
+        const result = makeResult({
+            detected: ['claude'],
+            existing: ['claude'],
+            newlyAdded: [],
+            union: ['claude'],
+            manifestUpdated: false,
+            serverStamp: { stamped: false, surfaces: ['claude'] },
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        expect(summary).not.toContain(LOCKED_QUESTION);
+        // Existing should appear in summary
+        expect(summary).toContain('claude');
+    });
+    it('server-stamp-error case surfaces the error and does NOT append the locked question', () => {
+        // If detect-surfaces fails at the server stamp but DID find surfaces locally,
+        // the error should appear but the bare-repo question should not.
+        const result = makeResult({
+            detected: ['cursor'],
+            existing: [],
+            newlyAdded: ['cursor'],
+            union: ['cursor'],
+            manifestUpdated: true,
+            serverStamp: null,
+            serverStampError: 'Network timeout connecting to workspace',
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        // Error is surfaced
+        expect(summary).toContain('Server stamp failed: Network timeout connecting to workspace');
+        // Bare-repo question is NOT appended (surfaces were found)
+        expect(summary).not.toContain(LOCKED_QUESTION);
+    });
+    it('bare-repo with server-stamp-error (edge case: zero surfaces + server error) appends locked question', () => {
+        // Zero detected + zero existing → bare-repo. Server stamp would not have been
+        // called (union is empty), but if serverStampError somehow populated, the
+        // bare-repo signal still dominates and the question should appear.
+        const result = makeResult({
+            detected: [],
+            existing: [],
+            newlyAdded: [],
+            union: [],
+            manifestUpdated: false,
+            serverStamp: null,
+            serverStampError: 'Config missing',
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        // Server stamp error is surfaced
+        expect(summary).toContain('Server stamp failed: Config missing');
+        // Bare-repo guidance still applies
+        expect(summary).toContain(LOCKED_QUESTION);
+    });
+    it('summary has correct shape for bare-repo result', () => {
+        const result = makeResult();
+        const summary = formatDetectSurfacesSummary(result);
+        // Base line before the question
+        expect(summary).toMatch(/^Detected: none \(new: none\)\. Existing: none\. Manifest unchanged\./);
+    });
+    it('summary has correct shape for normal detect', () => {
+        const result = makeResult({
+            detected: ['claude', 'cursor'],
+            existing: ['claude'],
+            newlyAdded: ['cursor'],
+            union: ['claude', 'cursor'],
+            manifestUpdated: true,
+            serverStamp: { stamped: true, surfaces: ['claude', 'cursor'] },
+        });
+        const summary = formatDetectSurfacesSummary(result);
+        expect(summary).toContain('Detected: claude, cursor');
+        expect(summary).toContain('new: cursor');
+        expect(summary).toContain('Existing: claude');
+        expect(summary).toContain('Manifest updated.');
+        expect(summary).toContain('Server stamped.');
+        expect(summary).not.toContain(LOCKED_QUESTION);
+    });
+});
+//# sourceMappingURL=setup-detect-surfaces.test.js.map