@productbrain/cli 0.1.0-beta.4243 → 0.1.0-beta.4257

package/dist/lib/gitEnvLeakKeysParity.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=gitEnvLeakKeysParity.test.d.ts.map

package/dist/lib/gitEnvLeakKeysParity.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"gitEnvLeakKeysParity.test.d.ts","sourceRoot":"","sources":["../../src/lib/gitEnvLeakKeysParity.test.ts"],"names":[],"mappings":""}

package/dist/lib/gitEnvLeakKeysParity.test.js

@@ -0,0 +1,73 @@
+// Parity test for the two hand-synced GIT_ENV_LEAK_KEYS copies in packages/cli (review round 4,
+// PR #632 follow-up, PRRT_kwDORS4ils6YoYoM).
+//
+// packages/cli/src/commands/files.test.ts and packages/cli/src/lib/productbrain-files.test.ts
+// each carry a LOCAL inline copy of scripts/lib/gitFixtureEnv.mjs's canonical GIT_ENV_LEAK_KEYS
+// array — kept local (rather than a cross-package import) per the note on each copy. A future
+// git version bump updates the canonical array (its own superset test,
+// scripts/lib/gitFixtureEnv.node-test.mjs, would fail and prompt the fix there) but nothing
+// previously asserted the two packages/cli copies got updated too — they could silently rot out
+// of sync, each one individually still "passing" its own file's tests while quietly missing a
+// newer git-named env var.
+//
+// Reads all three sources as TEXT and extracts each array by regex (no cross-package import —
+// packages/cli is a separately published package, and scripts/lib/gitFixtureEnv.mjs lives
+// outside its rootDir; importing another *.test.ts file directly would also risk vitest
+// double-collecting its describe/it blocks). This is exactly the "reading the canonical file
+// from repo root is fine in a test" approach.
+import { describe, it, expect } from 'vitest';
+import { readFileSync } from 'node:fs';
+import { resolve, dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+const HERE = dirname(fileURLToPath(import.meta.url));
+// packages/cli/src/lib -> packages/cli/src -> packages/cli -> packages -> repo root
+const REPO_ROOT = resolve(HERE, '../../../..');
+// Review round 3 (PR #634, PRRT_kwDORS4ils6Yp28g): a commented-out quoted token inside the array
+// span (e.g. `// 'GIT_OLD_VAR', -- retired`) previously counted as a real list entry, since the
+// extraction regex below doesn't distinguish code from comments — making the parity check dishonest
+// (it could pass or fail based on comment text, not the actual arrays). Strips both comment forms
+// from the matched span before extracting; safe in this narrow context (a flat array of ALL-CAPS
+// env-var-name string literals — no regex literals or other content that a naive comment strip
+// could misparse, unlike the general-purpose scripts/lib/gitFixtureTextMask.mjs this repo uses
+// elsewhere for exactly that reason).
+function extractGitEnvLeakKeys(source) {
+    const match = /\bGIT_ENV_LEAK_KEYS[^=]*=\s*\[([\s\S]*?)\]/m.exec(source);
+    if (!match)
+        throw new Error('GIT_ENV_LEAK_KEYS array not found in source');
+    const withoutComments = match[1].replace(/\/\*[\s\S]*?\*\//g, '').replace(/\/\/.*$/gm, '');
+    return [...withoutComments.matchAll(/'([^']+)'/g)].map((m) => m[1]);
+}
+describe('GIT_ENV_LEAK_KEYS parity across the canonical source and both packages/cli inline copies', () => {
+    const canonicalPath = resolve(REPO_ROOT, 'scripts/lib/gitFixtureEnv.mjs');
+    const canonical = extractGitEnvLeakKeys(readFileSync(canonicalPath, 'utf8'));
+    it('the canonical list itself is non-empty (sanity check on the extraction regex, not just the comparisons below)', () => {
+        expect(canonical.length).toBeGreaterThan(0);
+    });
+    it('packages/cli/src/commands/files.test.ts stays in sync with the canonical scripts/lib/gitFixtureEnv.mjs list', () => {
+        const source = readFileSync(resolve(REPO_ROOT, 'packages/cli/src/commands/files.test.ts'), 'utf8');
+        const copy = extractGitEnvLeakKeys(source);
+        expect([...copy].sort()).toEqual([...canonical].sort());
+    });
+    it('packages/cli/src/lib/productbrain-files.test.ts stays in sync with the canonical scripts/lib/gitFixtureEnv.mjs list', () => {
+        const source = readFileSync(resolve(REPO_ROOT, 'packages/cli/src/lib/productbrain-files.test.ts'), 'utf8');
+        const copy = extractGitEnvLeakKeys(source);
+        expect([...copy].sort()).toEqual([...canonical].sort());
+    });
+});
+describe('extractGitEnvLeakKeys ignores commented-out entries (review round 3, PRRT_kwDORS4ils6Yp28g)', () => {
+    it('a line-commented-out quoted token inside the array span is NOT counted as a real entry', () => {
+        const source = [
+            'export const GIT_ENV_LEAK_KEYS = [',
+            "\t'GIT_DIR',",
+            "\t// 'GIT_RETIRED_VAR', -- no longer needed",
+            "\t'GIT_WORK_TREE',",
+            '];',
+        ].join('\n');
+        expect(extractGitEnvLeakKeys(source)).toEqual(['GIT_DIR', 'GIT_WORK_TREE']);
+    });
+    it('a block-commented-out quoted token inside the array span is NOT counted as a real entry', () => {
+        const source = ["export const GIT_ENV_LEAK_KEYS = [", "\t'GIT_DIR',", "\t/* 'GIT_RETIRED_VAR', */", "\t'GIT_WORK_TREE',", '];'].join('\n');
+        expect(extractGitEnvLeakKeys(source)).toEqual(['GIT_DIR', 'GIT_WORK_TREE']);
+    });
+});
+//# sourceMappingURL=gitEnvLeakKeysParity.test.js.map

package/dist/lib/gitEnvLeakKeysParity.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"gitEnvLeakKeysParity.test.js","sourceRoot":"","sources":["../../src/lib/gitEnvLeakKeysParity.test.ts"],"names":[],"mappings":"AAAA,gGAAgG;AAChG,6CAA6C;AAC7C,EAAE;AACF,8FAA8F;AAC9F,gGAAgG;AAChG,8FAA8F;AAC9F,uEAAuE;AACvE,4FAA4F;AAC5F,gGAAgG;AAChG,8FAA8F;AAC9F,2BAA2B;AAC3B,EAAE;AACF,8FAA8F;AAC9F,0FAA0F;AAC1F,wFAAwF;AACxF,6FAA6F;AAC7F,8CAA8C;AAC9C,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAC7C,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,IAAI,GAAG,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AACrD,oFAAoF;AACpF,MAAM,SAAS,GAAG,OAAO,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC;AAE/C,iGAAiG;AACjG,gGAAgG;AAChG,oGAAoG;AACpG,kGAAkG;AAClG,iGAAiG;AACjG,+FAA+F;AAC/F,+FAA+F;AAC/F,sCAAsC;AACtC,SAAS,qBAAqB,CAAC,MAAc;IAC3C,MAAM,KAAK,GAAG,6CAA6C,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACzE,IAAI,CAAC,KAAK;QAAE,MAAM,IAAI,KAAK,CAAC,6CAA6C,CAAC,CAAC;IAC3E,MAAM,eAAe,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,mBAAmB,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC;IAC3F,OAAO,CAAC,GAAG,eAAe,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AACtE,CAAC;AAED,QAAQ,CAAC,0FAA0F,EAAE,GAAG,EAAE;IACxG,MAAM,aAAa,GAAG,OAAO,CAAC,SAAS,EAAE,+BAA+B,CAAC,CAAC;IAC1E,MAAM,SAAS,GAAG,qBAAqB,CAAC,YAAY,CAAC,aAAa,EAAE,MAAM,CAAC,CAAC,CAAC;IAE7E,EAAE,CAAC,+GAA+G,EAAE,GAAG,EAAE;QACvH,MAAM,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6GAA6G,EAAE,GAAG,EAAE;QACrH,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,SAAS,EAAE,yCAAyC,CAAC,EAAE,MAAM,CAAC,CAAC;QACnG,MAAM,IAAI,GAAG,qBAAqB,CAAC,MAAM,CAAC,CAAC;QAC3C,MAAM,CAAC,CAAC,GAAG,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,SAAS,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qHAAqH,EAAE,GAAG,EAAE;QAC7H,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,SAAS,EAAE,iDAAiD,CAAC,EAAE,MAAM,CAAC,CAAC;QAC3G,MAAM,IAAI,GAAG,qBAAqB,CAAC,MAAM,CAAC,CAAC;QAC3C,MAAM,CAAC,CAAC,GAAG,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,SAAS,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,6FAA6F,EAAE,GAAG,EAAE;IAC3G,EAAE,CAAC,wFAAwF,EAAE,GAAG,EAAE;QAChG,MAAM,MAAM,GAAG;YACb,oCAAoC;YACpC,cAAc;YACd,6CAA6C;YAC7C,oBAAoB;YACpB,IAAI;SACL,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACb,MAAM,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,EAAE,eAAe,CAAC,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yFAAyF,EAAE,GAAG,EAAE;QACjG,MAAM,MAAM,GAAG,CAAC,oCAAoC,EAAE,cAAc,EAAE,4BAA4B,EAAE,oBAAoB,EAAE,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3I,MAAM,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,EAAE,eAAe,CAAC,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@productbrain/cli",
-  "version": "0.1.0-beta.4243",
+  "version": "0.1.0-beta.4257",
   "description": "Product Brain — Chain knowledge and write-back CLI",
   "type": "module",
   "bin": {